tang7526 commented on pull request #10501:
URL: https://github.com/apache/kafka/pull/10501#issuecomment-815470002
> @tang7526 thanks for your patch. Could you merge trunk to trigger QA? It
seems this PR does not include recent fixes for flaky.
Done. I have rebased trunk.
--
This
ableegoldman merged pull request #10484:
URL: https://github.com/apache/kafka/pull/10484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ableegoldman commented on pull request #10484:
URL: https://github.com/apache/kafka/pull/10484#issuecomment-815431683
One unrelated flaky test failure:
`kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()`
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316849#comment-17316849
]
A. Sophie Blee-Goldman commented on KAFKA-12624:
Had to change a handful of dependencies
[
https://issues.apache.org/jira/browse/KAFKA-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12624.
Resolution: Fixed
> Fix LICENSE in 2.6
> --
>
>
chia7712 commented on pull request #10501:
URL: https://github.com/apache/kafka/pull/10501#issuecomment-815427209
@tang7526 thanks for your patch. Could you merge trunk to trigger QA? It
seems this PR does not include recent fixes for flaky.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12622:
---
Description:
In https://issues.apache.org/jira/browse/KAFKA-12602, we
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316812#comment-17316812
]
Justine Olshan commented on KAFKA-12629:
I am also seeing the timeout for createTopics
> Flaky
kpatelatwork opened a new pull request #10503:
URL: https://github.com/apache/kafka/pull/10503
*Uncaught exceptions logged during task stop were misleading because the
task is already on its way of being shutdown.*
*The suppression of exception causes a change in behavior as the
guozhangwang commented on pull request #10502:
URL: https://github.com/apache/kafka/pull/10502#issuecomment-815368022
ping @ableegoldman @abbccdda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang opened a new pull request #10502:
URL: https://github.com/apache/kafka/pull/10502
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
[
https://issues.apache.org/jira/browse/KAFKA-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-12568.
---
Fix Version/s: 3.0.0
Assignee: Guozhang Wang
Resolution: Fixed
> Remove
guozhangwang merged pull request #10421:
URL: https://github.com/apache/kafka/pull/10421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
guozhangwang commented on a change in pull request #10421:
URL: https://github.com/apache/kafka/pull/10421#discussion_r609160610
##
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##
@@ -725,12 +725,11 @@ public void
kowshik commented on pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#issuecomment-815353566
cc @dhruvilshah3 @junrao @satishd -- this PR is ready for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cmccabe commented on a change in pull request #10343:
URL: https://github.com/apache/kafka/pull/10343#discussion_r609096892
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1007,6 +1014,112 @@ int bestLeader(int[]
junrao commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r609073411
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java
##
@@ -0,0 +1,160 @@
+/*
+ *
hachikuji commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r609108151
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2256,6 +2261,11 @@ private Long append(int epoch, List records,
[
https://issues.apache.org/jira/browse/KAFKA-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316756#comment-17316756
]
Jason Gustafson commented on KAFKA-12607:
-
A good follow-up once this is merged is
Jason Gustafson created KAFKA-12631:
---
Summary: Support api to resign raft leadership
Key: KAFKA-12631
URL: https://issues.apache.org/jira/browse/KAFKA-12631
Project: Kafka
Issue Type:
cmccabe commented on a change in pull request #10343:
URL: https://github.com/apache/kafka/pull/10343#discussion_r609098540
##
File path:
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java
##
@@ -518,4 +523,89 @@ public void
cmccabe commented on a change in pull request #10343:
URL: https://github.com/apache/kafka/pull/10343#discussion_r609093462
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -538,4 +542,57 @@ class ControllerApis(val requestChannel: RequestChannel,
hachikuji commented on a change in pull request #10343:
URL: https://github.com/apache/kafka/pull/10343#discussion_r609081390
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1007,6 +1014,112 @@ int bestLeader(int[]
Guozhang Wang created KAFKA-12630:
-
Summary: Remove deprecated KafkaClientSupplier#getAdminClient
Key: KAFKA-12630
URL: https://issues.apache.org/jira/browse/KAFKA-12630
Project: Kafka
Issue
vvcephei commented on a change in pull request #10421:
URL: https://github.com/apache/kafka/pull/10421#discussion_r609080989
##
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##
@@ -725,12 +725,11 @@ public void
ijuma commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-815270148
Seems reasonable to me. Any downside for the alternative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guozhangwang merged pull request #10380:
URL: https://github.com/apache/kafka/pull/10380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hachikuji commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r609062875
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
hachikuji commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r609061910
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
junrao merged pull request #10489:
URL: https://github.com/apache/kafka/pull/10489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
hachikuji commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r609058148
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-7785.
--
Resolution: Fixed
> Remove PartitionGrouper interface and it's config and move
>
guozhangwang commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-815245190
Merged to trunk, thanks @highluck !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
guozhangwang merged pull request #10302:
URL: https://github.com/apache/kafka/pull/10302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
guozhangwang commented on pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#issuecomment-815244582
Merged to trunk, thanks @spena !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guozhangwang merged pull request #10331:
URL: https://github.com/apache/kafka/pull/10331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hachikuji commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r608935314
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -73,17 +77,25 @@ class BrokerMetadataListener(brokerId:
hachikuji commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r608934941
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2256,6 +2261,11 @@ private Long append(int epoch, List records,
[
https://issues.apache.org/jira/browse/KAFKA-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316569#comment-17316569
]
Ismael Juma commented on KAFKA-12383:
-
Thanks [~mjsax]!
> Get RaftClusterTest.java and other
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316564#comment-17316564
]
Justine Olshan edited comment on KAFKA-12629 at 4/7/21, 6:57 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316564#comment-17316564
]
Justine Olshan edited comment on KAFKA-12629 at 4/7/21, 6:57 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316564#comment-17316564
]
Justine Olshan edited comment on KAFKA-12629 at 4/7/21, 6:55 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316564#comment-17316564
]
Justine Olshan edited comment on KAFKA-12629 at 4/7/21, 6:55 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316564#comment-17316564
]
Justine Olshan commented on KAFKA-12629:
java.lang.ClassNotFoundException:
bbejeck edited a comment on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-815142541
@g1geordie, thanks for the PR and sorry for the delay in the review.
Can you rebase this PR to resolve the conflicts? I plan on reviewing this
in the next day
bbejeck commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-815142541
@g1geordie, thanks for the PR and sorry for the delay in the review.
Can you rebase this PR? I plan on reviewing this in the next day or so.
Also, there seem to be
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316552#comment-17316552
]
Matthias J. Sax commented on KAFKA-12629:
-
Also observed a timeout issue
{quote}
[
https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316559#comment-17316559
]
Matthias J. Sax commented on KAFKA-12319:
-
Failed again.
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316558#comment-17316558
]
Matthias J. Sax commented on KAFKA-12566:
-
Another timeout:
{quote}
[
https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316543#comment-17316543
]
Matthias J. Sax edited comment on KAFKA-12566 at 4/7/21, 6:43 PM:
--
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608905403
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -133,34 +141,37 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316553#comment-17316553
]
Matthias J. Sax commented on KAFKA-12383:
-
Created
Matthias J. Sax created KAFKA-12629:
---
Summary: Flaky Test RaftClusterTest
Key: KAFKA-12629
URL: https://issues.apache.org/jira/browse/KAFKA-12629
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316546#comment-17316546
]
Matthias J. Sax commented on KAFKA-9009:
One more:
{quote} {{java.lang.AssertionError: assertion
[
https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316543#comment-17316543
]
Matthias J. Sax commented on KAFKA-12566:
-
Different method:
guozhangwang commented on a change in pull request #10495:
URL: https://github.com/apache/kafka/pull/10495#discussion_r608898617
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -874,6 +874,7 @@ public void abortTransaction()
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608896190
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -133,34 +141,37 @@ public void
jsancio commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r608893213
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -73,17 +77,25 @@ class BrokerMetadataListener(brokerId: Int,
jsancio commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r608891411
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2256,6 +2261,11 @@ private Long append(int epoch, List records,
hachikuji commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r60370
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2256,6 +2261,11 @@ private Long append(int epoch, List records,
hachikuji commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r60570
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -73,17 +77,25 @@ class BrokerMetadataListener(brokerId:
hachikuji commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r60370
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2256,6 +2261,11 @@ private Long append(int epoch, List records,
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608887445
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -161,7 +181,7 @@ public void
jsancio commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r608864999
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -73,17 +77,25 @@ class BrokerMetadataListener(brokerId: Int,
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608860297
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##
@@ -211,6 +246,66 @@ private void
hachikuji commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608881469
##
File path: core/src/main/scala/kafka/tools/TestRaftServer.scala
##
@@ -51,7 +51,8 @@ class TestRaftServer(
) extends Logging {
import
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608846573
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ValueOrOtherValue.java
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
hachikuji commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608863873
##
File path: core/src/main/scala/kafka/tools/TestRaftServer.scala
##
@@ -52,6 +52,7 @@ class TestRaftServer(
import kafka.tools.TestRaftServer._
jolshan commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608861828
##
File path: clients/src/main/java/org/apache/kafka/common/Uuid.java
##
@@ -27,6 +27,10 @@
*/
public class Uuid implements Comparable {
+/**
+
jolshan commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608861438
##
File path: core/src/main/scala/kafka/tools/TestRaftServer.scala
##
@@ -52,6 +52,7 @@ class TestRaftServer(
import kafka.tools.TestRaftServer._
cmccabe merged pull request #10465:
URL: https://github.com/apache/kafka/pull/10465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608833831
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyAndJoinSide.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
hachikuji commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608789181
##
File path: clients/src/main/java/org/apache/kafka/common/Uuid.java
##
@@ -27,6 +27,10 @@
*/
public class Uuid implements Comparable {
+/**
tang7526 opened a new pull request #10501:
URL: https://github.com/apache/kafka/pull/10501
Remove redundant test code
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
jthurne edited a comment on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-815069751
> Does the clean task delete the local caches or not?
`clean` does not delete the local build cache.
> If not, how would one force cache deletion in case of
jthurne commented on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-815069751
> Does the clean task delete the local caches or not?
It does not delete the local build cache.
> If not, how would one force cache deletion in case of a bug?
guozhangwang commented on pull request #10481:
URL: https://github.com/apache/kafka/pull/10481#issuecomment-815068321
> The refactor proposed here may even give us a stronger way to enforce the
invariant: https://github.com/apache/kafka/pull/10480/files. What do you think?
Sounds
guozhangwang commented on pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#issuecomment-815063710
I've triggered another round of unit tests to see if they are transient --
will review the latest commit now.
--
This is an automated message from the Apache Git
guozhangwang commented on pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#issuecomment-815063166
> @guozhangwang The test failures are not related to this PR.
Sounds good. I think they are irrelevant indeed, similarly the other
failures from
satishd commented on pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#issuecomment-815062947
@junrao This PR is on top of https://github.com/apache/kafka/pull/10489 .
So, https://github.com/apache/kafka/pull/10489 be merged before merging this
PR.
--
This is an
satishd commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r608822419
##
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentState.java
##
@@ -87,4 +89,27 @@ public byte id() {
satishd commented on a change in pull request #10218:
URL: https://github.com/apache/kafka/pull/10218#discussion_r608820288
##
File path:
remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed
spena commented on pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#issuecomment-815058791
@guozhangwang The test failures are not related to this PR.
```
Build / JDK 8 and Scala 2.12 /
[
https://issues.apache.org/jira/browse/KAFKA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
raphael auv updated KAFKA-12628:
Issue Type: Bug (was: Improvement)
> SSL context is never re-evaluate by consumer or producer
>
[
https://issues.apache.org/jira/browse/KAFKA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
raphael auv updated KAFKA-12628:
Description:
*SslChannelBuilder reconfigure is never call ->*
[
https://issues.apache.org/jira/browse/KAFKA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
raphael auv updated KAFKA-12628:
Description:
*SslChannelBuilder reconfigure is never call ->*
[
https://issues.apache.org/jira/browse/KAFKA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
raphael auv updated KAFKA-12628:
Description:
*SslChannelBuilder reconfigure is never call ->*
raphael auv created KAFKA-12628:
---
Summary: SSL context is never re-evaluate by consumer or producer
Key: KAFKA-12628
URL: https://issues.apache.org/jira/browse/KAFKA-12628
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dielhenn reassigned KAFKA-12265:
-
Assignee: Ryan Dielhenn (was: Rohit Deshpande)
> Move the BatchAccumulator in
guozhangwang commented on pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#issuecomment-815012568
Re-triggered unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
runningcode edited a comment on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-814921056
> On the CI-server side, these changes have little to no impact at all,
unfortunately.
The CI build improvements will come from using the Gradle Enteprise
chia7712 commented on pull request #9229:
URL: https://github.com/apache/kafka/pull/9229#issuecomment-815002256
> When you say performance test, you mean the ducktape ones?
yep. maybe `benchmark_test.py` (although I feel the benefit gets more
obvious in long-run production)
--
ijuma commented on pull request #9229:
URL: https://github.com/apache/kafka/pull/9229#issuecomment-814999556
@chia7712 When you say performance test, you mean the ducktape ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#issuecomment-814998520
cc @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608748053
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java
##
@@ -77,12 +73,41 @@ public ConsumerRecord(String topic,
ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608745722
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java
##
@@ -32,7 +31,6 @@
public class ConsumerRecord {
public
[
https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316380#comment-17316380
]
Angelos Kaltsikis edited comment on KAFKA-12468 at 4/7/21, 2:36 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316380#comment-17316380
]
Angelos Kaltsikis edited comment on KAFKA-12468 at 4/7/21, 2:35 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316388#comment-17316388
]
Angelos Kaltsikis commented on KAFKA-12468:
---
We were also considering to add the following
[
https://issues.apache.org/jira/browse/KAFKA-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-12626.
-
Assignee: Colin McCabe
Resolution: Fixed
> RaftClusterTest and ClusterTestExtensionTest
1 - 100 of 135 matches
Mail list logo
