[GitHub] [kafka] ijuma merged pull request #10522: MINOR: Remove `setupGradle()` from Jenkinsfile

2021-04-11 Thread GitBox
ijuma merged pull request #10522: URL: https://github.com/apache/kafka/pull/10522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] ijuma merged pull request #10524: MINOR: Use `testRuntimeOnly` instead of `testRuntime` in storage modules

2021-04-11 Thread GitBox
ijuma merged pull request #10524: URL: https://github.com/apache/kafka/pull/10524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] ijuma commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin

2021-04-11 Thread GitBox
ijuma commented on pull request #10491: URL: https://github.com/apache/kafka/pull/10491#issuecomment-817501577 @jthurne This change causes new failures: > [2021-04-12T03:23:02.541Z] > A failure occurred while executing org.nosphere.apache.rat.RatWork > >

[GitHub] [kafka] chia7712 commented on pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

2021-04-11 Thread GitBox
chia7712 commented on pull request #10488: URL: https://github.com/apache/kafka/pull/10488#issuecomment-817499047 @dengziming Could you trigger QA again? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] chia7712 commented on a change in pull request #10469: KAFKA-12611: Fix using random payload in ProducerPerformance incorrectly

2021-04-11 Thread GitBox
chia7712 commented on a change in pull request #10469: URL: https://github.com/apache/kafka/pull/10469#discussion_r611320152 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -111,13 +111,8 @@ public static void main(String[] args) throws

[jira] [Commented] (KAFKA-12510) Unable to access Kafka connection on a machine behind the company firewall

2021-04-11 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319012#comment-17319012 ] Jordan Moore commented on KAFKA-12510: -- Please update the issue with more details. For example,

[jira] [Commented] (KAFKA-12517) Kafka's readme should provide Run configurations in the BUILD with IDE Section

2021-04-11 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319011#comment-17319011 ] Jordan Moore commented on KAFKA-12517: -- I think the recommendation is to actually use

[jira] [Commented] (KAFKA-12530) kafka-configs.sh does not work while changing the sasl jaas configurations.

2021-04-11 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319006#comment-17319006 ] Jordan Moore commented on KAFKA-12530: -- Duplicates KAFKA-12529 KAFKA-12528 > kafka-configs.sh

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-11 Thread GitBox
showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-817457115 @ableegoldman , I've updated this PR to revert the increasing heartbeat interval change. Thank you. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-04-11 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319001#comment-17319001 ] Jordan Moore commented on KAFKA-12534: -- Include --command-config parameter with a file that

[GitHub] [kafka] showuon commented on a change in pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-11 Thread GitBox
showuon commented on a change in pull request #10409: URL: https://github.com/apache/kafka/pull/10409#discussion_r611308540 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyInnerJoinMultiIntegrationTest.java ## @@ -172,38 +170,35

[GitHub] [kafka] showuon commented on a change in pull request #10409: KAFKA-9295: increase heartbeat interval to avoid unneeded rebalance

2021-04-11 Thread GitBox
showuon commented on a change in pull request #10409: URL: https://github.com/apache/kafka/pull/10409#discussion_r611308156 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyInnerJoinMultiIntegrationTest.java ## @@ -154,8 +154,6 @@

[jira] [Commented] (KAFKA-12621) Kafka setup with Zookeeper- specifying an alternate znode creates the configuration at the wrong znode

2021-04-11 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318999#comment-17318999 ] Jordan Moore commented on KAFKA-12621: -- Based on various examples, you only need the znode on the

[GitHub] [kafka] ijuma commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin

2021-04-11 Thread GitBox
ijuma commented on pull request #10491: URL: https://github.com/apache/kafka/pull/10491#issuecomment-817450432 Started another build (the previous got canceled due to environmental issues). -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kamalcph commented on a change in pull request #10499: MINOR: Use the correct label while inspecting the docker images.

2021-04-11 Thread GitBox
kamalcph commented on a change in pull request #10499: URL: https://github.com/apache/kafka/pull/10499#discussion_r611300574 ## File path: tests/docker/ducker-ak ## @@ -217,6 +217,8 @@ ask_yes_no() { # $1: The name of the image to build. ducker_build() { local

[GitHub] [kafka] kamalcph commented on a change in pull request #10499: MINOR: Use the correct label while inspecting the docker images.

2021-04-11 Thread GitBox
kamalcph commented on a change in pull request #10499: URL: https://github.com/apache/kafka/pull/10499#discussion_r611300404 ## File path: tests/docker/ducker-ak ## @@ -311,15 +313,16 @@ use only ${num_nodes}." ducker_build "${image_name}" -docker inspect

[GitHub] [kafka] satishd commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-11 Thread GitBox
satishd commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r611288890 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -255,19 +261,21 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason {

[GitHub] [kafka] ijuma commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-11 Thread GitBox
ijuma commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-817431040 This PR has the same package in two separate jars. That is what's called "split packages" in the article above. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kowshik commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-11 Thread GitBox
kowshik commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-817414476 I just looked at the clients code under `kafka/clients/`. As an example to @ijuma's suggestion, I see the interface: `org.apache.kafka.common.KafkaFuture` and its

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-11 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r611267145 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,316 @@ +/* + *

[jira] [Updated] (KAFKA-12653) Reverse DNS Lookup on Zookeeper Connect String

2021-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Köcke updated KAFKA-12653: Description: Hey,    in my setup I try to set several zookeeper nodes within my kafka

[jira] [Updated] (KAFKA-12653) Reverse DNS Lookup on Zookeeper Connect String

2021-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Köcke updated KAFKA-12653: Description: Hey,    in my setup I try to set several zookeeper nodes within my kafka

[jira] [Updated] (KAFKA-12653) Reverse DNS Lookup on Zookeeper Connect String

2021-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Köcke updated KAFKA-12653: Description: Hey,    in my setup I try to set several zookeeper nodes within my kafka

[jira] [Updated] (KAFKA-12653) Reverse DNS Lookup on Zookeeper Connect String

2021-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Köcke updated KAFKA-12653: Description: Hey,    in my setup I try to set several zookeeper nodes within my kafka

[jira] [Created] (KAFKA-12653) Reverse DNS Lookup on Zookeeper Connect String

2021-04-11 Thread Jira
Christian Köcke created KAFKA-12653: --- Summary: Reverse DNS Lookup on Zookeeper Connect String Key: KAFKA-12653 URL: https://issues.apache.org/jira/browse/KAFKA-12653 Project: Kafka Issue

[GitHub] [kafka] ijuma edited a comment on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-11 Thread GitBox
ijuma edited a comment on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-817341612 One option is to use `log.remote.storage` as the public api package and add `internals` for the non public. That's similar to what we do for the clients api. We need to

[GitHub] [kafka] ijuma commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-11 Thread GitBox
ijuma commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-817341654 Also cc @kowshik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-11 Thread GitBox
ijuma commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-817341612 One option is to use `log.remote.storage` as the public api package and add `internals` for the non public. That's similar to what we do for the clients api. -- This is an

[GitHub] [kafka] ijuma commented on pull request #10524: MINOR: Use `testRuntimeOnly` instead of `testRuntime` in storage modules

2021-04-11 Thread GitBox
ijuma commented on pull request #10524: URL: https://github.com/apache/kafka/pull/10524#issuecomment-817339182 cc @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ijuma opened a new pull request #10524: MINOR: Use `testRuntimeOnly` instead of `testRuntime` in storage modules

2021-04-11 Thread GitBox
ijuma opened a new pull request #10524: URL: https://github.com/apache/kafka/pull/10524 `testRuntime` is deprecated in Gradle 6.x and has been removed in Gradle 7.0. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] ijuma commented on a change in pull request #10523: MINOR: Optimeze side effect brought by EpochState.canGrantVote

2021-04-11 Thread GitBox
ijuma commented on a change in pull request #10523: URL: https://github.com/apache/kafka/pull/10523#discussion_r611216846 ## File path: raft/src/main/java/org/apache/kafka/raft/CandidateState.java ## @@ -241,12 +236,14 @@ public int epoch() { } @Override -

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-04-11 Thread GitBox
jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r611214209 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1165,16 +1189,23 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-04-11 Thread GitBox
jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r611214209 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1165,16 +1189,23 @@ class KafkaApis(val requestChannel: RequestChannel, }

[jira] [Commented] (KAFKA-12651) Connect should register REST extensions before REST resources

2021-04-11 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318793#comment-17318793 ] Chris Egerton commented on KAFKA-12651: --- Whoops, turns out the REST resources aren't online

[jira] [Resolved] (KAFKA-12651) Connect should register REST extensions before REST resources

2021-04-11 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-12651. --- Resolution: Not A Problem > Connect should register REST extensions before REST resources >

[GitHub] [kafka] C0urante closed pull request #10521: KAFKA-12651: Register Connect REST extensions before bringing up REST resources

2021-04-11 Thread GitBox
C0urante closed pull request #10521: URL: https://github.com/apache/kafka/pull/10521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] C0urante commented on pull request #10521: KAFKA-12651: Register Connect REST extensions before bringing up REST resources

2021-04-11 Thread GitBox
C0urante commented on pull request #10521: URL: https://github.com/apache/kafka/pull/10521#issuecomment-817316483 Whoops, turns out the REST resources aren't online immediately after being registered and are only brought up at a [later

[jira] [Created] (KAFKA-12652) connector doesnt accept transformation configuration

2021-04-11 Thread amit cahanovich (Jira)
amit cahanovich created KAFKA-12652: --- Summary: connector doesnt accept transformation configuration Key: KAFKA-12652 URL: https://issues.apache.org/jira/browse/KAFKA-12652 Project: Kafka

[GitHub] [kafka] predatorray commented on pull request #5858: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-11 Thread GitBox
predatorray commented on pull request #5858: URL: https://github.com/apache/kafka/pull/5858#issuecomment-817269784 @viktorsomogyi I have opened the PR #10518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL