[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2021-04-17 Thread Aviral Srivastava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324391#comment-17324391 ] Aviral Srivastava commented on KAFKA-12506: --- Hi [~ableegoldman], upon running the command:

[GitHub] [kafka] wenbingshen commented on pull request #10553: MINOR: Fix the negative time difference value from Log.scala

2021-04-17 Thread GitBox
wenbingshen commented on pull request #10553: URL: https://github.com/apache/kafka/pull/10553#issuecomment-821914238 @dajac Can you take a look at this PR? Thanks. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] wenbingshen commented on pull request #10553: MINOR: Fix the negative time difference value from Log.scala

2021-04-17 Thread GitBox
wenbingshen commented on pull request #10553: URL: https://github.com/apache/kafka/pull/10553#issuecomment-821913990 @lbradstreet Can you take a look at this PR? I think you made a mistake by accident. :) -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324378#comment-17324378 ] Luke Chen commented on KAFKA-12675: --- Awesome! I'll also check your code to see how we can improve in

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-17 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r615204809 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataContext.java ## @@ -0,0 +1,83 @@ +/* + *

[jira] [Resolved] (KAFKA-9119) KIP-500: Replace ZooKeeper with a Metadata Quorum

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-9119. - Fix Version/s: 2.8.0 Resolution: Done > KIP-500: Replace ZooKeeper with a Metadata Quorum

[jira] [Commented] (KAFKA-9705) Zookeeper mutation protocols should be redirected to Controller only

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324370#comment-17324370 ] Colin McCabe commented on KAFKA-9705: - [~vvcephei]: this isn't a blocker for 2.8, but we will have to

[jira] [Resolved] (KAFKA-9125) GroupMetadataManager and TransactionStateManager should query the controller instead of zkClient

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-9125. - Fix Version/s: 2.8.0 Assignee: Ron Dagostino (was: Viktor Somogyi-Vass)

[jira] [Commented] (KAFKA-9125) GroupMetadataManager and TransactionStateManager should query the controller instead of zkClient

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324369#comment-17324369 ] Colin McCabe commented on KAFKA-9125: - We do indeed now get GroupMetadataManager and

[jira] [Updated] (KAFKA-10691) AlterIsr Respond with wrong Error Id

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-10691: - Labels: kip-500 (was: ) > AlterIsr Respond with wrong Error Id >

[jira] [Updated] (KAFKA-8820) kafka-reassign-partitions.sh should support the KIP-455 API

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-8820: Labels: kip-500 (was: ) > kafka-reassign-partitions.sh should support the KIP-455 API >

[jira] [Updated] (KAFKA-9119) KIP-500: Replace ZooKeeper with a Metadata Quorum

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9119: Labels: kip-500 (was: ) > KIP-500: Replace ZooKeeper with a Metadata Quorum >

[jira] [Updated] (KAFKA-9167) Implement a broker to controller request channel

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9167: Labels: kip-500 (was: ) > Implement a broker to controller request channel >

[jira] [Updated] (KAFKA-9154) ProducerId generation should be managed by the Controller

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9154: Labels: kip-500 (was: ) > ProducerId generation should be managed by the Controller >

[jira] [Updated] (KAFKA-9166) Implement MetadataFetch API

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9166: Labels: kip-500 (was: ) > Implement MetadataFetch API > --- > >

[jira] [Updated] (KAFKA-9154) ProducerId generation should be managed by the Controller

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9154: Parent: (was: KAFKA-9119) Issue Type: New Feature (was: Sub-task) > ProducerId

[jira] [Commented] (KAFKA-9154) ProducerId generation should be managed by the Controller

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324367#comment-17324367 ] Colin McCabe commented on KAFKA-9154: - [~satish.duggana]: [~mumrah] posted a KIP about this, KIP-730.

[jira] [Assigned] (KAFKA-9154) ProducerId generation should be managed by the Controller

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-9154: --- Assignee: David Arthur (was: Colin McCabe) > ProducerId generation should be managed by

[jira] [Updated] (KAFKA-9837) New RPC for notifying controller of failed replica

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9837: Parent: (was: KAFKA-9119) Issue Type: New Feature (was: Sub-task) > New RPC for

[jira] [Updated] (KAFKA-9837) New RPC for notifying controller of failed replica

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9837: Labels: kip-500 (was: ) > New RPC for notifying controller of failed replica >

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-17 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615310932 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[jira] [Resolved] (KAFKA-9166) Implement MetadataFetch API

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-9166. - Fix Version/s: 2.8.0 Resolution: Duplicate Closing as duplicate of KAFKA-10435 >

[jira] [Updated] (KAFKA-9118) LogDirFailureHandler shouldn't use Zookeeper

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9118: Parent: (was: KAFKA-9119) Issue Type: Improvement (was: Sub-task) >

[jira] [Commented] (KAFKA-9167) Implement a broker to controller request channel

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324359#comment-17324359 ] Colin McCabe commented on KAFKA-9167: - Closing as duplicate of KAFKA-10270 > Implement a broker to

[jira] [Resolved] (KAFKA-9124) KIP-497: ISR changes should be propagated via Kafka protocol

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-9124. - Fix Version/s: 2.7.0 Resolution: Fixed > KIP-497: ISR changes should be propagated via

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-17 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324358#comment-17324358 ] Travis Bischel commented on KAFKA-12675: Great insight on getting rid of

[jira] [Commented] (KAFKA-9124) KIP-497: ISR changes should be propagated via Kafka protocol

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324357#comment-17324357 ] Colin McCabe commented on KAFKA-9124: - [~mumrah] implemented this here:

[jira] [Assigned] (KAFKA-9124) KIP-497: ISR changes should be propagated via Kafka protocol

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-9124: --- Assignee: David Arthur (was: Colin McCabe) > KIP-497: ISR changes should be propagated via

[jira] [Commented] (KAFKA-9119) KIP-500: Replace ZooKeeper with a Metadata Quorum

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324356#comment-17324356 ] Colin McCabe commented on KAFKA-9119: - The upcoming Kafka 2.8 release now supports running in KRaft

[jira] [Resolved] (KAFKA-12345) KIP-500: AlterIsrManager crashes on broker idle-state

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12345. -- Fix Version/s: 2.8.0 Assignee: Boyang Chen Resolution: Fixed > KIP-500:

[jira] [Assigned] (KAFKA-12349) Follow up on PartitionEpoch in KIP-500

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12349: Assignee: Jason Gustafson (was: Colin McCabe) > Follow up on PartitionEpoch in KIP-500

[jira] [Commented] (KAFKA-12349) Follow up on PartitionEpoch in KIP-500

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324355#comment-17324355 ] Colin McCabe commented on KAFKA-12349: -- [~hachikuji] has a PR for removing the compatibility shim

[jira] [Resolved] (KAFKA-12276) Add KIP-500 controller code

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12276. -- Fix Version/s: 2.8.0 Resolution: Fixed > Add KIP-500 controller code >

[jira] [Resolved] (KAFKA-12282) KIP-500: Reconcile configuration variables between trunk and the KIP-500 branch

2021-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12282. -- Fix Version/s: 2.8.0 Resolution: Fixed > KIP-500: Reconcile configuration variables

[GitHub] [kafka] kebab-mai-haddi opened a new pull request #10554: Expand AdjustStreamThreadCountTest by writing some data to Kafka topics

2021-04-17 Thread GitBox
kebab-mai-haddi opened a new pull request #10554: URL: https://github.com/apache/kafka/pull/10554 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary

[GitHub] [kafka] kebab-mai-haddi closed pull request #10432: KAFKA-12506

2021-04-17 Thread GitBox
kebab-mai-haddi closed pull request #10432: URL: https://github.com/apache/kafka/pull/10432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Created] (KAFKA-12680) Failed to restart the broker in kraft mode

2021-04-17 Thread Wenbing Shen (Jira)
Wenbing Shen created KAFKA-12680: Summary: Failed to restart the broker in kraft mode Key: KAFKA-12680 URL: https://issues.apache.org/jira/browse/KAFKA-12680 Project: Kafka Issue Type: Bug

[GitHub] [kafka] wenbingshen opened a new pull request #10553: MINOR: Fix the negative time difference value from Log.scala

2021-04-17 Thread GitBox
wenbingshen opened a new pull request #10553: URL: https://github.com/apache/kafka/pull/10553 When I tested the kraft mode, I found that the time taken to load the snapshot in the startup log was negative. [2021-04-18 00:19:37,377] INFO [Log partition=@metadata-0,

[GitHub] [kafka] dejan2609 commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821841765 Ok, I finished my writings above (I just had to be as detailed as possible, these comments serve me a lot). > Could we reintroduce a configuration that behaves the same

[GitHub] [kafka] dejan2609 commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821841078 So, I started to abandon quick and dirty solution and to lean towards something heavier (i.e. to a some form of refactoring): -

[GitHub] [kafka] ijuma edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
ijuma edited a comment on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821839178 Could we reintroduce a configuration that behaves the same as `testRuntime` did before it was removed? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
ijuma commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821839178 Could we reintroduce a configuration that behaved the same as `testRuntime`? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dejan2609 edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
dejan2609 edited a comment on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821837798 Digging through project history I managed to find some commits that are seems to be related (see the comment): ``` project(':streams') { dependencies {

[GitHub] [kafka] dejan2609 edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
dejan2609 edited a comment on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821837798 Digging through project history I managed to find some commits that are seems to be related (see the comment): ``` project(':streams') { dependencies {

[GitHub] [kafka] dejan2609 commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821837798 Digging through project history I managed to find some commits that are seems to be related (see the comment): ``` project(':streams') { dependencies {

[jira] [Assigned] (KAFKA-12660) Do not update offset commit sensor after append failure

2021-04-17 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-12660: -- Assignee: dengziming > Do not update offset commit sensor after append failure >

[jira] [Resolved] (KAFKA-10783) Rewrite TopicPartitionStateZNode struct with auto-generated protocol

2021-04-17 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-10783. Resolution: Won't Do > Rewrite TopicPartitionStateZNode struct with auto-generated protocol >

[GitHub] [kafka] dejan2609 commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-17 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821831500 Also, after some digging I stumbled upon these GitHub resources (I will intentionally leave them formatted as code): - `https://github.com/gradle/gradle/issues/6353` -

[GitHub] [kafka] dejan2609 commented on pull request #10466: MINOR: Gradle upgrade: 6.8.3 -->> 7.0-rc-2 [work in progress]

2021-04-17 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821826801 I am going to split my findings to a separate comments... here it goes. I decided to work with Gradle 6.8.3 for the moment (that is, until circular dependency issue is

[GitHub] [kafka] ketulgupta1995 commented on pull request #10519: KAFKA-12344 Support SlidingWindows in the Scala API

2021-04-17 Thread GitBox
ketulgupta1995 commented on pull request #10519: URL: https://github.com/apache/kafka/pull/10519#issuecomment-821793666 Hi @lct45 removed the nits and checkstyle issues. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324204#comment-17324204 ] Luke Chen commented on KAFKA-12675: --- PR: [https://github.com/apache/kafka/pull/10552] [~twmb], I

[GitHub] [kafka] showuon commented on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-821792471 @ableegoldman , please help review this PR. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] wenbingshen commented on a change in pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest

2021-04-17 Thread GitBox
wenbingshen commented on a change in pull request #10551: URL: https://github.com/apache/kafka/pull/10551#discussion_r615229878 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -736,7 +735,6 @@ class

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229673 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -453,6 +453,43 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229332 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -527,12 +615,23 @@ private int

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229332 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -527,12 +615,23 @@ private int

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229166 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -387,58 +398,121 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615228815 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -362,23 +360,36 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615228600 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -387,58 +398,121 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615227866 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -313,26 +312,24 @@ private boolean

[GitHub] [kafka] showuon opened a new pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-04-17 Thread GitBox
showuon opened a new pull request #10552: URL: https://github.com/apache/kafka/pull/10552 I did code refactor, keep the same algorithm in this PR. I've achieved: 1. Originally, With this setting: ``` topicCount = 50; partitionCount = 800; consumerCount = 800; ``` We

[GitHub] [kafka] chia7712 commented on a change in pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest

2021-04-17 Thread GitBox
chia7712 commented on a change in pull request #10551: URL: https://github.com/apache/kafka/pull/10551#discussion_r615220275 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -736,7 +735,6 @@ class TopicCommandWithAdminClientTest

[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version

2021-04-17 Thread GitBox
feyman2016 commented on pull request #10377: URL: https://github.com/apache/kafka/pull/10377#issuecomment-821774667 Hi, I checked locally, all the failed tests should be unrelated: ``` Build / JDK 8 and Scala 2.12 /