dajac commented on pull request #10558:
URL: https://github.com/apache/kafka/pull/10558#issuecomment-822213853
@wenbingshen Thanks for the patch. Should we add a unit test to verify this
or perhaps extend an existing one?
--
This is an automated message from the Apache Git Service.
To re
wenbingshen commented on pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#issuecomment-822208422
> @wenbingshen thanks for your patch. LGTM
>
> Could you revise the title of this PR? I'd like to merge it tomorrow.
Of course, I will modify it now, thank y
wenbingshen commented on a change in pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#discussion_r615572667
##
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##
@@ -17,32 +17,27 @@
package kafka.admin
-import java.io.PrintStre
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r615228600
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +398,121 @@ private boolean all
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r615227866
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -313,26 +312,24 @@ private boolean allS
showuon commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-822200511
The performance comparison in jenkins for uniform subscription and non-equal
subscription with the setting:
```
topicCount = 500;
partitionCount = 2000;
consumerCount
chia7712 commented on a change in pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#discussion_r615554096
##
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##
@@ -17,32 +17,27 @@
package kafka.admin
-import java.io.PrintStream
wenbingshen commented on a change in pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#discussion_r615547868
##
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##
@@ -465,7 +465,7 @@ class TopicCommandWithAdminClientTest
wenbingshen commented on a change in pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#discussion_r615545404
##
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##
@@ -17,32 +17,27 @@
package kafka.admin
-import java.io.PrintStre
showuon commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822144126
@cmccabe , I think the root cause might need some time to get fix. Do you
think we should disable the tests first? Thanks.
--
This is an automated message from the Apache Git
showuon commented on a change in pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#discussion_r615524139
##
File path: core/src/test/scala/integration/kafka/server/RaftClusterTest.scala
##
@@ -22,14 +22,16 @@ import kafka.utils.TestUtils
import org.apache.ka
showuon opened a new pull request #10559:
URL: https://github.com/apache/kafka/pull/10559
Disable the flaky RaftClusterTest tests before the root cause KAFKA-12677
got fixed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Ve
[
https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324358#comment-17324358
]
Travis Bischel edited comment on KAFKA-12675 at 4/19/21, 3:33 AM:
[
https://issues.apache.org/jira/browse/KAFKA-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12485:
-
Assignee: Luke Chen
> Speed up Consumer#committed by returning cached offsets for owned partiti
chia7712 commented on a change in pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#discussion_r615517933
##
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##
@@ -17,32 +17,27 @@
package kafka.admin
-import java.io.PrintStream
[
https://issues.apache.org/jira/browse/KAFKA-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenbing Shen reassigned KAFKA-12684:
Assignee: Wenbing Shen
> The valid partition list is incorrectly replaced by the successf
wenbingshen commented on pull request #10558:
URL: https://github.com/apache/kafka/pull/10558#issuecomment-822129034
@dajac @chia7712 Can you help review it? Thanks. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
wenbingshen opened a new pull request #10558:
URL: https://github.com/apache/kafka/pull/10558
When using the kafka-election-tool for preferred replica election, if there
are partitions in the elected list that are in the preferred replica, the list
of partitions already in the preferred re
Wenbing Shen created KAFKA-12684:
Summary: The valid partition list is incorrectly replaced by the
successfully elected partition list
Key: KAFKA-12684
URL: https://issues.apache.org/jira/browse/KAFKA-12684
highluck commented on pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#issuecomment-822113308
@guozhangwang
There was an error in the code. Now I have fixed it and the tests are
running fine.
Thanks for review!
--
This is an automated message from the Apache Git
guozhangwang commented on pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#issuecomment-822036798
@highluck I read through the code, and it looks good to me overall. However
the unit test failure seems relevant:
```
org.apache.kafka.streams.processor.internals.
guozhangwang commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-822036454
@dongjinleekr @vvcephei just checking are you still working on it? I saw
@vvcephei has approved the PR but it was not yet merged, hence asking.
--
This is an automated mess
guozhangwang commented on pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#issuecomment-822036332
> @guozhangwang @highluck Sorry, I've been swamped with other things lately.
If you have a minute to review it yourself Guozhang I would appreciate it! Also
ping @cadonna or
guozhangwang merged pull request #10537:
URL: https://github.com/apache/kafka/pull/10537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
guozhangwang commented on pull request #10537:
URL: https://github.com/apache/kafka/pull/10537#issuecomment-822036117
Merged to trunk, thanks @spena !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/KAFKA-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324575#comment-17324575
]
Guozhang Wang commented on KAFKA-12669:
---
Hi [~dongjin] , thanks for your interests
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324574#comment-17324574
]
Guozhang Wang commented on KAFKA-9168:
--
Hi [~sagarrao] just for my own education cou
guozhangwang commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-822034184
@tombentley could you see if @hachikuji 's comments can be addressed? This
is a pretty tricky bug that I would like to get fixed in 3.0. Thanks!
--
This is an automated mes
guozhangwang commented on pull request #10557:
URL: https://github.com/apache/kafka/pull/10557#issuecomment-822032717
ping @abbccdda for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang opened a new pull request #10557:
URL: https://github.com/apache/kafka/pull/10557
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
Guozhang Wang created KAFKA-12683:
-
Summary: Remove deprecated "UsePreviousTimeOnInvalidTimeStamp"
Key: KAFKA-12683
URL: https://issues.apache.org/jira/browse/KAFKA-12683
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-12633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-12633.
---
Fix Version/s: 3.0.0
Resolution: Fixed
> Remove deprecated "TopologyTestDriver#pipeIn
guozhangwang merged pull request #10508:
URL: https://github.com/apache/kafka/pull/10508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
guozhangwang commented on pull request #10508:
URL: https://github.com/apache/kafka/pull/10508#issuecomment-822030658
> Looks like there are some related test failures, though.
Thanks! I have fixed the unit test, will merge after confirming green builds
locally.
--
This is an auto
[
https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324536#comment-17324536
]
Haoran Xuan commented on KAFKA-10800:
-
Hi, [~jagsancio], seems that the dependencies
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324517#comment-17324517
]
Wenbing Shen commented on KAFKA-12629:
--
Found another error log today:
One of the
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky updated KAFKA-12682:
--
Description:
In version 2.8, MetadataPartitionsBuilder has the field _localChanged and
_localRemoved which re
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky reopened KAFKA-12682:
---
> Kraft MetadataPartitionsBuilder _localChanged and _localRemoved out of order
> --
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky resolved KAFKA-12682.
---
Resolution: Not A Problem
> Kraft MetadataPartitionsBuilder _localChanged and _localRemoved out of order
>
wenbingshen commented on pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#issuecomment-821975837
Dear @ijuma @chia7712 Can you take a look at it？Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wenbingshen opened a new pull request #10556:
URL: https://github.com/apache/kafka/pull/10556
Remove some redundant parameters and configurations
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI buil
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-821968689
> Could we reintroduce a configuration that behaves the same as
`testRuntime` did before it was removed?
@ijuma Can you please expand on this ? Are you referring to a `
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky reopened KAFKA-12682:
---
> Kraft MetadataPartitionsBuilder _localChanged and _localRemoved out of order
> --
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky resolved KAFKA-12682.
---
Resolution: Not A Problem
> Kraft MetadataPartitionsBuilder _localChanged and _localRemoved out of order
>
IUSR opened a new pull request #10555:
URL: https://github.com/apache/kafka/pull/10555
* The initial capacities for some `HashMap` objects are less than expected
and result in resizing.
* Increase the initial capacity, similar to what `java.util.HashSet` does.
--
This is an automa
satishd commented on pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#issuecomment-821960939
Thanks @junrao for your comments. Addressed them with commit
[e909c7f](https://github.com/apache/kafka/pull/10271/commits/e909c7fc481945e54b7e364d2f52c9d191f988ec).
--
This is
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r615369734
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java
##
@@ -0,0 +1,1
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r615369347
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataContext.java
##
@@ -0,0 +1,83 @@
+/*
+ * License
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r615368480
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerdes.java
##
@@ -0,0 +1,56 @@
+/
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky updated KAFKA-12682:
--
Description:
In version 2.8, MetadataPartitionsBuilder has the field _localChanged and
_localRemoved which re
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jacky updated KAFKA-12682:
--
Description:
In version 2.8, MetadataPartitionsBuilder has the field _localChanged and
_localRemoved which re
51 matches
Mail list logo
