[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-23 Thread Haoran Xuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331149#comment-17331149 ] Haoran Xuan commented on KAFKA-10800: - [~jagsancio]  Thanks for the clarification, now I'm clear

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619559055 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -126,10 +129,10 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619558964 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -111,6 +113,7 @@ private

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619558819 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java ## @@ -115,7 +115,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619558551 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -603,7 +606,7 @@ boolean runLoop() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619557786 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -291,23 +293,35 @@ * * Enabling exactly-once

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619557404 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619557012 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619556206 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619555279 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619554270 ## File path: docs/streams/upgrade-guide.html ## @@ -53,17 +53,19 @@ Upgrade Guide and API Changes -Starting in Kafka Streams

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-23 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r619545527 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataContext.java ## @@ -0,0 +1,74 @@ +/* + *

[jira] [Commented] (KAFKA-12711) Add a back off option to replace thread

2021-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331098#comment-17331098 ] Guozhang Wang commented on KAFKA-12711: --- On the other hand, I think maybe we do not, at least in

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331097#comment-17331097 ] Guozhang Wang commented on KAFKA-10493: --- Without KIP-280, it would always be an issue; what I'm

[jira] [Commented] (KAFKA-12711) Add a back off option to replace thread

2021-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331095#comment-17331095 ] Guozhang Wang commented on KAFKA-12711: --- I'm +1 for this feature. Generally speaking, we should

[GitHub] [kafka] vitojeng commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-23 Thread GitBox
vitojeng commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-825981428 > Merged to trunk, ready for the next PR  Will do, thanks @ableegoldman ! :) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-23 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619504008 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -642,7 +647,10 @@ public void beginTransaction() throws

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331042#comment-17331042 ] Matthias J. Sax commented on KAFKA-10493: - Not sure if I understand the idea about "restore by

[jira] [Updated] (KAFKA-12711) Add a back off option to replace thread

2021-04-23 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12711: --- Description: There should be a native option to set a back off period when replacing a

[jira] [Updated] (KAFKA-12711) Add a back off option to replace thread

2021-04-23 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12711: --- Summary: Add a back off option to replace thread (was: Add a back off option to Replace

[jira] [Updated] (KAFKA-12711) Add a back off option to Replace thread

2021-04-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12711: Labels: needs-kip (was: ) > Add a back off option to Replace thread >

[GitHub] [kafka] ableegoldman commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-23 Thread GitBox
ableegoldman commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-825863470 Merged to trunk, ready for the next PR  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ableegoldman merged pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-23 Thread GitBox
ableegoldman merged pull request #9821: URL: https://github.com/apache/kafka/pull/9821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-23 Thread GitBox
ableegoldman commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-825862826 Just two unrelated test failures in the build: `connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()`

[jira] [Commented] (KAFKA-12710) Consider enabling (at least some) optimizations by default

2021-04-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330995#comment-17330995 ] A. Sophie Blee-Goldman commented on KAFKA-12710: Thanks, I'd forgotten about that KIP.

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330987#comment-17330987 ] Guozhang Wang commented on KAFKA-10493: --- While thinking about

[jira] [Updated] (KAFKA-12693) Consecutive rebalances with zombie instances may cause corrupted changelogs

2021-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12693: -- Labels: streams (was: ) > Consecutive rebalances with zombie instances may cause corrupted

[jira] [Commented] (KAFKA-12710) Consider enabling (at least some) optimizations by default

2021-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330979#comment-17330979 ] Guozhang Wang commented on KAFKA-12710: --- Thanks [~ableegoldman], this seems relevant to

[GitHub] [kafka] guozhangwang commented on a change in pull request #10587: KAFKA-8897: Upgrade RocksDB to 6.8.1

2021-04-23 Thread GitBox
guozhangwang commented on a change in pull request #10587: URL: https://github.com/apache/kafka/pull/10587#discussion_r619416799 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@

[jira] [Updated] (KAFKA-12712) KRaft: Missing controller.quorom.voters config not properly handled

2021-04-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12712: Fix Version/s: 3.0.0 > KRaft: Missing controller.quorom.voters config not properly handled >

[jira] [Comment Edited] (KAFKA-10619) Producer will enable EOS by default

2021-04-23 Thread Soumyajit Sahu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329915#comment-17329915 ] Soumyajit Sahu edited comment on KAFKA-10619 at 4/23/21, 5:47 PM: -- Hi

[jira] [Comment Edited] (KAFKA-10619) Producer will enable EOS by default

2021-04-23 Thread Soumyajit Sahu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329915#comment-17329915 ] Soumyajit Sahu edited comment on KAFKA-10619 at 4/23/21, 5:45 PM: -- Hi

[jira] [Comment Edited] (KAFKA-12698) CVE-2019-25013 high priority vulnerability reported in Kafka

2021-04-23 Thread Andrew May (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330927#comment-17330927 ] Andrew May edited comment on KAFKA-12698 at 4/23/21, 5:14 PM: -- That

[jira] [Commented] (KAFKA-12698) CVE-2019-25013 high priority vulnerability reported in Kafka

2021-04-23 Thread Andrew May (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330927#comment-17330927 ] Andrew May commented on KAFKA-12698: That vulnerability is a glibc one, so I'm not sure why it's

[GitHub] [kafka] guozhangwang merged pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-23 Thread GitBox
guozhangwang merged pull request #9640: URL: https://github.com/apache/kafka/pull/9640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] guozhangwang commented on pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-23 Thread GitBox
guozhangwang commented on pull request #9640: URL: https://github.com/apache/kafka/pull/9640#issuecomment-825795078 LGTM! And merged to trunk. Thanks @highluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-12712) KRaft: Missing controller.quorom.voters config not properly handled

2021-04-23 Thread Magnus Edenhill (Jira)
Magnus Edenhill created KAFKA-12712: --- Summary: KRaft: Missing controller.quorom.voters config not properly handled Key: KAFKA-12712 URL: https://issues.apache.org/jira/browse/KAFKA-12712 Project:

[jira] [Closed] (KAFKA-12691) TaskMetadata timeSinceIdlingStarted not reporting correctly

2021-04-23 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-12691. -- > TaskMetadata timeSinceIdlingStarted not reporting correctly >

[jira] [Updated] (KAFKA-12711) Add a back off option to Replace thread

2021-04-23 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12711: --- Description: There should be a native option to set a back off period when replacing a

[jira] [Created] (KAFKA-12711) Add a back off option to Replace thread

2021-04-23 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12711: -- Summary: Add a back off option to Replace thread Key: KAFKA-12711 URL: https://issues.apache.org/jira/browse/KAFKA-12711 Project: Kafka Issue Type:

[GitHub] [kafka] bruto1 opened a new pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-04-23 Thread GitBox
bruto1 opened a new pull request #10590: URL: https://github.com/apache/kafka/pull/10590 Allows to use pooled byte buffer implementations to serialize record value before calling KafkaProducer.send and reclaim the buffer afterwards, thus reducing unnecessary allocations and GC pressure

[GitHub] [kafka] vamossagar12 commented on pull request #10542: KAFKA-12313: Streamling windowed Deserialiser configs.

2021-04-23 Thread GitBox
vamossagar12 commented on pull request #10542: URL: https://github.com/apache/kafka/pull/10542#issuecomment-825558068 Thanks @ableegoldman , actually i think i had updated the ticket as well that we need to include serialisers as well. i have updated the KIP. and sent it again for

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330116#comment-17330116 ] Matthias J. Sax commented on KAFKA-10493: - {quote}What is worse not dropping out-of-order

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-23 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825451248 @chia7712 , please take a look. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] showuon edited a comment on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-23 Thread GitBox
showuon edited a comment on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825382213 Failed test cases are unrelated and flaky (all passed in my local env). Thanks. `tests/Build/JDK 11 and Scala 2.13` --> all tests passed ``` Build / JDK 15 and

[jira] [Commented] (KAFKA-12698) CVE-2019-25013 high priority vulnerability reported in Kafka

2021-04-23 Thread priya Vijay (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330046#comment-17330046 ] priya Vijay commented on KAFKA-12698: - can someone please provide some insight in to this, Is Kafka

[jira] [Updated] (KAFKA-12698) CVE-2019-25013 high priority vulnerability reported in Kafka

2021-04-23 Thread priya Vijay (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] priya Vijay updated KAFKA-12698: Summary: CVE-2019-25013 high priority vulnerability reported in Kafka (was: CVE-2019-25013

[GitHub] [kafka] highluck commented on pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-23 Thread GitBox
highluck commented on pull request #9640: URL: https://github.com/apache/kafka/pull/9640#issuecomment-825427682 @guozhangwang Yes, I checked, but the logic was not changed except for assignActiveToConsumer, so the test is consistent. There seems to be no problem locally! -- This