[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331366#comment-17331366 ] Patrick O'Keeffe commented on KAFKA-12453: -- Thanks for the explanation [~mjsax]

[GitHub] [kafka] feyman2016 closed pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

feyman2016 closed pull request #10593: URL: https://github.com/apache/kafka/pull/10593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [kafka] feyman2016 opened a new pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

feyman2016 opened a new pull request #10593: URL: https://github.com/apache/kafka/pull/10593 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary

[GitHub] [kafka] dengziming commented on pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

dengziming commented on pull request #10592: URL: https://github.com/apache/kafka/pull/10592#issuecomment-826196454 @kowshik , Thank you for your suggestions, I have rewritten the code according to your comments, PTAL again. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331319#comment-17331319 ] Matthias J. Sax commented on KAFKA-10493: - {quote}Without KIP-280, it would alwa

[jira] [Commented] (KAFKA-12713) Report "REAL" broker/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331311#comment-17331311 ] Ismael Juma commented on KAFKA-12713: - It would definitely be useful to have a bette

[GitHub] [kafka] bruto1 edited a comment on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

bruto1 edited a comment on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-826126350 I guess the failing tests are par for the course here pls review! @chia7712 ? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] bruto1 commented on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

bruto1 commented on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-826126350 I guess the failing tests are par for the course here pls review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Updated] (KAFKA-12713) Report "REAL" broker/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming Liu updated KAFKA-12713: - Summary: Report "REAL" broker/consumer fetch latency (was: Report broker/consumer fetch latency more ac

[jira] [Created] (KAFKA-12713) Report broker/consumer fetch latency more accurately

Ming Liu created KAFKA-12713: Summary: Report broker/consumer fetch latency more accurately Key: KAFKA-12713 URL: https://issues.apache.org/jira/browse/KAFKA-12713 Project: Kafka Issue Type: Bug

[GitHub] [kafka] kowshik commented on a change in pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

kowshik commented on a change in pull request #10592: URL: https://github.com/apache/kafka/pull/10592#discussion_r619682506 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala ## @@ -35,6 +39,17 @@ class LogSegmentsTest { LogTestUtils.createSegment(offse

[GitHub] [kafka] kowshik commented on a change in pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

kowshik commented on a change in pull request #10592: URL: https://github.com/apache/kafka/pull/10592#discussion_r619682506 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala ## @@ -35,6 +39,17 @@ class LogSegmentsTest { LogTestUtils.createSegment(offse

[jira] [Commented] (KAFKA-5761) Serializer API should support ByteBuffer

[ https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331240#comment-17331240 ] Kirill Rodionov commented on KAFKA-5761: please see https://github.com/apache/kaf

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331232#comment-17331232 ] Haoran Xuan commented on KAFKA-10800: - I got you~ And yeah, I was also thinking tha

[GitHub] [kafka] dengziming commented on pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

dengziming commented on pull request #10592: URL: https://github.com/apache/kafka/pull/10592#issuecomment-826089682 Hello, @kowshik PTAL, also cc @junrao . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] AndroideRob opened a new pull request #10591: Fix minor bugs in the existing documentation

AndroideRob opened a new pull request #10591: URL: https://github.com/apache/kafka/pull/10591 Just finished reading the official docs, found some inconsistencies, here they are -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331194#comment-17331194 ] Jose Armando Garcia Sancio commented on KAFKA-10800: {quote}I think

[GitHub] [kafka] dejan2609 commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-826067611 @ijuma quick update: I did made some progress developing a ~~_quick and dirty_~~ **fast** solution for this... will update this ticket today or tomorrow. -- This is an auto

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331171#comment-17331171 ] Bruno Cadonna commented on KAFKA-10493: --- Are you proposing to drop out-of-order re