[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619989241 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records,

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619988848 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records,

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619988848 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records,

[jira] [Assigned] (KAFKA-12535) Consider Revising Document Anchors for Properties

2021-04-25 Thread Minoru Tomioka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Minoru Tomioka reassigned KAFKA-12535: -- Assignee: (was: Minoru Tomioka) > Consider Revising Document Anchors for

[GitHub] [kafka] socutes opened a new pull request #10596: KAFKA-12715: ACL authentication, Host field support IP network segment

2021-04-25 Thread GitBox
socutes opened a new pull request #10596: URL: https://github.com/apache/kafka/pull/10596 At present, ACL authentication, the Host field only supports equal matching of source IP, so we hope that the Host field can support matching of IP network segment. ### Committer Checklist

[GitHub] [kafka] socutes closed pull request #10594: Merge pull request #1 from apache/trunk

2021-04-25 Thread GitBox
socutes closed pull request #10594: URL: https://github.com/apache/kafka/pull/10594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] mjsax commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-25 Thread GitBox
mjsax commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-826417134 Seems there is some checkstyle error: ``` [2021-04-22T23:02:56.789Z] [ant:checkstyle] [ERROR]

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[jira] [Comment Edited] (KAFKA-12713) Report "REAL" broker/consumer fetch latency

2021-04-25 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331590#comment-17331590 ] Ming Liu edited comment on KAFKA-12713 at 4/25/21, 11:16 PM: - The idea is:

[GitHub] [kafka] ijuma commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

2021-04-25 Thread GitBox
ijuma commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-826400303 @dejan2609 can you please rebase on trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] ijuma commented on a change in pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

2021-04-25 Thread GitBox
ijuma commented on a change in pull request #10466: URL: https://github.com/apache/kafka/pull/10466#discussion_r619889058 ## File path: build.gradle ## @@ -1491,13 +1491,14 @@ project(':streams') { } tasks.create(name: "copyDependantLibs", type: Copy) { -from

[GitHub] [kafka] ijuma commented on a change in pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

2021-04-25 Thread GitBox
ijuma commented on a change in pull request #10466: URL: https://github.com/apache/kafka/pull/10466#discussion_r619888968 ## File path: build.gradle ## @@ -1491,13 +1491,14 @@ project(':streams') { } tasks.create(name: "copyDependantLibs", type: Copy) { -from

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619882204 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1335,6 +1313,51 @@ public void

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619882084 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records,

[jira] [Updated] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-10800: --- Description: When the state machine attempts to create a snapshot

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619878083 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -126,10 +129,10 @@ public void setup() {

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619877817 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -111,6 +113,7 @@ private final

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619877425 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -603,7 +606,7 @@ boolean runLoop() {

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619876369 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619876217 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-25 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r619875764 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +95,12 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-04-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331635#comment-17331635 ] Matthias J. Sax commented on KAFKA-12453: - Thanks for asking. In general 3rd parties hold the

[GitHub] [kafka] dejan2609 commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

2021-04-25 Thread GitBox
dejan2609 commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-826381116 @ijuma So, now I have something to show: I managed perform some reverse-engineering and received exactly the same content in `/streams/build/dependent-libs-${version.scala}`

[GitHub] [kafka] wenbingshen opened a new pull request #10595: MINOR: Add some metrics names

2021-04-25 Thread GitBox
wenbingshen opened a new pull request #10595: URL: https://github.com/apache/kafka/pull/10595 As the title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[jira] [Comment Edited] (KAFKA-12713) Report "REAL" broker/consumer fetch latency

2021-04-25 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331590#comment-17331590 ] Ming Liu edited comment on KAFKA-12713 at 4/25/21, 5:33 PM: The idea I am

[jira] [Commented] (KAFKA-12713) Report "REAL" broker/consumer fetch latency

2021-04-25 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331590#comment-17331590 ] Ming Liu commented on KAFKA-12713: -- The idea is like this,  we can: 1. Add waitTimeMS in FetchResponse.

[GitHub] [kafka] socutes opened a new pull request #10594: Merge pull request #1 from apache/trunk

2021-04-25 Thread GitBox
socutes opened a new pull request #10594: URL: https://github.com/apache/kafka/pull/10594 merge *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[jira] [Commented] (KAFKA-12715) ACL authentication, Host field support IP network segment

2021-04-25 Thread xu lobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331526#comment-17331526 ] xu lobo commented on KAFKA-12715: - I could add this feature and would like to hear from the community。

[jira] [Created] (KAFKA-12715) ACL authentication, Host field support IP network segment

2021-04-25 Thread xu lobo (Jira)
xu lobo created KAFKA-12715: --- Summary: ACL authentication, Host field support IP network segment Key: KAFKA-12715 URL: https://issues.apache.org/jira/browse/KAFKA-12715 Project: Kafka Issue Type:

[jira] [Resolved] (KAFKA-12702) Unhandled exception caught in InterBrokerSendThread

2021-04-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12702. Fix Version/s: 2.8.1 3.0.0 Resolution: Fixed > Unhandled

[GitHub] [kafka] chia7712 commented on pull request #10586: KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8

2021-04-25 Thread GitBox
chia7712 commented on pull request #10586: URL: https://github.com/apache/kafka/pull/10586#issuecomment-826324896 @wenbingshen thanks for this backport! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] chia7712 merged pull request #10586: KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8

2021-04-25 Thread GitBox
chia7712 merged pull request #10586: URL: https://github.com/apache/kafka/pull/10586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] chia7712 merged pull request #10558: KAFKA-12684: Fix noop set is incorrectly replaced with succeeded set from LeaderElectionCommand

2021-04-25 Thread GitBox
chia7712 merged pull request #10558: URL: https://github.com/apache/kafka/pull/10558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (KAFKA-12684) The valid partition list is incorrectly replaced by the successfully elected partition list

2021-04-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12684. Resolution: Fixed > The valid partition list is incorrectly replaced by the successfully

[GitHub] [kafka] chia7712 commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-25 Thread GitBox
chia7712 commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-826320025 @showuon thanks for this patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 merged pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-25 Thread GitBox
chia7712 merged pull request #9627: URL: https://github.com/apache/kafka/pull/9627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (KAFKA-12714) Kafka 2.8 server not starting on Windows OS

2021-04-25 Thread Rajni Jain (Jira)
Rajni Jain created KAFKA-12714: -- Summary: Kafka 2.8 server not starting on Windows OS Key: KAFKA-12714 URL: https://issues.apache.org/jira/browse/KAFKA-12714 Project: Kafka Issue Type: Bug

[GitHub] [kafka] tang7526 commented on a change in pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-04-25 Thread GitBox
tang7526 commented on a change in pull request #10588: URL: https://github.com/apache/kafka/pull/10588#discussion_r619798137 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -190,6 +166,51 @@ public static void main(String[] args) throws

[GitHub] [kafka] tang7526 commented on a change in pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-04-25 Thread GitBox
tang7526 commented on a change in pull request #10588: URL: https://github.com/apache/kafka/pull/10588#discussion_r619798057 ## File path: build.gradle ## @@ -1485,7 +1485,7 @@ project(':tools') { testImplementation libs.junitJupiter testImplementation

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread Haoran Xuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331498#comment-17331498 ] Haoran Xuan commented on KAFKA-10800: - [~jagsancio] The PR [GitHub Pull Request

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-826304130 @jsancio Could you please help to review? Thanks! Locally verified, all the failed tests should not be related. See failed tests in

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619795184 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records,

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619793903 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1335,6 +1313,51 @@ public void

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619793844 ## File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterTest.java ## @@ -38,7 +38,7 @@ @Test public void

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-25 Thread GitBox
feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619793709 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java ## @@ -96,7 +96,7 @@ public BatchBuilder( } /** - *