[jira] [Resolved] (KAFKA-12661) ConfigEntry#equal does not compare other fields when value is NOT null

2021-05-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12661. Fix Version/s: 3.0.0 Resolution: Fixed > ConfigEntry#equal does not compare other

[GitHub] [kafka] chia7712 merged pull request #10446: KAFKA-12661 ConfigEntry#equal does not compare other fields when value is NOT null

2021-05-01 Thread GitBox
chia7712 merged pull request #10446: URL: https://github.com/apache/kafka/pull/10446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] chia7712 commented on pull request #10446: KAFKA-12661 ConfigEntry#equal does not compare other fields when value is NOT null

2021-05-01 Thread GitBox
chia7712 commented on pull request #10446: URL: https://github.com/apache/kafka/pull/10446#issuecomment-830741353 ``` Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions() ``` unrelated error. Merge this PR to

[GitHub] [kafka] tang7526 commented on pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-05-01 Thread GitBox
tang7526 commented on pull request #10588: URL: https://github.com/apache/kafka/pull/10588#issuecomment-830735655 > @tang7526 , thanks for the patch! Could we add some tests for the `argParser`? ex: try pass unexpected arguments and verify the error thrown. Thanks. @showuon Thank

[jira] [Comment Edited] (KAFKA-12605) kafka consumer churns through buffer memory iterating over records

2021-05-01 Thread radai rosenblatt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337897#comment-17337897 ] radai rosenblatt edited comment on KAFKA-12605 at 5/2/21, 12:37 AM:

[jira] [Commented] (KAFKA-12605) kafka consumer churns through buffer memory iterating over records

2021-05-01 Thread radai rosenblatt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337897#comment-17337897 ] radai rosenblatt commented on KAFKA-12605: -- PR files against trunk -

[GitHub] [kafka] radai-rosenblatt opened a new pull request #10624: KAFKA-12605 - make GZIP decompression use BufferSupplier

2021-05-01 Thread GitBox
radai-rosenblatt opened a new pull request #10624: URL: https://github.com/apache/kafka/pull/10624 as laid out in https://issues.apache.org/jira/browse/KAFKA-12605 kafka consumers decoding gzip'ed payloads currently do not re-use memory buffers because the JDK classes used have no support

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2021-05-01 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337896#comment-17337896 ] Ning Zhang commented on KAFKA-12635: > This state can be reached if the source consumer group

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2021-05-01 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337894#comment-17337894 ] Ning Zhang commented on KAFKA-12635: hi [~dragotic] could you please elaborate on how you can

[GitHub] [kafka] wenbingshen opened a new pull request #10623: MINOR: Clean up some redundant code from ReplicaManager

2021-05-01 Thread GitBox
wenbingshen opened a new pull request #10623: URL: https://github.com/apache/kafka/pull/10623 1. brokerEpoch has been processed in handleStopReplicaRequest, and has no practical effect in ReplicaManager.stopReplicas. 2. responseMap.put(topicPartition, Errors.forException(e)) has a

[jira] [Resolved] (KAFKA-12154) API and implementation for snapshot loading

2021-05-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12154. - Resolution: Fixed > API and implementation for snapshot loading >

[GitHub] [kafka] hachikuji merged pull request #10085: KAFKA-12154: Snapshot Loading API

2021-05-01 Thread GitBox
hachikuji merged pull request #10085: URL: https://github.com/apache/kafka/pull/10085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ijuma commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-01 Thread GitBox
ijuma commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r624529198 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[GitHub] [kafka] lbradstreet commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-01 Thread GitBox
lbradstreet commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r624525594 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[GitHub] [kafka] lbradstreet commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-01 Thread GitBox
lbradstreet commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r624525594 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[jira] [Resolved] (KAFKA-12683) Remove deprecated "UsePreviousTimeOnInvalidTimeStamp"

2021-05-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12683. --- Fix Version/s: 3.0.0 Assignee: Guozhang Wang Resolution: Fixed > Remove

[GitHub] [kafka] guozhangwang merged pull request #10622: MINOR: Remove unused Utils.delete

2021-05-01 Thread GitBox
guozhangwang merged pull request #10622: URL: https://github.com/apache/kafka/pull/10622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] guozhangwang merged pull request #10557: KAFKA-12683: Remove deprecated UsePreviousTimeOnInvalidTimestamp

2021-05-01 Thread GitBox
guozhangwang merged pull request #10557: URL: https://github.com/apache/kafka/pull/10557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] lbradstreet commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-01 Thread GitBox
lbradstreet commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r624525594 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[GitHub] [kafka] chia7712 merged pull request #10604: MINOR: system test spelling/pydoc/dead code fixes

2021-05-01 Thread GitBox
chia7712 merged pull request #10604: URL: https://github.com/apache/kafka/pull/10604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] chia7712 commented on a change in pull request #10619: MINOR: Update test libraries and gradle plugins for better JDK 16/17 support

2021-05-01 Thread GitBox
chia7712 commented on a change in pull request #10619: URL: https://github.com/apache/kafka/pull/10619#discussion_r624523356 ## File path: build.gradle ## @@ -30,15 +30,15 @@ buildscript { } plugins { - id 'com.diffplug.spotless' version '5.10.2' - id

[GitHub] [kafka] ijuma commented on a change in pull request #10446: KAFKA-12661 ConfigEntry#equal does not compare other fields when value is NOT null

2021-05-01 Thread GitBox
ijuma commented on a change in pull request #10446: URL: https://github.com/apache/kafka/pull/10446#discussion_r624518845 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -803,7 +803,14 @@ class ConfigCommandTest extends ZooKeeperTestHarness

[GitHub] [kafka] ijuma commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-01 Thread GitBox
ijuma commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r624518310 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[GitHub] [kafka] feyman2016 removed a comment on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-01 Thread GitBox
feyman2016 removed a comment on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-830564003 @jsancio Hi, I addressed the comments and the failed tests should not be related -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-01 Thread GitBox
feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-830563990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For