[jira] [Comment Edited] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339995#comment-17339995 ] Travis Bischel edited comment on KAFKA-12671 at 5/6/21, 6:45 AM: -

[jira] [Commented] (KAFKA-10442) Tooling to detect and abort hanging transactions (KIP-664)

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340029#comment-17340029 ] Travis Bischel commented on KAFKA-10442: I believe that KAFKA-12671 is related t

[GitHub] [kafka] satishd opened a new pull request #10638: MINOR Added `server-common` module to have server side common classes.

2021-05-05 Thread GitBox
satishd opened a new pull request #10638: URL: https://github.com/apache/kafka/pull/10638 MINOR Added `server-common` module to have server side common classes. Moved ApiMessageAndVersion, RecordSerde, AbstractApiMessageSerde, and BytesApiMessageSerde to server-common module.

[GitHub] [kafka] chia7712 commented on pull request #10637: MINOR: remove storage/src/generated from tracked files

2021-05-05 Thread GitBox
chia7712 commented on pull request #10637: URL: https://github.com/apache/kafka/pull/10637#issuecomment-833258233 @satishd @kowshik FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] chia7712 opened a new pull request #10637: MINOR: remove storage/src/generated from tracked files

2021-05-05 Thread GitBox
chia7712 opened a new pull request #10637: URL: https://github.com/apache/kafka/pull/10637 related to #10271 The generated code from other modules have beed excluded from tracked files. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementa

[GitHub] [kafka] dengziming commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-05 Thread GitBox
dengziming commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r627099786 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -242,85 +246,125 @@ final class KafkaMetadataLog private ( } override

[GitHub] [kafka] satishd closed pull request #10578: MINOR Moved ApiMessageAndVersion and AbstractApiMessageAndVersionSerde to clients module.

2021-05-05 Thread GitBox
satishd closed pull request #10578: URL: https://github.com/apache/kafka/pull/10578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Priority: Blocker (was: Critical) > Out of order processing with a transactional producer c

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Labels: Transactions (was: ) > Out of order processing with a transactional producer can le

[GitHub] [kafka] ableegoldman commented on pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
ableegoldman commented on pull request #10635: URL: https://github.com/apache/kafka/pull/10635#issuecomment-833225272 Merged to trunk -- let's hope these good results continue. I'm going to close the ticket again so people are more likely to report it if they see things to continue to brea

[GitHub] [kafka] ableegoldman merged pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
ableegoldman merged pull request #10635: URL: https://github.com/apache/kafka/pull/10635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339995#comment-17339995 ] Travis Bischel commented on KAFKA-12671: The only fix for this if it occurs is t

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Affects Version/s: (was: 2.6.2) (was: 2.6.1)

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-05 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Affects Version/s: 2.2.2 2.4.0 2.3.1

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-833207399 Thank you very much, @ableegoldman ! Let's make it better together! :) I'll address the rest of comments in another PR. And I'll also refine my another PR(https://github.com/a

[GitHub] [kafka] showuon commented on pull request #10610: MINOR: replace deprecated Class.newInstance() to new one

2021-05-05 Thread GitBox
showuon commented on pull request #10610: URL: https://github.com/apache/kafka/pull/10610#issuecomment-833206456 @rhauch , could you help review this simple PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] showuon commented on pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
showuon commented on pull request #10635: URL: https://github.com/apache/kafka/pull/10635#issuecomment-833204958 @ableegoldman , the failed tests are all flaky. (3 `RaftClusterTest`, and 1 `testMetricsDuringTopicCreateDelete` traced in KAFKA-9009). And most importantly, no failed `shouldIn

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2021-05-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339976#comment-17339976 ] Luke Chen commented on KAFKA-9009: -- Failed again. [https://ci-builds.apache.org/job/Kaf

[GitHub] [kafka] dengziming commented on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-05-05 Thread GitBox
dengziming commented on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-833187678 ping @mumrah to have a look 😉. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-05 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627027404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -314,22 +321,24 @@ class SessionErrorContext(val error: Errors, override def fore

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-05 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627027261 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -319,12 +355,25 @@ public int maxBytes() { return dat

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-05 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627026623 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -820,20 +838,30 @@ class KafkaApis(val requestChannel: RequestChannel, def creat

[GitHub] [kafka] ableegoldman merged pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman merged pull request #10509: URL: https://github.com/apache/kafka/pull/10509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627021459 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627020968 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] shayelkin opened a new pull request #10636: MINOR: Bump Jersey deps to 2.34 due to CVE-2021-28168

2021-05-05 Thread GitBox
shayelkin opened a new pull request #10636: URL: https://github.com/apache/kafka/pull/10636 The version of the Eclipse Jersey library brought as dependences, 2.31, has a known vulnerability, CVE-2021-28168 (https://github.com/advisories/GHSA-c43q-5hpj-4crv). This replaces it with

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627020382 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627019548 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-05 Thread GitBox
junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r625422142 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +438,27 @@ class IncrementalFetchContext(private val time: Time, val

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627016997 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627015270 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627016286 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627015270 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627014485 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] showuon commented on pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
showuon commented on pull request #10635: URL: https://github.com/apache/kafka/pull/10635#issuecomment-833152754 This should be merged soon, and I'm confident increasing the timeout will reduce the number of failure a lot. 🤞 Let's wait for the jenkins build. :) -- This is an automated me

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r627012042 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -149,141 +149,210 @@ private boole

[GitHub] [kafka] wcarlson5 commented on pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-05 Thread GitBox
wcarlson5 commented on pull request #10634: URL: https://github.com/apache/kafka/pull/10634#issuecomment-833150214 @ableegoldman yep it looks like I am going to have to go back to the drawing board for either the test or the impl. I will look at it tomorrow -- This is an automated messag

[GitHub] [kafka] ableegoldman commented on pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
ableegoldman commented on pull request #10635: URL: https://github.com/apache/kafka/pull/10635#issuecomment-833149684 Just ping me when the build passes, you know the drill 🙂 By the way, even if it does fail at another point later on in this test, I'd like to go ahead and merge this

[GitHub] [kafka] showuon commented on pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
showuon commented on pull request #10635: URL: https://github.com/apache/kafka/pull/10635#issuecomment-833148107 @ableegoldman , please take a look. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon opened a new pull request #10635: KAFKA-9295: increase start stream timeout

2021-05-05 Thread GitBox
showuon opened a new pull request #10635: URL: https://github.com/apache/kafka/pull/10635 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] dosvath commented on pull request #10375: KAFKA-12522: Cast SMT should allow null value records to pass through

2021-05-05 Thread GitBox
dosvath commented on pull request #10375: URL: https://github.com/apache/kafka/pull/10375#issuecomment-833132393 @ewencp @mjsax one more ping on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-05 Thread GitBox
ableegoldman commented on pull request #10634: URL: https://github.com/apache/kafka/pull/10634#issuecomment-833125376 @wcarlson5 there's a failure that I'm guessing is related: `streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation` -- This is

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r626990213 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r626989130 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-05-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339937#comment-17339937 ] Luke Chen commented on KAFKA-9295: -- Let me create another PR for it later. > KTableKTab

[jira] [Resolved] (KAFKA-8531) Change default replication factor config

2021-05-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-8531. Resolution: Fixed > Change default replication factor config >

[GitHub] [kafka] mjsax merged pull request #10532: KAFKA-8531: Change default replication factor config

2021-05-05 Thread GitBox
mjsax merged pull request #10532: URL: https://github.com/apache/kafka/pull/10532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r626176038 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -396,6 +396,21 @@ public void clo

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r626971805 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -

[GitHub] [kafka] ableegoldman commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
ableegoldman commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r626971137 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -

[jira] [Created] (KAFKA-12756) Update Zookeeper to 3.6.3 or higher

2021-05-05 Thread Boojapho (Jira)
Boojapho created KAFKA-12756: Summary: Update Zookeeper to 3.6.3 or higher Key: KAFKA-12756 URL: https://issues.apache.org/jira/browse/KAFKA-12756 Project: Kafka Issue Type: Task Affects Vers

[jira] [Comment Edited] (KAFKA-9177) Pause completed partitions on restore consumer

2021-05-05 Thread Andrey Polyakov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339336#comment-17339336 ] Andrey Polyakov edited comment on KAFKA-9177 at 5/5/21, 10:01 PM: -

[GitHub] [kafka] rhauch merged pull request #10014: KAFKA-12252 and KAFKA-12262: Fix session key rotation when leadership changes

2021-05-05 Thread GitBox
rhauch merged pull request #10014: URL: https://github.com/apache/kafka/pull/10014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-10340) Source connectors should report error when trying to produce records to non-existent topics instead of hanging forever

2021-05-05 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339862#comment-17339862 ] Randall Hauch commented on KAFKA-10340: --- I cherry-picked the original PR (https://

[jira] [Updated] (KAFKA-10340) Source connectors should report error when trying to produce records to non-existent topics instead of hanging forever

2021-05-05 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10340: -- Fix Version/s: 2.8.1 > Source connectors should report error when trying to produce records to

[jira] [Commented] (KAFKA-12717) Remove internal converter config properties

2021-05-05 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339833#comment-17339833 ] Chris Egerton commented on KAFKA-12717: --- Filed [https://cwiki.apache.org/confluen

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-05-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339825#comment-17339825 ] A. Sophie Blee-Goldman commented on KAFKA-9295: --- [~showuon] are you interes

[GitHub] [kafka] chia7712 commented on pull request #10632: MINOR: fix streams_broker_compatibility_test.py

2021-05-05 Thread GitBox
chia7712 commented on pull request #10632: URL: https://github.com/apache/kafka/pull/10632#issuecomment-832903232 > I'm just going to go ahead and merge this so we can get the system tests fixed ASAP. Hope you don't mind thanks for merging this patch :) -- This is an automated me

[GitHub] [kafka] ableegoldman merged pull request #10632: MINOR: fix streams_broker_compatibility_test.py

2021-05-05 Thread GitBox
ableegoldman merged pull request #10632: URL: https://github.com/apache/kafka/pull/10632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10632: MINOR: fix streams_broker_compatibility_test.py

2021-05-05 Thread GitBox
ableegoldman commented on pull request #10632: URL: https://github.com/apache/kafka/pull/10632#issuecomment-832901885 @chia7712 I'm just going to go ahead and merge this so we can get the system tests fixed ASAP. Hope you don't mind, and thank you again for the PR -- This is an automated

[GitHub] [kafka] rhauch commented on pull request #10238: KAFKA-10340: Backport proactively close producer when cancelling source tasks

2021-05-05 Thread GitBox
rhauch commented on pull request #10238: URL: https://github.com/apache/kafka/pull/10238#issuecomment-832898998 Closed without merging. Instead, I cherry-picked the commit from #10016 to the `2.8` branch now that 2.8.0 is out. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] rhauch closed pull request #10238: KAFKA-10340: Backport proactively close producer when cancelling source tasks

2021-05-05 Thread GitBox
rhauch closed pull request #10238: URL: https://github.com/apache/kafka/pull/10238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] lct45 commented on pull request #10631: MINOR: Stop using hamcrest in system tests

2021-05-05 Thread GitBox
lct45 commented on pull request #10631: URL: https://github.com/apache/kafka/pull/10631#issuecomment-832873282 kicked off https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4492/, if it passes this fix is good enough for now, if it fails then the missing dependencies are bi

[GitHub] [kafka] guozhangwang commented on pull request #10613: KAFKA-10847: Set shared outer store to an in-memory store when in-memory stores are supplied

2021-05-05 Thread GitBox
guozhangwang commented on pull request #10613: URL: https://github.com/apache/kafka/pull/10613#issuecomment-832870539 Merged to trunk, thanks @spena -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang merged pull request #10613: KAFKA-10847: Set shared outer store to an in-memory store when in-memory stores are supplied

2021-05-05 Thread GitBox
guozhangwang merged pull request #10613: URL: https://github.com/apache/kafka/pull/10613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Assigned] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12755: Assignee: Colin McCabe > Add server-common, server-tools gradle modules > ---

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-05 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r626749507 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val version

[GitHub] [kafka] guozhangwang commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
guozhangwang commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-832855351 I'm re-triggering the unit tests again, @cadonna lmk if you think one green is sufficient (i.e. if in the past we are likely to hit one virtual function with one run). --

[GitHub] [kafka] guozhangwang commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
guozhangwang commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r626735704 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStreamThreadTest.java ## @@ -189,16 +199,6 @@ public void sho

[jira] [Updated] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12755: - Description: *Problems* The core module takes a long time to compile. There are several reasons

[jira] [Commented] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339766#comment-17339766 ] Kowshik Prakasam commented on KAFKA-12755: -- cc [~satishd]  with whom we discuss

[jira] [Updated] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12755: - Description: *Problems* The core module takes a long time to compile. There are several reasons

[jira] [Updated] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12755: - Description: *Problems* The core module takes a long time to compile. There are several reasons

[jira] [Commented] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339765#comment-17339765 ] Colin McCabe commented on KAFKA-12755: -- out.jpg reflects the current dependencies

[jira] [Updated] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12755: - Attachment: out.jpg > Add server-common, server-tools gradle modules > -

[jira] [Updated] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12755: - Attachment: out2.jpg > Add server-common, server-tools gradle modules >

[jira] [Updated] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12755: - Description: *Problems* The core module takes a long time to compile. There are several

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-832838475 The build fail due to known flaky tests but not due to SIGABRT. 🥳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] wcarlson5 commented on pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-05 Thread GitBox
wcarlson5 commented on pull request #10634: URL: https://github.com/apache/kafka/pull/10634#issuecomment-832838663 @rodesai @abbccdda @ableegoldman I had to make a couple changes to the task metadata to improve when the end offset was updated. Now we get it at poll phase which should give

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-05-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339760#comment-17339760 ] Bruno Cadonna commented on KAFKA-9295: -- Failed multiple times for a PR (https://ci-

[jira] [Created] (KAFKA-12755) Add server-common, server-tools gradle modules

2021-05-05 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12755: Summary: Add server-common, server-tools gradle modules Key: KAFKA-12755 URL: https://issues.apache.org/jira/browse/KAFKA-12755 Project: Kafka Issue Type: Im

[GitHub] [kafka] wcarlson5 opened a new pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-05 Thread GitBox
wcarlson5 opened a new pull request #10634: URL: https://github.com/apache/kafka/pull/10634 Improve endOffsets for TaskMetadata also add an int test for TaskMetadata offset collections ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] C0urante commented on pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

2021-05-05 Thread GitBox
C0urante commented on pull request #10630: URL: https://github.com/apache/kafka/pull/10630#issuecomment-832831207 Thanks @tombentley--good point, I agree that the record content is probably not necessary there and think it's safest to remove the record content from the message. I've altere

[jira] [Commented] (KAFKA-10154) Issue in updating metadata if not exists during sending message to different topics

2021-05-05 Thread Oleksandr Tomchakov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339746#comment-17339746 ] Oleksandr Tomchakov commented on KAFKA-10154: - Hi, I've created test-case: [

[jira] [Updated] (KAFKA-10154) Issue in updating metadata if not exists during sending message to different topics

2021-05-05 Thread Oleksandr Tomchakov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Tomchakov updated KAFKA-10154: Attachment: Screenshot 2021-05-05 at 19.07.26.png > Issue in updating metadata if

[jira] [Created] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-05 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12754: -- Summary: TaskMetadata endOffsets does not update when the offsets are read Key: KAFKA-12754 URL: https://issues.apache.org/jira/browse/KAFKA-12754 Project: Kafka

[jira] [Created] (KAFKA-12753) Add configuration to prevent MM2 from automatically creating topics on target cluster

2021-05-05 Thread Dave Beech (Jira)
Dave Beech created KAFKA-12753: -- Summary: Add configuration to prevent MM2 from automatically creating topics on target cluster Key: KAFKA-12753 URL: https://issues.apache.org/jira/browse/KAFKA-12753 Pro

[jira] [Updated] (KAFKA-12730) A single Kerberos login failure fails all future connections from Java 9 onwards

2021-05-05 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-12730: --- Fix Version/s: 2.8.1 2.7.2 2.6.3 2.5

[jira] [Updated] (KAFKA-10727) Kafka clients throw AuthenticationException during Kerberos re-login

2021-05-05 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-10727: --- Fix Version/s: 2.7.2 2.6.3 2.5.2 > Kafka clients throw

[jira] [Created] (KAFKA-12752) CVE-2021-28168 upgrade jersey to 2.34 or 3.02

2021-05-05 Thread John Stacy (Jira)
John Stacy created KAFKA-12752: -- Summary: CVE-2021-28168 upgrade jersey to 2.34 or 3.02 Key: KAFKA-12752 URL: https://issues.apache.org/jira/browse/KAFKA-12752 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-12751) ISRs remain in in-flight state if proposed state is same as actual state

2021-05-05 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-12751: -- Summary: ISRs remain in in-flight state if proposed state is same as actual state Key: KAFKA-12751 URL: https://issues.apache.org/jira/browse/KAFKA-12751 Project:

[GitHub] [kafka] feyman2016 edited a comment on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-05 Thread GitBox
feyman2016 edited a comment on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-832764031 @jsancio Hi, could you help to take a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-05 Thread GitBox
feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-832764031 @jsancio Hi, could you help to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (KAFKA-12429) Serdes for all message types in internal topic which is used in default implementation for RLMM.

2021-05-05 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12429. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk > Serdes for all message types in

[GitHub] [kafka] junrao merged pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-05-05 Thread GitBox
junrao merged pull request #10271: URL: https://github.com/apache/kafka/pull/10271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] rajinisivaram opened a new pull request #10633: MINOR: Reset AlterIsr in-flight state for duplicate update requests

2021-05-05 Thread GitBox
rajinisivaram opened a new pull request #10633: URL: https://github.com/apache/kafka/pull/10633 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] spena commented on pull request #10613: KAFKA-10847: Set shared outer store to an in-memory store when in-memory stores are supplied

2021-05-05 Thread GitBox
spena commented on pull request #10613: URL: https://github.com/apache/kafka/pull/10613#issuecomment-832730649 Thanks @guozhangwang, that seems the culprit of performance problem. In fact, when the performance tests finish, the script takes some time to complete cleaning - I assume it is t

[GitHub] [kafka] lct45 commented on a change in pull request #10631: MINOR: Stop using hamcrest in system tests

2021-05-05 Thread GitBox
lct45 commented on a change in pull request #10631: URL: https://github.com/apache/kafka/pull/10631#discussion_r626608131 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/RelationalSmokeTest.java ## @@ -806,20 +799,14 @@ public static boolean verifySync(final

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-05 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-832644717 I increased the RocksDB version since I found a more recent version on maven central. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.16.4

2021-05-05 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-832643004 OK, the other builds failed due to test failures, not due to SIGABRT. Thta is a good sign. -- This is an automated message from the Apache Git Service. To respond to the messa

  1   2   >