[
https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353920#comment-17353920
]
loboxu commented on KAFKA-10900:
[~showuon] I have received the Jire. May I ask whether the Jire has
socutes commented on a change in pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#discussion_r642010687
##
File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java
##
@@ -945,11 +946,10 @@ public void testObserverUnattachedToFollower()
socutes removed a comment on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-850052203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
socutes closed pull request #10749:
URL: https://github.com/apache/kafka/pull/10749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
socutes commented on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-850931986
> > Left 2 comments. Thanks.
>
> fixed! @showuon Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12677:
-
Assignee: Luke Chen (was: Colin McCabe)
> The raftCluster always send to the wrong active
dengziming commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r642003507
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractApiMessageSerde.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
VJvaLbhYbfr edited a comment on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
Thank you for your review.
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is
VJvaLbhYbfr edited a comment on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
Thank you for your review.
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is
VJvaLbhYbfr edited a comment on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
Thank you for your review.
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is
VJvaLbhYbfr edited a comment on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
Thank you for your review.
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is
VJvaLbhYbfr edited a comment on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is somehow prepared for future test, but I
VJvaLbhYbfr commented on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is somehow prepared for future test, but I
think
VJvaLbhYbfr edited a comment on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135
>
>
> In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is somehow prepared for future test, but I
dengziming opened a new pull request #10793:
URL: https://github.com/apache/kafka/pull/10793
*More detailed description of your change*
`MetadataParser` is a duplication of `MetadataRecordSerde` and it's not used
in any code, so we can remove it.
*Summary of testing strategy
[
https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353909#comment-17353909
]
Ismael Juma commented on KAFKA-12677:
-
Go for it [~showuon]
> The raftCluster always send to the
dengziming commented on pull request #10792:
URL: https://github.com/apache/kafka/pull/10792#issuecomment-850919041
In fact, `Collections.singleton` is more efficient than other collection
constructor and the `highWatermark` is somehow prepared for future test, but I
think this PR is
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353903#comment-17353903
]
Luke Chen edited comment on KAFKA-12629 at 5/29/21, 11:24 PM:
--
Good news! I
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353903#comment-17353903
]
Luke Chen edited comment on KAFKA-12629 at 5/29/21, 11:23 PM:
--
Good news! I
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353903#comment-17353903
]
Luke Chen edited comment on KAFKA-12629 at 5/29/21, 11:23 PM:
--
Good news! I
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353903#comment-17353903
]
Luke Chen commented on KAFKA-12629:
---
Good news! I found a root cause of the blocker bug KAFKA-12677
[
https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353882#comment-17353882
]
Luke Chen commented on KAFKA-12677:
---
[~cmccabe], I've found the root cause of this issue, and have a
VJvaLbhYbfr opened a new pull request #10792:
URL: https://github.com/apache/kafka/pull/10792
Removed redundant method parameter.
Replaced Collections.singleton with Utils.mkSet for consistency.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353849#comment-17353849
]
Georgy commented on KAFKA-5560:
---
[~huxi_2b] [~junrao] Will this task be in progress someday or maybe there
ijuma commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r641965516
##
File path: build.gradle
##
@@ -449,6 +449,14 @@ subprojects {
}
}
+ // remove test output from Test, IntegrationTest and UnitTest
Review
ijuma commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-850871754
Good catch. The build definition doesn't require changes to mention this
annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar reassigned KAFKA-12865:
-
Assignee: Rohit Sachan
> Documentation error for Admin Client API in describe ACLs
>
[
https://issues.apache.org/jira/browse/KAFKA-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-12865.
---
Fix Version/s: 3.0.0
Resolution: Fixed
> Documentation error for Admin Client API in
omkreddy merged pull request #10790:
URL: https://github.com/apache/kafka/pull/10790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
chia7712 opened a new pull request #10791:
URL: https://github.com/apache/kafka/pull/10791
The command `./gradlew raft:integrationTest` can't run any integration test
since `org.junit.jupiter.api.Tag` does not work for jqwik engine (see
chia7712 commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r641907832
##
File path: build.gradle
##
@@ -380,6 +380,15 @@ subprojects {
}
}
+ cleanTest {
+subprojects.each {
+ delete
rohit-sachan opened a new pull request #10790:
URL: https://github.com/apache/kafka/pull/10790
It's a small fix for documentation bug. I don't think any test case is
required for that.
closes KAFKA-12865
### Committer Checklist (excluded from commit message)
- [ ] Verify
Rohit Sachan created KAFKA-12865:
Summary: Documentation error for Admin Client API in describe ACLs
Key: KAFKA-12865
URL: https://issues.apache.org/jira/browse/KAFKA-12865
Project: Kafka
chia7712 merged pull request #10661:
URL: https://github.com/apache/kafka/pull/10661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
34 matches
Mail list logo
