[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-19 Thread GitBox
showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r654763984 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -124,8 +124,15 @@ object RequestChannel extends Logging { def buildRespons

[GitHub] [kafka] showuon commented on pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-19 Thread GitBox
showuon commented on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-864374754 @hachikuji , I checked and there's no race condition there. The reason why we didn't put `NOT_CONTROLLER` in EnvelopResponse itself is because we will build envelopeResponse **w

[GitHub] [kafka] C0urante opened a new pull request #10907: KAFKA-10000: Exactly-once support for source connectors

2021-06-19 Thread GitBox
C0urante opened a new pull request #10907: URL: https://github.com/apache/kafka/pull/10907 Implements [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSourceConnectors-Newmetrics). There are

[GitHub] [kafka] C0urante commented on pull request #10907: KAFKA-10000: Exactly-once support for source connectors

2021-06-19 Thread GitBox
C0urante commented on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-864380630 @gharris1727 you've been tremendously helpful so far in the design process; if you have time would you like to take a look at the implementation as well? -- This is an automa

[GitHub] [kafka] vamossagar12 commented on pull request #10877: KAFKA-12925: adding presfixScan operation for missed implementations

2021-06-19 Thread GitBox
vamossagar12 commented on pull request #10877: URL: https://github.com/apache/kafka/pull/10877#issuecomment-864382529 @mjsax , have added the tests for the combinations that you have mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-12689) Remove deprecated EOS configs

2021-06-19 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365914#comment-17365914 ] loboxu commented on KAFKA-12689: Thank you very much for reminding me. I know what I sho

[jira] [Issue Comment Deleted] (KAFKA-10900) Add metrics enumerated in KIP-630

2021-06-19 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu updated KAFKA-10900: --- Comment: was deleted (was: [~jagsancio]  Can you give me some guidance? Where the metrics are added in the

[jira] [Assigned] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-06-19 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12851: -- Assignee: (was: loboxu) > Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

[jira] [Assigned] (KAFKA-12333) KafkaMetadataLog and MockLock should validate that appended epochs are monotonically

2021-06-19 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12333: -- Assignee: (was: loboxu) > KafkaMetadataLog and MockLock should validate that appended epochs are

[jira] [Assigned] (KAFKA-12243) Add toString methods to some of the classes introduced by this Epic

2021-06-19 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12243: -- Assignee: loboxu > Add toString methods to some of the classes introduced by this Epic >

[jira] [Assigned] (KAFKA-12243) Add toString methods to some of the classes introduced by this Epic

2021-06-19 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12243: -- Assignee: (was: loboxu) > Add toString methods to some of the classes introduced by this Epic > -

[GitHub] [kafka] chia7712 opened a new pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

2021-06-19 Thread GitBox
chia7712 opened a new pull request #10908: URL: https://github.com/apache/kafka/pull/10908 The broker id starts with 1 (https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/kafka/kafka.py#L207) so `round_trip_fault_test.py` do assign replica to nonexistent broker. The

[jira] [Assigned] (KAFKA-12908) Load snapshot heuristic

2021-06-19 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-12908: -- Assignee: dengziming > Load snapshot heuristic > --- > >

[GitHub] [kafka] chia7712 merged pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

2021-06-19 Thread GitBox
chia7712 merged pull request #10908: URL: https://github.com/apache/kafka/pull/10908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] chia7712 merged pull request #10905: MINOR Addressed minor typos in READMEs.

2021-06-19 Thread GitBox
chia7712 merged pull request #10905: URL: https://github.com/apache/kafka/pull/10905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] guozhangwang commented on pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-19 Thread GitBox
guozhangwang commented on pull request #10869: URL: https://github.com/apache/kafka/pull/10869#issuecomment-864424835 @vvcephei I took a quick look at the more recent commits (for `KStream.java` the part you wanted me to take another look is around the javadoc copy-paste errors, right?), s

[jira] [Created] (KAFKA-12971) Kakfa 1.1.x clients cache broker hostnames, client stuck when host is swapped for the same broker.id

2021-06-19 Thread GEORGE LI (Jira)
GEORGE LI created KAFKA-12971: - Summary: Kakfa 1.1.x clients cache broker hostnames, client stuck when host is swapped for the same broker.id Key: KAFKA-12971 URL: https://issues.apache.org/jira/browse/KAFKA-12971

[jira] [Commented] (KAFKA-12971) Kakfa 1.1.x clients cache broker hostnames, client stuck when host is swapped for the same broker.id

2021-06-19 Thread GEORGE LI (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366011#comment-17366011 ] GEORGE LI commented on KAFKA-12971: --- This issue is fixed in the {{1.1.x}} kafka client

[jira] [Commented] (KAFKA-12971) Kakfa 1.1.x clients cache broker hostnames, client stuck when host is swapped for the same broker.id

2021-06-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366015#comment-17366015 ] Ismael Juma commented on KAFKA-12971: - Thanks for the report. 1.1.1 is no longer sup

[GitHub] [kafka] guozhangwang commented on pull request #10818: KAFKA-12889: log clean relative index range check of group consider empty log segment to avoid too many empty log segment left

2021-06-19 Thread GitBox
guozhangwang commented on pull request #10818: URL: https://github.com/apache/kafka/pull/10818#issuecomment-864471492 @iamgd67 Thanks for the PR! and also thank @showuon for the reviews. I made a quick pass and it LGTM. Merging to trunk now. -- This is an automated message from the Apach

[GitHub] [kafka] guozhangwang merged pull request #10818: KAFKA-12889: log clean relative index range check of group consider empty log segment to avoid too many empty log segment left

2021-06-19 Thread GitBox
guozhangwang merged pull request #10818: URL: https://github.com/apache/kafka/pull/10818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (KAFKA-12889) log clean group consider empty log segment to avoid empty log left

2021-06-19 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366024#comment-17366024 ] Guozhang Wang commented on KAFKA-12889: --- Thanks [~iamgd67] for reporting the issue

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

2021-06-19 Thread GitBox
showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r654866143 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiError.java ## @@ -36,10 +37,16 @@ private final String message; public

[GitHub] [kafka] kpatelatwork commented on pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

2021-06-19 Thread GitBox
kpatelatwork commented on pull request #10822: URL: https://github.com/apache/kafka/pull/10822#issuecomment-864493282 Fired up local kafka server and kafka connect and was able to curl the API locally. > ➜ kafka git:(KAFKA-4793) ✗ curl http://192.168.1.220:8083/connectors/local-fil

[jira] [Commented] (KAFKA-12908) Load snapshot heuristic

2021-06-19 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366100#comment-17366100 ] dengziming commented on KAFKA-12908: This may be depend on KAFKA-12155 > Load snaps

[jira] [Comment Edited] (KAFKA-12908) Load snapshot heuristic

2021-06-19 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366100#comment-17366100 ] dengziming edited comment on KAFKA-12908 at 6/20/21, 4:30 AM:

[jira] [Assigned] (KAFKA-12158) Consider better return type of RaftClient.scheduleAppend

2021-06-19 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-12158: -- Assignee: dengziming > Consider better return type of RaftClient.scheduleAppend > ---