[GitHub] [kafka] guozhangwang merged pull request #10925: MINOR: To verify segment.hasOverflow, the path of the segment should be printed

guozhangwang merged pull request #10925: URL: https://github.com/apache/kafka/pull/10925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #10925: MINOR: To verify segment.hasOverflow, the path of the segment should be printed

guozhangwang commented on pull request #10925: URL: https://github.com/apache/kafka/pull/10925#issuecomment-869324107 LGTM! Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for StreamsMe…

ijuma commented on pull request #10881: URL: https://github.com/apache/kafka/pull/10881#issuecomment-869298381 @vvcephei @ableegoldman can one of you review this PR please? It gets us closer to disabling the JDK 15 builds. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on pull request #10904: MINOR: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest

ijuma commented on pull request #10904: URL: https://github.com/apache/kafka/pull/10904#issuecomment-869296229 Thanks for the PR. We should update build.gradle to remove this test from the JDK 16 exclusion list. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659410595 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659401537 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

ijuma commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659391951 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659388593 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-12920) Consumer's cooperative sticky assignor need to clear generation / assignment data upon `onPartitionsLost`

[ https://issues.apache.org/jira/browse/KAFKA-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370370#comment-17370370 ] Guozhang Wang commented on KAFKA-12920: --- Adding the other created root cause issue ticket here. >

[jira] [Commented] (KAFKA-12378) If a broker is down for more then `delete.retention.ms` deleted records in a compacted topic can come back.

[ https://issues.apache.org/jira/browse/KAFKA-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370369#comment-17370369 ] Guozhang Wang commented on KAFKA-12378: --- Hello [~shanesaww], I agree this is a tricky problem to

[GitHub] [kafka] ijuma commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

ijuma commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659386218 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

ijuma commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659385893 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma edited a comment on pull request #10929: KAFKA-12995 [WIP] Allow old Broker compatibility for Metadata calls

ijuma edited a comment on pull request #10929: URL: https://github.com/apache/kafka/pull/10929#issuecomment-869232659 Thanks for the PR. I am tempted to specify list offsets methods to support 0.11.0 brokers and newer. 0.10.x is extremely old now. It was different when we implemented

[GitHub] [kafka] ijuma edited a comment on pull request #10929: KAFKA-12995 [WIP] Allow old Broker compatibility for Metadata calls

ijuma edited a comment on pull request #10929: URL: https://github.com/apache/kafka/pull/10929#issuecomment-869232659 Thanks for the PR. I am tempted to specify list offsets to support 0.11.0 brokers and newer. 0.10.x is extremely old now. It was different when we implemented #3098 4+

[GitHub] [kafka] ijuma commented on pull request #10929: KAFKA-12995 [WIP] Allow old Broker compatibility for Metadata calls

ijuma commented on pull request #10929: URL: https://github.com/apache/kafka/pull/10929#issuecomment-869232659 Thanks for the PR. I am tempted to specify list offsets to support 0.11.0 brokers and newer. 0.10.x is extremely old now. It was different when we implemented #3098. -- This

[GitHub] [kafka] izzyacademy commented on a change in pull request #10926: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations

izzyacademy commented on a change in pull request #10926: URL: https://github.com/apache/kafka/pull/10926#discussion_r659384531 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java ## @@ -83,16 +92,52 @@ private TimeWindows(final long sizeMs,

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370331#comment-17370331 ] Guozhang Wang commented on KAFKA-12559: --- [~msundeq] I've re-assigned the ticket for you. Please

[jira] [Assigned] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-12559: - Assignee: Martin Sundeqvist (was: amuthan Ganeshan) > Add a top-level Streams config

[GitHub] [kafka] ableegoldman commented on a change in pull request #10926: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations

ableegoldman commented on a change in pull request #10926: URL: https://github.com/apache/kafka/pull/10926#discussion_r659381726 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java ## @@ -83,16 +92,52 @@ private TimeWindows(final long sizeMs,

[jira] [Assigned] (KAFKA-12995) AdminClient listOffsets fail with old Kafka Broker

[ https://issues.apache.org/jira/browse/KAFKA-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-12995: - Assignee: Alan Artigao Carreño > AdminClient listOffsets fail with old Kafka Broker >

[jira] [Updated] (KAFKA-12790) Remove SslTransportLayerTest.testUnsupportedTlsVersion

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12790: Description: Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11 and all

[jira] [Updated] (KAFKA-12790) Remove SslTransportLayerTest.testUnsupportedTlsVersion

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12790: Summary: Remove SslTransportLayerTest.testUnsupportedTlsVersion (was: Fix

[GitHub] [kafka] ableegoldman commented on a change in pull request #10926: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations

ableegoldman commented on a change in pull request #10926: URL: https://github.com/apache/kafka/pull/10926#discussion_r659377314 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java ## @@ -83,16 +92,52 @@ private TimeWindows(final long sizeMs,

[GitHub] [kafka] ijuma merged pull request #10922: KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion

ijuma merged pull request #10922: URL: https://github.com/apache/kafka/pull/10922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jacky1193610322 commented on a change in pull request #10931: KAFKA-12998: Implement broker-side KRaft snapshots (WIP)

jacky1193610322 commented on a change in pull request #10931: URL: https://github.com/apache/kafka/pull/10931#discussion_r659292704 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software