[
https://issues.apache.org/jira/browse/KAFKA-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373909#comment-17373909
]
David Jacot commented on KAFKA-13029:
-
For the consumer, I think a simpler version would be to have
jolshan commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r663286816
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -209,65 +209,59 @@ default CreateTopicsResult
skaundinya15 commented on pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#issuecomment-873300983
@rajinisivaram @dajac I just sent out a proposal for the Admin APIs to the
mailing list, regarding `ListConsumerGroupOffsetsOptions`. For now I've closed
this pull request
skaundinya15 commented on pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#issuecomment-873300555
Closing this in favor of https://github.com/apache/kafka/pull/10964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
skaundinya15 opened a new pull request #10964:
URL: https://github.com/apache/kafka/pull/10964
This implements the AdminAPI portion of KIP-709:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173084258. The
request/response changes was implemented in
skaundinya15 closed pull request #10954:
URL: https://github.com/apache/kafka/pull/10954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663277869
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -70,230 +58,188 @@ class BrokerMetadataListener(
*/
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663276540
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2032,4 +2001,207 @@ class ReplicaManager(val config: KafkaConfig,
}
}
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663275737
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2032,4 +2001,207 @@ class ReplicaManager(val config: KafkaConfig,
}
}
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663275737
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2032,4 +2001,207 @@ class ReplicaManager(val config: KafkaConfig,
}
}
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663274842
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##
@@ -0,0 +1,249 @@
+/**
+ * Licensed to the Apache Software
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663273638
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1302,7 +1278,8 @@ class ReplicaManager(val config: KafkaConfig,
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663271546
##
File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala
##
@@ -127,6 +131,22 @@ class FinalizedFeatureCache(private val
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663271148
##
File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala
##
@@ -127,6 +131,22 @@ class FinalizedFeatureCache(private val
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663270570
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -331,46 +327,40 @@ class BrokerServer(
new
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663269838
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -264,19 +266,13 @@ class BrokerServer(
/* Add all reconfigurables for
cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663269838
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -264,19 +266,13 @@ class BrokerServer(
/* Add all reconfigurables for
chia7712 opened a new pull request #10963:
URL: https://github.com/apache/kafka/pull/10963
issue: https://issues.apache.org/jira/browse/KAFKA-13030
[
https://issues.apache.org/jira/browse/KAFKA-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-13030:
---
Summary: FindCoordinators batching causes slow poll when requesting older
broker (was:
Chia-Ping Tsai created KAFKA-13030:
--
Summary: FindCoordinators batching make slow poll when requesting
older broker
Key: KAFKA-13030
URL: https://issues.apache.org/jira/browse/KAFKA-13030
Project:
ijuma commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r663240717
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -209,65 +209,59 @@ default CreateTopicsResult
createTopics(Collection
jolshan commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r663239333
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -209,65 +209,59 @@ default CreateTopicsResult
izzyacademy commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-873238772
> @guozhangwang , Thank you for the PR!
>
>
>
> I had some comments about the unit tests.
>
>
>
> Yesterday during our discussion, I forgot to
izzyacademy commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-873237780
@cadonna thanks a lot for your verify detailed explanation and educational
feedback. I was not aware of that when I submitted my changes for KIP 633. So I
will make a note
skaundinya15 edited a comment on pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#issuecomment-873216708
Thank you for the reviews @rajinisivaram and @dajac. As discussed offline, I
have split this PR into 2: 1 for the request/response side of things, and will
open
skaundinya15 commented on pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#issuecomment-873216708
Thank you for the reviews @rajinisivaram and @dajac. As discussed offline, I
have split this PR into 2: 1 for the request/response side of things, and will
open another
skaundinya15 opened a new pull request #10962:
URL: https://github.com/apache/kafka/pull/10962
This implements the request and response portion of KIP-709:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173084258. The
Admin APIs will be implemented in a follow up PR.
thomaskwscott commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r663208192
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords,
//
[
https://issues.apache.org/jira/browse/KAFKA-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373734#comment-17373734
]
Mickael Maison commented on KAFKA-13029:
Right, I missed that!
For the Consumer/Producer, I
Rajini Sivaram created KAFKA-13029:
--
Summary: FindCoordinators batching can break consumers during
rolling upgrade
Key: KAFKA-13029
URL: https://issues.apache.org/jira/browse/KAFKA-13029
Project:
chia7712 commented on a change in pull request #10868:
URL: https://github.com/apache/kafka/pull/10868#discussion_r663183197
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -74,7 +75,15 @@ class ControllerApis(val requestChannel: RequestChannel,
[
https://issues.apache.org/jira/browse/KAFKA-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch reassigned KAFKA-13028:
-
Assignee: Randall Hauch
> AbstractConfig should allow config provider configuration to
rhauch opened a new pull request #10961:
URL: https://github.com/apache/kafka/pull/10961
**DO NOT MERGE UNTIL IT IS DETERMINED WHETHER THIS REQUIRED A KIP.**
See [KAFKA-13028](https://issues.apache.org/jira/browse/KAFKA-13028)
The AbstractConfig constructor is changed to
ijuma commented on a change in pull request #10868:
URL: https://github.com/apache/kafka/pull/10868#discussion_r663181788
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -74,7 +75,15 @@ class ControllerApis(val requestChannel: RequestChannel,
val
chia7712 commented on pull request #10868:
URL: https://github.com/apache/kafka/pull/10868#issuecomment-873176227
@ijuma I had added the unit test. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373715#comment-17373715
]
Randall Hauch commented on KAFKA-13028:
---
h2. Is a KIP required?
Randall Hauch created KAFKA-13028:
-
Summary: AbstractConfig should allow config provider configuration
to use variables referencing other config providers earlier in the list
Key: KAFKA-13028
URL:
cadonna merged pull request #10958:
URL: https://github.com/apache/kafka/pull/10958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#issuecomment-873167429
Test failures are unrelated and known to be flaky.
```
Build / JDK 11 and Scala 2.13 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
```
hachikuji commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663154812
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2032,4 +2001,207 @@ class ReplicaManager(val config: KafkaConfig,
}
ijuma commented on pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#issuecomment-873163159
@mimaison were you planning to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ryannedolan commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r663166559
##
File path:
core/src/test/scala/integration/kafka/tools/MirrorMakerIntegrationTest.scala
##
@@ -35,6 +35,9 @@ import org.junit.jupiter.api.Test
chia7712 commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r663136853
##
File path: clients/src/main/java/org/apache/kafka/common/KafkaFuture.java
##
@@ -19,75 +19,57 @@
import
mimaison commented on pull request #10277:
URL: https://github.com/apache/kafka/pull/10277#issuecomment-873143110
Thanks for the PR and sorry for the delay.
The last build had a bunch of failures in connect:mirror:test. It was mostly
timeouts so it's probably not related to this PR
jolshan commented on pull request #10957:
URL: https://github.com/apache/kafka/pull/10957#issuecomment-873124675
Yes, sounds good. Somehow I missed this. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cadonna commented on a change in pull request #10944:
URL: https://github.com/apache/kafka/pull/10944#discussion_r663088560
##
File path: tests/kafkatest/tests/streams/streams_eos_test.py
##
@@ -128,45 +128,61 @@ def run_failure_and_recovery(self, processor1,
processor2,
[
https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373572#comment-17373572
]
Sagar Rao edited comment on KAFKA-8295 at 7/2/21, 2:36 PM:
---
[~ableegoldman], I
[
https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373572#comment-17373572
]
Sagar Rao commented on KAFKA-8295:
--
[~ableegoldman], I did some more analysis and here's a summary of
cadonna edited a comment on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-873033160
@showuon It is not different. With this PR it is again equal to previous
releases. PR #10378 made it different, but PR #10378 has been never released.
It was merged to
cadonna commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-873033160
@showuon It is not different. With this PR it is again equal. PR #10378 made
it different, but PR #10378 has been never released. It was merged to trunk
after 2.8 was released.
showuon commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-873006141
Thanks for @cadonna 's explanation! Very clear. I'm thinking we should put
that explanation in java doc, so that other members could know why the grace
period computing is
[
https://issues.apache.org/jira/browse/KAFKA-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373540#comment-17373540
]
Frode Carlsen commented on KAFKA-13027:
---
That was fast :)
If this will bring all client
zhaohaidao commented on pull request #10932:
URL: https://github.com/apache/kafka/pull/10932#issuecomment-872975936
@jsancio @showuon Thank you. Could you please merge this pr to trunk if it's
approved.
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r662991037
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords,
// volatile for
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662990335
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -247,17 +138,32 @@ public boolean
rajinisivaram commented on a change in pull request #10649:
URL: https://github.com/apache/kafka/pull/10649#discussion_r662986120
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -105,11 +105,13 @@ public boolean
tombentley commented on pull request #8571:
URL: https://github.com/apache/kafka/pull/8571#issuecomment-872964840
@kkonstantine I've done the rebase if you'd like to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373488#comment-17373488
]
Dongjin Lee commented on KAFKA-13027:
-
Hi [~frocarz],
Thank you for raising this issue. I have
thomaskwscott opened a new pull request #10960:
URL: https://github.com/apache/kafka/pull/10960
This PR refactors LogSegment.offsetOfMaxTimestampSoFar and
LogSegment.maxTimestampSoFar to single tuple to ensure consistent update/read
*More detailed description of your change,
if
thomaskwscott commented on pull request #10959:
URL: https://github.com/apache/kafka/pull/10959#issuecomment-872957381
Closing to be replaced with cleaner PR on separate branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
thomaskwscott closed pull request #10959:
URL: https://github.com/apache/kafka/pull/10959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thomaskwscott opened a new pull request #10959:
URL: https://github.com/apache/kafka/pull/10959
This PR refactors LogSegment.offsetOfMaxTimestampSoFar and
LogSegment.maxTimestampSoFar to single tuple to ensure consistent update/read
*More detailed description of your change,
if
dajac commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662963252
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -247,17 +138,32 @@ public boolean
rajinisivaram commented on a change in pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#discussion_r662935021
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsOptions.java
##
@@ -17,37 +17,51 @@
package
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662933606
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -247,17 +138,32 @@ public boolean
dengziming commented on a change in pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#discussion_r662911075
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -416,9 +418,16 @@ private Topology
cadonna commented on a change in pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#discussion_r662908418
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -416,9 +418,16 @@ private Topology
dajac commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662901841
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -247,17 +138,32 @@ public boolean
dengziming commented on a change in pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#discussion_r662895466
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##
@@ -315,6 +316,9 @@ private
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662879817
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -267,50 +173,77 @@ public T get() throws
cadonna commented on pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#issuecomment-872858688
FYI: @mjsax @lct45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cadonna commented on a change in pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#discussion_r662865972
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -98,6 +98,8 @@
tombentley commented on pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#issuecomment-872856197
@kkonstantine @dajac thanks for the reviews, I really appreciate it. I think
I've addressed all the comments and hopefully answered your questions, if you'd
like to take
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662873005
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -27,217 +28,107 @@
/**
* A flexible future which
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r662866236
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -132,17 +122,22 @@ object ConfigCommand extends Config {
val entity =
dajac commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662860700
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -267,50 +173,77 @@ public T get() throws
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662856714
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -267,50 +173,77 @@ public T get() throws
dajac commented on a change in pull request #10954:
URL: https://github.com/apache/kafka/pull/10954#discussion_r662850732
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -888,22 +888,26 @@ default ListConsumerGroupsResult
showuon commented on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-872830334
@rondagostino, thanks for the comments. I've removed the constraint for the
`zk-tls-config-file`. Also, I added some constraint to only allow `user` type
update SCRAM related
dajac commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662847775
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -247,17 +138,32 @@ public boolean
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662837733
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -247,17 +138,32 @@ public boolean
dengziming commented on a change in pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#discussion_r662836638
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -383,7 +385,7 @@ private Topology
dajac commented on pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#issuecomment-872815681
The changes look reasonable to me. It would be great to get someone from
streams to confirm. @cadonna Could you verify?
--
This is an automated message from the Apache Git
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662832035
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -27,217 +28,107 @@
/**
* A flexible future which
cadonna commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r662830942
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java
##
@@ -81,18 +90,63 @@ private TimeWindows(final long sizeMs,
cadonna commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r662830942
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java
##
@@ -81,18 +90,63 @@ private TimeWindows(final long sizeMs,
cadonna edited a comment on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-872811076
Some details for the other reviewers.
In 2.8 and before, we computed the default grace period with
`Math.max(maintainDurationMs - sizeMs, 0);` in method
showuon commented on a change in pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#discussion_r662828834
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
##
@@ -103,6 +104,11 @@ public void
cadonna commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-872811076
Some details for the other reviewers.
In 2.8 and before, we computed the default grace period with
`Math.max(maintainDurationMs - sizeMs, 0);` in method `gracePeriodMs()`
dajac commented on pull request #10895:
URL: https://github.com/apache/kafka/pull/10895#issuecomment-872805762
@hachikuji Could you take a look when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#issuecomment-872804128
Thanks for the PR, @dengziming. I was also chasing this one down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cadonna commented on a change in pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#discussion_r662816403
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java
##
@@ -57,6 +57,11 @@ public void
dajac commented on a change in pull request #10955:
URL: https://github.com/apache/kafka/pull/10955#discussion_r662815972
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3677,7 +3677,8 @@ public ListOffsetsResult listOffsets(Map
cadonna commented on a change in pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#discussion_r662807687
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
##
@@ -103,6 +104,11 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12981:
Parent: (was: KAFKA-12541)
Issue Type: Improvement (was: Sub-task)
> Ensure
[
https://issues.apache.org/jira/browse/KAFKA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-12981:
---
Assignee: Tom Scott
> Ensure LogSegment.maxTimestampSoFar and
dajac commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662791694
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -27,217 +28,107 @@
/**
* A flexible future which
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662784505
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -27,217 +28,107 @@
/**
* A flexible future which
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r662782741
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -27,217 +28,107 @@
/**
* A flexible future which
Frode Carlsen created KAFKA-13027:
-
Summary: Support for Jakarta EE 9.x to allow applications to
migrate
Key: KAFKA-13027
URL: https://issues.apache.org/jira/browse/KAFKA-13027
Project: Kafka
100 matches
Mail list logo