[GitHub] [kafka] ijuma commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

2021-07-24 Thread GitBox
ijuma commented on a change in pull request #9433: URL: https://github.com/apache/kafka/pull/9433#discussion_r676083224 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -109,8 +109,10 @@ public int throttleTimeMs() {

[GitHub] [kafka] ijuma commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

2021-07-24 Thread GitBox
ijuma commented on a change in pull request #9433: URL: https://github.com/apache/kafka/pull/9433#discussion_r676083224 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -109,8 +109,10 @@ public int throttleTimeMs() {

[jira] [Resolved] (KAFKA-12958) Add simulation invariant for leadership and snapshot

2021-07-24 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao resolved KAFKA-12958. - Resolution: Fixed > Add simulation invariant for leadership and snapshot >

[GitHub] [kafka] zhaohaidao commented on pull request #11015: KAFKA-12333:KafkaMetadataLog and MockLog should validate that appended epochs are monotonically

2021-07-24 Thread GitBox
zhaohaidao commented on pull request #11015: URL: https://github.com/apache/kafka/pull/11015#issuecomment-886144844 > The original issue said both the MockLog and KafkaMetadataLog should only allow appendAsLeader and appendAsFollower with monotonically increasing epochs. > However, It

[jira] [Updated] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-13132: --- Description: With the change in 3.0 to how topic IDs are assigned to logs, a bug was

[jira] [Updated] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-13132: --- Description: With the change in 3.0 to how topic IDs are assigned to logs, a bug was

[GitHub] [kafka] jolshan opened a new pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-24 Thread GitBox
jolshan opened a new pull request #11126: URL: https://github.com/apache/kafka/pull/11126 As described in the ticket, in 3.0 there was a change that resulted in no longer assigning topic IDs to the log and the partition.metadata file in certain upgrade scenarios. This PR adds a check for

[jira] [Updated] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-13132: --- Description: With the change in 3.0 to how topic IDs are assigned to logs, a bug was

[jira] [Created] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-24 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-13132: -- Summary: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 Key: KAFKA-13132 URL: https://issues.apache.org/jira/browse/KAFKA-13132 Project:

[GitHub] [kafka] chia7712 commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

2021-07-24 Thread GitBox
chia7712 commented on a change in pull request #9433: URL: https://github.com/apache/kafka/pull/9433#discussion_r676077742 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -109,8 +109,10 @@ public int throttleTimeMs() {

[GitHub] [kafka] d8tltanc commented on pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-24 Thread GitBox
d8tltanc commented on pull request #11002: URL: https://github.com/apache/kafka/pull/11002#issuecomment-886134636 The suspicious related failures are fixed in the latest chunk, and my latest system run after rebasing the trunk has passed these two tests.

[GitHub] [kafka] d8tltanc commented on pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-24 Thread GitBox
d8tltanc commented on pull request #11002: URL: https://github.com/apache/kafka/pull/11002#issuecomment-886134366 System test run 4614 failures: ignored: 197 test_id:

[GitHub] [kafka] tang7526 commented on pull request #11074: KAFKA-13101: Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-07-24 Thread GitBox
tang7526 commented on pull request #11074: URL: https://github.com/apache/kafka/pull/11074#issuecomment-886132012 > Thanks for the PR, we should also update https://github.com/apache/kafka/blob/trunk/build.gradle#L373 @ijuma Copy that. Done. -- This is an automated message from

[jira] [Updated] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-07-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12851: --- Labels: kip-500 (was: ) > Flaky Test

[jira] [Updated] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-07-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12851: --- Component/s: kraft > Flaky Test

[jira] [Commented] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-07-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386794#comment-17386794 ] Jose Armando Garcia Sancio commented on KAFKA-12851: It still fails against trunk

[jira] [Commented] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-07-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386793#comment-17386793 ] Jose Armando Garcia Sancio commented on KAFKA-12851:  The seed in the PR build

[jira] [Commented] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-07-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386789#comment-17386789 ] Jose Armando Garcia Sancio commented on KAFKA-12851: Test passes with that seed

[jira] [Commented] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-07-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386787#comment-17386787 ] Jose Armando Garcia Sancio commented on KAFKA-12851: Thanks for the report and

[GitHub] [kafka] ijuma commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

2021-07-24 Thread GitBox
ijuma commented on a change in pull request #9433: URL: https://github.com/apache/kafka/pull/9433#discussion_r676053218 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -109,8 +109,10 @@ public int throttleTimeMs() {

[jira] [Commented] (KAFKA-13131) Consumer offsets lost during partition reassignment

2021-07-24 Thread Sergejs Andrejevs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386781#comment-17386781 ] Sergejs Andrejevs commented on KAFKA-13131: --- This happened once at production cluster and,

[GitHub] [kafka] ijuma commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

2021-07-24 Thread GitBox
ijuma commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r676047197 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -140,79 +141,154 @@ class

[GitHub] [kafka] ijuma commented on pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-07-24 Thread GitBox
ijuma commented on pull request #0: URL: https://github.com/apache/kafka/pull/0#issuecomment-886113803 Thanks for the PR. We should include the motivation when suggesting a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on pull request #11074: KAFKA-13101: Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-07-24 Thread GitBox
ijuma commented on pull request #11074: URL: https://github.com/apache/kafka/pull/11074#issuecomment-886113652 Thanks for the PR, we should also update https://github.com/apache/kafka/blob/trunk/build.gradle#L373 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] omkreddy opened a new pull request #11125: MINOR: Update `./gradlew allDepInsight` example in README

2021-07-24 Thread GitBox
omkreddy opened a new pull request #11125: URL: https://github.com/apache/kafka/pull/11125 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] wycccccc commented on a change in pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for Streams…

2021-07-24 Thread GitBox
wycc commented on a change in pull request #10881: URL: https://github.com/apache/kafka/pull/10881#discussion_r675973748 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java ## @@ -23,43 +23,32 @@ import

[GitHub] [kafka] showuon opened a new pull request #11124: [WIP] KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-24 Thread GitBox
showuon opened a new pull request #11124: URL: https://github.com/apache/kafka/pull/11124 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] showuon commented on a change in pull request #11123: MINOR: factor state checks into descriptive methods and clarify javadocs

2021-07-24 Thread GitBox
showuon commented on a change in pull request #11123: URL: https://github.com/apache/kafka/pull/11123#discussion_r675962838 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1428,12 +1447,12 @@ public synchronized boolean close(final

[GitHub] [kafka] showuon commented on a change in pull request #11123: MINOR: factor state checks into descriptive methods and clarify javadocs

2021-07-24 Thread GitBox
showuon commented on a change in pull request #11123: URL: https://github.com/apache/kafka/pull/11123#discussion_r675962656 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -386,23 +405,23 @@ public void setStateListener(final

[GitHub] [kafka] showuon commented on pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-24 Thread GitBox
showuon commented on pull request #11105: URL: https://github.com/apache/kafka/pull/11105#issuecomment-886009717 Failed tests are unrelated. Thank you. ``` Build / JDK 11 and Scala 2.13 /