[GitHub] [kafka] showuon commented on a change in pull request #11160: MINOR: update batch.size doc

2021-07-31 Thread GitBox
showuon commented on a change in pull request #11160: URL: https://github.com/apache/kafka/pull/11160#discussion_r680443544 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -106,7 +111,7 @@ private static final String LINGER_

[GitHub] [kafka] showuon opened a new pull request #11160: MINOR: update batch.size doc

2021-07-31 Thread GitBox
showuon opened a new pull request #11160: URL: https://github.com/apache/kafka/pull/11160 Found we didn't mention anything about the `linger.ms` and upper bound batch size concept in the `batch.size`, which will lead users believe we'll send every batch with this `batch.size` setting value

[GitHub] [kafka] dielhennr removed a comment on pull request #11159: MINOR: Change default node id in kraft broker properties

2021-07-31 Thread GitBox
dielhennr removed a comment on pull request #11159: URL: https://github.com/apache/kafka/pull/11159#issuecomment-890412999 If all quorum voters wrote a `RegisterVoterRecord` or similar to the metadata quorum with the `node.id` and `process.roles` of that node, then controllers would be ab

[GitHub] [kafka] dielhennr edited a comment on pull request #11159: MINOR: Change default node id in kraft broker properties

2021-07-31 Thread GitBox
dielhennr edited a comment on pull request #11159: URL: https://github.com/apache/kafka/pull/11159#issuecomment-890412999 If all quorum voters wrote a `RegisterVoterRecord` or similar to the metadata quorum with the `node.id` and `process.roles` of that node, then controllers would be abl

[GitHub] [kafka] dielhennr commented on pull request #11159: MINOR: Change default node id in kraft broker properties

2021-07-31 Thread GitBox
dielhennr commented on pull request #11159: URL: https://github.com/apache/kafka/pull/11159#issuecomment-890412999 If all quorum voters wrote a `RegisterVoterRecord` or similar to the metadata quorum with the `node.id` and `process.roles` of that node, then controllers would be able to tr

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-31 Thread GitBox
jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r680401984 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] dielhennr opened a new pull request #11159: MINOR: Change default node id in kraft broker properties

2021-07-31 Thread GitBox
dielhennr opened a new pull request #11159: URL: https://github.com/apache/kafka/pull/11159 Previously, the default `node.id` specified in `config/kraft/controller.properties` was the same as the `node.id` specified in `config/kraft/broker.properties`. If the user didn't change one of the

[GitHub] [kafka] jsancio commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

2021-07-31 Thread GitBox
jsancio commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r680388871 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -113,22 +116,23 @@ public Long append(int epoch, List record

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-07-31 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390988#comment-17390988 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 7/31/21, 3:52 PM:

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-07-31 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390988#comment-17390988 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 7/31/21, 3:48 PM:

[jira] [Commented] (KAFKA-7025) Android client support

2021-07-31 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390988#comment-17390988 ] Nikolai Lubiagov commented on KAFKA-7025: - I comment this code and now it can com

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-07-31 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390977#comment-17390977 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 7/31/21, 2:52 PM:

[jira] [Commented] (KAFKA-7025) Android client support

2021-07-31 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390977#comment-17390977 ] Nikolai Lubiagov commented on KAFKA-7025: - Hm, compiler does not specify file whe

[jira] [Commented] (KAFKA-9965) Uneven distribution with RoundRobinPartitioner in AK 2.4+

2021-07-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390950#comment-17390950 ] Luke Chen commented on KAFKA-9965: -- [~cmccabe] [~ijuma] , I have a proposal for this iss

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-31 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r680328486 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the A

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-31 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r680328486 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the A

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-31 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r680328486 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the A

[jira] [Resolved] (KAFKA-13153) Disallow KRaft broker registration if the node.id is already in use

2021-07-31 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn resolved KAFKA-13153. --- Resolution: Won't Fix This would render colocated Kraft useless. > Disallow KRaft broker re

[GitHub] [kafka] dielhennr commented on pull request #11158: KAFKA-13153: Disallow KRaft broker registration if the node.id is already in use by a controller

2021-07-31 Thread GitBox
dielhennr commented on pull request #11158: URL: https://github.com/apache/kafka/pull/11158#issuecomment-890309169 This renders colocated KRaft useless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dielhennr closed pull request #11158: KAFKA-13153: Disallow KRaft broker registration if the node.id is already in use by a controller

2021-07-31 Thread GitBox
dielhennr closed pull request #11158: URL: https://github.com/apache/kafka/pull/11158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-31 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r680325822 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -42,6 +34,14 @@ import org.apache.kafka.common.quota.ClientQuotaFilt

[GitHub] [kafka] dielhennr opened a new pull request #11158: KAFKA-13153: Disallow KRaft broker registration if the node.id is already in use

2021-07-31 Thread GitBox
dielhennr opened a new pull request #11158: URL: https://github.com/apache/kafka/pull/11158 Kraft brokers were previously able to register with the same `node.id` as a controller without failing startup but they would not unfence themselves since they are never able to catchup to the last

[jira] [Created] (KAFKA-13153) Disallow KRaft broker registration if the node.id is already in use

2021-07-31 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13153: - Summary: Disallow KRaft broker registration if the node.id is already in use Key: KAFKA-13153 URL: https://issues.apache.org/jira/browse/KAFKA-13153 Project: Kafka