[GitHub] [kafka] wangxianghu opened a new pull request #11210: KAFKA-13199: Make Task extends Versioned

wangxianghu opened a new pull request #11210: URL: https://github.com/apache/kafka/pull/11210 Since `Task` is versioned, we can make it extends `Versioned` directly, no need to introduce `String version()` again ### Committer Checklist (excluded from commit message) - [ ] Verify

[jira] [Updated] (KAFKA-13199) Make Task extends Versioned

[ https://issues.apache.org/jira/browse/KAFKA-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xianghu Wang updated KAFKA-13199: - Summary: Make Task extends Versioned (was: Make Task extend Versioned) > Make Task extends

[jira] [Created] (KAFKA-13199) Make Task extend Versioned

Xianghu Wang created KAFKA-13199: Summary: Make Task extend Versioned Key: KAFKA-13199 URL: https://issues.apache.org/jira/browse/KAFKA-13199 Project: Kafka Issue Type: Wish

[GitHub] [kafka] kamalcph commented on pull request #11197: 28x TS changes

kamalcph commented on pull request #11197: URL: https://github.com/apache/kafka/pull/11197#issuecomment-898206391 retest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-12155) Delay increasing the log start offset

[ https://issues.apache.org/jira/browse/KAFKA-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-12155. Resolution: Fixed > Delay increasing the log start offset > -

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688255651 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -730,6 +732,41 @@ public void

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688245686 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -590,9 +593,11 @@ else if (acks != -1) public void

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r68825 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsThreadTotalBlockedTime.java ## @@ -0,0 +1,61 @@ +/* + * Licensed

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688242729 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -200,6 +201,30 @@ public

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688240994 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -178,12 +180,39 @@ public void

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688240676 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -730,6 +732,41 @@ public void

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688239443 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -178,12 +180,39 @@ public void

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688236582 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -590,9 +593,11 @@ else if (acks != -1) public void

[GitHub] [kafka] showuon commented on a change in pull request #11208: MINOR: Refactored BrokerHeartbeatManager::findOneStaleBroker to not use

showuon commented on a change in pull request #11208: URL: https://github.com/apache/kafka/pull/11208#discussion_r688206957 ## File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java ## @@ -200,6 +200,14 @@ void

[GitHub] [kafka] dengziming commented on pull request #11209: KAFKA-12465: Logic about inconsistent cluster id

dengziming commented on pull request #11209: URL: https://github.com/apache/kafka/pull/11209#issuecomment-898134690 Hi @hachikuji @jsancio , PTAL. I also moved the logic for `UNKNOWN_TOPIC_OR_PARTITION` in handleFetchSnapshot to `RaftUtil.java`. -- This is an automated message from

[GitHub] [kafka] dengziming opened a new pull request #11209: KAFKA-12465: Logic about inconsistent cluster id

dengziming opened a new pull request #11209: URL: https://github.com/apache/kafka/pull/11209 *More detailed description of your change* When handling a response, invalid cluster id are fatal unless a previous response contained a valid cluster id. Note that this is not a perfect, see

[GitHub] [kafka] lbradstreet commented on pull request #11199: KAFKA-13194: bound cleaning by both LSO and HWM when firstUnstableOffsetMetadata is None

lbradstreet commented on pull request #11199: URL: https://github.com/apache/kafka/pull/11199#issuecomment-898057637 > @lbradstreet : Thanks for the updated PR. LGTM. Are the 29 test failures related to this PR? @junrao yeah, they're looking related. Let me clean those up. --

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r688142016 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -1369,4 +1385,67 @@ public void

[jira] [Resolved] (KAFKA-13068) Rename Log to UnifiedLog

[ https://issues.apache.org/jira/browse/KAFKA-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-13068. - Fix Version/s: 3.1.0 Resolution: Fixed Merged the PR to trunk > Rename Log to UnifiedLog >

[GitHub] [kafka] junrao merged pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

junrao merged pull request #11154: URL: https://github.com/apache/kafka/pull/11154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-13198) TopicsDelta doesn't update deleted topic when processing PartitionChangeRecord

Jose Armando Garcia Sancio created KAFKA-13198: -- Summary: TopicsDelta doesn't update deleted topic when processing PartitionChangeRecord Key: KAFKA-13198 URL:

[GitHub] [kafka] lbradstreet commented on a change in pull request #11199: KAFKA-13194: bound cleaning by both LSO and HWM when firstUnstableOffsetMetadata is None

lbradstreet commented on a change in pull request #11199: URL: https://github.com/apache/kafka/pull/11199#discussion_r688051998 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala ## @@ -541,6 +541,29 @@ class LogCleanerManagerTest extends Logging {

[GitHub] [kafka] lbradstreet commented on a change in pull request #11199: KAFKA-13194: bound cleaning by both LSO and HWM when firstUnstableOffsetMetadata is None

lbradstreet commented on a change in pull request #11199: URL: https://github.com/apache/kafka/pull/11199#discussion_r688051673 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -595,8 +595,8 @@ private[log] object LogCleanerManager extends Logging {

[GitHub] [kafka] rondagostino commented on a change in pull request #11200: KAFKA-13192: Prevent inconsistent broker.id/node.id values

rondagostino commented on a change in pull request #11200: URL: https://github.com/apache/kafka/pull/11200#discussion_r688016827 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1905,6 +1905,13 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] rondagostino commented on a change in pull request #11200: KAFKA-13192: Prevent inconsistent broker.id/node.id values

rondagostino commented on a change in pull request #11200: URL: https://github.com/apache/kafka/pull/11200#discussion_r688016827 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1905,6 +1905,13 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] rondagostino commented on a change in pull request #11200: KAFKA-13192: Prevent inconsistent broker.id/node.id values

rondagostino commented on a change in pull request #11200: URL: https://github.com/apache/kafka/pull/11200#discussion_r688014091 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1905,6 +1905,13 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] junrao commented on a change in pull request #11199: KAFKA-13194: bound cleaning by both LSO and HWM when firstUnstableOffsetMetadata is None

junrao commented on a change in pull request #11199: URL: https://github.com/apache/kafka/pull/11199#discussion_r687993862 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -595,8 +595,8 @@ private[log] object LogCleanerManager extends Logging { //

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13142: - Fix Version/s: (was: 3.0.0) 3.0.1 Affects Version/s: 3.0.0 >

[jira] [Resolved] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

[ https://issues.apache.org/jira/browse/KAFKA-13173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-13173. -- Resolution: Fixed > KRaft controller does not handle simultaneous broker expirations

[jira] [Commented] (KAFKA-13162) ElectLeader API must be forwarded to Controller

[ https://issues.apache.org/jira/browse/KAFKA-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17398209#comment-17398209 ] Jason Gustafson commented on KAFKA-13162: - This has turned out to be more work than expected. I

[jira] [Updated] (KAFKA-13162) ElectLeader API must be forwarded to Controller

[ https://issues.apache.org/jira/browse/KAFKA-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13162: Fix Version/s: (was: 3.0.0) 3.0.1 > ElectLeader API must be

[GitHub] [kafka] niket-goel opened a new pull request #11208: MINOR: Refactored BrokerHeartbeatManager::findOneStaleBroker to not use

niket-goel opened a new pull request #11208: URL: https://github.com/apache/kafka/pull/11208 Some code refactoring based on https://github.com/apache/kafka/pull/11191 feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] niket-goel commented on pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

niket-goel commented on pull request #11191: URL: https://github.com/apache/kafka/pull/11191#issuecomment-897806958 @hachikuji Will follow up with a follow-up. Thanks for merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Assigned] (KAFKA-12956) Validate the snapshot id when the state machine freeze a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-12956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12956: -- Assignee: loboxu > Validate the snapshot id when the state machine freeze a snapshot >

[jira] [Assigned] (KAFKA-13016) Interpret snapshot header version to correctly parse the snapshot

[ https://issues.apache.org/jira/browse/KAFKA-13016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-13016: -- Assignee: loboxu > Interpret snapshot header version to correctly parse the snapshot >

[GitHub] [kafka] socutes commented on pull request #11207: KAFKA-10900: Add metrics enumerated in KIP-630

socutes commented on pull request #11207: URL: https://github.com/apache/kafka/pull/11207#issuecomment-897797158 @jsancio @cmccabe please help review this pr. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] socutes opened a new pull request #11207: KAFKA-10900: Add metrics enumerated in KIP-630

socutes opened a new pull request #11207: URL: https://github.com/apache/kafka/pull/11207 KIP-630 enumerates a few metrics. Makes sure that those metrics are implemented. Add the following Metrics. kafka.controller:type=KafkaController,name=GenSnapshotLatencyMs , A histogram of the

[GitHub] [kafka] hachikuji merged pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

hachikuji merged pull request #11191: URL: https://github.com/apache/kafka/pull/11191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji commented on pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

hachikuji commented on pull request #11191: URL: https://github.com/apache/kafka/pull/11191#issuecomment-897785278 @niket-goel I'm inclined to merge this as is so that we don't need to wait for another build. Perhaps you can submit a small follow-up to address @jsancio 's comments? --

[jira] [Commented] (KAFKA-13188) Release the memory back into MemoryPool

[ https://issues.apache.org/jira/browse/KAFKA-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17398148#comment-17398148 ] Alok Nikhil commented on KAFKA-13188: - [~luwang] I see that the consumer side memory pool management

[GitHub] [kafka] socutes closed pull request #11205: KAFKA-10900: Add metrics enumerated in KIP-630

socutes closed pull request #11205: URL: https://github.com/apache/kafka/pull/11205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a change in pull request #11191: KAFKA-13173 Making the controller fence stale brokers one at a time if multiple stale brokers are discovered at the same time

jsancio commented on a change in pull request #11191: URL: https://github.com/apache/kafka/pull/11191#discussion_r687047710 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -161,6 +163,14 @@ public void deactivate() {

[GitHub] [kafka] SkyTianTian edited a comment on pull request #10277: KAFKA-9914: Fix replication cycle detection

SkyTianTian edited a comment on pull request #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-897736948 Hi, is there anyone who knows any workaround to avoid this heartbeat issue temporarily? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] jsancio commented on a change in pull request #11200: KAFKA-13192: Prevent inconsistent broker.id/node.id values

jsancio commented on a change in pull request #11200: URL: https://github.com/apache/kafka/pull/11200#discussion_r687854292 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1905,6 +1905,13 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] SkyTianTian commented on pull request #10277: KAFKA-9914: Fix replication cycle detection

SkyTianTian commented on pull request #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-897736948 Hi, is there anyone who knows any workaround to avoid this heartbeat issue? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-13197) KStream-GlobalKTable join semantics don't match documentation

Tommy Becker created KAFKA-13197: Summary: KStream-GlobalKTable join semantics don't match documentation Key: KAFKA-13197 URL: https://issues.apache.org/jira/browse/KAFKA-13197 Project: Kafka

[jira] [Updated] (KAFKA-13196) MirrorMaker 2 not always start tasks

[ https://issues.apache.org/jira/browse/KAFKA-13196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jozef Vilcek updated KAFKA-13196: - Summary: MirrorMaker 2 not always start tasks (was: MirrorMaker 2 not always starting tasks)

[jira] [Updated] (KAFKA-13196) MirrorMaker 2 not always start tasks

[ https://issues.apache.org/jira/browse/KAFKA-13196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jozef Vilcek updated KAFKA-13196: - Description: I am using MirrorMaker 2.0 and running it via [ 

[jira] [Updated] (KAFKA-13196) MirrorMaker 2 not always start tasks

[ https://issues.apache.org/jira/browse/KAFKA-13196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jozef Vilcek updated KAFKA-13196: - Description: I am using MirrorMaker 2.0 and running it via [ 

[jira] [Updated] (KAFKA-13196) MirrorMaker 2 not always starting tasks

[ https://issues.apache.org/jira/browse/KAFKA-13196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jozef Vilcek updated KAFKA-13196: - Summary: MirrorMaker 2 not always starting tasks (was: MirrorMaker 2 not always starting tasks

[jira] [Created] (KAFKA-13196) MirrorMaker 2 not always starting tasks after upgrade 2.4.0 -> 2.7.1

Jozef Vilcek created KAFKA-13196: Summary: MirrorMaker 2 not always starting tasks after upgrade 2.4.0 -> 2.7.1 Key: KAFKA-13196 URL: https://issues.apache.org/jira/browse/KAFKA-13196 Project: Kafka

[GitHub] [kafka] tvainika commented on a change in pull request #10277: KAFKA-9914: Fix replication cycle detection

tvainika commented on a change in pull request #10277: URL: https://github.com/apache/kafka/pull/10277#discussion_r687772348 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -489,7 +489,17 @@ boolean isCycle(String

[jira] [Created] (KAFKA-13195) StateSerde don't honor DeserializationExceptionHandler

Ludo created KAFKA-13195: Summary: StateSerde don't honor DeserializationExceptionHandler Key: KAFKA-13195 URL: https://issues.apache.org/jira/browse/KAFKA-13195 Project: Kafka Issue Type: Bug

[GitHub] [kafka] ryannedolan commented on a change in pull request #10277: KAFKA-9914: Fix replication cycle detection

ryannedolan commented on a change in pull request #10277: URL: https://github.com/apache/kafka/pull/10277#discussion_r687741760 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -489,7 +489,17 @@ boolean isCycle(String

[GitHub] [kafka] showuon commented on pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

showuon commented on pull request #11206: URL: https://github.com/apache/kafka/pull/11206#issuecomment-897622337 @bbejeck , please help review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon opened a new pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

showuon opened a new pull request #11206: URL: https://github.com/apache/kafka/pull/11206 Update the streams doc: 1. close `KeyValueIterator` in example code https://user-images.githubusercontent.com/43372967/129201334-326ff4f9-e06e-426d-9d2d-ce70e13cbf9c.png;> 2. Fix the

[GitHub] [kafka] socutes opened a new pull request #11205: KAFKA-10900: Add metrics enumerated in KIP-630

socutes opened a new pull request #11205: URL: https://github.com/apache/kafka/pull/11205 KIP-630 enumerates a few metrics. Makes sure that those metrics are implemented. Add the following Metrics. kafka.controller:type=KafkaController,name=GenSnapshotLatencyMs | A histogram of

[GitHub] [kafka] showuon commented on a change in pull request #11200: KAFKA-13192: Prevent inconsistent broker.id/node.id values

showuon commented on a change in pull request #11200: URL: https://github.com/apache/kafka/pull/11200#discussion_r687624316 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1905,6 +1905,13 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] xdgrulez commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

xdgrulez commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-897524395 Hi, will do that as soon as I have some time - and sorry for not finding time yet… If anyone else would have some more time on her/his hand - you basically just

[jira] [Commented] (KAFKA-13014) KAFKA-Stream stucked when the offset is no more existing

[ https://issues.apache.org/jira/browse/KAFKA-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397957#comment-17397957 ] Ahmed Toumi commented on KAFKA-13014: - thanks [~mjsax] : but the problem was more complicated then i

[jira] [Updated] (KAFKA-12835) Topic IDs can mismatch on brokers (after interbroker protocol version update)

[ https://issues.apache.org/jira/browse/KAFKA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12835: Fix Version/s: 2.8.1 > Topic IDs can mismatch on brokers (after interbroker protocol version

[GitHub] [kafka] dajac commented on pull request #11201: MINOR: fix mbean tag name ordering in JMX reporter

dajac commented on pull request #11201: URL: https://github.com/apache/kafka/pull/11201#issuecomment-897421076 @xvrl Thanks for the patch. I think that ordering tags make sense. However, I am a little concerned by the potential implication of changing this. I vaguely recall having to

[GitHub] [kafka] tvainika commented on a change in pull request #10277: KAFKA-9914: Fix replication cycle detection

tvainika commented on a change in pull request #10277: URL: https://github.com/apache/kafka/pull/10277#discussion_r687419372 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -489,7 +489,17 @@ boolean isCycle(String