[GitHub] [kafka] satishd closed pull request #11197: 28x TS changes

satishd closed pull request #11197: URL: https://github.com/apache/kafka/pull/11197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] dengziming commented on pull request #11198: MINOR: Use compressionType parameter in SnapshotWriter

dengziming commented on pull request #11198: URL: https://github.com/apache/kafka/pull/11198#issuecomment-80080 @showuon Thank you, I am thinking how can I test this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] mjsax commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

mjsax commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r690013977 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,78 @@ privat

[GitHub] [kafka] showuon commented on a change in pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

showuon commented on a change in pull request #11218: URL: https://github.com/apache/kafka/pull/11218#discussion_r690007620 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -48,6 +53,16 @@ public class ConsumerConfig extends Abst

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689978096 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -2074,48 +2073,23 @@ class ReplicaManager(val config: KafkaConfig, } }

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689978096 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -2074,48 +2073,23 @@ class ReplicaManager(val config: KafkaConfig, } }

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689974956 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -2074,48 +2073,23 @@ class ReplicaManager(val config: KafkaConfig, } }

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r689953353 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,78 @@ priv

[GitHub] [kafka] mjsax commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

mjsax commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r689950309 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,78 @@ privat

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689940858 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String n

[jira] [Created] (KAFKA-13208) Use TopicIdPartition instead of TopicPartition when computing the topic delta

Jose Armando Garcia Sancio created KAFKA-13208: -- Summary: Use TopicIdPartition instead of TopicPartition when computing the topic delta Key: KAFKA-13208 URL: https://issues.apache.org/jira/browse/KAFK

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689937435 ## File path: core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala ## @@ -410,6 +421,32 @@ class KRaftClusterTest { } } + privat

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689870784 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String n

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400039#comment-17400039 ] Ismael Juma commented on KAFKA-12713: - I had missed that. Worth bumping that thread

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400037#comment-17400037 ] Kai Huang commented on KAFKA-12713: --- [~ijuma] here is the [discussion thread|https://

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689907759 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String na

[GitHub] [kafka] hachikuji commented on a change in pull request #11221: KAFKA-13207: Don't partition state on fetch response with diverging epoch if partition removed from fetcher

hachikuji commented on a change in pull request #11221: URL: https://github.com/apache/kafka/pull/11221#discussion_r689886267 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -268,7 +262,10 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689874304 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String n

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689871542 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String n

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689870784 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String n

[GitHub] [kafka] rajinisivaram commented on a change in pull request #11221: KAFKA-13207: Don't partition state on fetch response with diverging epoch if partition removed from fetcher

rajinisivaram commented on a change in pull request #11221: URL: https://github.com/apache/kafka/pull/11221#discussion_r689860826 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -229,9 +229,16 @@ abstract class AbstractFetcherThread(name: String

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689841279 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String na

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1730#comment-1730 ] Ismael Juma commented on KAFKA-12713: - [~kaihuang] Thanks for the KIP. I suggest sta

[jira] [Commented] (KAFKA-13206) shutting down broker needs to stop fetching as a follower in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399978#comment-17399978 ] Jun Rao commented on KAFKA-13206: - It's probably after the controller has acted on the c

[jira] [Updated] (KAFKA-13206) shutting down broker needs to stop fetching as a follower in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13206: --- Component/s: replication kraft > shutting down brok

[jira] [Commented] (KAFKA-13206) shutting down broker needs to stop fetching as a follower in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399976#comment-17399976 ] Jose Armando Garcia Sancio commented on KAFKA-13206: Thanks for the

[GitHub] [kafka] rondagostino opened a new pull request #11222: MINOR: Test ReplicaManager MBean names

rondagostino opened a new pull request #11222: URL: https://github.com/apache/kafka/pull/11222 This patch closes a testing gap by confirming that ReplicaManager metrics are exposed with the expected MBean names. ### Committer Checklist (excluded from commit message) - [ ] Verify d

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689787245 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -162,4 +163,39 @@ public boolean topicWasDeleted(String topicName) {

[GitHub] [kafka] cmccabe merged pull request #11219: MINOR: clarify assertion in handleListPartitionReassignmentsRequest

cmccabe merged pull request #11219: URL: https://github.com/apache/kafka/pull/11219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Comment Edited] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399940#comment-17399940 ] Kai Huang edited comment on KAFKA-12713 at 8/16/21, 6:48 PM: -

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399940#comment-17399940 ] Kai Huang commented on KAFKA-12713: --- [~ijuma] I would like to follow up on this ticket

[GitHub] [kafka] dajac commented on a change in pull request #11221: KAFKA-13207: Don't partition state on fetch response with diverging epoch if partition removed from fetcher

dajac commented on a change in pull request #11221: URL: https://github.com/apache/kafka/pull/11221#discussion_r689770112 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -229,9 +229,16 @@ abstract class AbstractFetcherThread(name: String, }

[jira] [Commented] (KAFKA-13195) StateSerde don't honor DeserializationExceptionHandler

[ https://issues.apache.org/jira/browse/KAFKA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399913#comment-17399913 ] Ludo commented on KAFKA-13195: -- Thanks for all the clarification, really appreciated. I wil

[jira] [Commented] (KAFKA-13206) shutting down broker needs to stop fetching as a follower in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399908#comment-17399908 ] Jun Rao commented on KAFKA-13206: - [~cmccabe] mentioned the following. The broker being

[jira] [Commented] (KAFKA-13195) StateSerde don't honor DeserializationExceptionHandler

[ https://issues.apache.org/jira/browse/KAFKA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399902#comment-17399902 ] Matthias J. Sax commented on KAFKA-13195: - Your transformer is in the stacktrace

[jira] [Updated] (KAFKA-13195) StateSerde don't honor DeserializationExceptionHandler

[ https://issues.apache.org/jira/browse/KAFKA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13195: Issue Type: Improvement (was: Bug) > StateSerde don't honor DeserializationExceptionHandl

[GitHub] [kafka] rajinisivaram opened a new pull request #11221: KAFKA-13207: Don't partition state on fetch response with diverging epoch if partition removed from fetcher

rajinisivaram opened a new pull request #11221: URL: https://github.com/apache/kafka/pull/11221 `AbstractFetcherThread#truncateOnFetchResponse` is used with IBP 2.7 and above to truncate partitions based on diverging epoch returned in fetch responses. Truncation should only be performed fo

[jira] [Created] (KAFKA-13207) Replica fetcher should not update partition state on diverging epoch if partition removed from fetcher

Rajini Sivaram created KAFKA-13207: -- Summary: Replica fetcher should not update partition state on diverging epoch if partition removed from fetcher Key: KAFKA-13207 URL: https://issues.apache.org/jira/browse/KAF

[jira] [Updated] (KAFKA-13206) shutting down broker needs to stop fetching as a follower in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13206: Labels: kip-500 (was: ) > shutting down broker needs to stop fetching as a follower in KRaft mode

[jira] [Created] (KAFKA-13206) shutting down broker needs to stop fetching as a follower in KRaft mode

Jun Rao created KAFKA-13206: --- Summary: shutting down broker needs to stop fetching as a follower in KRaft mode Key: KAFKA-13206 URL: https://issues.apache.org/jira/browse/KAFKA-13206 Project: Kafka

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689659905 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -162,4 +163,39 @@ public boolean topicWasDeleted(String topicName) {

[GitHub] [kafka] OmniaGM opened a new pull request #11220: KAFKA-10777: Add additional configuration to control MirrorMaker 2 internal topics naming convention

OmniaGM opened a new pull request #11220: URL: https://github.com/apache/kafka/pull/11220 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of tes

[GitHub] [kafka] rondagostino commented on pull request #11219: MINOR: Forward list partition reassignments

rondagostino commented on pull request #11219: URL: https://github.com/apache/kafka/pull/11219#issuecomment-899637052 Actually, I see now that this is simply fixing the error message. LGTM as-is. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] xdgrulez commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

xdgrulez commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-899621818 Hi, I've fixed the tests now - on my local machine, the complete :streams:test suite is now working perfectly fine again :) Best regards, Ralph -- This i

[GitHub] [kafka] rondagostino commented on pull request #11219: MINOR: Forward list partition reassignments

rondagostino commented on pull request #11219: URL: https://github.com/apache/kafka/pull/11219#issuecomment-899567795 Good catch. I wonder if this should be fixed for 3.0 -- i.e. should it be a blocker? Also, is there a way to close the testing gap that allowed this to exist -- maybe hav

[jira] [Commented] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399752#comment-17399752 ] Eran Levy commented on KAFKA-10643: --- Actually I think that we never solved it but it r

[GitHub] [kafka] dengziming commented on pull request #11219: MINOR: Forward list partition reassignments

dengziming commented on pull request #11219: URL: https://github.com/apache/kafka/pull/11219#issuecomment-899490789 ping @rondagostino @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] dengziming opened a new pull request #11219: MINOR: Forward list partition reassignments

dengziming opened a new pull request #11219: URL: https://github.com/apache/kafka/pull/11219 *More detailed description of your change* We already support list partition reassignments in KRAFT mode, so change `notYetSupported` to `shouldAlwaysForward` *Summary of testing strategy

[jira] [Created] (KAFKA-13205) Clarify API specification of Kafka Connect endpoint

Jonathan Kaleve created KAFKA-13205: --- Summary: Clarify API specification of Kafka Connect endpoint Key: KAFKA-13205 URL: https://issues.apache.org/jira/browse/KAFKA-13205 Project: Kafka Iss

[jira] [Updated] (KAFKA-13205) Clarify API specification of Kafka Connect endpoint

[ https://issues.apache.org/jira/browse/KAFKA-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Kaleve updated KAFKA-13205: Description: Since Version 2.5, Kafka Connect exposes an Endpoint for getting all topics

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399346#comment-17399346 ] Maatari edited comment on KAFKA-10643 at 8/16/21, 11:44 AM:

[GitHub] [kafka] mimaison commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

mimaison commented on pull request #11212: URL: https://github.com/apache/kafka/pull/11212#issuecomment-899357757 @showuon Good point, updated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] showuon commented on pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

showuon commented on pull request #11218: URL: https://github.com/apache/kafka/pull/11218#issuecomment-899357307 @guozhangwang @ableegoldman , please take a look when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] showuon commented on a change in pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

showuon commented on a change in pull request #11218: URL: https://github.com/apache/kafka/pull/11218#discussion_r689370424 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -597,28 +603,32 @@ private void updateGrou

[GitHub] [kafka] showuon opened a new pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

showuon opened a new pull request #11218: URL: https://github.com/apache/kafka/pull/11218 Found this while reading the code. We did a "a little heavy" check each time after performing assignment, which is to compare the "assigned topics" set and the "subscribed topics" set, to see if there

[GitHub] [kafka] showuon commented on pull request #11217: KAFKA-13204: assignor name conflict check

showuon commented on pull request #11217: URL: https://github.com/apache/kafka/pull/11217#issuecomment-899322956 @ableegoldman , please take a look when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] showuon opened a new pull request #11217: KAFKA-13204: assignor name conflict check

showuon opened a new pull request #11217: URL: https://github.com/apache/kafka/pull/11217 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[jira] [Commented] (KAFKA-13081) Port sticky assignor fixes (KAFKA-12984) back to 2.8

[ https://issues.apache.org/jira/browse/KAFKA-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399588#comment-17399588 ] Luke Chen commented on KAFKA-13081: --- My PR is ready for [~ableegoldman] 's review, I t

[jira] [Commented] (KAFKA-13081) Port sticky assignor fixes (KAFKA-12984) back to 2.8

[ https://issues.apache.org/jira/browse/KAFKA-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399566#comment-17399566 ] David Jacot commented on KAFKA-13081: - [~ableegoldman] [~showuon] This is the only r

[jira] [Created] (KAFKA-13204) wrong assignor selected if the assignor name is identical

Luke Chen created KAFKA-13204: - Summary: wrong assignor selected if the assignor name is identical Key: KAFKA-13204 URL: https://issues.apache.org/jira/browse/KAFKA-13204 Project: Kafka Issue Typ

[jira] [Updated] (KAFKA-13204) wrong assignor selected if the assignor name is identical

[ https://issues.apache.org/jira/browse/KAFKA-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13204: -- Description: We used the partition assignor name to identify which assignor to use in consumer coordin