[jira] [Commented] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-30 Thread Anamika Nadkarni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407122#comment-17407122 ] Anamika Nadkarni commented on KAFKA-13255: -- To replicate source topic in destin

[jira] [Commented] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-30 Thread Anamika Nadkarni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407116#comment-17407116 ] Anamika Nadkarni commented on KAFKA-13255: -- I keep getting HTTP error 403 when

[jira] [Created] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-30 Thread Anamika Nadkarni (Jira)
Anamika Nadkarni created KAFKA-13255: Summary: Mirrormaker config property config.properties.exclude is not working as expected Key: KAFKA-13255 URL: https://issues.apache.org/jira/browse/KAFKA-13255

[GitHub] [kafka] rodesai commented on pull request #11286: add units to metrics descriptions + test fix

2021-08-30 Thread GitBox
rodesai commented on pull request #11286: URL: https://github.com/apache/kafka/pull/11286#issuecomment-908931988 @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] rodesai opened a new pull request #11286: add units to metrics descriptions + test fix

2021-08-30 Thread GitBox
rodesai opened a new pull request #11286: URL: https://github.com/apache/kafka/pull/11286 Fix some review feedback and test flakiness from #11149 - adds units to metrics descriptions for total blocked time metrics - fix producer metrics test checks -- This is an automated message f

[jira] [Commented] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java

2021-08-30 Thread S. B. Hunter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407070#comment-17407070 ] S. B. Hunter commented on KAFKA-13248: -- I would love to. I already have changed the

[GitHub] [kafka] hutchiko edited a comment on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-30 Thread GitBox
hutchiko edited a comment on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908804447 @ableegoldman I did not test against 3.0 just 2.7 and 2.8. I'll rebase onto `trunk` as see how that goes. -- This is an automated message from the Apache Git Service.

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-30 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Affects Version/s: 3.0.0 > Checkpoints do not contain latest offsets on shutdown when us

[GitHub] [kafka] hutchiko commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-30 Thread GitBox
hutchiko commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908826996 Yeah I've rebased and verified the issue is there in `trunk` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] hutchiko commented on a change in pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-30 Thread GitBox
hutchiko commented on a change in pull request #11283: URL: https://github.com/apache/kafka/pull/11283#discussion_r698898574 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -565,7 +565,7 @@ public void closeCleanAndRecycle

[GitHub] [kafka] hutchiko commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-30 Thread GitBox
hutchiko commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908804447 @ableegoldman I did not test against 3.0 just 2.7 and 2.8. I'll rebase onto trunk/3.0 as see how that goes. -- This is an automated message from the Apache Git Service. To re

[jira] [Updated] (KAFKA-13091) Increment HW after shrinking ISR through AlterIsr

2021-08-30 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13091: Fix Version/s: (was: 3.0.1) > Increment HW after shrinking ISR through AlterIsr >

[jira] [Updated] (KAFKA-13254) Deadlock when expanding ISR

2021-08-30 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13254: Issue Type: Bug (was: Improvement) > Deadlock when expanding ISR > --

[jira] [Created] (KAFKA-13254) Deadlock when expanding ISR

2021-08-30 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13254: --- Summary: Deadlock when expanding ISR Key: KAFKA-13254 URL: https://issues.apache.org/jira/browse/KAFKA-13254 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java

2021-08-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406991#comment-17406991 ] A. Sophie Blee-Goldman commented on KAFKA-13248: Nice find, thanks for t

[GitHub] [kafka] gitlw opened a new pull request #11285: KAFKA-10548: Implement topic deletion logic with the LeaderAndIsr in KIP-516

2021-08-30 Thread GitBox
gitlw opened a new pull request #11285: URL: https://github.com/apache/kafka/pull/11285 This PR includes the following changes 1. Adding the type field to the LeaderAndIsr request as proposed in KIP-516 2. Letting the controller set the type of LeaderAndIsr requests to be either FULL

[GitHub] [kafka] ableegoldman commented on a change in pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-30 Thread GitBox
ableegoldman commented on a change in pull request #11283: URL: https://github.com/apache/kafka/pull/11283#discussion_r698868805 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -565,7 +565,7 @@ public void closeCleanAndRec

[jira] [Commented] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406988#comment-17406988 ] A. Sophie Blee-Goldman commented on KAFKA-13249: Thanks for the detailed

[GitHub] [kafka] guozhangwang merged pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-30 Thread GitBox
guozhangwang merged pull request #11149: URL: https://github.com/apache/kafka/pull/11149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-30 Thread GitBox
guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r698854001 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/KafkaProducerMetrics.java ## @@ -0,0 +1,123 @@ +/* + * Licensed to t

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13249: --- Affects Version/s: (was: 2.7.1) > Checkpoints do not contain latest offs

[GitHub] [kafka] ableegoldman commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-30 Thread GitBox
ableegoldman commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908748576 Hey @hutchiko , thanks for digging into this bug so thoroughly and providing a patch! One quick question before I review -- does this only affect version 2.8 or below speci

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-30 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r698849242 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[GitHub] [kafka] kirktrue opened a new pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-08-30 Thread GitBox
kirktrue opened a new pull request #11284: URL: https://github.com/apache/kafka/pull/11284 This task is to provide a concrete implementation of the interfaces defined in KIP-255 to allow Kafka to connect to an OAuth/OIDC identity provider for authentication and token retrieval. While KIP-2

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-30 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r698693107 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-30 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r698693107 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-30 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r698652526 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[jira] [Resolved] (KAFKA-13253) Kafka Connect losing task (re)configuration when connector name has special characters

2021-08-30 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban resolved KAFKA-13253. -- Resolution: Duplicate Same issue as KAFKA-9747 - that one already has a fix under review > Ka

[GitHub] [kafka] junrao merged pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-08-30 Thread GitBox
junrao merged pull request #11060: URL: https://github.com/apache/kafka/pull/11060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-30 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-908365423 Test failure is related to https://issues.apache.org/jira/browse/KAFKA-8138 but not the same, as in this particular instance it seems more like a failure in the test itself (topi

[GitHub] [kafka] dajac commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-30 Thread GitBox
dajac commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-908364578 @lbradstreet @junrao Could you take a look at this one as you both reviewed the original PR? -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Updated] (KAFKA-13253) Kafka Connect losing task (re)configuration when connector name has special characters

2021-08-30 Thread David Dufour (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Dufour updated KAFKA-13253: - Description: When not leader, DistributedHerder.reconfigureConnector() forwards the task config

[jira] [Updated] (KAFKA-13253) Kafka Connect losing task (re)configuration when connector name has special characters

2021-08-30 Thread David Dufour (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Dufour updated KAFKA-13253: - Description: When not leader, DistributedHerder.reconfigureConnector() forwards the task config

[jira] [Updated] (KAFKA-13253) Kafka Connect losing task (re)configuration when connector name has special characters

2021-08-30 Thread David Dufour (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Dufour updated KAFKA-13253: - Description: When not leader, DistributedHerder.reconfigureConnector() forwards the task config

[jira] [Updated] (KAFKA-13253) Kafka Connect losing task (re)configuration when connector name has special characters

2021-08-30 Thread David Dufour (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Dufour updated KAFKA-13253: - Description: When not leader, DistributedHerder.reconfigureConnector() forwards the task config

[jira] [Created] (KAFKA-13253) Kafka Connect losing task (re)configuration when connector name has special characters

2021-08-30 Thread David Dufour (Jira)
David Dufour created KAFKA-13253: Summary: Kafka Connect losing task (re)configuration when connector name has special characters Key: KAFKA-13253 URL: https://issues.apache.org/jira/browse/KAFKA-13253

[jira] [Closed] (KAFKA-13252) ISR shrink to an error broker

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos closed KAFKA-13252. - duplicated > ISR shrink to an error broker > - > > Key: KAFKA-13252 >

[jira] [Closed] (KAFKA-13250) 2.4.0

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos closed KAFKA-13250. - duplicated > 2.4.0 > - > > Key: KAFKA-13250 > URL: https://issues.apache.org/ji

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-30 Thread GitBox
vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-908275012 @showuon , is there an existing integration test for Metered classes? I tried to find one to add the relevant tests but couldnt't find one.. -- This is an automated messa

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-30 Thread GitBox
vamossagar12 commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r698417779 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -217,6 +230,24 @@ public V fetch(final K

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-30 Thread GitBox
vamossagar12 commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r698416259 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PersistentSessionStore.java ## @@ -0,0 +1,28 @@ +/* + * Licensed to the

[jira] [Resolved] (KAFKA-13250) 2.4.0

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos resolved KAFKA-13250. --- Resolution: Duplicate > 2.4.0 > - > > Key: KAFKA-13250 > URL: https://is

[jira] [Resolved] (KAFKA-13252) ISR shrink to an error broker

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos resolved KAFKA-13252. --- Resolution: Duplicate > ISR shrink to an error broker > - > > Ke

[jira] [Updated] (KAFKA-13251) ISR shrink to an error broker

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos updated KAFKA-13251: -- Summary: ISR shrink to an error broker (was: 2.4.0) > ISR shrink to an error broker > ---

[jira] [Created] (KAFKA-13252) ISR shrink to an error broker

2021-08-30 Thread chaos (Jira)
chaos created KAFKA-13252: - Summary: ISR shrink to an error broker Key: KAFKA-13252 URL: https://issues.apache.org/jira/browse/KAFKA-13252 Project: Kafka Issue Type: Bug Reporter: chaos

[jira] [Updated] (KAFKA-13251) 2.4.0

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos updated KAFKA-13251: -- Description: Disk error occurred in broker(=42),and then Shrinking ISR to itself. so why Shrinking ISR to an

[jira] [Updated] (KAFKA-13251) 2.4.0

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos updated KAFKA-13251: -- Component/s: core > 2.4.0 > - > > Key: KAFKA-13251 > URL: https://issues.a

[jira] [Updated] (KAFKA-13251) 2.4.0

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos updated KAFKA-13251: -- Description: Disk error occurred in broker(=42),and then Shrinking ISR to itself. so why Shrinking ISR to an

[jira] [Updated] (KAFKA-13251) 2.4.0

2021-08-30 Thread chaos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaos updated KAFKA-13251: -- Description: Disk error occurred in broker(=42),and then Shrinking ISR, why Shrinking ISR to error broker ?

[GitHub] [kafka] cadonna commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-30 Thread GitBox
cadonna commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r698327147 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -178,12 +184,48 @@ public void resetProducer(

[jira] [Created] (KAFKA-13251) 2.4.0

2021-08-30 Thread chaos (Jira)
chaos created KAFKA-13251: - Summary: 2.4.0 Key: KAFKA-13251 URL: https://issues.apache.org/jira/browse/KAFKA-13251 Project: Kafka Issue Type: Bug Affects Versions: 2.4.0 Environment: lin

[jira] [Created] (KAFKA-13250) 2.4.0

2021-08-30 Thread chaos (Jira)
chaos created KAFKA-13250: - Summary: 2.4.0 Key: KAFKA-13250 URL: https://issues.apache.org/jira/browse/KAFKA-13250 Project: Kafka Issue Type: Bug Affects Versions: 2.4.0 Environment: lin

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-30 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-908160013 @cadonna Applied your feedback as well, thanks for the comments. I also realized the `AtomicBoolean` variables in the test could be final and added that as well. -- This is an

[GitHub] [kafka] wangxianghu closed pull request #11210: KAFKA-13199: Make Task extends Versioned

2021-08-30 Thread GitBox
wangxianghu closed pull request #11210: URL: https://github.com/apache/kafka/pull/11210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsub

[GitHub] [kafka] cadonna commented on a change in pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-30 Thread GitBox
cadonna commented on a change in pull request #11228: URL: https://github.com/apache/kafka/pull/11228#discussion_r698280849 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -495,9 +498,23 @@ private void replaceStreamThread(final Throwable t

[GitHub] [kafka] jlprat commented on a change in pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-30 Thread GitBox
jlprat commented on a change in pull request #11228: URL: https://github.com/apache/kafka/pull/11228#discussion_r698268258 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -509,7 +526,7 @@ private void handleStreamsUncaughtException(final Thr

[jira] [Commented] (KAFKA-12963) Improve error message for Class cast exception

2021-08-30 Thread Rasmus Helbig Hansen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406600#comment-17406600 ] Rasmus Helbig Hansen commented on KAFKA-12963: -- [~ableegoldman] first of al