[jira] [Created] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
Alagukannan created KAFKA-13257: --- Summary: KafkaStreams Support For Latest RocksDB Version Key: KAFKA-13257 URL: https://issues.apache.org/jira/browse/KAFKA-13257 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alagukannan updated KAFKA-13257: Description: Hi, Can you please let us know if there is any plan for adding the latest versions

[jira] [Updated] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alagukannan updated KAFKA-13257: Attachment: hs_err_pid6.log Description: Hi, Can you please let us know if there is any plan

[jira] [Updated] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alagukannan updated KAFKA-13257: Description: Hi, Can you please let us know if there is any plan for adding the latest versions

[jira] [Commented] (KAFKA-8334) Occasional OffsetCommit Timeout

2021-09-01 Thread chenchao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407907#comment-17407907 ] chenchao commented on KAFKA-8334: - Excuse me, this problem also occurs in my online envir

[jira] [Commented] (KAFKA-10208) org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.OffsetFetchResponseHandler return null when Broker unexpectedly doesn't support requireStable flag on v

2021-09-01 Thread chenchao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407913#comment-17407913 ] chenchao commented on KAFKA-10208: --  should format your code > org.apache.kafka.client

[GitHub] [kafka] showuon commented on a change in pull request #11272: KAFKA-12648: introduce TopologyConfig and TaskConfig for topology-level overrides

2021-09-01 Thread GitBox
showuon commented on a change in pull request #11272: URL: https://github.com/apache/kafka/pull/11272#discussion_r699942903 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -0,0 +1,176 @@ +/* + * Licensed

[jira] [Updated] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alagukannan updated KAFKA-13257: Attachment: (was: hs_err_pid6.log) > KafkaStreams Support For Latest RocksDB Version > ---

[jira] [Updated] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alagukannan updated KAFKA-13257: Attachment: hs_err_pid6.log > KafkaStreams Support For Latest RocksDB Version > --

[GitHub] [kafka] mimaison opened a new pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison opened a new pull request #11288: URL: https://github.com/apache/kafka/pull/11288 AlterClientQuotas, DescribeProducers and FindCoordinator have issues when building error responses. This can lead to brokers returning responses without errors even when some have happened. ##

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-09-01 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910048239 Ping @cadonna and @guozhangwang Is there anything else you'd like changed in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] mimaison commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910053809 This affects 2.8.0 too so part of this PR will need to be backported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
dajac commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910057197 @mimaison Is it a regression? It would be good to file a bug for it in order to have a trace about it. I was about to cut a RC for 2.8.1 but I'll wait on this one. -- This is a

[GitHub] [kafka] mimaison commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910060115 Yes it's partly a regression: - AlterClientQuotas worked correctlyup to 2.7.0 and is broken since 2.8.0. - FindCoordinator worked correctly up to 2.8.0 and is broken since

[GitHub] [kafka] mimaison edited a comment on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison edited a comment on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910060115 Yes it's partly a regression: - AlterClientQuotas worked correctly up to 2.7.0 and is broken since 2.8.0. - FindCoordinator worked correctly up to 2.8.0 and is broke

[jira] [Created] (KAFKA-13258) AlterClientQuotas response does not include an error when it failed

2021-09-01 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-13258: -- Summary: AlterClientQuotas response does not include an error when it failed Key: KAFKA-13258 URL: https://issues.apache.org/jira/browse/KAFKA-13258 Project: Kafk

[jira] [Created] (KAFKA-13259) DescribeProducers response does not include an error when it failed

2021-09-01 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-13259: -- Summary: DescribeProducers response does not include an error when it failed Key: KAFKA-13259 URL: https://issues.apache.org/jira/browse/KAFKA-13259 Project: Kafk

[jira] [Created] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

2021-09-01 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-13260: -- Summary: FindCoordinator errorCounts does not handle v4 Key: KAFKA-13260 URL: https://issues.apache.org/jira/browse/KAFKA-13260 Project: Kafka Issue Type

[GitHub] [kafka] mimaison commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910086728 I opened: - https://issues.apache.org/jira/browse/KAFKA-13258 - https://issues.apache.org/jira/browse/KAFKA-13259 - https://issues.apache.org/jira/browse/KAFKA-13260

[GitHub] [kafka] junrao commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-09-01 Thread GitBox
junrao commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r699482697 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -574,14 +577,17 @@ private[log] class Cleaner(val id: Int, val abortedTransacti

[jira] [Commented] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

2021-09-01 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408003#comment-17408003 ] David Jacot commented on KAFKA-13260: - [~mimaison] Do this one affect 3.0 as well?

[jira] [Commented] (KAFKA-13258) AlterClientQuotas response does not include an error when it failed

2021-09-01 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408011#comment-17408011 ] David Jacot commented on KAFKA-13258: - It seems that this one has been introduced by

[GitHub] [kafka] mimaison commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910053809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r699777919 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] dajac commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
dajac commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910057197 @mimaison Is it a regression? It would be good to file a bug for it in order to have a trace about it. I was about to cut a RC for 2.8.1 but I'll wait on this one. -- This is a

[jira] [Updated] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

2021-09-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13260: --- Affects Version/s: 3.0.0 > FindCoordinator errorCounts does not handle v4 >

[jira] [Commented] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

2021-09-01 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408018#comment-17408018 ] Mickael Maison commented on KAFKA-13260: Yes, I've tagged it correctly. Thanks

[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely

2021-09-01 Thread GitBox
dadufour commented on pull request #11174: URL: https://github.com/apache/kafka/pull/11174#issuecomment-909121030 Any chance to have it in a 2.7.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-09-01 Thread GitBox
viktorsomogyi edited a comment on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037718 @mimaison would you please review this or suggest someone who can do it? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-09-01 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r699714060 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -156,13 +162,13 @@ public void ensureValid() { }

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-09-01 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910048239 Ping @cadonna and @guozhangwang Is there anything else you'd like changed in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] mimaison edited a comment on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison edited a comment on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910060115 Yes it's partly a regression: - AlterClientQuotas worked correctly up to 2.7.0 and is broken since 2.8.0. - FindCoordinator worked correctly up to 2.8.0 and is broke

[GitHub] [kafka] guozhangwang merged pull request #11286: add units to metrics descriptions + test fix

2021-09-01 Thread GitBox
guozhangwang merged pull request #11286: URL: https://github.com/apache/kafka/pull/11286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] showuon commented on a change in pull request #11272: KAFKA-12648: introduce TopologyConfig and TaskConfig for topology-level overrides

2021-09-01 Thread GitBox
showuon commented on a change in pull request #11272: URL: https://github.com/apache/kafka/pull/11272#discussion_r699942903 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] [kafka] viktorsomogyi commented on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-09-01 Thread GitBox
viktorsomogyi commented on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] junrao commented on pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

2021-09-01 Thread GitBox
junrao commented on pull request #10463: URL: https://github.com/apache/kafka/pull/10463#issuecomment-909609953 @dielhennr : Thanks. Since trunk has changed quite a bit, it would be useful to pull all the changes into this PR and rebase before reviewing it again. -- This is an automated

[GitHub] [kafka] dajac commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
dajac commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910101460 Thanks. I wonder if we should consider them as blockers for 3.0. KAFKA-13258 is clearly a regression introduced in 2.8 and KAFKA-13260 could be quite bad as well. What do you thin

[GitHub] [kafka] mimaison commented on pull request #11288: MINOR: Fix error response generation

2021-09-01 Thread GitBox
mimaison commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-910126913 KAFKA-13260 is a regression in 3.0. However, I'm not sure if it actually has any impact. Looking at all callers of `errorCounts()`, it looks like it's mostly used to check for

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2021-09-01 Thread yale (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408133#comment-17408133 ] yale commented on KAFKA-9366: - May I kindly ask about the plan to upgrade log4j to version 2.

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2021-09-01 Thread yale (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408133#comment-17408133 ] yale edited comment on KAFKA-9366 at 9/1/21, 12:11 PM: --- May I kindl

[jira] [Updated] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Alagukannan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alagukannan updated KAFKA-13257: Description: Hi, Can you please let us know if there is any plan for adding the latest versions

[GitHub] [kafka] mdedetrich commented on pull request #10839: KAFKA-12913: Make case class's final

2021-09-01 Thread GitBox
mdedetrich commented on pull request #10839: URL: https://github.com/apache/kafka/pull/10839#issuecomment-910295551 I have just rebased the PR so there should be no conflicts, also removed the unnecessary migration changes in `upgrade.html` -- This is an automated message from the Apache

[jira] [Created] (KAFKA-13261) KTable to KTable foreign key join does not produce output when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
Tomas Forsman created KAFKA-13261: - Summary: KTable to KTable foreign key join does not produce output when using several partitions Key: KAFKA-13261 URL: https://issues.apache.org/jira/browse/KAFKA-13261

[jira] [Updated] (KAFKA-13261) KTable to KTable foreign key join does not produce output when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Forsman updated KAFKA-13261: -- Description: Two incoming streams A and B.  Stream A uses a composite key [a, b] Stream B ha

[jira] [Updated] (KAFKA-13261) KTable to KTable foreign key join does not produce output when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Forsman updated KAFKA-13261: -- Description: Two incoming streams A and B.  Stream A uses a composite key [a, b] Stream B ha

[jira] [Updated] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Forsman updated KAFKA-13261: -- Description: Two incoming streams A and B.  Stream A uses a composite key [a, b] Stream B ha

[jira] [Updated] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Forsman updated KAFKA-13261: -- Summary: KTable to KTable foreign key join loose events when using several partitions (was: K

[jira] [Updated] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Forsman updated KAFKA-13261: -- Description: Two incoming streams A and B.  Stream A uses a composite key [a, b] Stream B ha

[GitHub] [kafka] mdedetrich edited a comment on pull request #10839: KAFKA-12913: Make case class's final

2021-09-01 Thread GitBox
mdedetrich edited a comment on pull request #10839: URL: https://github.com/apache/kafka/pull/10839#issuecomment-910295551 I have just rebased the PR so there should be no conflicts, also removed the unnecessary migration changes in `upgrade.html` @mjsax @ijuma The PR is ready for re

[jira] [Updated] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Forsman updated KAFKA-13261: -- Description: Two incoming streams A and B.  Stream A uses a composite key [a, b] Stream B ha

[GitHub] [kafka] fabian-wiesman commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-09-01 Thread GitBox
fabian-wiesman commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910378434 Aiven Inc - https://aiven.io/ is misusing of Apache Kafka trademark as 'Aiven Kafka' [1] and violates Apache trademarks. See - [1] https://help.aiven.io/en/?q=%22aiven+

[GitHub] [kafka] hachikuji commented on pull request #11267: KAFKA-13234; Transaction system test should clear URPs after broker restarts

2021-09-01 Thread GitBox
hachikuji commented on pull request #11267: URL: https://github.com/apache/kafka/pull/11267#issuecomment-910402729 @ijuma @showuon Thanks for reviews. I've reverted the changes to the upgrade/downgrade tests so that I can move them to a separate PR. I was seeing some compatibility issues w

[GitHub] [kafka] hachikuji merged pull request #11267: KAFKA-13234; Transaction system test should clear URPs after broker restarts

2021-09-01 Thread GitBox
hachikuji merged pull request #11267: URL: https://github.com/apache/kafka/pull/11267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-13234) Transaction system tests should check URPs between broker bounces

2021-09-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13234. - Resolution: Fixed > Transaction system tests should check URPs between broker bounces >

[GitHub] [kafka] guozhangwang merged pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-09-01 Thread GitBox
guozhangwang merged pull request #11228: URL: https://github.com/apache/kafka/pull/11228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] guozhangwang commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-09-01 Thread GitBox
guozhangwang commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910473712 Merged to trunk, thanks @jlprat ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408280#comment-17408280 ] Guozhang Wang commented on KAFKA-13257: --- Hello [~kannan94], in the next release 3.

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-09-01 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910482302 Thanks for the reviews @guozhangwang and @cadonna ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] guozhangwang merged pull request #11226: KAFKA-13175; Optimization TopicExistsException,When a topic is marked…

2021-09-01 Thread GitBox
guozhangwang merged pull request #11226: URL: https://github.com/apache/kafka/pull/11226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Resolved] (KAFKA-13175) The topic is marked for deletion, create topic with the same name throw exception topic already exists.

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13175. --- Fix Version/s: 3.1.0 Resolution: Fixed > The topic is marked for deletion, create top

[jira] [Commented] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Satyam Bala (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408291#comment-17408291 ] Satyam Bala commented on KAFKA-13257: - Hello [~guozhang],  thanks for your response.

[GitHub] [kafka] hachikuji opened a new pull request #11289: KAFKA-13254 [WIP]: Fix deadlock when AlterIsr response returns

2021-09-01 Thread GitBox
hachikuji opened a new pull request #11289: URL: https://github.com/apache/kafka/pull/11289 This patch fixes a deadlock when incrementing the high watermark after the synchronous zk ISR modification happens. The main difference is that we prevent the callback from executing while under the

[jira] [Commented] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408294#comment-17408294 ] Guozhang Wang commented on KAFKA-13261: --- Thanks for reporting this [~xnix]. I've

[jira] [Commented] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408295#comment-17408295 ] Guozhang Wang commented on KAFKA-13257: --- Currently the RC is under voting. You can

[jira] [Resolved] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13257. --- Resolution: Not A Problem > KafkaStreams Support For Latest RocksDB Version > --

[GitHub] [kafka] guozhangwang commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-09-01 Thread GitBox
guozhangwang commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-910510701 Tests failed on compilation due to checkstyle warnings: ``` [2021-08-28T18:29:04.088Z] > Task :streams:streams-scala:compileTestScala [2021-08-28T18:29:04.08

[GitHub] [kafka] rhauch commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910510910 First of all, thanks for trying to fix this issue, @C0urante. And thanks for your insight, @hachikuji. I agree that it seems like we should not have to block the offset com

[jira] [Commented] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408303#comment-17408303 ] Adam Bellemare commented on KAFKA-13261: Hi [~xnix]. We'll need some more inform

[GitHub] [kafka] rhauch edited a comment on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch edited a comment on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910510910 First of all, thanks for trying to fix this issue, @C0urante. And thanks for your insight, @hachikuji. I agree that it seems like we should not have to block the off

[jira] [Comment Edited] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-01 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408303#comment-17408303 ] Adam Bellemare edited comment on KAFKA-13261 at 9/1/21, 6:05 PM: -

[GitHub] [kafka] rhauch commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910540773 My previous suggestion simply dequeues all completed records until an unacked record is found. This is really straightforward, but we could try to do better. We could dequ

[GitHub] [kafka] rhauch edited a comment on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch edited a comment on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910540773 My previous suggestion simply dequeues all completed records until an unacked record is found. This is really straightforward, but we could try to do better. We cou

[GitHub] [kafka] rhauch commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910557464 Also, with my proposed approach, the `offsetWriter` is only used (directly or indirectly) within the `commitOffsets()` method. That means we could actually do without the `synchr

[GitHub] [kafka] rhauch edited a comment on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch edited a comment on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910540773 My previous suggestion simply dequeues all completed records until an unacked record is found. This is really straightforward, but we could try to do better. We cou

[jira] [Created] (KAFKA-13262) Mock Clients Now Have Final close() Methods

2021-09-01 Thread Gary Russell (Jira)
Gary Russell created KAFKA-13262: Summary: Mock Clients Now Have Final close() Methods Key: KAFKA-13262 URL: https://issues.apache.org/jira/browse/KAFKA-13262 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-13262) Mock Clients Now Have Final close() Methods

2021-09-01 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Russell updated KAFKA-13262: - Description: Subclasses can no longer clean up resources when the consumer or producer is close

[jira] [Updated] (KAFKA-13262) Mock Clients Now Have Final close() Methods

2021-09-01 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Russell updated KAFKA-13262: - Description: Subclasses can no longer clean up resources when the consumer is closed. Caused by

[GitHub] [kafka] ijuma commented on pull request #11226: KAFKA-13175; Optimization TopicExistsException,When a topic is marked…

2021-09-01 Thread GitBox
ijuma commented on pull request #11226: URL: https://github.com/apache/kafka/pull/11226#issuecomment-910564657 Generally, we should include test(s) for changes like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] rhauch edited a comment on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-09-01 Thread GitBox
rhauch edited a comment on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910540773 My previous suggestion simply dequeues all completed records until an unacked record is found. This is really straightforward, but we could try to do better. We cou

[GitHub] [kafka] guozhangwang commented on a change in pull request #11272: KAFKA-12648: introduce TopologyConfig and TaskConfig for topology-level overrides

2021-09-01 Thread GitBox
guozhangwang commented on a change in pull request #11272: URL: https://github.com/apache/kafka/pull/11272#discussion_r700479414 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -611,6 +611,7 @@ public synchronized Topology build() {

[GitHub] [kafka] dielhennr opened a new pull request #11290: MINOR: Expose 0 for controller metrics in KRaft if the controller is a standby controller.

2021-09-01 Thread GitBox
dielhennr opened a new pull request #11290: URL: https://github.com/apache/kafka/pull/11290 Expose 0 on standby controllers for controller metrics so that the sum of a metric collected from all nodes in a cluster is equal to the current value of the metric. -- This is an automated messa

[jira] [Created] (KAFKA-13263) TimeoutException when calling initializeTransactions() in a healthy cluster, persisting until a broker was restarted

2021-09-01 Thread Donny Nadolny (Jira)
Donny Nadolny created KAFKA-13263: - Summary: TimeoutException when calling initializeTransactions() in a healthy cluster, persisting until a broker was restarted Key: KAFKA-13263 URL: https://issues.apache.org/jir

[jira] [Updated] (KAFKA-13263) TimeoutException when calling initializeTransactions() in a healthy cluster, persisting until a broker was restarted

2021-09-01 Thread Donny Nadolny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donny Nadolny updated KAFKA-13263: -- Description: Summary: - we had multiple transactional kafka clients (different Apache Flink

[jira] [Commented] (KAFKA-10360) Disabling JmxReporter registration

2021-09-01 Thread Oleksii Ignachuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408398#comment-17408398 ] Oleksii Ignachuk commented on KAFKA-10360: -- This one is pretty tricky when you

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-09-01 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r700607209 ## File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala ## @@ -732,6 +730,79 @@ class ControllerApisTest { controllerApis.cr

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-09-01 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r700614819 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -856,21 +867,24 @@ ApiError electLeader(String to

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-09-01 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r700620002 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -804,7 +817,7 @@ void handleBrokerUnfenced(int br

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-09-01 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r700614819 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -856,21 +867,24 @@ ApiError electLeader(String to

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r700643818 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r700644408 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[jira] [Commented] (KAFKA-13245) KIP 771: Change behavior of how controller metrics are exposed when using KRaft.

2021-09-01 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408435#comment-17408435 ] Ryan Dielhenn commented on KAFKA-13245: --- https://github.com/apache/kafka/pull/1129

[jira] [Updated] (KAFKA-13245) KIP 771: Change behavior of how controller metrics are exposed when using KRaft.

2021-09-01 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13245: -- Description: Pre-Kraft brokers expose 0 for controller metrics in the case of controller fail

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r700656961 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r700657822 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-09-01 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r700658878 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -562,12 +569,12 @@ class LogCleanerTest { // Both the batch and the m

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r700660131 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-09-01 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r700661885 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-09-01 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r700663048 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java ## @@ -483,6 +499,53 @@ public void testBuildEndTxnMarker()

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-09-01 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r700664177 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java ## @@ -37,6 +40,7 @@ import java.util.Arrays; import java

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-09-01 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r700684311 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -500,14 +500,15 @@ private[log] class Cleaner(val id: Int, case None => 0L

  1   2   >