ijuma commented on pull request #11295:
URL: https://github.com/apache/kafka/pull/11295#issuecomment-913389764
@omkreddy if you have cycles, this is a 3.0 blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ijuma commented on pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#issuecomment-913379778
And we have a green build. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
satishd commented on pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#issuecomment-913321617
@junrao gentle reminder to review the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
satishd commented on pull request #11033:
URL: https://github.com/apache/kafka/pull/11033#issuecomment-913321448
Thanks @junrao for your comment. Addressed the review comment with the
latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
satishd commented on a change in pull request #11033:
URL: https://github.com/apache/kafka/pull/11033#discussion_r702548933
##
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java
##
@@ -62,16 +63,17 @@
* @param re
jasonyanwenl commented on pull request #11297:
URL: https://github.com/apache/kafka/pull/11297#issuecomment-913314815
Hi @guozhangwang, I saw you are assigned as the reviewer of the ticket
[KAFKA-10038](https://issues.apache.org/jira/browse/KAFKA-10038), please help
take a look at this PR
[
https://issues.apache.org/jira/browse/KAFKA-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410351#comment-17410351
]
Yanwen Lin commented on KAFKA-5666:
---
Hi [~yevabyzek], [~apurva], is this still an issue
ijuma commented on a change in pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#discussion_r702529338
##
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##
@@ -2799,4 +2779,11 @@ public void testObserverFetchWithNoLocalId() throw
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410283#comment-17410283
]
Dongjin Lee commented on KAFKA-9366:
ALL // Sorry for being late. This KIP was origin
lbradstreet opened a new pull request #11298:
URL: https://github.com/apache/kafka/pull/11298
Some minor typos that have annoyed me along with a fix to a docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lbradstreet commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r702508503
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -198,8 +199,23 @@ private[log] class LogCleanerManager(val logDirs:
Seq[Fil
lbradstreet commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r702503828
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -198,13 +204,28 @@ private[log] class LogCleanerManager(val logDirs:
Seq[Fi
lbradstreet commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r702503726
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -163,17 +168,18 @@ private[log] class LogCleanerManager(val logDirs:
Seq[Fi
[
https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410256#comment-17410256
]
Tomas Forsman commented on KAFKA-13261:
---
I've added a test that seem to verify a p
gunnarmorling commented on a change in pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#discussion_r702474291
##
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##
@@ -2799,4 +2779,11 @@ public void testObserverFetchWithNoLocalId
ijuma commented on pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#issuecomment-913214595
@chia7712 @omkreddy Any of you have the cycles to review this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ijuma edited a comment on pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#issuecomment-913214267
Build 6 (including Java 16) passed:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11296/6/
I will now remove Java 16 from Jenkinsfile.
--
This is an a
ijuma commented on pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#issuecomment-913214267
Build #6 passed:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11296/6/
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
[
https://issues.apache.org/jira/browse/KAFKA-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13275:
Description:
We added several `--add-opens` to make a number of tests pass with Java 17 (via
KAFK
[
https://issues.apache.org/jira/browse/KAFKA-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13275:
Description:
We added several `--add-opens` to make a number of tests pass with Java 17 (via
KAFK
Ismael Juma created KAFKA-13275:
---
Summary: Remove --add-opens from build.gradle (where possible)
Key: KAFKA-13275
URL: https://issues.apache.org/jira/browse/KAFKA-13275
Project: Kafka
Issue Typ
[
https://issues.apache.org/jira/browse/KAFKA-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13273:
Comment: was deleted
(was: PR: https://github.com/apache/kafka/pull/11296)
> Add support for Java
Ismael Juma created KAFKA-13274:
---
Summary: Ensure system tests run successfully with Java 17
Key: KAFKA-13274
URL: https://issues.apache.org/jira/browse/KAFKA-13274
Project: Kafka
Issue Type: I
ijuma commented on a change in pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#discussion_r702460031
##
File path: build.gradle
##
@@ -37,7 +37,7 @@ plugins {
id 'org.owasp.dependencycheck' version '6.1.6'
id 'org.nosphere.apache.rat' version "0.7.0"
ijuma commented on a change in pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#discussion_r702450561
##
File path: build.gradle
##
@@ -37,7 +37,7 @@ plugins {
id 'org.owasp.dependencycheck' version '6.1.6'
id 'org.nosphere.apache.rat' version "0.7.0"
ijuma commented on a change in pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#discussion_r702450437
##
File path: gradle/wrapper/gradle-wrapper.properties
##
@@ -1,6 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionSh
[
https://issues.apache.org/jira/browse/KAFKA-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13273:
Description:
Java 17 is at release candidate stage and it will be a LTS release once
it's out (pre
Ismael Juma created KAFKA-13273:
---
Summary: Add support for Java 17
Key: KAFKA-13273
URL: https://issues.apache.org/jira/browse/KAFKA-13273
Project: Kafka
Issue Type: Improvement
Rep
[
https://issues.apache.org/jira/browse/KAFKA-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410206#comment-17410206
]
Ismael Juma commented on KAFKA-13273:
-
PR: https://github.com/apache/kafka/pull/1129
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r702422832
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/CommittedOffsetsFile.java
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/KAFKA-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao reassigned KAFKA-9886:
--
Assignee: HaiyuanZhao
> Validate segment range before reading in `Log.read`
>
31 matches
Mail list logo
