ijuma commented on pull request #11308:
URL: https://github.com/apache/kafka/pull/11308#issuecomment-914931279
@rajinisivaram Please cherry-pick to 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
showuon commented on pull request #11218:
URL: https://github.com/apache/kafka/pull/11218#issuecomment-914911904
Failed tests are unrelated. Thanks.
```
Build / JDK 11 and Scala 2.13 /
kafka.server.DynamicBrokerConfigTest.testPasswordConfigEncoderSecretChange()
```
--
This is an
satishd commented on a change in pull request #11033:
URL: https://github.com/apache/kafka/pull/11033#discussion_r704021954
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -129,37 +132,44 @@
satishd commented on a change in pull request #11033:
URL: https://github.com/apache/kafka/pull/11033#discussion_r704021729
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -129,37 +132,44 @@
[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411675#comment-17411675
]
Yanwen Lin commented on KAFKA-10038:
Sure, thanks for your super fast reply. Let's w
[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411674#comment-17411674
]
Guozhang Wang commented on KAFKA-10038:
---
Yeah that should happen.. let's wait for
[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411669#comment-17411669
]
Yanwen Lin commented on KAFKA-10038:
Hey [~guozhang], per this wiki:
[https://cwiki
[
https://issues.apache.org/jira/browse/KAFKA-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411666#comment-17411666
]
Matthias J. Sax commented on KAFKA-13267:
-
[~guozhang] [~hachikuji] – Given the
[
https://issues.apache.org/jira/browse/KAFKA-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13267:
Component/s: streams
> InvalidPidMappingException: The producer attempted to use a produce
ableegoldman merged pull request #11214:
URL: https://github.com/apache/kafka/pull/11214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
[
https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411644#comment-17411644
]
A. Sophie Blee-Goldman commented on KAFKA-12963:
{quote}I can imagine th
ableegoldman commented on a change in pull request #11218:
URL: https://github.com/apache/kafka/pull/11218#discussion_r703978721
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
##
@@ -48,6 +53,16 @@
public class ConsumerConfig extends
ableegoldman commented on a change in pull request #11278:
URL: https://github.com/apache/kafka/pull/11278#discussion_r703973474
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java
##
@@ -84,13 +85,34 @@ public synchronized void resize
[
https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411631#comment-17411631
]
S. B. Hunter commented on KAFKA-13248:
--
No. Go right ahead. Thank you for your hand
showuon commented on a change in pull request #11218:
URL: https://github.com/apache/kafka/pull/11218#discussion_r703970666
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
##
@@ -48,6 +53,16 @@
public class ConsumerConfig extends Abst
[
https://issues.apache.org/jira/browse/KAFKA-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411619#comment-17411619
]
A. Sophie Blee-Goldman commented on KAFKA-13268:
What's the name of that
guozhangwang commented on pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#issuecomment-914789772
Thanks for the POC @showuon ! I made a pass and here are some high-level
thoughts:
1) On the PAPI layer, users today can only add stores via
Topology#addStateStore i
ableegoldman commented on a change in pull request #11283:
URL: https://github.com/apache/kafka/pull/11283#discussion_r703953000
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -565,7 +565,7 @@ public void closeCleanAndRec
[
https://issues.apache.org/jira/browse/KAFKA-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411606#comment-17411606
]
A. Sophie Blee-Goldman commented on KAFKA-13269:
Hey [~rohitbobade], tha
ableegoldman commented on a change in pull request #11292:
URL: https://github.com/apache/kafka/pull/11292#discussion_r703945833
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/WindowStoreFetchIntegrationTest.java
##
@@ -0,0 +1,229 @@
+/*
+ * Licensed
hachikuji commented on a change in pull request #11294:
URL: https://github.com/apache/kafka/pull/11294#discussion_r703942630
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -3242,6 +3260,92 @@ class ReplicaManagerTest {
}
}
+ @Test
ableegoldman commented on a change in pull request #11218:
URL: https://github.com/apache/kafka/pull/11218#discussion_r703933946
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
##
@@ -48,6 +53,16 @@
public class ConsumerConfig extends
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411592#comment-17411592
]
Matthias J. Sax commented on KAFKA-10493:
-
Agreed. The original API only had `bu
[
https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411582#comment-17411582
]
Matthias J. Sax commented on KAFKA-13256:
-
[~rk3rn3r] Thanks for reporting this
vvcephei merged pull request #11213:
URL: https://github.com/apache/kafka/pull/11213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
vvcephei commented on pull request #11213:
URL: https://github.com/apache/kafka/pull/11213#issuecomment-914663785
Java 17 errored out:
```
[2021-09-07T21:03:23.475Z] * What went wrong:
[2021-09-07T21:03:23.475Z] Execution failed for task ':core:integrationTest'.
[2021
dejan2609 commented on pull request #10967:
URL: https://github.com/apache/kafka/pull/10967#issuecomment-914653605
Adding a comment (just to bring this PR to the surface).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
C0urante edited a comment on pull request #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-914640232
Hey Gunnar! Sorry for the delay.
> Initializing a Struct with a builder rather than a Schema seems to be an
odd thing to do, no?
Indeed it is rather odd, bu
C0urante commented on pull request #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-914640232
Hey Gunnar! Sorry for the delay.
> Initializing a Struct with a builder rather than a Schema seems to be an
odd thing to do, no?
Indeed it is rather odd, but it's
guozhangwang commented on pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#issuecomment-914624644
Okay, let me re-trigger the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guozhangwang commented on a change in pull request #11302:
URL: https://github.com/apache/kafka/pull/11302#discussion_r703822498
##
File path: docs/upgrade.html
##
@@ -22,9 +22,12 @@
Notable changes in
3.1.0
Apache Kafka supports Java 17.
+The following metrics hav
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411480#comment-17411480
]
Ashish Patil commented on KAFKA-9366:
-
Thanks, [~dongjin]
> Upgrade log4j to log4j2
guozhangwang merged pull request #11304:
URL: https://github.com/apache/kafka/pull/11304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang merged pull request #11297:
URL: https://github.com/apache/kafka/pull/11297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang commented on pull request #11297:
URL: https://github.com/apache/kafka/pull/11297#issuecomment-914619982
Thanks @jasonyanwenl , the PR lgtm, and thank you also for adding the unit
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message,
junrao commented on a change in pull request #11033:
URL: https://github.com/apache/kafka/pull/11033#discussion_r703798708
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -129,37 +132,44 @@ p
ccding edited a comment on pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#issuecomment-914613398
It failed here
https://github.com/apache/kafka/blob/9d107c174bfb23e5ce0daca9a59796f018f627c6/core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala#L43
ccding commented on pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#issuecomment-914613398
It failed here
https://github.com/apache/kafka/blob/9d107c174bfb23e5ce0daca9a59796f018f627c6/core[…]t/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala
```
Expec
cmccabe merged pull request #11308:
URL: https://github.com/apache/kafka/pull/11308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
ijuma commented on pull request #11307:
URL: https://github.com/apache/kafka/pull/11307#issuecomment-914552427
Merged to master and cherry-picked to 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ijuma merged pull request #11307:
URL: https://github.com/apache/kafka/pull/11307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
ijuma commented on pull request #11307:
URL: https://github.com/apache/kafka/pull/11307#issuecomment-914551974
Unrelated test failures:
> Build / JDK 17 and Scala 2.13 /
org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldPrefixAllInternalTopicNamesWithNamedTopolo
rhauch commented on pull request #10112:
URL: https://github.com/apache/kafka/pull/10112#issuecomment-914547745
@C0urante, thanks for the feedback on my suggestion. I like your option 3,
because it does allow the iteration to stop on each source partition as soon as
it encounters the first
jeqo commented on a change in pull request #11213:
URL: https://github.com/apache/kafka/pull/11213#discussion_r703713785
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java
##
@@ -198,7 +201,7 @@ private
jeqo commented on a change in pull request #11213:
URL: https://github.com/apache/kafka/pull/11213#discussion_r703713785
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java
##
@@ -198,7 +201,7 @@ private
spena commented on a change in pull request #11252:
URL: https://github.com/apache/kafka/pull/11252#discussion_r703675892
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedTimestampedKeyAndJoinSideSerializerTest.java
##
@@ -24,49 +24,49 @@
[
https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411347#comment-17411347
]
Guozhang Wang commented on KAFKA-13248:
---
[~sider-bughunter] Thanks for the find. I
rajinisivaram opened a new pull request #11308:
URL: https://github.com/apache/kafka/pull/11308
Size calculation for tagged fields is currently incorrect and works only for
small strings. This results in BufferOverflowException when serializing
requests with large strings in tagged fields.
ijuma commented on pull request #11300:
URL: https://github.com/apache/kafka/pull/11300#issuecomment-914446506
@mimaison I synced with @kkonstantine and he said he's ok with this being
merged to 3.0. He will update the release thread soon, but let's get this in
when we're ready to avoid de
[
https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13258:
Priority: Blocker (was: Major)
> AlterClientQuotas response does not include an error when it fai
[
https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13258:
Affects Version/s: (was: 3.0.0)
> AlterClientQuotas response does not include an error when it
[
https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13258:
Fix Version/s: 2.8.1
> AlterClientQuotas response does not include an error when it failed
> -
[
https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13258:
Fix Version/s: 3.0.0
> AlterClientQuotas response does not include an error when it failed
> -
[
https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13259:
Fix Version/s: 2.8.1
> DescribeProducers response does not include an error when it failed
> -
[
https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13259:
Affects Version/s: (was: 3.0.0)
> DescribeProducers response does not include an error when it
[
https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13259:
Fix Version/s: 3.0.0
> DescribeProducers response does not include an error when it failed
> -
[
https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13260:
Priority: Blocker (was: Major)
> FindCoordinator errorCounts does not handle v4
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reassigned KAFKA-13276:
---
Assignee: Tom Bentley
> Public DescribeConsumerGroupsResult constructor refers to KafkaFutu
[
https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13260:
Fix Version/s: 3.0.0
> FindCoordinator errorCounts does not handle v4
> --
[
https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13260:
Affects Version/s: (was: 3.0.0)
> FindCoordinator errorCounts does not handle v4
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13266:
Affects Version/s: (was: 3.0.0)
> `InitialFetchState` should be created after partition is rem
[
https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411315#comment-17411315
]
Ismael Juma commented on KAFKA-13260:
-
3.0.0 hasn't been released yet, so it's a bit
[
https://issues.apache.org/jira/browse/KAFKA-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13266:
Fix Version/s: 3.0.0
> `InitialFetchState` should be created after partition is removed from the
[
https://issues.apache.org/jira/browse/KAFKA-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13266:
Priority: Blocker (was: Critical)
> `InitialFetchState` should be created after partition is remo
[
https://issues.apache.org/jira/browse/KAFKA-13276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13276:
Fix Version/s: 3.0.0
> Public DescribeConsumerGroupsResult constructor refers to KafkaFutureImpl
>
[
https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-13277:
---
Fix Version/s: (was: 3.0.1)
3.0.0
> Serialization of long tagged stri
[
https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-13277:
---
Priority: Blocker (was: Major)
> Serialization of long tagged string in request/response th
[
https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411311#comment-17411311
]
Rajini Sivaram commented on KAFKA-13277:
[~ijuma] Yes, it will be good include i
vvcephei commented on a change in pull request #11213:
URL: https://github.com/apache/kafka/pull/11213#discussion_r703630483
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java
##
@@ -198,7 +201,7 @@ priv
[
https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411309#comment-17411309
]
Ismael Juma commented on KAFKA-13277:
-
[~rsivaram] isn't this a blocker for 3.0?
>
ijuma merged pull request #11303:
URL: https://github.com/apache/kafka/pull/11303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
Rajini Sivaram created KAFKA-13277:
--
Summary: Serialization of long tagged string in request/response
throws BufferOverflowException
Key: KAFKA-13277
URL: https://issues.apache.org/jira/browse/KAFKA-13277
vvcephei commented on a change in pull request #11213:
URL: https://github.com/apache/kafka/pull/11213#discussion_r703627436
##
File path:
streams/src/test/java/org/apache/kafka/test/MockInternalNewProcessorContext.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Softw
vvcephei commented on a change in pull request #11213:
URL: https://github.com/apache/kafka/pull/11213#discussion_r703626660
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java
##
@@ -150,16 +153,16 @@ pu
viktorsomogyi commented on pull request #11276:
URL: https://github.com/apache/kafka/pull/11276#issuecomment-914396172
Rebased the build, it was conflicting with another change that replaced
EasyMock/Powermock with Mockito so I had to change that part of my tests too.
(Ran them locally suc
[
https://issues.apache.org/jira/browse/KAFKA-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat updated KAFKA-13243:
---
Fix Version/s: 3.1.0
> Differentiate metric latency measured in millis and nanos
> -
C0urante commented on pull request #10112:
URL: https://github.com/apache/kafka/pull/10112#issuecomment-914348989
@rhauch Overall that looks good to me. It's an elegant solution to the
tricky problem you noted about the opacity of task-provided source offsets
w/r/t ordering.
I'm a l
ijuma commented on a change in pull request #11307:
URL: https://github.com/apache/kafka/pull/11307#discussion_r703555946
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##
@@ -446,8 +447,8 @@ public synchronized void resume(Collection
dajac commented on a change in pull request #11307:
URL: https://github.com/apache/kafka/pull/11307#discussion_r703548948
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##
@@ -446,8 +447,8 @@ public synchronized void resume(Collection
ijuma opened a new pull request #11307:
URL: https://github.com/apache/kafka/pull/11307
I added the final via 2f3600198722 to catch overriding mistakes
since the implementation was moved from the deprecated and
overloaded `close` with two parameters to the no-arg
`close`.
I d
ijuma opened a new pull request #11306:
URL: https://github.com/apache/kafka/pull/11306
TBD: release notes, etc
Note that checkstyle will be upgraded in a separate PR as it requires
code changes in a large number of files.
### Committer Checklist (excluded from commit messag
[
https://issues.apache.org/jira/browse/KAFKA-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reassigned KAFKA-13262:
---
Assignee: Ismael Juma
> Mock Clients Now Have Final close() Methods
> -
vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703469853
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
cadonna commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703455477
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java
##
@@ -3
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703454226
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java
##
@
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703445767
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java
##
@
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703445686
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java
##
@
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703445569
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java
##
@
patrickstuedi commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703439679
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterat
jlprat commented on pull request #11302:
URL: https://github.com/apache/kafka/pull/11302#issuecomment-914195040
Thanks for your feedback @tombentley . You feel free to review the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cadonna commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703386486
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java
##
@@ -1
jlprat commented on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-914189101
Rebased the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
tombentley commented on a change in pull request #11302:
URL: https://github.com/apache/kafka/pull/11302#discussion_r703359283
##
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##
@@ -1272,12 +1274,27 @@ private Meter createMeter(Metrics metrics,
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r703348241
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -2
apenam opened a new pull request #11305:
URL: https://github.com/apache/kafka/pull/11305
Fix `The input line is too long. The syntax of the command is incorrect`
error when running on a windows environment.
*More detailed description of your change,
if necessary. The PR title and
vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703336198
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703336198
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r70661
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
patrickstuedi commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703312659
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterat
patrickstuedi commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703309462
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterat
1 - 100 of 104 matches
Mail list logo
