[jira] [Comment Edited] (KAFKA-13226) Partition expansion may cause uneven distribution

2021-10-31 Thread shizhenzhen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435380#comment-17435380 ] shizhenzhen edited comment on KAFKA-13226 at 11/1/21, 2:40 AM: --- I hava

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-955804300 Hi, Regarding the failing tests: I think the kafka.admin.LeaderElectionCommandTest might contain flaky tests. They pass locally. See image. Could you trigger a

[GitHub] [kafka] Luizfrf3 edited a comment on pull request #11441: KAFKA-8941: Add RocksDB Metrics that Could not be Added due to RocksD…

2021-10-31 Thread GitBox
Luizfrf3 edited a comment on pull request #11441: URL: https://github.com/apache/kafka/pull/11441#issuecomment-954094430 Hello @cadonna, @ableegoldman and @mjsax. The pull request is ready to be reviewed. Best regards, -- This is an automated message from the Apache Git

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739869555 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739869555 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739869555 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] florin-akermann edited a comment on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann edited a comment on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-955775367 @cmccabe Assuming you have the privileges for it, please could you trigger a build and assign me to the ticket https://issues.apache.org/jira/browse/KAFKA-13351

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-955775367 @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-13351) Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436525#comment-17436525 ] Florin Akermann commented on KAFKA-13351: - Hi, I made a PR for it. However I cannot set the

[GitHub] [kafka] florin-akermann opened a new pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann opened a new pull request #11456: URL: https://github.com/apache/kafka/pull/11456 Adding: --property parse.headers=true to cmdl enabled header parsing. Just like with the ConsoleConsumer, tif headers and/or key enabled then the order is "headers key value". The

[GitHub] [kafka] dongjinleekr commented on pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
dongjinleekr commented on pull request #11431: URL: https://github.com/apache/kafka/pull/11431#issuecomment-955660566 So, We can now organize the issues like the following: 1. Preventing the malfunctioning (i.e., replication of MM2 internal topics) 2. Keeping consistency (as far

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
dongjinleekr commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r73941 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public

[GitHub] [kafka] dongjinleekr commented on pull request #11454: KAFKA-13341: Quotas are not applied to requests with null clientId

2021-10-31 Thread GitBox
dongjinleekr commented on pull request #11454: URL: https://github.com/apache/kafka/pull/11454#issuecomment-955650953 Hi @splett2, It seems like this issue is somewhat overlapped one, like: 1. Null client IDs were being improperly propagated (addressed by #11385.) 2.

[jira] [Updated] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13424: -- Description: In `*TopicDeletionManager.completeDeleteTopic()*`,

[jira] [Updated] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13424: -- Description: In `*TopicDeletionManager.completeDeleteTopic()*`,

[jira] [Updated] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13424: -- Description: In ```TopicDeletionManager.completeDeleteTopic()```,

[jira] [Created] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
Xiaobing Fang created KAFKA-13424: - Summary: Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager Key: KAFKA-13424 URL: https://issues.apache.org/jira/browse/KAFKA-13424

[GitHub] [kafka] dongjinleekr commented on pull request #11430: KAFKA-13352: Kafka Client does not support passwords starting with number in jaas config

2021-10-31 Thread GitBox
dongjinleekr commented on pull request #11430: URL: https://github.com/apache/kafka/pull/11430#issuecomment-955643910 Here is the update. I added some line-by-line comments on what each line does. -- This is an automated message from the Apache Git Service. To respond to the message,