[jira] [Commented] (KAFKA-13299) Accept listeners that have the same port but use IPv4 vs IPv6

2021-11-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439054#comment-17439054 ] Luke Chen commented on KAFKA-13299: --- [~mdedetrich-aiven], thanks for reporting this is

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743370521 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743370708 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,22 +793,23 @@ class ReplicaManagerTest { // We receive on

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743370419 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743369512 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743365481 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -1091,18 +1089,20 @@ class AbstractFetcherThreadTest { ov

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743361897 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2069,10 +2071,10 @@ public void testReturnRecordsDuri

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743360648 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743357376 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743357376 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743355748 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743354926 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +173,35 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743351017 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -1361,102 +1542,113 @@ class FetchSessionTest { val resp4 = context2

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743350813 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -3530,37 +3534,37 @@ class KafkaApisTest { def testSizeOfThrottledPartiti

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743349370 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -4814,6 +4842,7 @@ private void buildDependencies(

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743349235 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -4814,6 +4842,7 @@ private void buildDependencies(

[GitHub] [kafka] RivenSun2 commented on pull request #11461: KAFKA-13422: Add verification of duplicate configuration for each type of LoginModule in JaasConfigFile

2021-11-04 Thread GitBox
RivenSun2 commented on pull request #11461: URL: https://github.com/apache/kafka/pull/11461#issuecomment-961575399 @guozhangwang @ijuma please help check this PR when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743243975 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743243975 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[jira] [Commented] (KAFKA-13375) Kafka streams apps w/EOS unable to start at InitProducerId

2021-11-04 Thread Lerh Chuan Low (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438957#comment-17438957 ] Lerh Chuan Low commented on KAFKA-13375: [~guozhang] Thank you for reading throu

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743243111 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2659,6 +2661,9 @@ private FetchResponse fetchResponse

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743242849 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2069,10 +2071,10 @@ public void testReturnRecordsDuri

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743242346 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743241513 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743241204 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743240526 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743240074 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743239514 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -202,29 +203,30 @@ public void testSessionless() {

[GitHub] [kafka] ijuma commented on pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-11-04 Thread GitBox
ijuma commented on pull request #11429: URL: https://github.com/apache/kafka/pull/11429#issuecomment-961367197 @dajac Makes sense, pushed to trunk, 3.1 and 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac commented on pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-04 Thread GitBox
dajac commented on pull request #11467: URL: https://github.com/apache/kafka/pull/11467#issuecomment-961343975 @showuon Thanks. I will take a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac commented on pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-11-04 Thread GitBox
dajac commented on pull request #11429: URL: https://github.com/apache/kafka/pull/11429#issuecomment-961343546 @ijuma Should we pick this one to the 3.1 branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dajac opened a new pull request #11468: WIP

2021-11-04 Thread GitBox
dajac opened a new pull request #11468: URL: https://github.com/apache/kafka/pull/11468 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] bdesert commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-04 Thread GitBox
bdesert commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r743062367 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java ## @@ -152,6 +155,48 @@ public void testConfigP

[GitHub] [kafka] dajac commented on pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on pull request #11331: URL: https://github.com/apache/kafka/pull/11331#issuecomment-961259072 @jolshan It seems that there are a few compilation errors, at least for `JDK 8 and Scala 2.12`. Could you check? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743046927 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -66,16 +69,28 @@ public PartitionData( int maxByt

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743046003 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743044970 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +173,35 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743044369 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743041695 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743011890 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -1361,102 +1542,113 @@ class FetchSessionTest { val resp4 = context2.u

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-04 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742933244 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDowng

[GitHub] [kafka] ijuma merged pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-11-04 Thread GitBox
ijuma merged pull request #11429: URL: https://github.com/apache/kafka/pull/11429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] showuon commented on pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-11-04 Thread GitBox
showuon commented on pull request #11429: URL: https://github.com/apache/kafka/pull/11429#issuecomment-960951629 Yes, cherry-pick back to v3.0.1, too, please. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-11-04 Thread GitBox
ijuma commented on pull request #11429: URL: https://github.com/apache/kafka/pull/11429#issuecomment-960945328 @showuon we should have this in 3.0.1 too, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-04 Thread GitBox
showuon commented on pull request #11467: URL: https://github.com/apache/kafka/pull/11467#issuecomment-960867632 @dajac , please help review this java doc update, and I think this fix should put into V3.1.0. WDYT? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] showuon commented on a change in pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-04 Thread GitBox
showuon commented on a change in pull request #11467: URL: https://github.com/apache/kafka/pull/11467#discussion_r742808430 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -100,8 +100,6 @@ * {@code * Properties props = new Pro

[GitHub] [kafka] showuon commented on a change in pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-04 Thread GitBox
showuon commented on a change in pull request #11467: URL: https://github.com/apache/kafka/pull/11467#discussion_r742808430 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -100,8 +100,6 @@ * {@code * Properties props = new Pro

[GitHub] [kafka] showuon commented on a change in pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-04 Thread GitBox
showuon commented on a change in pull request #11467: URL: https://github.com/apache/kafka/pull/11467#discussion_r742807104 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -117,14 +115,15 @@ * as well as a background I/O thread

[GitHub] [kafka] showuon opened a new pull request #11467: MINOR: fix java doc in kafkaProducer

2021-11-04 Thread GitBox
showuon opened a new pull request #11467: URL: https://github.com/apache/kafka/pull/11467 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] Gerrrr commented on pull request #11447: KAFKA-13024: Use not-null filter only in optimizable repartitions

2021-11-04 Thread GitBox
Ge commented on pull request #11447: URL: https://github.com/apache/kafka/pull/11447#issuecomment-960765623 Thanks for the review! I agree that solving this issue by removing the not-null optimization completely is very much suboptimal. 8f176cb reverts the first commit. 7c6e97f introdu

[jira] [Comment Edited] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438556#comment-17438556 ] Aiden Gong edited comment on KAFKA-13433 at 11/4/21, 9:38 AM:

[GitHub] [kafka] mimaison commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-04 Thread GitBox
mimaison commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r742653123 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java ## @@ -152,6 +155,48 @@ public void testConfig

[jira] [Commented] (KAFKA-12487) Sink connectors do not work with the cooperative consumer rebalance protocol

2021-11-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438579#comment-17438579 ] David Jacot commented on KAFKA-12487: - Hi [~kkonstantine]. My understanding of the i

[GitHub] [kafka] showuon commented on pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-11-04 Thread GitBox
showuon commented on pull request #11429: URL: https://github.com/apache/kafka/pull/11429#issuecomment-960575313 @ijuma , please help check it when available. This is a regression issue, so I think we should put it v3.1.0. Thank you. -- This is an automated message from the Apache Git Se

[jira] [Resolved] (KAFKA-13430) Remove broker-wide quota properties from the documentation

2021-11-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13430. - Fix Version/s: 3.0.0 3.1.0 Reviewer: David Jacot Resolution: F

[jira] [Commented] (KAFKA-13430) Remove broker-wide quota properties from the documentation

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438574#comment-17438574 ] ASF GitHub Bot commented on KAFKA-13430: dajac merged pull request #380: URL: ht

[jira] [Commented] (KAFKA-13351) Add possibility to write kafka headers in Kafka Console Producer

2021-11-04 Thread Seweryn Habdank-Wojewodzki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438573#comment-17438573 ] Seweryn Habdank-Wojewodzki commented on KAFKA-13351: Thanks a lot!

[GitHub] [kafka] dajac commented on pull request #11463: KAFKA-13430: Remove broker-wide quota properties from the documentation

2021-11-04 Thread GitBox
dajac commented on pull request #11463: URL: https://github.com/apache/kafka/pull/11463#issuecomment-960571438 Merged to trunk and 3.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] dajac merged pull request #11463: KAFKA-13430: Remove broker-wide quota properties from the documentation

2021-11-04 Thread GitBox
dajac merged pull request #11463: URL: https://github.com/apache/kafka/pull/11463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Updated] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong updated KAFKA-13433: --- Labels: connect (was: connect-api) > JsonConverter's method convertToJson when field is optional wi

[jira] [Updated] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong updated KAFKA-13433: --- Labels: connect-api (was: ) > JsonConverter's method convertToJson when field is optional with defa

[jira] [Updated] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong updated KAFKA-13433: --- Priority: Major (was: Minor) > JsonConverter's method convertToJson when field is optional with def

[jira] [Updated] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong updated KAFKA-13433: --- Priority: Minor (was: Blocker) > JsonConverter's method convertToJson when field is optional with d

[jira] [Commented] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438556#comment-17438556 ] Aiden Gong commented on KAFKA-13433: Class org.apache.kafka.connect.json.JsonConvert

[jira] [Commented] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438553#comment-17438553 ] Aiden Gong commented on KAFKA-13433: I will submit  a pr to fix this issue. Please a

[jira] [Updated] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong updated KAFKA-13433: --- Description: JsonConverter's method convertToJson when field is optional with default value and valu

[jira] [Updated] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong updated KAFKA-13433: --- Description: JsonConverter's method convertToJson when field is optional with default value and valu

[jira] [Created] (KAFKA-13433) JsonConverter's method convertToJson when field is optional with default value and value is null, return default value.

2021-11-04 Thread Aiden Gong (Jira)
Aiden Gong created KAFKA-13433: -- Summary: JsonConverter's method convertToJson when field is optional with default value and value is null, return default value. Key: KAFKA-13433 URL: https://issues.apache.org/jira/

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

2021-11-04 Thread GitBox
RivenSun2 commented on a change in pull request #11460: URL: https://github.com/apache/kafka/pull/11460#discussion_r742601310 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -326,6 +330,10 @@ private Exception invo

[GitHub] [kafka] RivenSun2 commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-11-04 Thread GitBox
RivenSun2 commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-960522880 @guozhangwang @showuon Thanks for your helpful review. I just commit a new change If you have time, please browse it. -- This is an automated message from the A

[GitHub] [kafka] showuon commented on a change in pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

2021-11-04 Thread GitBox
showuon commented on a change in pull request #11460: URL: https://github.com/apache/kafka/pull/11460#discussion_r742596144 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -326,6 +330,10 @@ private Exception invoke

[GitHub] [kafka] RivenSun2 commented on pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

2021-11-04 Thread GitBox
RivenSun2 commented on pull request #11460: URL: https://github.com/apache/kafka/pull/11460#issuecomment-960521298 @showuon Thanks for your review I just commited a new change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

2021-11-04 Thread GitBox
RivenSun2 commented on a change in pull request #11460: URL: https://github.com/apache/kafka/pull/11460#discussion_r742589702 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -307,6 +307,10 @@ private Exception invo

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

2021-11-04 Thread GitBox
RivenSun2 commented on a change in pull request #11460: URL: https://github.com/apache/kafka/pull/11460#discussion_r742589553 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -2007,7 +2007,7 @@ public OffsetAndMetadata committed(To

[GitHub] [kafka] showuon commented on a change in pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

2021-11-04 Thread GitBox
showuon commented on a change in pull request #11460: URL: https://github.com/apache/kafka/pull/11460#discussion_r742575556 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -2007,7 +2007,7 @@ public OffsetAndMetadata committed(Topi