[GitHub] [kafka] dengziming commented on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-12-04 Thread GitBox
dengziming commented on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-986161398 Thank you for your comments @soarez , PTAL again. ping @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dengziming commented on a change in pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-12-04 Thread GitBox
dengziming commented on a change in pull request #9577: URL: https://github.com/apache/kafka/pull/9577#discussion_r762506268 ## File path: core/src/main/scala/kafka/server/LogDirEventManagerImpl.scala ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] dengziming commented on a change in pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-12-04 Thread GitBox
dengziming commented on a change in pull request #9577: URL: https://github.com/apache/kafka/pull/9577#discussion_r762506030 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -313,6 +315,21 @@ class KafkaServer( } alterIsrManager.start()

[GitHub] [kafka] dengziming commented on a change in pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-12-04 Thread GitBox
dengziming commented on a change in pull request #9577: URL: https://github.com/apache/kafka/pull/9577#discussion_r762506014 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3276,6 +3277,23 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[jira] [Assigned] (KAFKA-13499) Avoid restoring outdated records

2021-12-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13499: - Assignee: Sagar Rao > Avoid restoring outdated records > > >

[jira] [Assigned] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

2021-12-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13501: - Assignee: Sagar Rao > Avoid state restore via rebalance if standbys are enabled > -

[GitHub] [kafka] florin-akermann commented on a change in pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-04 Thread GitBox
florin-akermann commented on a change in pull request #11456: URL: https://github.com/apache/kafka/pull/11456#discussion_r762369085 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -274,28 +296,74 @@ object ConsoleProducer { parseKey = props.ge

[GitHub] [kafka] florin-akermann commented on a change in pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-04 Thread GitBox
florin-akermann commented on a change in pull request #11456: URL: https://github.com/apache/kafka/pull/11456#discussion_r762368709 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -274,28 +296,74 @@ object ConsoleProducer { parseKey = props.ge