[GitHub] [kafka] ableegoldman opened a new pull request #11601: KAFKA-12648: Minor fixes for input topic management

2021-12-13 Thread GitBox
ableegoldman opened a new pull request #11601: URL: https://github.com/apache/kafka/pull/11601 While working on [#11600](https://github.com/apache/kafka/pull/11600) I noticed a few issues with how we manage topics in the TopologyMetadata, particularly surrounding the code to update and tra

[jira] [Commented] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

2021-12-13 Thread Kashish Bansal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458927#comment-17458927 ] Kashish Bansal commented on KAFKA-13077: [~junrao] We faced the same issue while

[GitHub] [kafka] ableegoldman opened a new pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

2021-12-13 Thread GitBox
ableegoldman opened a new pull request #11600: URL: https://github.com/apache/kafka/pull/11600 Another source of flakiness we found in the NamedTopologyIntegrationTest was an ocasional MissingSourceTopicException that was causing the application to shut down. We created all source topics a

[jira] [Commented] (KAFKA-13543) Consumer may pass stale cluster metadata to the assignor following a subscription update

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458923#comment-17458923 ] A. Sophie Blee-Goldman commented on KAFKA-13543: One possible fix would

[jira] [Created] (KAFKA-13543) Consumer may pass stale cluster metadata to the assignor following a subscription update

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13543: -- Summary: Consumer may pass stale cluster metadata to the assignor following a subscription update Key: KAFKA-13543 URL: https://issues.apache.org/jira/browse/K

[jira] [Commented] (KAFKA-13281) Support live upgrades with dynamic addition/removal of modular topologies

2021-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458847#comment-17458847 ] Luke Chen commented on KAFKA-13281: --- Thanks! [~ableegoldman] ! :) > Support live upgr

[jira] [Created] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13542: -- Summary: Utilize the new Consumer#enforceRebalance(reason) API in Streams Key: KAFKA-13542 URL: https://issues.apache.org/jira/browse/KAFKA-13542

[jira] [Updated] (KAFKA-13281) Support live upgrades with dynamic addition/removal of modular topologies

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13281: --- Summary: Support live upgrades with dynamic addition/removal of modular topo

[jira] [Updated] (KAFKA-13282) Draft final NamedTopology API and publish a KIP

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13282: --- Description: The pre-KIP experimental phase has left quite a few open questi

[jira] [Commented] (KAFKA-13281) Support upgrades with dynamic addition/removal of disjoint "named" topologies

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458831#comment-17458831 ] A. Sophie Blee-Goldman commented on KAFKA-13281: Sorry, I'm super behind

[GitHub] [kafka] vvcephei commented on pull request #11598: feat: Implement range and scan queries

2021-12-13 Thread GitBox
vvcephei commented on pull request #11598: URL: https://github.com/apache/kafka/pull/11598#issuecomment-992981391 Oh, one other thing I just noticed, @vpapavas , can you add JavaDoc explaining what the RangeQuery is for and what each one of its methods does? That's a public API, so it shou

[GitHub] [kafka] vvcephei commented on a change in pull request #11598: feat: Implement range and scan queries

2021-12-13 Thread GitBox
vvcephei commented on a change in pull request #11598: URL: https://github.com/apache/kafka/pull/11598#discussion_r768122088 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java ## @@ -175,6 +194,7 @@ public synchronized void

[jira] [Commented] (KAFKA-13476) Streams crashes when non Base64 Offset Metadata is found

2021-12-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458730#comment-17458730 ] Guozhang Wang commented on KAFKA-13476: --- Thanks [~RBosch81], that clears my questi

[GitHub] [kafka] vvcephei commented on pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

2021-12-13 Thread GitBox
vvcephei commented on pull request #11582: URL: https://github.com/apache/kafka/pull/11582#issuecomment-992922162 Note to reviewers, upon reflection, and based on the discussions on the other ongoing KIPs to add IQv2 queries, I've decided to drop the "RawKeyQuery" that I had originally pro

[jira] [Resolved] (KAFKA-13540) UniformStickyPartitioner leads to uneven Kafka partitions

2021-12-13 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Livshits resolved KAFKA-13540. Resolution: Duplicate See also https://cwiki.apache.org/confluence/display/KAFKA/KIP-794%

[GitHub] [kafka] mimaison opened a new pull request #11599: KAFKA-13527: Add top-level error code field to DescribeLogDirsResponse

2021-12-13 Thread GitBox
mimaison opened a new pull request #11599: URL: https://github.com/apache/kafka/pull/11599 Implements KIP-784 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documen

[jira] [Updated] (KAFKA-13511) Update TimestampConverter SMT to support unix epoch as millis, micros, and seconds

2021-12-13 Thread Julien Chanaud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Chanaud updated KAFKA-13511: --- Labels: connect-transformation needs-kip (was: ) > Update TimestampConverter SMT to support

[jira] [Assigned] (KAFKA-13511) Update TimestampConverter SMT to support unix epoch as millis, micros, and seconds

2021-12-13 Thread Julien Chanaud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Chanaud reassigned KAFKA-13511: -- Assignee: Julien Chanaud > Update TimestampConverter SMT to support unix epoch as mil

[GitHub] [kafka] vpapavas opened a new pull request #11598: feat: Implement range and scan queries

2021-12-13 Thread GitBox
vpapavas opened a new pull request #11598: URL: https://github.com/apache/kafka/pull/11598 Implement the RangeQuery as proposed in KIP-805 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build statu

[GitHub] [kafka] jsancio commented on pull request #11593: KAFKA-13528: KRaft RegisterBroker should validate that the cluster ID matches

2021-12-13 Thread GitBox
jsancio commented on pull request #11593: URL: https://github.com/apache/kafka/pull/11593#issuecomment-992715953 Thanks for the reply @cmccabe . Should we add an integration that shows the expected behavior on the broker side? Can we add a description to the PR so that it is i

[GitHub] [kafka] AndyGee commented on a change in pull request #11426: KAFKA-13391: don't fsync directory on Windows OS

2021-12-13 Thread GitBox
AndyGee commented on a change in pull request #11426: URL: https://github.com/apache/kafka/pull/11426#discussion_r767968720 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -948,10 +948,12 @@ public static void atomicMoveWithFallback(Path sourc

[GitHub] [kafka] satishd commented on pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-13 Thread GitBox
satishd commented on pull request #11390: URL: https://github.com/apache/kafka/pull/11390#issuecomment-992617350 Thanks @junrao for the review. Please find inline replies, addressed most of them with latest commits. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

2021-12-13 Thread GitBox
vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r767856835 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -79,6 +88,14 @@ private StreamsMetrics

[GitHub] [kafka] prat0318 commented on pull request #11552: KAFKA-13488: Producer fails to recover if topic gets deleted midway

2021-12-13 Thread GitBox
prat0318 commented on pull request #11552: URL: https://github.com/apache/kafka/pull/11552#issuecomment-992560873 @hachikuji @jolshan Bump on the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] svudutala-vmware edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-12-13 Thread GitBox
svudutala-vmware edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-992556542 > > > Will this PR solve [CVE-2021-44228](https://github.com/advisories/GHSA-jfh8-c2jp-5v3q)? > > > > > > @soumiksamanta > > https://github.com/apach

[GitHub] [kafka] svudutala-vmware commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-12-13 Thread GitBox
svudutala-vmware commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-992556542 > > > Will this PR solve [CVE-2021-44228](https://github.com/advisories/GHSA-jfh8-c2jp-5v3q)? > > > > > > @soumiksamanta > > https://github.com/apache/kafka

[jira] [Commented] (KAFKA-13535) Workaround for mitigating CVE-2021-44228 Kafka

2021-12-13 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458384#comment-17458384 ] Akansh Shandilya commented on KAFKA-13535: -- [~showuon] Thanks , will wait as pe

[jira] [Updated] (KAFKA-13540) UniformStickyPartitioner leads to uneven Kafka partitions

2021-12-13 Thread nk2242696 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nk2242696 updated KAFKA-13540: -- Reviewer: (was: nk2242696) > UniformStickyPartitioner leads to uneven Kafka partitions > ---

[jira] [Updated] (KAFKA-13540) UniformStickyPartitioner leads to uneven Kafka partitions

2021-12-13 Thread nk2242696 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nk2242696 updated KAFKA-13540: -- Reviewer: nk2242696 > UniformStickyPartitioner leads to uneven Kafka partitions >

[jira] [Created] (KAFKA-13541) Make IQv2 query/store interface type safe

2021-12-13 Thread Patrick Stuedi (Jira)
Patrick Stuedi created KAFKA-13541: -- Summary: Make IQv2 query/store interface type safe Key: KAFKA-13541 URL: https://issues.apache.org/jira/browse/KAFKA-13541 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-13540) UniformStickyPartitioner leads to uneven Kafka partitions

2021-12-13 Thread nk2242696 (Jira)
nk2242696 created KAFKA-13540: - Summary: UniformStickyPartitioner leads to uneven Kafka partitions Key: KAFKA-13540 URL: https://issues.apache.org/jira/browse/KAFKA-13540 Project: Kafka Issue Typ

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-13 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767698400 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -715,6 +725,58 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] rajinisivaram opened a new pull request #11597: KAFKA-13539: Improve propagation and processing of SSL handshake failures

2021-12-13 Thread GitBox
rajinisivaram opened a new pull request #11597: URL: https://github.com/apache/kafka/pull/11597 When server fails SSL handshake and closes its connection, we attempt to report this to clients on a best-effort basis. When IOException is detected in the client, we may proceed to close the co

[jira] [Created] (KAFKA-13539) Improve propagation and processing of SSL handshake failures

2021-12-13 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-13539: -- Summary: Improve propagation and processing of SSL handshake failures Key: KAFKA-13539 URL: https://issues.apache.org/jira/browse/KAFKA-13539 Project: Kafka

[GitHub] [kafka] richard-axual commented on pull request #11535: KAFKA-13476: Increase resilience timestamp decoding Kafka Streams

2021-12-13 Thread GitBox
richard-axual commented on pull request #11535: URL: https://github.com/apache/kafka/pull/11535#issuecomment-992330136 @mjsax Thanks for the heads-up. I was on vacation for a while, but I've replied to your question in the Jira issue -- This is an automated message from the Apache Git Se

[jira] [Commented] (KAFKA-10888) Sticky partition leads to uneven product msg, resulting in abnormal delays in some partitions

2021-12-13 Thread nk2242696 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458258#comment-17458258 ] nk2242696 commented on KAFKA-10888: --- [~showuon] [~hachikuji]  I propose a solution ba

[jira] [Commented] (KAFKA-13476) Streams crashes when non Base64 Offset Metadata is found

2021-12-13 Thread Richard Bosch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458255#comment-17458255 ] Richard Bosch commented on KAFKA-13476: --- Hello [~mjsax] [~guozhang] , This is trig

[GitHub] [kafka] mimaison commented on pull request #11560: KAFKA-7589: Allow configuring network threads per listener

2021-12-13 Thread GitBox
mimaison commented on pull request #11560: URL: https://github.com/apache/kafka/pull/11560#issuecomment-992306969 @rajinisivaram @tombentley @dajac This PR is now ready for reviews. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2021-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458219#comment-17458219 ] Luke Chen commented on KAFKA-9366: -- Please upgrade to Log4j to 2.15.0 or newer for CVE-2

[GitHub] [kafka] dengziming commented on pull request #11261: KAFKA-13228: ApiVersionRequest is not properly handled in KRaft

2021-12-13 Thread GitBox
dengziming commented on pull request #11261: URL: https://github.com/apache/kafka/pull/11261#issuecomment-992240783 Hello @mumrah , are you interested in reviewing this? currently, APiVersionRequest is not properly handled in KRaft server and will have a bad effect on KIP-778. -- This i

[GitHub] [kafka] dengziming commented on pull request #11261: KAFKA-13228: ApiVersionRequest is not properly handled in KRaft

2021-12-13 Thread GitBox
dengziming commented on pull request #11261: URL: https://github.com/apache/kafka/pull/11261#issuecomment-992240131 Hello @mumrah , are you interested in reviewing this, currently, APiVersionRequest is not properly handled in KRaft server and will have a bad effect on KIP-778. -- This i

[jira] [Commented] (KAFKA-13535) Workaround for mitigating CVE-2021-44228 Kafka

2021-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458213#comment-17458213 ] Luke Chen commented on KAFKA-13535: --- [~akansh] , I think if users don't add jms append