vpapavas commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789494220
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java
##
@@ -72,7 +74,9 @@
private volatile boolea
vpapavas commented on pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#issuecomment-1018340913
Hey @patrickstuedi ! Great job! There seems to be one main comment: We had
discussed that only the leaf stores (RocksDB*) would be the ones that
checkpoint, no other stores wh
vpapavas commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789502603
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -333,6 +339,43 @@ public static boolean isPermit
vpapavas commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789503072
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -333,6 +339,43 @@ public static boolean isPermit
vpapavas commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789512396
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licensed to
vpapavas commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789512396
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licensed to
vpapavas commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789521565
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,796 @@
+/*
+ * Licensed to
ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r789559604
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -113,7 +113,7 @@ public StreamsMeta
ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r789559815
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -296,9 +316,10 @@ private boolean h
ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r789560559
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -428,7 +469,7 @@ private void rebui
ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r789561043
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -324,6 +345,45 @@ private void rebu
ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r789561299
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -324,6 +345,45 @@ private void rebu
ableegoldman commented on pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#issuecomment-1018402412
Hey @guozhangwang , thanks for the initial review and sorry for the delay,
I've been sitting on this PR while I worked on the tests but should have pushed
the non-testing
Stanislav Savulchik created KAFKA-13606:
---
Summary: MirrorCheckpointTask doesn't check offsets sync result
Key: KAFKA-13606
URL: https://issues.apache.org/jira/browse/KAFKA-13606
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Savulchik updated KAFKA-13606:
Description:
{{MirrorCheckpointTask}} doesn't check the result of calling
{{Admin
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789623730
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licens
Ge commented on pull request #11447:
URL: https://github.com/apache/kafka/pull/11447#issuecomment-1018475901
@suhas-satish Good idea! I'll take some time next week to rebase and provide
proper description.
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r789633567
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -97,49 +101,74 @@ public boolean setup() {
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789667469
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480081#comment-17480081
]
Bruno Cadonna commented on KAFKA-13600:
---
[~tim.patterson] I checked the assignor c
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1018535614
The latest commit (be3dcff4dc463fd8d23998537e36f852b99ec083) has a few
changes.
1. There's explicit fallback to fallback to `DefaultStandbyTaskAssignor`
logic if rac
Piotr Smolinski created KAFKA-13607:
---
Summary: Cannot use PEM certificate coding when parent defined
file-based
Key: KAFKA-13607
URL: https://issues.apache.org/jira/browse/KAFKA-13607
Project: Kafka
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r789687365
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,229
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r789687883
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,248
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789710920
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -85,8 +85,23 @@
* @throws IllegalStateExce
[
https://issues.apache.org/jira/browse/KAFKA-13325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480141#comment-17480141
]
Michal Toth commented on KAFKA-13325:
-
I think this Jira is fixed on 3.2.0 (current
Vicky Papavasileiou created KAFKA-13608:
---
Summary: Implement Position restoration for all in-memory state
stores
Key: KAFKA-13608
URL: https://issues.apache.org/jira/browse/KAFKA-13608
Project:
dajac opened a new pull request #11698:
URL: https://github.com/apache/kafka/pull/11698
Add 3.0.0 and 3.1.0 in various places. I will follow up with other PRs to
update the compatibility tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implemen
[
https://issues.apache.org/jira/browse/KAFKA-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13609:
-
Description:
Currently, we throw InvalidRequestException if the broker configuration fails
vali
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r789777106
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
Colin McCabe created KAFKA-13609:
Summary: Fix the exception type thrown from dynamic broker config
validation
Key: KAFKA-13609
URL: https://issues.apache.org/jira/browse/KAFKA-13609
Project: Kafka
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r789777106
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r789778586
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
Colin McCabe created KAFKA-13610:
Summary: Make log.cleaner.enable dynamically configurable
Key: KAFKA-13610
URL: https://issues.apache.org/jira/browse/KAFKA-13610
Project: Kafka
Issue Type:
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r789786332
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##
@@ -258,6 +270,15 @@ class BrokerMetadataPublisher(conf: KafkaCo
[
https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13610:
-
Description:
It's odd that things like the number of log cleaner threads are configurable,
but
[
https://issues.apache.org/jira/browse/KAFKA-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480165#comment-17480165
]
Kvicii.Yu commented on KAFKA-13583:
---
[~dajac] hi, I followed your advice and tried les
[
https://issues.apache.org/jira/browse/KAFKA-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480165#comment-17480165
]
Kvicii.Yu edited comment on KAFKA-13583 at 1/21/22, 4:23 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kvicii.Yu reassigned KAFKA-13583:
-
Assignee: Kvicii.Yu
> Fix FetchRequestBetweenDifferentIbpTest flaky tests
> ---
bbejeck commented on a change in pull request #11698:
URL: https://github.com/apache/kafka/pull/11698#discussion_r789802968
##
File path: tests/docker/Dockerfile
##
@@ -80,6 +82,8 @@ RUN curl -s "$KAFKA_MIRROR/kafka-streams-2.5.1-test.jar" -o
/opt/kafka-2.5.1/lib
RUN curl -s
Kvicii opened a new pull request #11699:
URL: https://github.com/apache/kafka/pull/11699
Too short polling time leads to not getting the results we want, so I
increase the polling time appropriately.Please tell me can this be done by
optimizing the internal logic.
### Committer Chec
cmccabe opened a new pull request #11700:
URL: https://github.com/apache/kafka/pull/11700
The batch of records that registers a new broker should be committed
atomically. This doesn't matter
right now, because we only create a single record to register the broker.
But if we create multi
dajac commented on pull request #11698:
URL: https://github.com/apache/kafka/pull/11698#issuecomment-1018669565
@bbejeck Thanks. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dajac merged pull request #11666:
URL: https://github.com/apache/kafka/pull/11666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
[
https://issues.apache.org/jira/browse/KAFKA-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13591.
-
Fix Version/s: 3.2.0
3.1.1
Reviewer: Jason Gustafson
Resolutio
dajac merged pull request #11671:
URL: https://github.com/apache/kafka/pull/11671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on pull request #11671:
URL: https://github.com/apache/kafka/pull/11671#issuecomment-1018687301
Merged to trunk, 3.1 and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13388.
-
Fix Version/s: 3.0.1
3.2.0
3.1.1
Reviewer: Rajini
jeqo commented on pull request #11534:
URL: https://github.com/apache/kafka/pull/11534#issuecomment-1018693211
cc @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vamossagar12 commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1018703979
> > hey @guozhangwang , did you get a chance to look at my above comment?
>
> Ah yes, for StreamsConfigs in order for backward compatibility we still
need to referen
vamossagar12 commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1018707721
Thanks for the confirmation @mjsax . I will proceed with the changes. Also,
will create a separate ticket / PR for the issue with caching stores.
--
This is an automate
Aljoscha Pörtner created KAFKA-13611:
Summary: Failed reconfiguration of tasks can cause missing offset
replications in MirrorCheckpointConnector
Key: KAFKA-13611
URL: https://issues.apache.org/jira/browse/KAF
[
https://issues.apache.org/jira/browse/KAFKA-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Pörtner updated KAFKA-13611:
-
Description:
Because the _knownConsumerGroups_ are stored within a variable an not queri
[
https://issues.apache.org/jira/browse/KAFKA-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13412.
-
Fix Version/s: 3.2.0
3.1.1
Resolution: Fixed
> Retry of initTr
guozhangwang commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1018728726
@vamossagar12 seems the jenkins fails still but due to `2 SpotBugs
violations were found` this time.
--
This is an automated message from the Apache Git Service.
To resp
cmccabe merged pull request #11696:
URL: https://github.com/apache/kafka/pull/11696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
cmccabe merged pull request #11700:
URL: https://github.com/apache/kafka/pull/11700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
dajac merged pull request #11698:
URL: https://github.com/apache/kafka/pull/11698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac opened a new pull request #11701:
URL: https://github.com/apache/kafka/pull/11701
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
dajac commented on pull request #11701:
URL: https://github.com/apache/kafka/pull/11701#issuecomment-1018848329
System test:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4758/
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
ableegoldman commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1018932990
@cadonna suggested renaming the metric to `input-buffer-bytes-total`, which
makes sense to me as well
--
This is an automated message from the Apache Git Service.
To res
wcarlson5 commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r790055369
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -1140,6 +1140,11 @@ private void completeShutd
jsancio merged pull request #11657:
URL: https://github.com/apache/kafka/pull/11657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
[
https://issues.apache.org/jira/browse/KAFKA-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-13552:
--
Assignee: Jose Armando Garcia Sancio
> Unable to dynamically
[
https://issues.apache.org/jira/browse/KAFKA-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13552.
Resolution: Fixed
> Unable to dynamically change broker log levels
[
https://issues.apache.org/jira/browse/KAFKA-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-13552:
--
Assignee: Colin McCabe (was: Jose Armando Garcia Sancio)
> U
[
https://issues.apache.org/jira/browse/KAFKA-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13502.
Resolution: Fixed
This issue was fixed by KAFKA-13552.
> Support
[
https://issues.apache.org/jira/browse/KAFKA-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-13609:
--
Assignee: dengziming
> Fix the exception type thrown from dynamic broker config validation
>
[
https://issues.apache.org/jira/browse/KAFKA-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480320#comment-17480320
]
dengziming commented on KAFKA-13609:
Hi [~cmccabe] , I am already doing since I foun
vvcephei opened a new pull request #11702:
URL: https://github.com/apache/kafka/pull/11702
There is a brief window between when the store is registered and when
it is initialized when it might handle a query, but there is no context.
We treat this condition just like a store that hasn'
[
https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13598:
--
Description:
In KAFKA-10619, we enabled idempotence by default. But we didn't update the
config valid
hachikuji commented on a change in pull request #11694:
URL: https://github.com/apache/kafka/pull/11694#discussion_r790091139
##
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##
@@ -82,9 +82,9 @@
* are retained only until either a ne
showuon commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1019019617
@hachikuji @vvcephei , @ijuma , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#issuecomment-1019081971
@dajac @kirktrue, please help review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480363#comment-17480363
]
Luke Chen commented on KAFKA-8541:
--
PR to fix the timeout exception issue:
https://gith
[
https://issues.apache.org/jira/browse/KAFKA-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kvicii.Yu updated KAFKA-12831:
--
Description:
方法
org.apache.kafka.streams.processor.StateStore#init(org.apache.kafka.streams.processor
[
https://issues.apache.org/jira/browse/KAFKA-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kvicii.Yu updated KAFKA-12831:
--
Description:
The method
org.apache.kafka.streams.processor.StateStore#init(org.apache.kafka.streams.p
[
https://issues.apache.org/jira/browse/KAFKA-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480366#comment-17480366
]
Luke Chen commented on KAFKA-13589:
---
The flaky test is because we want to verify the L
78 matches
Mail list logo