[GitHub] [kafka] showuon commented on a change in pull request #11493: KAFKA-12959: Prioritise assigning standby tasks to threads without any active tasks

2022-02-13 Thread GitBox
showuon commented on a change in pull request #11493: URL: https://github.com/apache/kafka/pull/11493#discussion_r805556147 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -997,6 +997,77 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11493: KAFKA-12959: Prioritise assigning standby tasks to threads without any active tasks

2022-02-13 Thread GitBox
showuon commented on a change in pull request #11493: URL: https://github.com/apache/kafka/pull/11493#discussion_r805557480 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -997,6 +997,77 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11493: KAFKA-12959: Prioritise assigning standby tasks to threads without any active tasks

2022-02-13 Thread GitBox
showuon commented on a change in pull request #11493: URL: https://github.com/apache/kafka/pull/11493#discussion_r805534017 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -784,21 +784,33 @@ private void

[GitHub] [kafka] guozhangwang commented on a change in pull request #11705: KAFKA-9847: add config to set default store type

2022-02-13 Thread GitBox
guozhangwang commented on a change in pull request #11705: URL: https://github.com/apache/kafka/pull/11705#discussion_r805466422 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionWindowedCogroupedKStreamImpl.java ## @@ -121,11 +121,20 @@

[GitHub] [kafka] dengziming edited a comment on pull request #11746: MINOR: Use timeout config in KafkaAdminClient

2022-02-13 Thread GitBox
dengziming edited a comment on pull request #11746: URL: https://github.com/apache/kafka/pull/11746#issuecomment-1037750296 Hello @dajac @showuon, I found that we set this to a large enough value in KAFKA-5324 so that we can overwrite per-call timeout with a lager value by

[GitHub] [kafka] showuon commented on pull request #11616: MINOR: update the description in Kraft example properties file

2022-02-13 Thread GitBox
showuon commented on pull request #11616: URL: https://github.com/apache/kafka/pull/11616#issuecomment-1037199304 @hachikuji , thanks for the comments. I've updated the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on a change in pull request #11749: MINOR: Small cleanups in mirror/mirror-client

2022-02-13 Thread GitBox
hachikuji commented on a change in pull request #11749: URL: https://github.com/apache/kafka/pull/11749#discussion_r805194799 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -93,17 +93,17 @@ public MirrorMakerConfig(Map

[GitHub] [kafka] showuon commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-13 Thread GitBox
showuon commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805156641 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/DefaultStandbyTaskAssignor.java ## @@ -0,0 +1,67 @@ +/* + *

[GitHub] [kafka] dengziming commented on pull request #11746: MINOR: Use timeout config in KafkaAdminClient

2022-02-13 Thread GitBox
dengziming commented on pull request #11746: URL: https://github.com/apache/kafka/pull/11746#issuecomment-1037750296 Hello @dajac @showuon, I found that we set this to a large enough value in KAFKA-5324 so that we can overwrite per-call timeout with a lager value by `AbstractOptions`. I

[GitHub] [kafka] hachikuji merged pull request #11603: MINOR: MetadataShell should handle ProducerIdsRecord

2022-02-13 Thread GitBox
hachikuji merged pull request #11603: URL: https://github.com/apache/kafka/pull/11603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-13 Thread GitBox
ijuma commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r805423796 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer

[GitHub] [kafka] cadonna commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-13 Thread GitBox
cadonna commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r805203233 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289 @@

[jira] [Commented] (KAFKA-13615) Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded

2022-02-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491742#comment-17491742 ] Guozhang Wang commented on KAFKA-13615: --- [~timcosta] You mean your brokers are on the MSK right?

[jira] [Commented] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

2022-02-13 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491738#comment-17491738 ] RivenSun commented on KAFKA-13437: -- [~ijuma]  Thank you for your reply I noticed early on that

[GitHub] [kafka] ijuma commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-13 Thread GitBox
ijuma commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r805423796 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer

[jira] [Commented] (KAFKA-13615) Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491703#comment-17491703 ] Ismael Juma commented on KAFKA-13615: - The client version doesn't have to match the broker version.

[GitHub] [kafka] ruanwenjun opened a new pull request #11754: MINOR: Optimize collection method in Utils

2022-02-13 Thread GitBox
ruanwenjun opened a new pull request #11754: URL: https://github.com/apache/kafka/pull/11754 * It's better to initialize collection size when create a collection like set, and the constructor like `HashSet(Collection c)` will calculate the best initialize size, so we don't need to

[jira] [Commented] (KAFKA-13615) Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded

2022-02-13 Thread Tim Costa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491609#comment-17491609 ] Tim Costa commented on KAFKA-13615: --- [~guozhang] we can reliably reproduce this issue, to a point. It

[jira] [Commented] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491550#comment-17491550 ] Ismael Juma commented on KAFKA-13437: - Also see KAFKA-7589. > Broker parameter optimization:

[jira] [Commented] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491549#comment-17491549 ] Ismael Juma commented on KAFKA-9320: [~yzang] Thanks for reporting the issue. Let's move the

[jira] [Commented] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491548#comment-17491548 ] Ismael Juma commented on KAFKA-13418: - [~skokoori] Thanks for the report. Can you please submit a

[jira] [Resolved] (KAFKA-6706) NETWORK_EXCEPTION and REQUEST_TIMED_OUT in mirrormaker producer after 1.0 broker upgrade

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-6706. Fix Version/s: 1.1.1 Resolution: Fixed > NETWORK_EXCEPTION and REQUEST_TIMED_OUT in

[jira] [Resolved] (KAFKA-4231) ZK metadata went inconsistent when migrating 0.10.0.0 -> 0.10.0.1

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-4231. Resolution: Cannot Reproduce > ZK metadata went inconsistent when migrating 0.10.0.0 -> 0.10.0.1 >

[jira] [Resolved] (KAFKA-7304) memory leakage in org.apache.kafka.common.network.Selector

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-7304. Fix Version/s: 2.0.1 Assignee: Rajini Sivaram Resolution: Fixed Marking as fixed

[jira] [Commented] (KAFKA-2561) Optionally support OpenSSL for SSL/TLS

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491540#comment-17491540 ] Ismael Juma commented on KAFKA-2561: Java 16 improved TLS performance further:

[jira] [Resolved] (KAFKA-2561) Optionally support OpenSSL for SSL/TLS

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-2561. Resolution: Won't Do > Optionally support OpenSSL for SSL/TLS >

[jira] [Commented] (KAFKA-13474) Regression in dynamic update of broker certificate

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491538#comment-17491538 ] Ismael Juma commented on KAFKA-13474: - Thanks for the report. We should triage this before the next

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker certificate

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13474: Priority: Critical (was: Blocker) > Regression in dynamic update of broker certificate >

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker certificate

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13474: Fix Version/s: 3.2.0 > Regression in dynamic update of broker certificate >

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker certificate

2022-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13474: Priority: Blocker (was: Major) > Regression in dynamic update of broker certificate >

[GitHub] [kafka] ruanwenjun opened a new pull request #11753: MINOR: Add license header in suppressions.xml

2022-02-13 Thread GitBox
ruanwenjun opened a new pull request #11753: URL: https://github.com/apache/kafka/pull/11753 I find there is no Apache License header in `suppressions.xml`, this pr is adding the license header. ### Committer Checklist (excluded from commit message) - [ ] Verify design and