[GitHub] [kafka] ruanwenjun commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-18 Thread GitBox
ruanwenjun commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r810426220 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer

[GitHub] [kafka] ruanwenjun commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-18 Thread GitBox
ruanwenjun commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r810426220 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-18 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-18 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-18 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void postProcessAndValidateIdem

[GitHub] [kafka] C0urante commented on a change in pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

2022-02-18 Thread GitBox
C0urante commented on a change in pull request #10367: URL: https://github.com/apache/kafka/pull/10367#discussion_r803045306 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -532,23 +531,23 @@ pr

[jira] [Commented] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2022-02-18 Thread shylaja kokoori (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494824#comment-17494824 ] shylaja kokoori commented on KAFKA-13418: - [~ijuma] Thank you. Let me test with

[GitHub] [kafka] splett2 commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-18 Thread GitBox
splett2 commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r810211960 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer e

[GitHub] [kafka] splett2 commented on a change in pull request #11754: MINOR: Optimize collection method in Utils

2022-02-18 Thread GitBox
splett2 commented on a change in pull request #11754: URL: https://github.com/apache/kafka/pull/11754#discussion_r810211960 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer e

[GitHub] [kafka] wcarlson5 commented on pull request #11791: KAFKA-13676: Commit tasks on error if ALOS

2022-02-18 Thread GitBox
wcarlson5 commented on pull request #11791: URL: https://github.com/apache/kafka/pull/11791#issuecomment-1044861346 @guozhangwang @ableegoldman This is ready for a pass when you have a sec -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] wcarlson5 opened a new pull request #11791: KAFKA-13676: Commit tasks on error if ALOS

2022-02-18 Thread GitBox
wcarlson5 opened a new pull request #11791: URL: https://github.com/apache/kafka/pull/11791 When we hit an exception when processing tasks we should save the work we have done so far. This will only be relevant with ALOS, not EOS. It will actually reduce the number of duplicated record

[GitHub] [kafka] jlprat commented on pull request #11432: KAFKA-13399 towards scala3

2022-02-18 Thread GitBox
jlprat commented on pull request #11432: URL: https://github.com/apache/kafka/pull/11432#issuecomment-1044848322 Hi @SethTisue thanks! I definitely will take a look at it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] SethTisue edited a comment on pull request #11432: KAFKA-13399 towards scala3

2022-02-18 Thread GitBox
SethTisue edited a comment on pull request #11432: URL: https://github.com/apache/kafka/pull/11432#issuecomment-1044840351 As an aside: once this lands it would be great to get Kafka in the Scala 3 community build. (Among other reasons, because there is a lot of Java code in Kafka, and the

[GitHub] [kafka] SethTisue commented on pull request #11432: KAFKA-13399 towards scala3

2022-02-18 Thread GitBox
SethTisue commented on pull request #11432: URL: https://github.com/apache/kafka/pull/11432#issuecomment-1044840351 As an aside: once this lands it would be great to get Kafka in the Scala 3 community build. I think VirtusLab hopes to support other build tools besides sbt there eventually,

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r810019916 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,295

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r810019916 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,295

[jira] [Created] (KAFKA-13676) When processing in ALOS we might as well commit progress made other tasks on a task specific exception

2022-02-18 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-13676: -- Summary: When processing in ALOS we might as well commit progress made other tasks on a task specific exception Key: KAFKA-13676 URL: https://issues.apache.org/jira/browse/KAF

[GitHub] [kafka] wcarlson5 closed pull request #10544: KAFKA-12648: minimum changes for error handling namedTopologies

2022-02-18 Thread GitBox
wcarlson5 closed pull request #10544: URL: https://github.com/apache/kafka/pull/10544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] wcarlson5 closed pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to

2022-02-18 Thread GitBox
wcarlson5 closed pull request #10543: URL: https://github.com/apache/kafka/pull/10543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-1044574529 Hi @showuon Thanks for the feedback. I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r810020380 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,295

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r810019916 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,295

[jira] [Resolved] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13666. --- Resolution: Fixed > Tests should not ignore exceptions for supported OS > --

[jira] [Updated] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13666: -- Fix Version/s: 3.2.0 > Tests should not ignore exceptions for supported OS > -

[GitHub] [kafka] cadonna merged pull request #11752: KAFKA-13666 Don't Only ignore test exceptions for windows OS for certain tests.

2022-02-18 Thread GitBox
cadonna merged pull request #11752: URL: https://github.com/apache/kafka/pull/11752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna commented on pull request #11752: KAFKA-13666 Don't Only ignore test exceptions for windows OS for certain tests.

2022-02-18 Thread GitBox
cadonna commented on pull request #11752: URL: https://github.com/apache/kafka/pull/11752#issuecomment-1044551717 Test failures are unrelated and known to be flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-8541) Flakey test LeaderElectionCommandTest#testTopicPartition

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494617#comment-17494617 ] Bruno Cadonna commented on KAFKA-8541: -- Should we open a separate ticket for the Ass

[jira] [Commented] (KAFKA-8541) Flakey test LeaderElectionCommandTest#testTopicPartition

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494616#comment-17494616 ] Bruno Cadonna commented on KAFKA-8541: -- https://ci-builds.apache.org/job/Kafka/job/k

[jira] [Commented] (KAFKA-13672) Flaky test kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494613#comment-17494613 ] Bruno Cadonna commented on KAFKA-13672: --- https://ci-builds.apache.org/job/Kafka/jo

[jira] [Commented] (KAFKA-12511) Flaky test DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494611#comment-17494611 ] Bruno Cadonna commented on KAFKA-12511: --- https://ci-builds.apache.org/job/Kafka/jo

[jira] [Commented] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494610#comment-17494610 ] Bruno Cadonna commented on KAFKA-8391: -- {code:java} java.lang.AssertionError: Tasks

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r810003432 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,295

[GitHub] [kafka] showuon commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
showuon commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r809980650 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignmentUtils.java ## @@ -0,0 +1,54 @@ +/* + * L

[GitHub] [kafka] ruanwenjun commented on a change in pull request #11789: MINOR: Print usage in StorageTool

2022-02-18 Thread GitBox
ruanwenjun commented on a change in pull request #11789: URL: https://github.com/apache/kafka/pull/11789#discussion_r809894308 ## File path: core/src/main/scala/kafka/tools/StorageTool.scala ## @@ -56,6 +55,11 @@ object StorageTool extends Logging { formatParser.addArgum

[GitHub] [kafka] showuon commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-18 Thread GitBox
showuon commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r809773328 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,295 @@ +

[GitHub] [kafka] ableegoldman merged pull request #11738: MINOR: move non-management methods from TaskManager to Task Executor

2022-02-18 Thread GitBox
ableegoldman merged pull request #11738: URL: https://github.com/apache/kafka/pull/11738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman commented on a change in pull request #11738: MINOR: move non-management methods from TaskManager to Task Executor

2022-02-18 Thread GitBox
ableegoldman commented on a change in pull request #11738: URL: https://github.com/apache/kafka/pull/11738#discussion_r809780324 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] ableegoldman commented on pull request #11738: MINOR: move non-management methods from TaskManager to Task Executor

2022-02-18 Thread GitBox
ableegoldman commented on pull request #11738: URL: https://github.com/apache/kafka/pull/11738#issuecomment-1044143849 Test failures are unrelated. Merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the