[GitHub] [kafka] RivenSun2 edited a comment on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

RivenSun2 edited a comment on pull request #11819: URL: https://github.com/apache/kafka/pull/11819#issuecomment-1053975616 Hi @guozhangwang @cmccabe @dajac and @showuon please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] RivenSun2 commented on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

RivenSun2 commented on pull request #11819: URL: https://github.com/apache/kafka/pull/11819#issuecomment-1053975616 Hi @guozhangwang @cmccabe @dajac please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] RivenSun2 opened a new pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

RivenSun2 opened a new pull request #11819: URL: https://github.com/apache/kafka/pull/11819 You can see their `toString` method in all xxx.java in `clients/src/generated/java` directory. For fields of type String, the `toString()` method is still called, which brings an unnecessary

[jira] [Comment Edited] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498734#comment-17498734 ] RivenSun edited comment on KAFKA-13694 at 2/28/22, 7:08 AM: Hi [~guozhang] 

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498734#comment-17498734 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang]  If we simply change to call

[jira] [Comment Edited] (KAFKA-12901) Metadata not updated after broker restart.

[ https://issues.apache.org/jira/browse/KAFKA-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498728#comment-17498728 ] Suriya Vijayaraghavan edited comment on KAFKA-12901 at 2/28/22, 6:26 AM:

[jira] [Commented] (KAFKA-12901) Metadata not updated after broker restart.

[ https://issues.apache.org/jira/browse/KAFKA-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498728#comment-17498728 ] Suriya Vijayaraghavan commented on KAFKA-12901: --- [~junrao]  Can you confirm this issue is

[GitHub] [kafka] vamossagar12 commented on pull request #11796: Kip 770

vamossagar12 commented on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1053825346 @guozhangwang , now i see failures with raft/zk tests. that seems unrelated to this PR. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on a change in pull request #11813: KAFKA-12648: fix #add/removeNamedTopology blocking behavior when app is in CREATED

guozhangwang commented on a change in pull request #11813: URL: https://github.com/apache/kafka/pull/11813#discussion_r815537908 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -100,7

[GitHub] [kafka] tim-patterson commented on a change in pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

tim-patterson commented on a change in pull request #11760: URL: https://github.com/apache/kafka/pull/11760#discussion_r815521489 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -56,25 +54,34 @@ private int

[GitHub] [kafka] emilnkrastev opened a new pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

emilnkrastev opened a new pull request #11818: URL: https://github.com/apache/kafka/pull/11818 This PR addresses the issue described here [KAFKA-12558](https://issues.apache.org/jira/browse/KAFKA-12558). Additionally, The PR also allows to configure the max outstanding syncs in

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1053493098 @showuon sure no worries! let me know whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] vamossagar12 commented on pull request #11796: Kip 770

vamossagar12 commented on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1053492332 @guozhangwang i had done a rebase before pushing and hadn't notice the issue. Not sure what went wrong there(maybe an oversight from me). Anyways i did another rebase

[jira] [Commented] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498563#comment-17498563 ] Sagar Rao commented on KAFKA-13501: --- [~mjsax] , In 12486 idea was to use the

[GitHub] [kafka] showuon commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

showuon commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r815407543 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java ## @@ -53,161 +53,166 @@ RocksDBStore

[GitHub] [kafka] showuon commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

showuon commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r815401329 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -371,43 +372,43 @@ public void