[GitHub] [kafka] showuon commented on a change in pull request #11855: MINOR: bring producer batch.size back

2022-03-12 Thread GitBox
showuon commented on a change in pull request #11855: URL: https://github.com/apache/kafka/pull/11855#discussion_r825266382 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -138,6 +140,12 @@ object ConsoleProducer {

[jira] [Assigned] (KAFKA-13667) add a constraints in listeners in combined mode

2022-03-12 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13667: -- Assignee: dengziming > add a constraints in listeners in combined mode >

[GitHub] [kafka] dengziming commented on pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-12 Thread GitBox
dengziming commented on pull request #11471: URL: https://github.com/apache/kafka/pull/11471#issuecomment-1065868667 Hello @mimaison , can you help to review this PR? thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2022-03-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505290#comment-17505290 ] Ismael Juma commented on KAFKA-13418: - Looks like the property that controls when th

[GitHub] [kafka] peterwanner commented on pull request #11855: MINOR: fix default producer batch.size config

2022-03-12 Thread GitBox
peterwanner commented on pull request #11855: URL: https://github.com/apache/kafka/pull/11855#issuecomment-1065987918 @showuon ok, maybe i mis-understanding what you say in the first comment. Best Thanks for your reminder. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on a change in pull request #11855: MINOR: fix default producer batch.size config

2022-03-12 Thread GitBox
showuon commented on a change in pull request #11855: URL: https://github.com/apache/kafka/pull/11855#discussion_r825377329 ## File path: core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala ## @@ -123,4 +163,37 @@ class ConsoleProducerTest { assertEquals("consol

[GitHub] [kafka] showuon commented on a change in pull request #11855: MINOR: fix default producer batch.size config

2022-03-12 Thread GitBox
showuon commented on a change in pull request #11855: URL: https://github.com/apache/kafka/pull/11855#discussion_r825377329 ## File path: core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala ## @@ -123,4 +163,37 @@ class ConsoleProducerTest { assertEquals("consol

[jira] [Commented] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505386#comment-17505386 ] Guozhang Wang commented on KAFKA-13699: --- I agree with [~mimaison], that we would o

[GitHub] [kafka] guozhangwang commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-12 Thread GitBox
guozhangwang commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1066020270 > I think we need to document that these calls need to be made in the same order with the same topologies for each client. That is what KSQL does to make sure it works