[GitHub] [kafka] showuon commented on pull request #11898: KAFKA-7540: commit offset sync before close

2022-03-20 Thread GitBox
showuon commented on pull request #11898: URL: https://github.com/apache/kafka/pull/11898#issuecomment-1073505938 After re-enabling the `testConsumptionWithBrokerFailures`, it failed again. Looks like it has different root cause as this one. Keep disabling it. -- This is an automated mes

[GitHub] [kafka] showuon commented on pull request #11898: KAFKA-7540: commit offset sync before close

2022-03-20 Thread GitBox
showuon commented on pull request #11898: URL: https://github.com/apache/kafka/pull/11898#issuecomment-1073453573 Thanks @guozhangwang , I think this should also fix the `testConsumptionWithBrokerFailures`. I've removed the disabled flag and see if the test failed. For `testRollingBr

[jira] [Assigned] (KAFKA-13342) LISR sent for topic queued for deletion in controller

2022-03-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13342: - Assignee: Lucas Bradstreet > LISR sent for topic queued for deletion in controller > --

[GitHub] [kafka] showuon commented on a change in pull request #11376: KAFKA-13342: LeaderAndIsrRequest should not be sent for topic queued for deletion

2022-03-20 Thread GitBox
showuon commented on a change in pull request #11376: URL: https://github.com/apache/kafka/pull/11376#discussion_r830724959 ## File path: core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala ## @@ -394,6 +394,22 @@ class ReplicaStateMachineTest { } @

[jira] [Commented] (KAFKA-13672) Race condition in DynamicBrokerConfig

2022-03-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509558#comment-17509558 ] Luke Chen commented on KAFKA-13672: --- Great to hear that! But I'm wondering why this ha

[GitHub] [kafka] XiaoyiPeng commented on pull request #11879: KAFKA-13728: fix PushHttpMetricsReporter no longer pushes metrics when network failure is recovered.

2022-03-20 Thread GitBox
XiaoyiPeng commented on pull request #11879: URL: https://github.com/apache/kafka/pull/11879#issuecomment-1073393200 > Hello @XiaoyiPeng Thanks for the quick fix. > > I read the description and thought about your proposal, and I think it's a reasonable one: for the http reporter it d

[jira] [Commented] (KAFKA-13714) Flaky test IQv2StoreIntegrationTest

2022-03-20 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509543#comment-17509543 ] John Roesler commented on KAFKA-13714: -- Oh, before I forget, here's how I'm getting

[jira] [Commented] (KAFKA-13714) Flaky test IQv2StoreIntegrationTest

2022-03-20 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509541#comment-17509541 ] John Roesler commented on KAFKA-13714: -- Added some more logs, and I think I'm onto

[GitHub] [kafka] msigmond edited a comment on pull request #11888: MINOR: Pass materialized to the inner KTable instance

2022-03-20 Thread GitBox
msigmond edited a comment on pull request #11888: URL: https://github.com/apache/kafka/pull/11888#issuecomment-1073372977 > @msigmond , nice catch! Could we add tests for it? Thanks. @showuon This is done, please review. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] msigmond commented on pull request #11888: MINOR: Pass materialized to the inner KTable instance

2022-03-20 Thread GitBox
msigmond commented on pull request #11888: URL: https://github.com/apache/kafka/pull/11888#issuecomment-1073372977 > @msigmond , nice catch! Could we add tests for it? Thanks. Done, please review. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] LiamClarkeNZ opened a new pull request #11920: [WIP] KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-20 Thread GitBox
LiamClarkeNZ opened a new pull request #11920: URL: https://github.com/apache/kafka/pull/11920 Prevent race condition in DynamicBrokerConfig that can prevent configuration being dynamically applied when broker is running slowly. *This race condition was made visible by an integration

[jira] [Commented] (KAFKA-13739) Sliding window without grace not working

2022-03-20 Thread bounkong khamphousone (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509455#comment-17509455 ] bounkong khamphousone commented on KAFKA-13739: --- Hi, I'll try my best to o

[GitHub] [kafka] RivenSun2 commented on pull request #11919: MINOR: Unify the log output of JaasContext.defaultContext

2022-03-20 Thread GitBox
RivenSun2 commented on pull request #11919: URL: https://github.com/apache/kafka/pull/11919#issuecomment-1073184667 And @dajac @guozhangwang @rajinisivaram This is a minor change. At present, KafkaServer already supports sasl.jaas.config, so the log output here can be unified. What