[
https://issues.apache.org/jira/browse/KAFKA-12380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513797#comment-17513797
]
Rajani Karuturi commented on KAFKA-12380:
-
PR build says test failures
I could not find the
karuturi commented on pull request #11955:
URL: https://github.com/apache/kafka/pull/11955#issuecomment-1081394335
I could not find the exact failed testcases. I can see assertion errors in
StreamsUncaughtExceptionHandlerIntegrationTest. If I run it locally, it's
taking forever.
guozhangwang merged pull request #11958:
URL: https://github.com/apache/kafka/pull/11958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on a change in pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#discussion_r837009747
##
File path: docs/upgrade.html
##
@@ -30,6 +30,7 @@ Notable changes in 3
Users can change this behavior to enable idempotence for some or
showuon commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1081347153
> > @showuon I only found the log4j12 dependencies in the following projects:
>
> > streams:upgrade-system-tests-0100
> > streams:upgrade-system-tests-0101
>
>
lihaosky commented on a change in pull request #11896:
URL: https://github.com/apache/kafka/pull/11896#discussion_r836956890
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImpl.java
##
@@ -224,7 +225,15 @@
lihaosky commented on a change in pull request #11917:
URL: https://github.com/apache/kafka/pull/11917#discussion_r836944209
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBTimeOrderedSegmentedBytesStore.java
##
@@ -0,0 +1,266 @@
dengziming opened a new pull request #9500:
URL: https://github.com/apache/kafka/pull/9500
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
guozhangwang commented on a change in pull request #11917:
URL: https://github.com/apache/kafka/pull/11917#discussion_r836921995
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedSessionKeySchemas.java
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed
cmccabe merged pull request #11957:
URL: https://github.com/apache/kafka/pull/11957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Colin McCabe created KAFKA-13774:
Summary: AclAuthorizer should handle it a bit more gracefully if
zookeeper.connect is null
Key: KAFKA-13774
URL: https://issues.apache.org/jira/browse/KAFKA-13774
guozhangwang opened a new pull request #11958:
URL: https://github.com/apache/kafka/pull/11958
I noticed two issues in the log4j entry:
1. It's formatted as "{}...{}" + param1, param2; effectively it is one param
only, and the printed line is effectively mis-aligned: we always print
cmccabe commented on pull request #11957:
URL: https://github.com/apache/kafka/pull/11957#issuecomment-1081103120
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
skaundinya15 commented on pull request #11957:
URL: https://github.com/apache/kafka/pull/11957#issuecomment-1081078809
@cmccabe Thanks for the feedback, just pushed a new patch where there's a
string in `TestInfoUtils` and used across all the tests.
--
This is an automated message from
lkokhreidze commented on a change in pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#discussion_r836386016
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -677,6 +685,30 @@ default.windowed.value.serde.innerThis is discussed in more
cmccabe commented on pull request #11957:
URL: https://github.com/apache/kafka/pull/11957#issuecomment-1081033496
Thanks for the PR, @skaundinya15 . This seems like a good readability
improvement. Is it possible to use a constant here rather than repeating the
literal string? If we had a
skaundinya15 opened a new pull request #11957:
URL: https://github.com/apache/kafka/pull/11957
This patch adds display names for KRaft and ZK tests. Without this, it
becomes hard to understand in Jenkins test reports which test failed. With this
addition, it becomes more clear which
guozhangwang commented on pull request #11927:
URL: https://github.com/apache/kafka/pull/11927#issuecomment-1081007451
@dajac could you revert this commit to re-disable the tests please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
FireBurn commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080975043
> @FireBurn What do you mean exactly with "a lot of references"? If you run
`./gradlew printAllDependencies` you will see that no log4j12 library is pulled
into (except for
FireBurn commented on a change in pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#discussion_r836707205
##
File path: gradle/dependencies.gradle
##
@@ -177,7 +177,6 @@ libs += [
kafkaStreams_28: "org.apache.kafka:kafka-streams:$versions.kafka_28",
FireBurn commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080969629
> 2\. ./gradlew printAllDependencies
That's that sorted now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#issuecomment-1080966972
Thanks for clarifying the PR title and description. Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
junrao commented on a change in pull request #11950:
URL: https://github.com/apache/kafka/pull/11950#discussion_r836679617
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -517,14 +558,16 @@ class LocalLog(@volatile private var _dir: File,
cadonna edited a comment on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080941806
@FireBurn What do you mean exactly with "a lot of references"? If you run
`./gradlew printAllDependencies` you will see that no log4j12 library is pulled
into (except
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080941806
@FireBurn What do you mean exactly with "a lot of references"? If you run
`./gradlew printAllDependencies` you will see that no log4j12 library is pulled
into (except for the
FireBurn commented on a change in pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#discussion_r836668095
##
File path: gradle/dependencies.gradle
##
@@ -189,14 +188,15 @@ libs += [
powermockJunit4:
FireBurn commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080932860
Doesn't the other request still have a lot of references to log4j?
I'm online now and can make any changes you'd like, unless you'd rather go
for the other PR
--
vvcephei commented on pull request #11952:
URL: https://github.com/apache/kafka/pull/11952#issuecomment-1080887880
Thanks for the quick reviews, @mjsax and @jeqo !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vvcephei commented on a change in pull request #11952:
URL: https://github.com/apache/kafka/pull/11952#discussion_r836631366
##
File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessor.java
##
@@ -92,6 +93,20 @@ public void process(final Record record) {
}
vvcephei commented on a change in pull request #11952:
URL: https://github.com/apache/kafka/pull/11952#discussion_r836629808
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java
##
@@ -887,6 +892,98 @@ public void
vvcephei merged pull request #11952:
URL: https://github.com/apache/kafka/pull/11952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei commented on pull request #11952:
URL: https://github.com/apache/kafka/pull/11952#issuecomment-1080880253
It seems like the build is getting better. Only a couple of unrelated test
failures:
```
[Build / JDK 8 and Scala 2.12 /
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r836585455
##
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##
@@ -1333,4 +1333,93 @@ class AbstractFetcherThreadTest {
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13600:
--
Fix Version/s: 3.2.0
> Rebalances while streams is in degraded state can cause stores to be
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13600.
---
Resolution: Fixed
> Rebalances while streams is in degraded state can cause stores to be
>
cadonna commented on pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#issuecomment-1080760269
Cherry-picked to 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna merged pull request #11760:
URL: https://github.com/apache/kafka/pull/11760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#issuecomment-1080744558
@ijuma I am aware of some but I can't claim to be aware of all :). This
seems to be a miss in the original implementation. I can't think of any reason
not to complete the fetch
cadonna commented on pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#issuecomment-1080743307
Streams system tests are green. Going to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ijuma commented on pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#issuecomment-1080735056
@dajac are you aware of previous changes in this area? cc @hachikuji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on pull request #11927:
URL: https://github.com/apache/kafka/pull/11927#issuecomment-1080733305
Oh... no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513426#comment-17513426
]
Bruno Cadonna commented on KAFKA-13736:
---
Reopened the ticket since I got a failure on an unrelated
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reopened KAFKA-13736:
---
> Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives
>
cadonna commented on pull request #11927:
URL: https://github.com/apache/kafka/pull/11927#issuecomment-1080728461
@dajac I got again a failure for
`SocketServerTest.closingChannelWithBufferedReceives()` on an unrelated PR
(https://github.com/apache/kafka/pull/11956).
--
This is an
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080721434
Fine with me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080720126
@cadonna your PR seems simpler. We can set @FireBurn as co-author and go
with yours perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna edited a comment on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080716374
> @showuon I only found the log4j12 dependencies in the following projects:
> streams:upgrade-system-tests-0100
streams:upgrade-system-tests-0101
cadonna edited a comment on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080716374
> @showuon I only found the log4j12 dependencies in the following projects:
> streams:upgrade-system-tests-0100
streams:upgrade-system-tests-0101
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080716374
> @showuon I only found the log4j12 dependencies in the following projects:
> streams:upgrade-system-tests-0100
streams:upgrade-system-tests-0101
>I
cadonna edited a comment on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080690140
@FireBurn Sorry, I did not intend to hijack the ticket, but code freeze is
this Wednesday and we did not know if you were available. OK then we can stay
on this PR.
cadonna edited a comment on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080690140
@FireBurn Sorry, I did not intent to hijack the ticket, but code freeze is
this Wednesday and we did not know if you were available. OK then we can stay
on this PR.
cadonna edited a comment on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080690140
Sorry, I did not intent to hijack the ticket, but code freeze is this
Wednesday and we did not know if you were available. OK then we can stay on
this PR.
--
This
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080690140
Sorry, I did not intent to hijack the ticket, but code freeze is this
Wednesday I we did not know if you were available. OK then we can stay on this
PR.
--
This is an
cadonna commented on pull request #11956:
URL: https://github.com/apache/kafka/pull/11956#issuecomment-1080687880
Call for review: @edoardocomar since you also commented on the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
FireBurn commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080687801
Sorry I can update it tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-1080686115
Since we haven't gotten any answer from the original author for a couple of
days and code freeze is approaching, I opened a new PR:
https://github.com/apache/kafka/pull/11956
cadonna opened a new pull request #11956:
URL: https://github.com/apache/kafka/pull/11956
This PR bumps the version of slf4j-log4j12 to 1.7.36 which automatically
uses slf4j-reload4j. The slf4j-reload4j binding delegates log processing to the
reload4j logging framework.
###
viktorsomogyi commented on pull request #10738:
URL: https://github.com/apache/kafka/pull/10738#issuecomment-1080679029
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-12380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513393#comment-17513393
]
Rajani Karuturi commented on KAFKA-12380:
-
I raised below pull request to fix this issue
karuturi opened a new pull request #11955:
URL: https://github.com/apache/kafka/pull/11955
added shutdown for executors and tests for the same
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build
Ge commented on a change in pull request #11945:
URL: https://github.com/apache/kafka/pull/11945#discussion_r836431097
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java
##
@@ -92,6 +103,32
Tm Alkemade created KAFKA-13773:
---
Summary: Data loss after recovery from crash due to full hard disk
Key: KAFKA-13773
URL: https://issues.apache.org/jira/browse/KAFKA-13773
Project: Kafka
Ge commented on a change in pull request #11945:
URL: https://github.com/apache/kafka/pull/11945#discussion_r836421028
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java
##
@@ -64,7 +64,7 @@
cadonna commented on pull request #11743:
URL: https://github.com/apache/kafka/pull/11743#issuecomment-108062
@showuon I only found the log4j12 dependencies in the following projects:
- `streams:upgrade-system-tests-0100`
- `streams:upgrade-system-tests-0101`
I guess they
lkokhreidze commented on a change in pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#discussion_r836386016
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -677,6 +685,30 @@ default.windowed.value.serde.innerThis is discussed in more
yufeiyan1220 commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r836342442
##
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##
@@ -1333,4 +1333,93 @@ class AbstractFetcherThreadTest {
dengziming commented on pull request #11951:
URL: https://github.com/apache/kafka/pull/11951#issuecomment-1080546553
Changing the heartbeat request to advertise an offset only after it has been
published, would make the test less flaky but can't completely remove the
flakiness, because
dotjdk commented on pull request #10390:
URL: https://github.com/apache/kafka/pull/10390#issuecomment-1080499059
The parameter name changes for `fetchSession` in this commit introduces some
potential confusion. Looks like a copy/paste mistake from the `findSessions`
methods.
dajac commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r836155421
##
File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala
##
@@ -61,7 +61,9 @@ abstract class AbstractFetcherManager[T <:
[
https://issues.apache.org/jira/browse/KAFKA-13735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13735.
---
Resolution: Fixed
> Flaky kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13736.
---
Resolution: Fixed
> Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives
cadonna commented on pull request #11927:
URL: https://github.com/apache/kafka/pull/11927#issuecomment-1080369649
@dajac Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513243#comment-17513243
]
Bruno Cadonna commented on KAFKA-13660:
---
[~vikash08mishra] I agree with [~tombentley] about
bozhao12 commented on a change in pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#discussion_r836181354
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1300,6 +1300,62 @@ class ReplicaManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhaobo updated KAFKA-13767:
---
Summary: Fetch should return immediately when preferred read replica is
defined (was: Fetch response did
[
https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513225#comment-17513225
]
Tom Bentley commented on KAFKA-13660:
-
[~vikash08mishra] I'm happy to include this in 3.1.1 if we
dajac commented on pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#issuecomment-1080325149
@bozhao12 Could you also update the description? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on a change in pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#discussion_r836134933
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1300,6 +1300,62 @@ class ReplicaManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513214#comment-17513214
]
Vikash Mishra commented on KAFKA-13660:
---
Hi [~cadonna] [~tombentley] , do we have any clarity on
showuon commented on pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#issuecomment-1080254334
@kkonstantine , sorry to keep pinging you, but we need your advice before we
can continue. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to
80 matches
Mail list logo
