dengziming commented on pull request #11990:
URL: https://github.com/apache/kafka/pull/11990#issuecomment-1086787319
In fact, we set package name to `kafka.integration` intentionally, they are
just put into the directories. In scala, package name can be different from
there directories.
[
https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516429#comment-17516429
]
RivenSun commented on KAFKA-13793:
--
Hi [~guozhang] [~dajac] [~showuon]
Could you give
RivenSun created KAFKA-13793:
Summary: Add validators for serialization and deserialization
related configuration
Key: KAFKA-13793
URL: https://issues.apache.org/jira/browse/KAFKA-13793
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
RivenSun resolved KAFKA-13786.
--
Reviewer: Luke Chen
Assignee: RivenSun
Resolution: Fixed
> Optimized documentation for con
[
https://issues.apache.org/jira/browse/KAFKA-13786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516427#comment-17516427
]
RivenSun commented on KAFKA-13786:
--
Hi [~showuon] You can modify the status of this jir
RivenSun2 commented on pull request #11985:
URL: https://github.com/apache/kafka/pull/11985#issuecomment-1086758489
Because a validator is added to `ProducerConfig.COMPRESSION_TYPE_CONFIG` and
`KafkaConfig.CompressionTypeProp`, the corresponding testCase is improved to
verify whether the w
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Summary: Wrong package name in Scala test files (was: Wrong package name
in UncleanLeaderEl
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Language: scala
Reviewer: Manikumar Reddy
> Wrong package name in UncleanLeaderElectionT
YeonCheolGit edited a comment on pull request #11990:
URL: https://github.com/apache/kafka/pull/11990#issuecomment-1086682088
@omkreddy Hello. I am not sure tagging you here but if you are available,
please review this.
--
This is an automated message from the Apache Git Service.
To resp
YeonCheolGit commented on pull request #11990:
URL: https://github.com/apache/kafka/pull/11990#issuecomment-1086682088
@omkreddy Hello. I am not sure tagging you for review but if you are
available, please review this.
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
External issue URL: https://github.com/apache/kafka/pull/11990
> Wrong package name in Uncle
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
External issue URL: (was: https://github.com/apache/kafka/pull/11990)
> Wrong package name
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Description:
Wrong package name in *UncleanLeaderElectionTest* and *QuorumImplementation*
f
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
External issue URL: https://github.com/apache/kafka/pull/11990 (was:
https://github.com/apa
YeonCheolGit removed a comment on pull request #11989:
URL: https://github.com/apache/kafka/pull/11989#issuecomment-1086676894
@omkreddy I am not sure tagging you but review please:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
YeonCheolGit closed pull request #11989:
URL: https://github.com/apache/kafka/pull/11989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
YeonCheolGit opened a new pull request #11990:
URL: https://github.com/apache/kafka/pull/11990
- Fix wrong package name in `QuorumImplementation` and
`UncleanLeaderElectionTest` files.
- import classes
*Summary of testing strategy (including rationale)
for the feature or bug fi
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Description:
Wrong package name in *UncleanLeaderElectionTest.scala.* Fix package name.
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Labels: easyfix scala test (was: )
> Wrong package name in UncleanLeaderElectionTest.scala
YeonCheolGit edited a comment on pull request #11989:
URL: https://github.com/apache/kafka/pull/11989#issuecomment-1086676894
@omkreddy I am not sure tagging you but review please:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Description:
package name in *UncleanLeaderElectionTest.scala* is wrong.
original: kafk
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
Description:
package name in *UncleanLeaderElectionTest.scala* is wrong.
original: kafka.i
YeonCheolGit commented on pull request #11989:
URL: https://github.com/apache/kafka/pull/11989#issuecomment-1086676894
@omkreddy I don't know who could review this but review this please:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
YeonCheolGit commented on pull request #11989:
URL: https://github.com/apache/kafka/pull/11989#issuecomment-1086676649
jira ticket: https://issues.apache.org/jira/browse/KAFKA-13792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YeonCheol Jang updated KAFKA-13792:
---
External issue URL: https://github.com/apache/kafka/pull/11989
> Fix UncleanLeaderElectionTe
YeonCheolGit opened a new pull request #11989:
URL: https://github.com/apache/kafka/pull/11989
Change `UncleanLeaderElectionTest` class package path.
original: kafka.integration
fix: unit.kafka.integration
*Summary of testing strategy (including rationale)
for the fea
YeonCheol Jang created KAFKA-13792:
--
Summary: Fix UncleanLeaderElectionTest package path
Key: KAFKA-13792
URL: https://issues.apache.org/jira/browse/KAFKA-13792
Project: Kafka
Issue Type: Bu
anatasiavela opened a new pull request #11987:
URL: https://github.com/apache/kafka/pull/11987
This PR fixes the flaky
SocketServerTest.testClientDisconnectionUpdatesRequestMetrics() test. When a
response is sent, the request metrics get updated. But if the metrics get
updated before expe
[
https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516240#comment-17516240
]
Yu-Jhe Li edited comment on KAFKA-13404 at 4/2/22 7:17 AM:
---
Th
[
https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516240#comment-17516240
]
Yu-Jhe Li edited comment on KAFKA-13404 at 4/2/22 7:15 AM:
---
Th
[
https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516240#comment-17516240
]
Yu-Jhe Li commented on KAFKA-13404:
---
Thanks for your explanation, [~ChrisEgerton].
Af
31 matches
Mail list logo
