[jira] [Commented] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-04-10 Thread Sayantanu Dey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520291#comment-17520291 ] Sayantanu Dey commented on KAFKA-13217: --- Hello, I picked up this task, I was going through the

[jira] [Resolved] (KAFKA-13802) Uncaught exception in scheduled task 'flush-log' (kafka.utils.KafkaScheduler)

2022-04-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13802. --- Resolution: Fixed Fixed in [#11605|https://github.com/apache/kafka/pull/11605]  > Uncaught

[jira] [Resolved] (KAFKA-13792) Wrong package name in Scala test files

2022-04-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13792. --- Resolution: Not A Problem > Wrong package name in Scala test files >

[jira] [Commented] (KAFKA-13810) Document behavior of KafkaProducer.flush() w.r.t callbacks

2022-04-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520278#comment-17520278 ] Luke Chen commented on KAFKA-13810: --- [~kspang_impala_76b0] , are you interested in submitting a PR to

[GitHub] [kafka] JoeCqupt closed pull request #12025: KAFKA-13802: handle uncaught exception

2022-04-10 Thread GitBox
JoeCqupt closed pull request #12025: KAFKA-13802: handle uncaught exception URL: https://github.com/apache/kafka/pull/12025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] JoeCqupt commented on pull request #12025: KAFKA-13802: handle uncaught exception

2022-04-10 Thread GitBox
JoeCqupt commented on PR #12025: URL: https://github.com/apache/kafka/pull/12025#issuecomment-1094490621 ok fine! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] bozhao12 commented on pull request #12022: MINOR:Remove repeated variable reset when controller execute…

2022-04-10 Thread GitBox
bozhao12 commented on PR #12022: URL: https://github.com/apache/kafka/pull/12022#issuecomment-1094488859 @showuon please take a look if you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] C0urante commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
C0urante commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r846908015 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -200,283 +229,149 @@ private Long

[GitHub] [kafka] C0urante commented on pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
C0urante commented on PR #12019: URL: https://github.com/apache/kafka/pull/12019#issuecomment-1094487905 Apologies @showuon, this does not actually (fully) address KAFKA-12495. Several of the test cases here relied on rebalances being triggered in circumstances that they would not normally

[jira] [Commented] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-10 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520273#comment-17520273 ] RivenSun commented on KAFKA-13793: -- Hi [~showuon]  Could you help review the KIP? Thanks a lot. > Add

[GitHub] [kafka] showuon commented on pull request #12025: KAFKA-13802: handle uncaught exception

2022-04-10 Thread GitBox
showuon commented on PR #12025: URL: https://github.com/apache/kafka/pull/12025#issuecomment-1094484248 @JoeCqupt , thanks for the PR. But I think this PR already addressed this issue: https://github.com/apache/kafka/pull/11605 , which should include in v3.2.0. Thank you. -- This is an

[GitHub] [kafka] showuon merged pull request #12026: MINOR: Change the log output information in the KafkaConsumer assign method

2022-04-10 Thread GitBox
showuon merged PR #12026: URL: https://github.com/apache/kafka/pull/12026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] RivenSun2 commented on pull request #12026: MINOR: Change the log output information in the KafkaConsumer assign method

2022-04-10 Thread GitBox
RivenSun2 commented on PR #12026: URL: https://github.com/apache/kafka/pull/12026#issuecomment-1094452838 Hi @showuon @hachikuji could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] RivenSun2 opened a new pull request, #12026: MINOR: Change the log output information in the KafkaConsumer assign method

2022-04-10 Thread GitBox
RivenSun2 opened a new pull request, #12026: URL: https://github.com/apache/kafka/pull/12026 Printing `Subscribed` in the assign method can confuse users who are clearly not using the `subscribe` mode. Even though the bottom layer of assign uses SubscriptionState to store assignments,

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-10 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1094440416 Hi @showuon @mimaison could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-10 Thread GitBox
RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-1094439959 Hi @showuon could you help to review the KIP-828? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] C0urante commented on a diff in pull request #12023: Create AbstractLogContext class with static and dynamic subclasses, remove DynamicPrefixLogger

2022-04-10 Thread GitBox
C0urante commented on code in PR #12023: URL: https://github.com/apache/kafka/pull/12023#discussion_r846829654 ## clients/src/main/java/org/apache/kafka/common/utils/LogContext.java: ## @@ -16,778 +16,28 @@ */ package org.apache.kafka.common.utils; -import

[GitHub] [kafka] JoeCqupt opened a new pull request, #12025: handle uncaught exception

2022-04-10 Thread GitBox
JoeCqupt opened a new pull request, #12025: URL: https://github.com/apache/kafka/pull/12025 handle uncaught exception [KAFKA-13802](https://issues.apache.org/jira/browse/KAFKA-13802) ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r846804952 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -200,283 +229,149 @@ private Long

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r846804952 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -200,283 +229,149 @@ private Long

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r846804952 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -200,283 +229,149 @@ private Long

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r846804952 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -200,283 +229,149 @@ private Long

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-10 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r846804952 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -200,283 +229,149 @@ private Long

[GitHub] [kafka] YeonCheolGit closed pull request #11990: KAFKA-13792: Fix wrong package name in Scala test files

2022-04-10 Thread GitBox
YeonCheolGit closed pull request #11990: KAFKA-13792: Fix wrong package name in Scala test files URL: https://github.com/apache/kafka/pull/11990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (KAFKA-13787) Failed to delete state store directory for it is not empty

2022-04-10 Thread Clive Cox (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520131#comment-17520131 ] Clive Cox edited comment on KAFKA-13787 at 4/10/22 10:10 AM: - Any update on

[jira] [Commented] (KAFKA-13787) Failed to delete state store directory for it is not empty

2022-04-10 Thread Clive Cox (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520131#comment-17520131 ] Clive Cox commented on KAFKA-13787: --- Any update on this? I see a file like

[jira] [Assigned] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-04-10 Thread Sayantanu Dey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sayantanu Dey reassigned KAFKA-13217: - Assignee: Sayantanu Dey > Reconsider skipping the LeaveGroup on close() or add an

[jira] [Commented] (KAFKA-13774) AclAuthorizer should handle it a bit more gracefully if zookeeper.connect is null

2022-04-10 Thread Sayantanu Dey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520084#comment-17520084 ] Sayantanu Dey commented on KAFKA-13774: --- is this issue related to the null value of