[jira] [Assigned] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13859: -- Assignee: dengziming > SCRAM authentication issues with kafka-clients 3.0.1 > ---

[jira] [Commented] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529204#comment-17529204 ] dengziming commented on KAFKA-13859: This maybe related to the fact that we enabled

[GitHub] [kafka] vamossagar12 commented on pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

vamossagar12 commented on PR #12104: URL: https://github.com/apache/kafka/pull/12104#issuecomment-750545 @guozhangwang , I added a fix for this test.. Plz review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-718569 Hi @guozhangwang @mimaison could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r860454746 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -1142,107 +982,65 @@ private void removeConn

[jira] [Commented] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529173#comment-17529173 ] RivenSun commented on KAFKA-13857: -- [~guozhang]  When I count the current number of me

[jira] [Commented] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529169#comment-17529169 ] dengziming commented on KAFKA-13859: [~opayne] Do you have more detailed exception s

[GitHub] [kafka] showuon merged pull request #12101: MINOR: Fix minor typos in `PartitionChangeBuilder`

showuon merged PR #12101: URL: https://github.com/apache/kafka/pull/12101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] vamossagar12 opened a new pull request, #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

vamossagar12 opened a new pull request, #12104: URL: https://github.com/apache/kafka/pull/12104 …rom describe topics command *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to pi

[GitHub] [kafka] dengziming commented on a diff in pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

dengziming commented on code in PR #12103: URL: https://github.com/apache/kafka/pull/12103#discussion_r860398065 ## shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java: ## @@ -333,6 +339,34 @@ private void handleCommitImpl(MetadataRecordType type, ApiMessage mes

[GitHub] [kafka] dengziming commented on a diff in pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

dengziming commented on code in PR #12103: URL: https://github.com/apache/kafka/pull/12103#discussion_r860398372 ## shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java: ## @@ -333,6 +339,34 @@ private void handleCommitImpl(MetadataRecordType type, ApiMessage mes

[GitHub] [kafka] dengziming opened a new pull request, #12103: KAFKA-13850: Show missing record type in MetadataShell

dengziming opened a new pull request, #12103: URL: https://github.com/apache/kafka/pull/12103 *More detailed description of your change* Currently, 8 record types are missing in MetadataShell: 1. AccessControlEntryRecord and RemoveAccessControlEntryRecord are added in KIP-801, Feat

[jira] [Commented] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529143#comment-17529143 ] RivenSun commented on KAFKA-13857: -- Hi [~guozhang]  Thank you for your reply. As you s

[GitHub] [kafka] hachikuji commented on pull request #12098: MINOR: Fix event output inconsistencies in TransactionalMessageCopier

hachikuji commented on PR #12098: URL: https://github.com/apache/kafka/pull/12098#issuecomment-618735 Branch builder test results: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-04-27--001.system-test-kafka-branch-builder--1651099983--hachikuji-

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r860332442 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory o

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r860331417 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -3325,6 +3325,32 @@ class UnifiedLogTest { assertEquals(1, log.numberOfSegments) } + /** + *

[GitHub] [kafka] ijuma commented on pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

ijuma commented on PR #12096: URL: https://github.com/apache/kafka/pull/12096#issuecomment-573554 Thanks for the careful analysis @hachikuji. We discussed the options offline and agreed to go with the most conservative option for the backports (add the producer id and epoch to the compa

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r860212157 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji commented on pull request #12098: MINOR: Fix event output inconsistencies in TransactionalMessageCopier

hachikuji commented on PR #12098: URL: https://github.com/apache/kafka/pull/12098#issuecomment-419044 @mumrah Yeah, we do. I updated the service class that used this and kicked off a run of `transactions_test.py`. I will report the results here when finished. -- This is an automated

[GitHub] [kafka] mumrah commented on a diff in pull request #12098: MINOR: Fix event output inconsistencies in TransactionalMessageCopier

mumrah commented on code in PR #12098: URL: https://github.com/apache/kafka/pull/12098#discussion_r860183642 ## tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java: ## @@ -260,27 +260,23 @@ private static String toJsonString(Map data) { return js

[GitHub] [kafka] guozhangwang commented on pull request #12102: HOTFIX: Only measure in nano when producer metadata refresh is required

guozhangwang commented on PR #12102: URL: https://github.com/apache/kafka/pull/12102#issuecomment-405207 Hi @cadonna could you please lmk if I can cherry-pick it to 3.2 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (KAFKA-13855) FileNotFoundException: Error while rolling log segment for topic partition in dir

[ https://issues.apache.org/jira/browse/KAFKA-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528966#comment-17528966 ] Sergey Ivanov commented on KAFKA-13855: --- Hi [~ocadaruma], Thank you for your answ

[GitHub] [kafka] guozhangwang merged pull request #12102: HOTFIX: Only measure in nano when producer metadata refresh is required

guozhangwang merged PR #12102: URL: https://github.com/apache/kafka/pull/12102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on pull request #12074: HOTFIX: fix broken trunk due to conflicting and overlapping commits

guozhangwang commented on PR #12074: URL: https://github.com/apache/kafka/pull/12074#issuecomment-312220 Thanks @mjsax! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [kafka] guozhangwang commented on pull request #12102: HOTFIX: Only measure in nano when producer metadata refresh is required

guozhangwang commented on PR #12102: URL: https://github.com/apache/kafka/pull/12102#issuecomment-287201 cc @rodesai for a quick look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] guozhangwang opened a new pull request, #12102: HOTFIX: Only measure in nano when producer metadata refresh is required

guozhangwang opened a new pull request, #12102: URL: https://github.com/apache/kafka/pull/12102 We added the metadata wait time in total blocked time (https://github.com/apache/kafka/pull/11805). But we added it in the critical path of `send` which is called per-record, whereas metadata ref

[GitHub] [kafka] guozhangwang commented on pull request #11896: KAFKA-13785: [6/N][Emit final] emit final for TimeWindowedKStreamImpl

guozhangwang commented on PR #11896: URL: https://github.com/apache/kafka/pull/11896#issuecomment-247643 Sorry about that @lihaosky , I just created a copy PR from the branch in order to merge sooner: https://github.com/apache/kafka/pull/12100 @mjsax could you take a look at that

[jira] [Commented] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528894#comment-17528894 ] Guozhang Wang commented on KAFKA-13857: --- Hi [~RivenSun] do you have a concrete use

[GitHub] [kafka] cadonna commented on pull request #11980: fix: make sliding window works without grace period (#kafka-13739)

cadonna commented on PR #11980: URL: https://github.com/apache/kafka/pull/11980#issuecomment-190669 Cherry-picked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ddrid commented on pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

ddrid commented on PR #12096: URL: https://github.com/apache/kafka/pull/12096#issuecomment-140327 Thanks for fixing it! LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Created] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

Oliver Payne created KAFKA-13859: Summary: SCRAM authentication issues with kafka-clients 3.0.1 Key: KAFKA-13859 URL: https://issues.apache.org/jira/browse/KAFKA-13859 Project: Kafka Issue Ty

[GitHub] [kafka] mumrah commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

mumrah commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859885889 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] dajac opened a new pull request, #12101: MINOR: Fix minor typos in `PartitionChangeBuilder`

dajac opened a new pull request, #12101: URL: https://github.com/apache/kafka/pull/12101 Two minor typos found while reading `PartitionChangeBuilder`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] showuon commented on a diff in pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

showuon commented on code in PR #11955: URL: https://github.com/apache/kafka/pull/11955#discussion_r859809462 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -222,6 +223,20 @@ public void stop() { connectorStatusMetricsGroup.close();

[GitHub] [kafka] showuon commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

showuon commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r859795409 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,8 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] karuturi commented on a diff in pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

karuturi commented on code in PR #11955: URL: https://github.com/apache/kafka/pull/11955#discussion_r859794942 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -222,6 +223,14 @@ public void stop() { connectorStatusMetricsGroup.close()

[GitHub] [kafka] dajac commented on pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

dajac commented on PR #12096: URL: https://github.com/apache/kafka/pull/12096#issuecomment-1110992583 @ijuma Sounds good to me, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] ijuma commented on pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

ijuma commented on PR #12096: URL: https://github.com/apache/kafka/pull/12096#issuecomment-1110988716 @dajac Yes, the original test still passes with this change, so it shows that this change also fixes the issue. Creating a test that fails due to a hashCode collision is difficult since the

[GitHub] [kafka] ijuma commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

ijuma commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r859784675 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,8 @@ private static class TopicPartitionEntry { /

[GitHub] [kafka] showuon commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

showuon commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r859762128 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,8 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] cadonna commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

cadonna commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1110697320 Cherry-picked to 3.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.