dajac opened a new pull request, #12147:
URL: https://github.com/apache/kafka/pull/12147
I have missed a few in
https://github.com/apache/kafka/commit/7c8c65fc54b9eb0386787632ff8315e097d99818.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implemen
Ge commented on PR #12122:
URL: https://github.com/apache/kafka/pull/12122#issuecomment-1123342913
@mjsax How can I trigger system tests in the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13892:
--
Fix Version/s: 3.3.0
> Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager
>
cadonna commented on code in PR #12137:
URL: https://github.com/apache/kafka/pull/12137#discussion_r870087244
##
streams/src/main/java/org/apache/kafka/streams/errors/StreamsException.java:
##
@@ -66,10 +80,15 @@ public StreamsException(final Throwable throwable, final
TaskId t
cadonna commented on code in PR #12137:
URL: https://github.com/apache/kafka/pull/12137#discussion_r870087908
##
streams/src/main/java/org/apache/kafka/streams/errors/StreamsException.java:
##
@@ -31,24 +37,34 @@ public class StreamsException extends KafkaException {
priv
cadonna commented on code in PR #12137:
URL: https://github.com/apache/kafka/pull/12137#discussion_r870089590
##
streams/src/main/java/org/apache/kafka/streams/errors/StreamsException.java:
##
@@ -57,19 +73,29 @@ public StreamsException(final Throwable throwable) {
public
cadonna commented on code in PR #12137:
URL: https://github.com/apache/kafka/pull/12137#discussion_r870089994
##
streams/src/main/java/org/apache/kafka/streams/errors/StreamsException.java:
##
@@ -57,19 +73,29 @@ public StreamsException(final Throwable throwable) {
public
cadonna commented on PR #12137:
URL: https://github.com/apache/kafka/pull/12137#issuecomment-1123449313
Avoiding the public API change seems quite hacky to me. I would prefer to
generalize `StreamsException` to hold multiple task IDs.
--
This is an automated message from the Apache Git Se
showuon commented on code in PR #12087:
URL: https://github.com/apache/kafka/pull/12087#discussion_r870132658
##
core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
showuon commented on code in PR #12087:
URL: https://github.com/apache/kafka/pull/12087#discussion_r870126321
##
core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534847#comment-17534847
]
lqjacklee edited comment on KAFKA-13888 at 5/11/22 12:06 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534847#comment-17534847
]
lqjacklee commented on KAFKA-13888:
---
{code:java}
// code placeholder
{code}
[~Niket Go
vamossagar12 commented on PR #12104:
URL: https://github.com/apache/kafka/pull/12104#issuecomment-1123698212
@dengziming , thanks. As suggested, for kraft mode I added the newly added
wait condition. For zk mode, I reverted to using the cached metadata as the
original flaky nature was seen
dengziming commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r870248221
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHa
Ge commented on code in PR #12122:
URL: https://github.com/apache/kafka/pull/12122#discussion_r870251321
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -37,6 +37,7 @@
metadata_1_versions = [str(LATEST_0_10_0)]
metadata_2_versions = [str(LATEST_0_10_1), s
Ge commented on code in PR #12122:
URL: https://github.com/apache/kafka/pull/12122#discussion_r870251550
##
streams/upgrade-system-tests-31/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java:
##
@@ -63,21 +80,30 @@ public static void main(final String[] arg
[
https://issues.apache.org/jira/browse/KAFKA-13365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534883#comment-17534883
]
Omnia Ibrahim commented on KAFKA-13365:
---
[~dongjin] I believe KAFKA-13876 may also
showuon commented on PR #11748:
URL: https://github.com/apache/kafka/pull/11748#issuecomment-1123736709
I'll take a look this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
[
https://issues.apache.org/jira/browse/KAFKA-13691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-13691:
--
Labels: need-kip pull-request-available (was: pull-request-available)
> Rename target topic t
alfhv commented on PR #8324:
URL: https://github.com/apache/kafka/pull/8324#issuecomment-1123741673
I'm running on version 2.6.1 and I'm having exactly same issue described
here.
During a DR test some kafka nodes and consumers went down. When consumers
were restarted they were rejected b
ijuma commented on PR #12131:
URL: https://github.com/apache/kafka/pull/12131#issuecomment-1123802358
Thanks for the explanation. It's interesting how these underlying primitives
end up not working as intended. In any case, the fix in this PR seems fine, but
we didn't add any documentation.
ijuma commented on PR #12131:
URL: https://github.com/apache/kafka/pull/12131#issuecomment-1123804143
Also, it's a bit of a challenge to explain that we don't consider it
completed for `reconnect backoff` purposes, but we consider it complete for
`connection setup` purposes.
--
This is a
ijuma opened a new pull request, #12148:
URL: https://github.com/apache/kafka/pull/12148
* Remove `log4j-appender` dependency from `tools`, `trogdor` and `shell`
* Remove explicit `log4j` dependency from `trogdor` and `tools`.
* Add `compileOnly` dependency from `tools` to `log4j` (same
ijuma commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1123834576
@cmccabe is there any reason why `shell` and `trogdor` need `log4j-appender`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dengziming created KAFKA-13893:
--
Summary: Add BrokerApiVersions Api in AdminClient
Key: KAFKA-13893
URL: https://issues.apache.org/jira/browse/KAFKA-13893
Project: Kafka
Issue Type: Task
dengziming commented on PR #11786:
URL: https://github.com/apache/kafka/pull/11786#issuecomment-112361
Hello @niket-goel, before you working on KIP-836 to improve
`DescribeQuorumResponse`, you can help to review this PR. currently we don't
show DescribeQuorumRequest in the [kafka protoc
[
https://issues.apache.org/jira/browse/KAFKA-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534944#comment-17534944
]
Mickael Maison commented on KAFKA-13893:
This idea already came up a few times a
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r870454341
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -273,6 +301,40 @@ public static MetadataVersion latest() {
return VALUE
jsancio commented on code in PR #12146:
URL: https://github.com/apache/kafka/pull/12146#discussion_r870457817
##
config/kraft/README.md:
##
@@ -114,9 +114,7 @@ We don't support any kind of upgrade right now, either to
or from KRaft mode. T
Finally, the following Kafka featu
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r870466324
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -273,6 +301,40 @@ public static MetadataVersion latest() {
return VALUE
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r870466924
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -273,6 +301,40 @@ public static MetadataVersion latest() {
return VALUE
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r870467175
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -70,13 +47,17 @@ object StorageTool extends Logging {
case "format" =>
val directories = c
chernyih commented on PR #12131:
URL: https://github.com/apache/kafka/pull/12131#issuecomment-1123948985
Do you think the following comments help to clear things up? If yes, I can
add the comments to `checkingApiVersions` function.
// At this state, the connection setup might not
jsancio commented on code in PR #12146:
URL: https://github.com/apache/kafka/pull/12146#discussion_r870486983
##
config/kraft/README.md:
##
@@ -114,9 +114,7 @@ We don't support any kind of upgrade right now, either to
or from KRaft mode. T
Finally, the following Kafka featu
[
https://issues.apache.org/jira/browse/KAFKA-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534984#comment-17534984
]
dengziming commented on KAFKA-13893:
[~mimaison] Thank you for pointing out this.
>
[
https://issues.apache.org/jira/browse/KAFKA-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming resolved KAFKA-13893.
Resolution: Invalid
> Add BrokerApiVersions Api in AdminClient
> -
ijuma commented on code in PR #12146:
URL: https://github.com/apache/kafka/pull/12146#discussion_r870498600
##
config/kraft/README.md:
##
@@ -114,9 +114,7 @@ We don't support any kind of upgrade right now, either to
or from KRaft mode. T
Finally, the following Kafka feature
ijuma commented on code in PR #12146:
URL: https://github.com/apache/kafka/pull/12146#discussion_r870499291
##
config/kraft/README.md:
##
@@ -114,9 +114,7 @@ We don't support any kind of upgrade right now, either to
or from KRaft mode. T
Finally, the following Kafka feature
jsancio commented on code in PR #12146:
URL: https://github.com/apache/kafka/pull/12146#discussion_r870516919
##
config/kraft/README.md:
##
@@ -114,9 +114,7 @@ We don't support any kind of upgrade right now, either to
or from KRaft mode. T
Finally, the following Kafka featu
ijuma commented on PR #12097:
URL: https://github.com/apache/kafka/pull/12097#issuecomment-1123994344
Looking at the test results, every test passed for at least one JDK version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ijuma merged PR #12097:
URL: https://github.com/apache/kafka/pull/12097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #12146:
URL: https://github.com/apache/kafka/pull/12146#issuecomment-1124007947
Since this only changes the readme, I'll go ahead and merge to trunk and
cherry-pick to 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ijuma merged PR #12146:
URL: https://github.com/apache/kafka/pull/12146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
vamossagar12 commented on PR #12104:
URL: https://github.com/apache/kafka/pull/12104#issuecomment-1124021398
> LGTM, left a minor comment, it's OK to take it or not.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
vamossagar12 commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r870550958
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTest
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535020#comment-17535020
]
Manuel Garcia Cabrera commented on KAFKA-12495:
---
I see two different issue
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535020#comment-17535020
]
Manuel Garcia Cabrera edited comment on KAFKA-12495 at 5/11/22 5:02 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535020#comment-17535020
]
Manuel Garcia Cabrera edited comment on KAFKA-12495 at 5/11/22 5:44 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535020#comment-17535020
]
Manuel Garcia Cabrera edited comment on KAFKA-12495 at 5/11/22 5:44 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-13861:
Fix Version/s: 3.2.1
> validateOnly request field does not work for CreatePartition reques
hachikuji commented on code in PR #11969:
URL: https://github.com/apache/kafka/pull/11969#discussion_r870639413
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -725,7 +727,11 @@ object KafkaConfig {
/* Authorizer Configuration ***/
val Au
hachikuji commented on code in PR #11969:
URL: https://github.com/apache/kafka/pull/11969#discussion_r870644114
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1509,4 +1512,29 @@ class KafkaConfigTest {
assertNotNull(config.getLong(KafkaConfig.SaslOA
ahuang98 commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r869745683
##
core/src/test/scala/unit/kafka/server/BrokerFeaturesTest.scala:
##
@@ -25,10 +25,6 @@ import scala.jdk.CollectionConverters._
class BrokerFeaturesTest {
- @Tes
jsancio commented on code in PR #12141:
URL: https://github.com/apache/kafka/pull/12141#discussion_r870749014
##
core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala:
##
@@ -17,24 +17,28 @@
package kafka.server
-import java.util.{Arrays, Collections}
-
+impor
philipnee opened a new pull request, #12149:
URL: https://github.com/apache/kafka/pull/12149
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
afireinside09 commented on PR #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-1124340583
Sorry for resurrecting an old thread but I'm still experiencing this in
Kafka 2.6.2 with Java kafka-clients 2.6.2.
```
ClientQuotaEntity clientEntity;
if (clie
afireinside09 commented on PR #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-1124340843
From the comments on `ClientQuotaEntity`:
```
Constructs a quota entity for the given types and names. If a name is null,
then it is mapped to the built-in default entity name.
Yiming Zang created KAFKA-13894:
---
Summary: Extend Kafka kerberos auth support to beyond only hostname
Key: KAFKA-13894
URL: https://issues.apache.org/jira/browse/KAFKA-13894
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-13894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiming Zang updated KAFKA-13894:
Component/s: clients
> Extend Kafka kerberos auth support to beyond only hostname
> --
[
https://issues.apache.org/jira/browse/KAFKA-13894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiming Zang updated KAFKA-13894:
Priority: Critical (was: Major)
> Extend Kafka kerberos auth support to beyond only hostname
> --
[
https://issues.apache.org/jira/browse/KAFKA-13894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535126#comment-17535126
]
Yiming Zang commented on KAFKA-13894:
-
We have internal changes that already fixed t
hachikuji opened a new pull request, #12150:
URL: https://github.com/apache/kafka/pull/12150
When a partition leader receives a `Fetch` request from a replica which is
not in the current replica set, the behavior today is to return a successful
fetch response, but with empty data. This caus
jparag opened a new pull request, #12151:
URL: https://github.com/apache/kafka/pull/12151
While running unitTest and integrationTest by tweaking the scala parallel
threads parameter, hit this issue where the command `./gradlew
-PmaxScalacThreads=4 unitTest` errored out, pointing to the bug
C0urante commented on PR #11775:
URL: https://github.com/apache/kafka/pull/11775#issuecomment-1124445220
@showuon how long would you like to wait before merging this if we don't
hear back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-13763.
---
Resolution: Done
> Improve unit testing coverage and flexibility for
> IncrementalCooperati
dengziming commented on code in PR #12141:
URL: https://github.com/apache/kafka/pull/12141#discussion_r870885220
##
core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala:
##
@@ -66,6 +70,11 @@ class DeleteTopicsRequestTest extends BaseRequestTest {
val respons
[
https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535843#comment-17535843
]
Chris Egerton commented on KAFKA-12657:
---
I've reviewed the test runs and managed t
dengziming commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r870922245
##
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##
@@ -102,6 +106,8 @@ class KafkaRaftServer(
threadNamePrefix,
controllerQuorumVotersFuture,
[
https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13763:
--
Fix Version/s: 3.3.0
> Improve unit testing coverage and flexibility for
> IncrementalCooperativeAssi
showuon merged PR #11775:
URL: https://github.com/apache/kafka/pull/11775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #11775:
URL: https://github.com/apache/kafka/pull/11775#issuecomment-1124596650
Thanks for your reminder. Merged into trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lim Qing Wei reassigned KAFKA-13882:
Assignee: Lim Qing Wei
> Dockerfile for previewing website
>
[
https://issues.apache.org/jira/browse/KAFKA-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535902#comment-17535902
]
Vrinda Halarnkar commented on KAFKA-13568:
--
Is there any workaround for this is
showuon merged PR #12151:
URL: https://github.com/apache/kafka/pull/12151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
74 matches
Mail list logo
