[GitHub] [kafka] AnGg98 opened a new pull request, #12247: replace ACL_AUTHORIZER attribute with ZK_ACL_AUTHORIZER

2022-06-02 Thread GitBox
AnGg98 opened a new pull request, #12247: URL: https://github.com/apache/kafka/pull/12247 Replace ACL_AUTHORIZER attribute with ZK_ACL_AUTHORIZER in tests. Required after the changes merged with https://github.com/apache/kafka/pull/12190 -- This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-13957) Flaky Test StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores

2022-06-02 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13957: --- Attachment: StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStor

[jira] [Created] (KAFKA-13957) Flaky Test StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores

2022-06-02 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13957: -- Summary: Flaky Test StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores Key: KAFKA-13957 URL: https://issues.apache.org/jira/browse/KAFKA-13957

[GitHub] [kafka] showuon commented on pull request #12246: KAFKA-13718: kafka-topics describe topic with default config will show `segment.bytes` overridden config

2022-06-02 Thread GitBox
showuon commented on PR #12246: URL: https://github.com/apache/kafka/pull/12246#issuecomment-1145537975 Thanks for the contribution, @Moovlin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-13718) kafka-topics describe topic with default config will show `segment.bytes` overridden config

2022-06-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13718. --- Fix Version/s: 3.3.0 Resolution: Fixed > kafka-topics describe topic with default config will

[GitHub] [kafka] showuon merged pull request #12246: KAFKA-13718: kafka-topics describe topic with default config will show `segment.bytes` overridden config

2022-06-02 Thread GitBox
showuon merged PR #12246: URL: https://github.com/apache/kafka/pull/12246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-02 Thread GitBox
jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r888522957 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

2022-06-02 Thread GitBox
guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r888483482 ## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java: ## @@ -202,25 +205,43 @@ public void remove(final Windowed sessionKey)

[jira] [Commented] (KAFKA-13936) Invalid consumer lag when monitoring from a kafka streams application

2022-06-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545686#comment-17545686 ] Matthias J. Sax commented on KAFKA-13936: - Might be worth to document for this c

[GitHub] [kafka] Moovlin opened a new pull request, #12246: KAFKA-13718: kafka-topics describe topic with default config will show `segment.bytes` overridden config

2022-06-02 Thread GitBox
Moovlin opened a new pull request, #12246: URL: https://github.com/apache/kafka/pull/12246 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* Effectively, commen

[jira] [Commented] (KAFKA-13718) kafka-topics describe topic with default config will show `segment.bytes` overridden config

2022-06-02 Thread Richard Joerger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545616#comment-17545616 ] Richard Joerger commented on KAFKA-13718: - Hey everybody. Sorry for the radio si

[jira] [Created] (KAFKA-13956) kafka-storage should accept a release version

2022-06-02 Thread David Arthur (Jira)
David Arthur created KAFKA-13956: Summary: kafka-storage should accept a release version Key: KAFKA-13956 URL: https://issues.apache.org/jira/browse/KAFKA-13956 Project: Kafka Issue Type: Sub

[GitHub] [kafka] guozhangwang commented on pull request #12244: [DO NOT MERGE] HOTFIX: only try to clear discover-coordinator future upon commit

2022-06-02 Thread GitBox
guozhangwang commented on PR #12244: URL: https://github.com/apache/kafka/pull/12244#issuecomment-1145176689 @showuon @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] guozhangwang opened a new pull request, #12244: [DO NOT MERGE] HOTFIX: only try to clear discover-coordinator future upon commit

2022-06-02 Thread GitBox
guozhangwang opened a new pull request, #12244: URL: https://github.com/apache/kafka/pull/12244 This is another way of fixing KAFKA-13563 other than #11631. Instead of letting the consumer to always try to discover coordinator in pool with either mode (subscribe / assign), we defer th

[GitHub] [kafka] cadonna merged pull request #12242: MINOR: Pin ducktape version to < 0.9

2022-06-02 Thread GitBox
cadonna merged PR #12242: URL: https://github.com/apache/kafka/pull/12242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] Kvicii opened a new pull request, #12243: fix doc

2022-06-02 Thread GitBox
Kvicii opened a new pull request, #12243: URL: https://github.com/apache/kafka/pull/12243 fix doc and improve code. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify docume

[GitHub] [kafka] cadonna commented on pull request #12242: MINOR: Pin ducktape version to < 0.9

2022-06-02 Thread GitBox
cadonna commented on PR #12242: URL: https://github.com/apache/kafka/pull/12242#issuecomment-1145147832 Call for review: @lbradstreet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cadonna opened a new pull request, #12242: MINOR: Pin ducktape version to < 0.9

2022-06-02 Thread GitBox
cadonna opened a new pull request, #12242: URL: https://github.com/apache/kafka/pull/12242 With newer ducktape versions than < 0.9 system tests may run into authentication issues with the AK system test infrastructure. ### Committer Checklist (excluded from commit message

[GitHub] [kafka] rittikaadhikari commented on pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-06-02 Thread GitBox
rittikaadhikari commented on PR #12005: URL: https://github.com/apache/kafka/pull/12005#issuecomment-1145117882 @junrao The test failures appear to all be related to KRaft (unrelated to this PR). -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (KAFKA-13953) kafka Console consumer fails with CorruptRecordException

2022-06-02 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545575#comment-17545575 ] Jun Rao commented on KAFKA-13953: - [~abasilbr] : This could be caused by data corruption

[GitHub] [kafka] jsancio commented on pull request #12236: MINOR: Use right enum value for broker registration change

2022-06-02 Thread GitBox
jsancio commented on PR #12236: URL: https://github.com/apache/kafka/pull/12236#issuecomment-1145057898 @dengziming Thanks for improving this! There are a lot of test failures. Can you take a look at those? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] jsancio commented on pull request #12238: KIP-835: MetadataMaxIdleIntervalMs should be much bigger than brokerHeartbeatIntervalMs

2022-06-02 Thread GitBox
jsancio commented on PR #12238: URL: https://github.com/apache/kafka/pull/12238#issuecomment-1145046468 @dengziming Thanks for looking at this. Did you consider fixing the logic for when the controller allows the broker to unfence? The current implementation requires that `request.cur

[GitHub] [kafka] C0urante commented on pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-02 Thread GitBox
C0urante commented on PR #11780: URL: https://github.com/apache/kafka/pull/11780#issuecomment-1144943380 Thanks Tom. Useful comments RE thread safety and an interesting point about transactional producer callbacks. Hoping we can do things the easy way on that front and let the clients libra

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-02 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r888026555 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTransactionContext.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-02 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r888026291 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -576,88 +672,42 @@ public boolean startTask( executor.submit(workerT

[GitHub] [kafka] tombentley commented on a diff in pull request #11778: KAFKA-10000: Use transactional producer for config topic (KIP-618)

2022-06-02 Thread GitBox
tombentley commented on code in PR #11778: URL: https://github.com/apache/kafka/pull/11778#discussion_r888026313 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ClusterConfigState.java: ## @@ -14,7 +14,7 @@ * See the License for the specific language governin

[GitHub] [kafka] bozhao12 opened a new pull request, #12241: MINOR: Fix docs in upgrade.html

2022-06-02 Thread GitBox
bozhao12 opened a new pull request, #12241: URL: https://github.com/apache/kafka/pull/12241 NotLeaderForPartitionException has been deprecated and replaced with NotLeaderOrFollowerException ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementati

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887982361 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_

[GitHub] [kafka] dajac commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
dajac commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887970373 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_TYPE

[GitHub] [kafka] dajac opened a new pull request, #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

2022-06-02 Thread GitBox
dajac opened a new pull request, #12240: URL: https://github.com/apache/kafka/pull/12240 This PR implements a first part of [KIP-841](https://cwiki.apache.org/confluence/display/KAFKA/KIP-841%3A+Fenced+replicas+should+not+be+allowed+to+join+the+ISR+in+KRaft). Specifically, it implements the

[GitHub] [kafka] showuon commented on pull request #12238: KIP-835: MetadataMaxIdleIntervalMs should be much bigger than brokerHeartbeatIntervalMs

2022-06-02 Thread GitBox
showuon commented on PR #12238: URL: https://github.com/apache/kafka/pull/12238#issuecomment-1144876598 [KAFKA-13955](https://issues.apache.org/jira/browse/KAFKA-13955) is created for this failing tests, in case duplicated works by other people. (Because it failed many tests in PR build res

[jira] [Commented] (KAFKA-13955) Fix failing KRaftClusterTest tests

2022-06-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545472#comment-17545472 ] Luke Chen commented on KAFKA-13955: --- PR: https://github.com/apache/kafka/pull/12238 >

[jira] [Created] (KAFKA-13955) Fix failing KRaftClusterTest tests

2022-06-02 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13955: - Summary: Fix failing KRaftClusterTest tests Key: KAFKA-13955 URL: https://issues.apache.org/jira/browse/KAFKA-13955 Project: Kafka Issue Type: Test Rep

[GitHub] [kafka] showuon commented on pull request #11845: MINOR: update the reassign-partition script results in docs

2022-06-02 Thread GitBox
showuon commented on PR #11845: URL: https://github.com/apache/kafka/pull/11845#issuecomment-1144871709 Addressed in https://github.com/apache/kafka/pull/12237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] showuon closed pull request #11845: MINOR: update the reassign-partition script results in docs

2022-06-02 Thread GitBox
showuon closed pull request #11845: MINOR: update the reassign-partition script results in docs URL: https://github.com/apache/kafka/pull/11845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] showuon merged pull request #12237: MINOR: Update the kafka-reassign-partitions script command in documentation

2022-06-02 Thread GitBox
showuon merged PR #12237: URL: https://github.com/apache/kafka/pull/12237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] C0urante commented on pull request #11778: KAFKA-10000: Use transactional producer for config topic (KIP-618)

2022-06-02 Thread GitBox
C0urante commented on PR #11778: URL: https://github.com/apache/kafka/pull/11778#issuecomment-1144858580 Thanks, Luke. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887935524 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887935524 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_

[GitHub] [kafka] showuon commented on pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
showuon commented on PR #12237: URL: https://github.com/apache/kafka/pull/12237#issuecomment-1144843191 Yes, the `KRaftClusterTest` failed tests are tracked in this PR: https://github.com/apache/kafka/pull/12238. And `testTopicIdUpgradeAfterReassigningPartitions` is tracked in another PR:

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-02 Thread GitBox
jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r887925475 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -275,7 +275,7 @@ private void commitSuccessfullyProcessedTasks() { int

[GitHub] [kafka] showuon commented on pull request #11778: KAFKA-10000: Use transactional producer for config topic (KIP-618)

2022-06-02 Thread GitBox
showuon commented on PR #11778: URL: https://github.com/apache/kafka/pull/11778#issuecomment-1144839204 I'll take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] dajac commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
dajac commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887910416 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_TYPE

[GitHub] [kafka] cadonna commented on a diff in pull request #12235: KAFKA-13945: add bytes/records consumed and produced metrics

2022-06-02 Thread GitBox
cadonna commented on code in PR #12235: URL: https://github.com/apache/kafka/pull/12235#discussion_r887767497 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java: ## @@ -166,4 +169,28 @@ public static String extractThreadId(final String fullTh

[GitHub] [kafka] cadonna commented on a diff in pull request #12235: KAFKA-13945: add bytes/records consumed and produced metrics

2022-06-02 Thread GitBox
cadonna commented on code in PR #12235: URL: https://github.com/apache/kafka/pull/12235#discussion_r887767497 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java: ## @@ -166,4 +169,28 @@ public static String extractThreadId(final String fullTh

[GitHub] [kafka] RivenSun2 commented on pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on PR #12226: URL: https://github.com/apache/kafka/pull/12226#issuecomment-1144788954 Hi @mimaison Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] RivenSun2 commented on pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
RivenSun2 commented on PR #12237: URL: https://github.com/apache/kafka/pull/12237#issuecomment-1144786776 The same error also appeared in a merged PR a few days ago: https://github.com/apache/kafka/pull/1/checks?check_run_id=6632831283 -- This is an automated message from the Apache

[GitHub] [kafka] cadonna merged pull request #12117: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-06-02 Thread GitBox
cadonna merged PR #12117: URL: https://github.com/apache/kafka/pull/12117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12117: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-06-02 Thread GitBox
cadonna commented on PR #12117: URL: https://github.com/apache/kafka/pull/12117#issuecomment-1144783785 Great! Thank you, @tombentley ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] RivenSun2 commented on pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
RivenSun2 commented on PR #12237: URL: https://github.com/apache/kafka/pull/12237#issuecomment-1144775882 The failed testcase:`testTopicIdUpgradeAfterReassigningPartitions()`, should not be related to this PR, this testcase seems unstable. In JDK8, an exception is thrown at `ControllerInt

[jira] [Commented] (KAFKA-8420) Graceful handling when consumer switches from subscribe to manual assign

2022-06-02 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545423#comment-17545423 ] Matthew de Detrich commented on KAFKA-8420: --- I am currently working on this iss

[jira] [Assigned] (KAFKA-8420) Graceful handling when consumer switches from subscribe to manual assign

2022-06-02 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich reassigned KAFKA-8420: - Assignee: Matthew de Detrich > Graceful handling when consumer switches from sub

[GitHub] [kafka] tombentley commented on a diff in pull request #12117: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-06-02 Thread GitBox
tombentley commented on code in PR #12117: URL: https://github.com/apache/kafka/pull/12117#discussion_r887842590 ## docs/upgrade.html: ## @@ -73,7 +73,13 @@ Notable changes in 3 via Connect worker and/or connector configuration. Connect may enable idempotent producers

[GitHub] [kafka] tombentley commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-02 Thread GitBox
tombentley commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r887801819 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-02 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r887814333 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -679,10 +679,11 @@ private long calcCompletionTimesAndReturn

[GitHub] [kafka] mimaison merged pull request #12239: MINOR: Small fixes in docs/upgrade.html

2022-06-02 Thread GitBox
mimaison merged PR #12239: URL: https://github.com/apache/kafka/pull/12239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-02 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r887787750 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -679,10 +679,11 @@ private long calcCompletionTimesAndReturn

[GitHub] [kafka] mimaison merged pull request #11776: KAFKA-10000: Add new preflight connector config validation logic (KIP-618)

2022-06-02 Thread GitBox
mimaison merged PR #11776: URL: https://github.com/apache/kafka/pull/11776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on a diff in pull request #12239: MINOR: Small fixes in docs/upgrade.html

2022-06-02 Thread GitBox
mimaison commented on code in PR #12239: URL: https://github.com/apache/kafka/pull/12239#discussion_r887779164 ## docs/upgrade.html: ## @@ -75,7 +75,7 @@ Notable changes in 3 Kafka has replaced log4j with reload4j due to security concerns. This only affects

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-02 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r887769458 ## build.gradle: ## @@ -1243,7 +1243,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter -testImplementation l

[GitHub] [kafka] dajac commented on a diff in pull request #12239: MINOR: Small fixes in docs/upgrade.html

2022-06-02 Thread GitBox
dajac commented on code in PR #12239: URL: https://github.com/apache/kafka/pull/12239#discussion_r887764340 ## docs/upgrade.html: ## @@ -75,7 +75,7 @@ Notable changes in 3 Kafka has replaced log4j with reload4j due to security concerns. This only affects mo

[GitHub] [kafka] mimaison opened a new pull request, #12239: MINOR: Small fixes in docs/upgrade.html

2022-06-02 Thread GitBox
mimaison opened a new pull request, #12239: URL: https://github.com/apache/kafka/pull/12239 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] dengziming commented on pull request #12238: KIP-835: MetadataMaxIdleIntervalMs should be much bigger than brokerHeartbeatIntervalMs

2022-06-02 Thread GitBox
dengziming commented on PR #12238: URL: https://github.com/apache/kafka/pull/12238#issuecomment-1144636319 @showuon Yes, after we reach a consensus here, we should update the KIP and note it in the KIP discussion thread. -- This is an automated message from the Apache Git Service. To resp

[jira] [Updated] (KAFKA-13954) Consumer Topic Offset reset to 0,baseoffset is wrong,Consumers do not consume

2022-06-02 Thread huangyoutai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huangyoutai updated KAFKA-13954: Affects Version/s: 2.6.0 > Consumer Topic Offset reset to 0,baseoffset is wrong,Consumers do not c

[jira] [Resolved] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

2022-06-02 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-13845. Resolution: Fixed > Add support for reading KRaft snapshots in kafka-dump-log > --

[jira] [Assigned] (KAFKA-12657) Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop

2022-06-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-12657: - Assignee: Chris Egerton > Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockI

[jira] [Resolved] (KAFKA-12657) Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop

2022-06-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-12657. --- Resolution: Fixed > Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorS

[GitHub] [kafka] showuon commented on pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

2022-06-02 Thread GitBox
showuon commented on PR #12159: URL: https://github.com/apache/kafka/pull/12159#issuecomment-1144607930 @tombentley , do you want to have another look? I'm going to merge this PR next week if you don't have any other comments. Thank you. -- This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

2022-06-02 Thread GitBox
showuon commented on PR #12159: URL: https://github.com/apache/kafka/pull/12159#issuecomment-1144607127 Failed tests are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.admin.TopicCommandIntegrationTest.testDescribeAtMinIsrPartitions(String).quorum=kraft Build / JDK 17 and

[GitHub] [kafka] showuon commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

2022-06-02 Thread GitBox
showuon commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r880476043 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[jira] [Created] (KAFKA-13954) Consumer Topic Offset reset to 0,baseoffset is wrong,Consumers do not consume

2022-06-02 Thread huangyoutai (Jira)
huangyoutai created KAFKA-13954: --- Summary: Consumer Topic Offset reset to 0,baseoffset is wrong,Consumers do not consume Key: KAFKA-13954 URL: https://issues.apache.org/jira/browse/KAFKA-13954 Project:

[GitHub] [kafka] showuon commented on pull request #12238: KIP-835: MetadataMaxIdleIntervalMs should be much bigger than brokerHeartbeatIntervalMs

2022-06-02 Thread GitBox
showuon commented on PR #12238: URL: https://github.com/apache/kafka/pull/12238#issuecomment-1144595607 Interesting bug. If we decided to increase the default `metadata.max.idle.interval.ms` value, we should note in the KIP discussion thread. However, I'm wondering if increasing the

[GitHub] [kafka] cadonna commented on a diff in pull request #12117: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-06-02 Thread GitBox
cadonna commented on code in PR #12117: URL: https://github.com/apache/kafka/pull/12117#discussion_r887704920 ## docs/upgrade.html: ## @@ -73,7 +73,13 @@ Notable changes in 3 via Connect worker and/or connector configuration. Connect may enable idempotent producers

[GitHub] [kafka] cadonna commented on a diff in pull request #12117: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-06-02 Thread GitBox
cadonna commented on code in PR #12117: URL: https://github.com/apache/kafka/pull/12117#discussion_r887704920 ## docs/upgrade.html: ## @@ -73,7 +73,13 @@ Notable changes in 3 via Connect worker and/or connector configuration. Connect may enable idempotent producers

[GitHub] [kafka] cadonna merged pull request #12191: KAFKA-12657: Increase timeouts in Connect integration tests

2022-06-02 Thread GitBox
cadonna merged PR #12191: URL: https://github.com/apache/kafka/pull/12191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] dengziming commented on pull request #12238: KIP-835: MetadataMaxIdleIntervalMs should be much bigger than brokerHeartbeatIntervalMs

2022-06-02 Thread GitBox
dengziming commented on PR #12238: URL: https://github.com/apache/kafka/pull/12238#issuecomment-1144578570 cc @jsancio @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887686539 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887686539 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_

[GitHub] [kafka] dengziming opened a new pull request, #12238: KIP-835: MetadataMaxIdleIntervalMs should be much bigger than brokerHeartbeatIntervalMs

2022-06-02 Thread GitBox
dengziming opened a new pull request, #12238: URL: https://github.com/apache/kafka/pull/12238 *More detailed description of your change* Will will generate NoOpRecord periodically to increase metadata LEO, however, when a broker startup, we will wait until its metadata LEO catches up wit

[GitHub] [kafka] cadonna commented on pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests

2022-06-02 Thread GitBox
cadonna commented on PR #12210: URL: https://github.com/apache/kafka/pull/12210#issuecomment-1144568953 @hachikuji Thanks for the review! I have already tried to trigger a system test run but there seems to be a environmental issue because I get authentication errors. Locally, the system te

[GitHub] [kafka] showuon commented on pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
showuon commented on PR #12237: URL: https://github.com/apache/kafka/pull/12237#issuecomment-1144564388 Waiting for the jenkins build since we have a output change in `ReassignPartitionsCommand.scala` -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12226: KAFKA-13890: Improve documentation of `ssl.keystore.type` and `ssl.truststore.type`

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12226: URL: https://github.com/apache/kafka/pull/12226#discussion_r887664798 ## clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java: ## @@ -69,7 +69,7 @@ public class SslConfigs { public static final String SSL_KEYSTORE_

[GitHub] [kafka] RivenSun2 commented on pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
RivenSun2 commented on PR #12237: URL: https://github.com/apache/kafka/pull/12237#issuecomment-1144547859 Hi @showuon I just resubmitted the code, please help to check. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12237: URL: https://github.com/apache/kafka/pull/12237#discussion_r887657044 ## docs/ops.html: ## @@ -397,9 +384,11 @@ > bin/kafka-reassign-partitions.sh --bootstrap-server localhost:9092 --verify --reassignment-json-file bigger-cluster.js

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12237: URL: https://github.com/apache/kafka/pull/12237#discussion_r887655468 ## docs/ops.html: ## @@ -361,14 +351,12 @@ + Successfully started partition reassignment for foo-0 Review Comment: Because there is only one topicPartition, outp

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12237: MINOR: Update the documentation that modifies the throttle of an active reassignment

2022-06-02 Thread GitBox
RivenSun2 commented on code in PR #12237: URL: https://github.com/apache/kafka/pull/12237#discussion_r887653354 ## core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala: ## @@ -331,7 +331,7 @@ object ReassignPartitionsCommand extends Logging { val state = states

[GitHub] [kafka] vamossagar12 commented on pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

2022-06-02 Thread GitBox
vamossagar12 commented on PR #12121: URL: https://github.com/apache/kafka/pull/12121#issuecomment-1144537837 > > @dajac , @guozhangwang The KIP has been approved. Also, as per one of the suggestions on the KIP, metricOrElseCreate has been renamed to getMetricOrElseCreate. > > Thanks!

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2022-06-02 Thread GitBox
vamossagar12 commented on code in PR #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r887646972 ## streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStoreTest.java: ## @@ -178,44 +178,36 @@ public void should