[GitHub] [kafka] fxbing commented on pull request #12333: MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"`

fxbing commented on PR #12333: URL: https://github.com/apache/kafka/pull/12333#issuecomment-1168224846 this pr can be merged? @divijvaidya @Kvicii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] aiquestion commented on pull request #12349: KAFKA-14024: Consumer keeps Commit offset in onJoinPrepare in Cooperative rebalance

aiquestion commented on PR #12349: URL: https://github.com/apache/kafka/pull/12349#issuecomment-1168158408 @showuon test added. Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907967640 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionSegmentedBytesStore.java: ## @@ -71,6 +72,36 @@ public byte[] fetchSessio

[GitHub] [kafka] guozhangwang commented on pull request #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang commented on PR #12204: URL: https://github.com/apache/kafka/pull/12204#issuecomment-1168138944 Thanks @mjsax , I've addressed your comment, and also added the test coverage. While adding tests I noticed a bug in the code and fixed it (see my comment above). Could you pl

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907966031 ## streams/src/main/java/org/apache/kafka/streams/state/internals/SessionKeySchema.java: ## @@ -35,7 +35,7 @@ public class SessionKeySchema implements SegmentedByt

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907965549 ## streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedSessionKeySchemas.java: ## @@ -204,7 +203,8 @@ public static void writeBinary(final ByteBu

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907965204 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java: ## @@ -148,55 +173,182 @@ public void process(final Record r

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907965067 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java: ## @@ -148,55 +173,182 @@ public void process(final Record r

[GitHub] [kafka] mjsax commented on pull request #12293: KAFKA-13963: Clarified java doc for processors api

mjsax commented on PR #12293: URL: https://github.com/apache/kafka/pull/12293#issuecomment-1168118034 Thanks for the PR! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] mjsax merged pull request #12293: KAFKA-13963: Clarified java doc for processors api

mjsax merged PR #12293: URL: https://github.com/apache/kafka/pull/12293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] C0urante commented on pull request #12354: Kafka 13816: Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances

C0urante commented on PR #12354: URL: https://github.com/apache/kafka/pull/12354#issuecomment-1168045395 @vamossagar12 Unfortunately I'm still in the same spot with this ticket as I was when we discussed earlier on Jira; I don't have the time right now to dedicate to thinking through all th

[GitHub] [kafka] C0urante opened a new pull request, #12355: KAFKA-14017: Implement new KIP-618 APIs in FileStreamSourceConnector

C0urante opened a new pull request, #12355: URL: https://github.com/apache/kafka/pull/12355 [Jira](https://issues.apache.org/jira/browse/KAFKA-14017) - Implements the new `SourceConnector::exactlyOnceSupport` method in the file source connector - - When reading from stdin, returns

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907880688 ## streams/src/main/java/org/apache/kafka/streams/state/internals/SessionKeySchema.java: ## @@ -35,7 +35,7 @@ public class SessionKeySchema implements SegmentedBytesStore

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907880169 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionSegmentedBytesStore.java: ## @@ -71,6 +72,36 @@ public byte[] fetchSession(final

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907879361 ## streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedSessionKeySchemas.java: ## @@ -204,7 +203,8 @@ public static void writeBinary(final ByteBuffer bu

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907876784 ## streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java: ## @@ -39,6 +39,13 @@ */ public interface SessionStore extends StateStore, ReadOnlySessionSt

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907876120 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java: ## @@ -148,55 +173,182 @@ public void process(final Record record)

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r907875412 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java: ## @@ -148,55 +173,182 @@ public void process(final Record record)

[GitHub] [kafka] hachikuji merged pull request #12336: MINOR: Support KRaft in GroupAuthorizerIntegrationTest

hachikuji merged PR #12336: URL: https://github.com/apache/kafka/pull/12336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Assigned] (KAFKA-14020) Performance regression in Producer

[ https://issues.apache.org/jira/browse/KAFKA-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Livshits reassigned KAFKA-14020: -- Assignee: Artem Livshits > Performance regression in Producer > -

[jira] [Updated] (KAFKA-14029) Consumer response serialization could block other response handlers at scale

[ https://issues.apache.org/jira/browse/KAFKA-14029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BugFinder updated KAFKA-14029: -- Priority: Minor (was: Blocker) > Consumer response serialization could block other response handlers

[jira] [Created] (KAFKA-14029) Consumer response serialization could block other response handlers at scale

BugFinder created KAFKA-14029: - Summary: Consumer response serialization could block other response handlers at scale Key: KAFKA-14029 URL: https://issues.apache.org/jira/browse/KAFKA-14029 Project: Kafka

[GitHub] [kafka] hachikuji commented on a diff in pull request #12265: KAFKA-13968: Fix 3 major bugs of KRaft snapshot generating

hachikuji commented on code in PR #12265: URL: https://github.com/apache/kafka/pull/12265#discussion_r907665218 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -117,26 +117,30 @@ class BrokerMetadataListener( } finally { reader.cl

[GitHub] [kafka] hachikuji commented on a diff in pull request #12265: KAFKA-13968: Fix 3 major bugs of KRaft snapshot generating

hachikuji commented on code in PR #12265: URL: https://github.com/apache/kafka/pull/12265#discussion_r907665218 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -117,26 +117,30 @@ class BrokerMetadataListener( } finally { reader.cl

[GitHub] [kafka] dajac commented on a diff in pull request #12337: KAFKA-10199: Remove main consumer from store changelog reader

dajac commented on code in PR #12337: URL: https://github.com/apache/kafka/pull/12337#discussion_r907667527 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsOptions.java: ## @@ -44,10 +45,21 @@ public ListConsumerGroupOffsetsOptions topicPartition

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12337: KAFKA-10199: Remove main consumer from store changelog reader

guozhangwang commented on code in PR #12337: URL: https://github.com/apache/kafka/pull/12337#discussion_r907614971 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsOptions.java: ## @@ -44,10 +45,21 @@ public ListConsumerGroupOffsetsOptions topicPa

[GitHub] [kafka] jonathan-albrecht-ibm commented on pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

jonathan-albrecht-ibm commented on PR #12343: URL: https://github.com/apache/kafka/pull/12343#issuecomment-1167374061 Thanks for the review @Kvicii. The CI seems to have failed due to a server error and looks stuck. Could the build be restarted? -- This is an automated message from the A

[jira] [Created] (KAFKA-14028) Add audit log in kafka server when clients try to fetch

Justinwins created KAFKA-14028: -- Summary: Add audit log in kafka server when clients try to fetch Key: KAFKA-14028 URL: https://issues.apache.org/jira/browse/KAFKA-14028 Project: Kafka Issue Typ

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12297: KAFKA-13846: Follow up PR to address review comments

vamossagar12 commented on code in PR #12297: URL: https://github.com/apache/kafka/pull/12297#discussion_r907329980 ## docs/upgrade.html: ## @@ -19,6 +19,56 @@

[jira] [Created] (KAFKA-14027) org.apache.kafka.connect.mirror.MirrorClient class clean up

Justinwins created KAFKA-14027: -- Summary: org.apache.kafka.connect.mirror.MirrorClient class clean up Key: KAFKA-14027 URL: https://issues.apache.org/jira/browse/KAFKA-14027 Project: Kafka Issu

[jira] [Assigned] (KAFKA-13972) Reassignment cancellation causes stray replicas

[ https://issues.apache.org/jira/browse/KAFKA-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-13972: --- Assignee: Jason Gustafson > Reassignment cancellation causes stray replicas > -

[GitHub] [kafka] vamossagar12 commented on pull request #12354: Kafka 13816: Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances

vamossagar12 commented on PR #12354: URL: https://github.com/apache/kafka/pull/12354#issuecomment-1167282139 @C0urante , This is an initial cut of the PR which is based off the initial cut that you had created. I have added test to verify the case where Leader fails to read the config topic

[GitHub] [kafka] vamossagar12 opened a new pull request, #12354: Kafka 13816: Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances

vamossagar12 opened a new pull request, #12354: URL: https://github.com/apache/kafka/pull/12354 Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances. This PR aims to address this issue . -- This is an automated message from the Apache Git Serv

[jira] [Created] (KAFKA-14026) ConsumerGroupReplicationPolicy (counterpart to DefaultReplicationPolicy for topic) can be added

Justinwins created KAFKA-14026: -- Summary: ConsumerGroupReplicationPolicy (counterpart to DefaultReplicationPolicy for topic) can be added Key: KAFKA-14026 URL: https://issues.apache.org/jira/browse/KAFKA-14026

[jira] [Updated] (KAFKA-13911) Rate is calculated as NaN for minimum config values

[ https://issues.apache.org/jira/browse/KAFKA-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-13911: - Fix Version/s: 3.3.0 > Rate is calculated as NaN for minimum config values > ---

[jira] [Updated] (KAFKA-13943) Fix flaky test QuorumControllerTest.testMissingInMemorySnapshot()

[ https://issues.apache.org/jira/browse/KAFKA-13943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-13943: - Issue Type: Bug (was: Test) > Fix flaky test QuorumControllerTest.testMissingInMemorySnapshot()

[GitHub] [kafka] RivenSun2 opened a new pull request, #12353: MINOR: Add indent space after hyperlink

RivenSun2 opened a new pull request, #12353: URL: https://github.com/apache/kafka/pull/12353 Add indent space after hyperlink ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Ver

[GitHub] [kafka] dev-chulbuji commented on pull request #12316: MINOR: Include kafka record inside RecordDeserializationException

dev-chulbuji commented on PR #12316: URL: https://github.com/apache/kafka/pull/12316#issuecomment-1167111435 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Commented] (KAFKA-13978) Trigger UncaughtExceptionHandler for IllegalArgument and IllegalState exceptions

[ https://issues.apache.org/jira/browse/KAFKA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559086#comment-17559086 ] Ben commented on KAFKA-13978: - Thanks! PR is up - though I had some CI issues which don't se

[GitHub] [kafka] aiquestion commented on pull request #12348: KAFKA-14016: Revoke more partitions than expected in Cooperative rebalance

aiquestion commented on PR #12348: URL: https://github.com/apache/kafka/pull/12348#issuecomment-1167098794 @showuon Yes. And Cooperative rebalance will make REBALANCE_IN_PROGRESS happens more often, because: after every consumer joined the group (joinGroupResponse) and leader send sync

[GitHub] [kafka] Smeb commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers

Smeb commented on PR #12352: URL: https://github.com/apache/kafka/pull/12352#issuecomment-1167014927 CI appears to timeout but I don't see how it could be related to my changes - I can also see that's the case for a lot of other PRs. -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] Smeb opened a new pull request, #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers

Smeb opened a new pull request, #12352: URL: https://github.com/apache/kafka/pull/12352 Previously `IllegalArgumentException` and `IllegalStateException` errors would always trigger an application shutdown. With this change those errors are treated the same as all other exceptions thrown wh

[jira] [Commented] (KAFKA-13997) one partition logs are not getting purged

[ https://issues.apache.org/jira/browse/KAFKA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559035#comment-17559035 ] Naveen P commented on KAFKA-13997: -- After following step 4 from below link issue was re

[jira] [Commented] (KAFKA-14024) Consumer keeps Commit offset in onJoinPrepare in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559024#comment-17559024 ] Luke Chen commented on KAFKA-14024: --- I see. Let's add some tests to make sure it won't