showuon commented on PR #12349:
URL: https://github.com/apache/kafka/pull/12349#issuecomment-1188561057
@aiquestion , since we already fixed the bug and other comments are just
refactoring it, I think we can fix the broken tests and merge it for now. And
then you create a follow-up PR to ad
showuon commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r924022486
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,6 +1377,178 @@ public void
testForceMetadataDeleteForPatt
showuon commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r923994624
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -740,24 +746,59 @@ private void validateCooperativeAssignment(final
guozhangwang commented on PR #12387:
URL: https://github.com/apache/kafka/pull/12387#issuecomment-1188468959
Thanks @cadonna ! I incorporated your comments and also added more tests.
Since I've not merged the previous one the diff should be clearer to review now.
--
This is an automated m
guozhangwang commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r923961624
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -428,6 +456,113 @@ private void shouldRemoveStatefulTask(f
guozhangwang commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r923952181
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -428,6 +456,113 @@ private void shouldRemoveStatefulTask(f
guozhangwang commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r923950586
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -47,6 +49,16 @@ public static TaskAndAction createRemoveTask(final T
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r923947288
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -652,6 +652,11 @@ void write(KafkaChannel channel) throws IOException {
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923946004
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if (log.
guozhangwang commented on PR #12386:
URL: https://github.com/apache/kafka/pull/12386#issuecomment-1188443250
@cadonna Thanks for the detailed review! I've incorporated them into this PR
and merged it.
Please feel free to leave more comments if you like, and I will rebase and
incorpor
guozhangwang merged PR #12386:
URL: https://github.com/apache/kafka/pull/12386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923943042
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if (log.
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r923925602
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/KAFKA-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim updated KAFKA-14075:
-
Description:
In
[GroupMetadata.removeAllOffsets()|https://github.com/apache/kafka/blob/trunk/core/src/m
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923921791
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -520,6 +568,8 @@ private Stream getStreamOfTasks() {
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923919872
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java:
##
@@ -94,6 +94,19 @@ public int hashCode() {
*/
void remove(fin
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923916317
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -498,6 +575,66 @@ private void shouldNotRemoveTaskFromFail
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923915840
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -428,6 +456,55 @@ private void shouldRemoveStatefulTask(fi
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923914613
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -267,8 +276,31 @@ private void removeTask(final TaskId taskId)
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923909025
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -983,6 +1120,27 @@ private void verifyRemovedTasks(final T
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923908100
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -143,6 +142,27 @@ public void shouldThrowIfStandbyTaskNotI
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923903522
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -1012,6 +1170,22 @@ private void verifyExceptionsAndFailed
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923900844
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -983,6 +1120,27 @@ private void verifyRemovedTasks(final T
[
https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-14079.
---
Reviewer: Randall Hauch
Resolution: Fixed
> Source task will not commit offsets and de
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923900551
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -143,6 +142,27 @@ public void shouldThrowIfStandbyTaskNotI
rhauch merged PR #12415:
URL: https://github.com/apache/kafka/pull/12415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923899776
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -55,7 +61,7 @@ public Task getTask() {
}
public TaskId g
rhauch merged PR #12412:
URL: https://github.com/apache/kafka/pull/12412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923898981
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -47,6 +48,11 @@ public static TaskAndAction createRemoveTask(final T
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923898461
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -267,8 +276,31 @@ private void removeTask(final TaskId taskId)
guozhangwang commented on PR #12386:
URL: https://github.com/apache/kafka/pull/12386#issuecomment-1188363535
> Currently, it is not clear to me if we also need to consider the case were
a task is paused before it is added to the state updater? Such a situation
might happen when a Kafka Stre
junrao commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923872243
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if (log
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923872451
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if (log.
[
https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-14079:
--
Priority: Critical (was: Major)
> Source task will not commit offsets and develops memory lea
mjsax commented on PR #12420:
URL: https://github.com/apache/kafka/pull/12420#issuecomment-1188316135
Thanks for the fix! Merged to `trunk` and cherry-picked to `3.3` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cmccabe commented on PR #12196:
URL: https://github.com/apache/kafka/pull/12196#issuecomment-1188314543
> @cmccabe is there a JIRA for this?
I created KAFKA-14084 for this. The message types and so on are spelled out
in KIP-631, I believe.
> Are you intending to implement suppo
mjsax merged PR #12420:
URL: https://github.com/apache/kafka/pull/12420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
Colin McCabe created KAFKA-14084:
Summary: Support SCRAM when using KRaft mode
Key: KAFKA-14084
URL: https://issues.apache.org/jira/browse/KAFKA-14084
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14084:
-
Labels: kip-500 (was: )
> Support SCRAM when using KRaft mode
> ---
cmccabe commented on PR #12278:
URL: https://github.com/apache/kafka/pull/12278#issuecomment-1188304891
It is part of the Authorizer KIP, but slipped from 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
cmccabe commented on PR #12403:
URL: https://github.com/apache/kafka/pull/12403#issuecomment-1188236978
So, we definitely need to get rid of the calls to *.get* and other cases of
needless blocking. There are definitely some cases where we aren't properly
handling errors as well (this is re
artemlivshits commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923725627
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
Artem Livshits created KAFKA-14083:
--
Summary: Check if we don't need to refresh time in
RecordAccumulator.append
Key: KAFKA-14083
URL: https://issues.apache.org/jira/browse/KAFKA-14083
Project: Kafka
wcarlson5 commented on PR #12324:
URL: https://github.com/apache/kafka/pull/12324#issuecomment-1188229295
@ableegoldman looks like i had a small issue fixed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/KAFKA-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568179#comment-17568179
]
Colin McCabe commented on KAFKA-13743:
--
The PR was merged, just not through the git
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568178#comment-17568178
]
Colin McCabe commented on KAFKA-13470:
--
We do not include the controller listener i
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13470:
-
Description: It should be possible to configure the controller to use
secure ports. We need a ju
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13470:
-
Priority: Major (was: Critical)
> Test the handling of secure controller ports
> --
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13470:
-
Issue Type: Improvement (was: Bug)
> Test the handling of secure controller ports
> ---
wcarlson5 opened a new pull request, #12421:
URL: https://github.com/apache/kafka/pull/12421
…r (#11228)"
This reverts commit 4835c64f
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
mumrah commented on PR #12349:
URL: https://github.com/apache/kafka/pull/12349#issuecomment-1188068663
@aiquestion looks like you've got a few test failures
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-12349/11/tests
--
This is an automated message fr
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568153#comment-17568153
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on PR #420:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568117#comment-17568117
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
Ge opened a new pull request, #12420:
URL: https://github.com/apache/kafka/pull/12420
This commit changes the version check from` !=` to `>` as the `process`
method
works correctly on both version 1 and 2. `!=` incorrectly throws on v1
records.
*Summary of testing strategy (
jolshan commented on PR #12378:
URL: https://github.com/apache/kafka/pull/12378#issuecomment-1187722165
I'm not sure I follow why this happens though -- can you share an example of
one of the logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568110#comment-17568110
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
FreerXY commented on code in PR #12419:
URL: https://github.com/apache/kafka/pull/12419#discussion_r923577568
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -297,10 +291,18 @@ private void syncTopicAcls()
private void syn
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568102#comment-17568102
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568101#comment-17568101
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
FreerXY commented on PR #12419:
URL: https://github.com/apache/kafka/pull/12419#issuecomment-1187700242
Fix Mirror Maker 2.0 sync topic configs need more validly ,linking:
https://issues.apache.org/jira/browse/KAFKA-14082
--
This is an automated message from the Apache Git Service.
To res
FreerXY opened a new pull request, #12419:
URL: https://github.com/apache/kafka/pull/12419
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
xiaoyao qu created KAFKA-14082:
--
Summary: Mirror Maker 2.0 sync topic configs need more validly
Key: KAFKA-14082
URL: https://issues.apache.org/jira/browse/KAFKA-14082
Project: Kafka
Issue Type
franz1981 commented on PR #12163:
URL: https://github.com/apache/kafka/pull/12163#issuecomment-1187692857
I've updated the PR, let me know if there're other concerns I can address
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568078#comment-17568078
]
Kirk True commented on KAFKA-14081:
---
Would you be able to share steps and/or some code
clolov commented on PR #12418:
URL: https://github.com/apache/kafka/pull/12418#issuecomment-1187678788
@mimaison I believe you might be best suited to review this pull request :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
clolov opened a new pull request, #12418:
URL: https://github.com/apache/kafka/pull/12418
Partially addressing https://issues.apache.org/jira/browse/KAFKA-13414.
Other test files will be updated in other pull requests.
--
This is an automated message from the Apache Git Service.
To respon
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568071#comment-17568071
]
Jim Hughes commented on KAFKA-13217:
[~jagsancio] I've got a PR up to try and fix th
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923511503
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
Gian Luca created KAFKA-14081:
-
Summary: Cannot get my MetricsReporter implementation to receive
meaningful metrics
Key: KAFKA-14081
URL: https://issues.apache.org/jira/browse/KAFKA-14081
Project: Kafka
cadonna commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r923475558
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -55,7 +67,7 @@ public Task getTask() {
}
public TaskId getTas
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923506717
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -498,6 +575,66 @@ private void shouldNotRemoveTaskFromFailedTas
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923506434
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -498,6 +575,66 @@ private void shouldNotRemoveTaskFromFailedTas
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923506009
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -983,6 +1120,27 @@ private void verifyRemovedTasks(final Task..
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923502725
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923500547
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mimaison commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923498937
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
}
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568060#comment-17568060
]
ASF GitHub Bot commented on KAFKA-13868:
tombentley commented on code in PR #421
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923486565
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -168,6 +171,8 @@ private boolean isTransitionValid(State source, Sta
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923486245
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -728,18 +779,11 @@ synchronized void maybeResolveSequences() {
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r923485781
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1413,10 +1458,55 @@ public void testOnJoinPrepareWithOffsetC
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r923485561
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1413,10 +1458,55 @@ public void testOnJoinPrepareWithOffsetC
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923484438
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923482851
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -241,12 +246,39 @@ synchronized TransactionalRequestResult
initiali
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568046#comment-17568046
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923463164
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -520,6 +568,8 @@ private Stream getStreamOfTasks() {
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568029#comment-17568029
]
ASF GitHub Bot commented on KAFKA-13868:
tombentley commented on code in PR #421
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568026#comment-17568026
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison commented on code in PR #421:
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923431888
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -206,6 +206,39 @@ class KafkaConfigTest {
assertBadConfigContainingMessage(props, "Each lis
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568025#comment-17568025
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison commented on PR #421:
URL: htt
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923282700
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -267,8 +276,31 @@ private void removeTask(final TaskId taskId) {
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923366063
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1187401803
@tombentley @mimaison I have gone through each of the review comments and
submitted the requested changes and marked them as resolved, only one comment
is still outstanding.
--
This
1 - 100 of 122 matches
Mail list logo
