swathi mocharla created KAFKA-14092:
---
Summary: Unsafe memory access operation exception leading to Error
processing append operation on partition
Key: KAFKA-14092
URL: https://issues.apache.org/jira/browse/KAFKA
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13217:
Labels: kip newbie newbie++ (was: needs-kip newbie newbie++)
> Reconsider skipping the Le
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13217:
Description:
In Kafka Streams, when an instance is shut down via the close() API, we
inte
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569283#comment-17569283
]
Matthias J. Sax commented on KAFKA-13217:
-
Just reviewed the PR and linked the t
[
https://issues.apache.org/jira/browse/KAFKA-14076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569282#comment-17569282
]
Matthias J. Sax commented on KAFKA-14076:
-
Marking this as blocker for 3.3, beca
[
https://issues.apache.org/jira/browse/KAFKA-14076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14076:
Priority: Blocker (was: Major)
> Fix issues with KafkaStreams.CloseOptions
>
[
https://issues.apache.org/jira/browse/KAFKA-14076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14076:
Fix Version/s: 3.3.0
> Fix issues with KafkaStreams.CloseOptions
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-14076:
---
Assignee: Jim Hughes
> Fix issues with KafkaStreams.CloseOptions
>
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r926285132
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r926217527
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r926216992
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
dengziming commented on PR #12294:
URL: https://github.com/apache/kafka/pull/12294#issuecomment-1190983840
cc @mumrah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r926201391
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,17 +1300,79 @@ public void
testForceMetadataDeleteForP
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r926113246
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1516,48 +1520,41 @@ public synchronized boolean close(final Duration
timeout) throws IllegalAr
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r926113971
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
splett2 commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r926147113
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,98 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests for KAFKA-1
C0urante commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r926146499
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569204#comment-17569204
]
Chris Egerton edited comment on KAFKA-14089 at 7/20/22 11:41 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569204#comment-17569204
]
Chris Egerton edited comment on KAFKA-14089 at 7/20/22 11:28 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569204#comment-17569204
]
Chris Egerton commented on KAFKA-14089:
---
Thanks [~mimaison]. We don't assert on or
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14089:
-
Assignee: Chris Egerton
> Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTop
C0urante commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1190816405
Ah, thanks for the update Luke! In the meantime, I've discovered and
addressed a few more issues that surfaced during my local runs yesterday:
Since follower workers don't retry wh
Chris Egerton created KAFKA-14091:
-
Summary: Suddenly-killed tasks can leave hanging transactions open
Key: KAFKA-14091
URL: https://issues.apache.org/jira/browse/KAFKA-14091
Project: Kafka
I
[
https://issues.apache.org/jira/browse/KAFKA-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13897:
-
Fix Version/s: (was: 3.2.1)
> Add 3.1.1 to system tests and streams upgrade tests
>
mumrah merged PR #12424:
URL: https://github.com/apache/kafka/pull/12424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925972749
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925971253
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
rhauch commented on code in PR #12424:
URL: https://github.com/apache/kafka/pull/12424#discussion_r925969756
##
docs/upgrade.html:
##
@@ -61,6 +61,22 @@ Upgrading to
3.2.0 from any vers
+Notable changes in
3.2.1
+
+A problem with OAuth token refresh was f
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925969588
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925966739
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1474,7 +1482,7 @@ private void closeToError() {
if (!setState(State.PENDING_ERROR)) {
Abraham Leal created KAFKA-14090:
Summary: Allow Kafka Streams to be configured to not create
internal topics
Key: KAFKA-14090
URL: https://issues.apache.org/jira/browse/KAFKA-14090
Project: Kafka
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925960794
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1431,6 +1434,10 @@ private Thread shutdownHelper(final boolean error) {
}
private b
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925952015
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1431,6 +1434,10 @@ private Thread shutdownHelper(final boolean error) {
}
private b
guozhangwang commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925945110
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java:
##
@@ -216,8 +216,9 @@ long partitionTimestamp(final TopicPartition parti
cadonna commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925917621
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java:
##
@@ -234,6 +236,43 @@ public void closeCleanAndRecycleState() {
log.in
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925895182
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1474,7 +1482,7 @@ private void closeToError() {
if (!setState(State.PENDING_ERROR)) {
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925894827
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
guozhangwang commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925892759
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java:
##
@@ -234,6 +236,43 @@ public void closeCleanAndRecycleState() {
l
guozhangwang commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925882848
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##
@@ -34,29 +33,40 @@
import java.util.TreeMap;
import java.util.stream.Collect
guozhangwang commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925881686
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java:
##
@@ -55,25 +57,28 @@ public abstract class AbstractTask implements Task {
guozhangwang commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925880702
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1307,9 +1307,9 @@ public Set characteristics() {
}
@SafeVarargs
-public st
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925862925
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
mjsax commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925862925
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
jolshan commented on PR #12378:
URL: https://github.com/apache/kafka/pull/12378#issuecomment-1190539986
Ah looks like the issue is that the oldID is null (not the new ID).
As described by this comment:
```
// If the new topic ID is valid and different from the l
[
https://issues.apache.org/jira/browse/KAFKA-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569115#comment-17569115
]
Divij Vaidya commented on KAFKA-13700:
--
cc: [~junrao] for visibility since he is an
[
https://issues.apache.org/jira/browse/KAFKA-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569114#comment-17569114
]
Divij Vaidya commented on KAFKA-13700:
--
Few questions to understand the situation b
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925809931
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925808463
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925805004
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925804504
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r925804187
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569104#comment-17569104
]
Doguscan Namal commented on KAFKA-13953:
[~junrao]
1) The DumpLogSegment tool
[
https://issues.apache.org/jira/browse/KAFKA-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-14020.
-
Resolution: Fixed
merged the PR to 3.3.
> Performance regression in Producer
>
junrao commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1190432816
cherry-picked the PR to 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
junrao merged PR #12365:
URL: https://github.com/apache/kafka/pull/12365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
rhauch commented on code in PR #12424:
URL: https://github.com/apache/kafka/pull/12424#discussion_r925721375
##
docs/upgrade.html:
##
@@ -61,6 +61,20 @@ Upgrading to
3.2.0 from any vers
+Notable changes in
3.2.1
+
+A problem with OAuth token refresh was f
mumrah opened a new pull request, #12424:
URL: https://github.com/apache/kafka/pull/12424
Looking through the issues fixed in
https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.2.1, I didn't
see any changes to public APIs (config/metrics/CLI/etc) or any changes to
default beh
[
https://issues.apache.org/jira/browse/KAFKA-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569027#comment-17569027
]
David Arthur commented on KAFKA-14002:
--
Removing 3.2.1 from the fix version.
> Upd
[
https://issues.apache.org/jira/browse/KAFKA-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14002:
-
Fix Version/s: (was: 3.2.1)
> Update Zookeeper client version to 3.8.0
> ---
showuon commented on PR #12347:
URL: https://github.com/apache/kafka/pull/12347#issuecomment-1190273171
@tombentley , I've addressed your comments in this commit:
https://github.com/apache/kafka/pull/12347/commits/42cd5ac41eb2cc83548066ea053dad47a0eddd22
. Thank you.
--
This is an automa
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r925591743
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -307,6 +309,27 @@ class LogManager(logDirs: Seq[File],
log
}
+ // factory class for naming the log re
showuon commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1190242675
@C0urante , my team members are trying to configure the testing environment
to run a system test against this branch. But it still needs some time.
@jsancio , it would be great if y
cadonna commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r925471614
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1307,9 +1307,9 @@ public Set characteristics() {
}
@SafeVarargs
-public static
urbandan commented on PR #12392:
URL: https://github.com/apache/kafka/pull/12392#issuecomment-1190135063
@showuon @artemlivshits Can you please take a look at this PR? This is the
issue we had a thread about on the dev list.
--
This is an automated message from the Apache Git Service.
To
viktorsomogyi commented on PR #12392:
URL: https://github.com/apache/kafka/pull/12392#issuecomment-1190132574
@hachikuji would you please review this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Mickael Maison created KAFKA-14089:
--
Summary: Flaky
ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic
Key: KAFKA-14089
URL: https://issues.apache.org/jira/browse/KAFKA-14089
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568972#comment-17568972
]
Mickael Maison commented on KAFKA-14089:
cc [~ChrisEgerton]
> Flaky ExactlyOnce
tombentley commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r925348863
##
core/src/main/scala/kafka/log/LogLoader.scala:
##
@@ -64,6 +65,7 @@ object LogLoader extends Logging {
* @param recoveryPointCheckpoint The checkpoint of the off
showuon commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190089583
Only doc change, so don't need to worry about test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mimaison closed pull request #11838: KAFKA-1372: separate 400 error from 500
error in RestClient
URL: https://github.com/apache/kafka/pull/11838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mimaison commented on PR #11838:
URL: https://github.com/apache/kafka/pull/11838#issuecomment-1190089277
We merged https://github.com/apache/kafka/pull/12320, so closing this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
showuon merged PR #12401:
URL: https://github.com/apache/kafka/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mimaison closed pull request #11844: KAFKA#13702 - Connect RestClient overrides
response status code on request failure
URL: https://github.com/apache/kafka/pull/11844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mimaison commented on PR #11844:
URL: https://github.com/apache/kafka/pull/11844#issuecomment-1190088514
We merged https://github.com/apache/kafka/pull/12320, so closing this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-13702.
Fix Version/s: 3.4.0
Resolution: Fixed
> Connect RestClient overrides response stat
[
https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568965#comment-17568965
]
Ismael Juma commented on KAFKA-13158:
-
Updated the Jira title to only refer to Conne
[
https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13158:
Summary: Replace EasyMock and PowerMock with Mockito for
ConnectClusterStateImplTest (was: Replac
ijuma commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r925416275
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {
fvaleri commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190050259
> > I think that's redundant information and most of the other images don't
have a title. That said, I'm not against adding it back, it's just a matter of
preference.
>
> Yes, I ag
mimaison merged PR #12320:
URL: https://github.com/apache/kafka/pull/12320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-13158:
--
Labels: connect runtime (was: a)
> Replace EasyMock and PowerMock with Mockito for ConnectClu
[
https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-13158:
--
Labels: a (was: connect runtime)
> Replace EasyMock and PowerMock with Mockito for ConnectClu
[
https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-13158:
-
Assignee: Christo Lolov (was: YI-CHEN WANG)
> Replace EasyMock and PowerMock with Mock
clolov commented on PR #12423:
URL: https://github.com/apache/kafka/pull/12423#issuecomment-1190043748
Hi @C0urante hopefully another quick review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
clolov opened a new pull request, #12423:
URL: https://github.com/apache/kafka/pull/12423
Addressing https://issues.apache.org/jira/browse/KAFKA-13158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cadonna commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1190036847
@clolov could you please rebase your PR since there are conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
cadonna commented on code in PR #12285:
URL: https://github.com/apache/kafka/pull/12285#discussion_r925333066
##
streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java:
##
@@ -52,36 +52,46 @@
import static org.hamcrest.CoreMatchers.equalTo;
[
https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568944#comment-17568944
]
Christo Lolov commented on KAFKA-13158:
---
ConnectorPluginsResourceTest appears to h
clolov commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r925346037
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {
clolov commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r925345205
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {
showuon commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190003899
> I think that's redundant information and most of the other images don't
have a title. That said, I'm not against adding it back, it's just a matter of
preference.
Yes, I agree. B
clolov commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r925339313
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -144,10 +149,6 @@ public void subscribe(String path, Set keys,
clolov commented on code in PR #12422:
URL: https://github.com/apache/kafka/pull/12422#discussion_r925337713
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java:
##
@@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {
clolov commented on PR #12409:
URL: https://github.com/apache/kafka/pull/12409#issuecomment-1189989887
I find this refactor quite readable. Looks good to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568922#comment-17568922
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison merged PR #424:
URL: https://g
clolov commented on PR #12410:
URL: https://github.com/apache/kafka/pull/12410#issuecomment-1189957440
Looks great to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ijuma commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189943978
@junrao the updated version looks good to me. Thanks @artemlivshits for the
patience and iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message
97 matches
Mail list logo
