ijuma commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1193073368
For other modules, we did the JUnit 5 migration in one PR to avoid this
problem. As @divijvaidya mentioned, the build expects each module to be JUnit 4
or JUnit 5.
--
This is an automate
C0urante opened a new pull request, #12433:
URL: https://github.com/apache/kafka/pull/12433
Largely copied from
[Jira](https://issues.apache.org/jira/browse/KAFKA-14093):
The Javadoc for the `testFencedLeaderRecovery` test case calls out that it
uses a one-node cluster, and the [chec
[
https://issues.apache.org/jira/browse/KAFKA-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570169#comment-17570169
]
Chris Egerton edited comment on KAFKA-14093 at 7/22/22 8:24 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570169#comment-17570169
]
Chris Egerton commented on KAFKA-14093:
---
Think the root cause of this is rather si
Chris Egerton created KAFKA-14098:
-
Summary: Internal Kafka clients used by Kafka Connect should have
distinguishable client IDs
Key: KAFKA-14098
URL: https://issues.apache.org/jira/browse/KAFKA-14098
[
https://issues.apache.org/jira/browse/KAFKA-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14098:
--
Priority: Minor (was: Major)
> Internal Kafka clients used by Kafka Connect should have disti
mimaison opened a new pull request, #12432:
URL: https://github.com/apache/kafka/pull/12432
We should not treat UNKNOWN_MEMBER_ID and FENCED_INSTANCE_ID as unexpected
errors in the Admin client. In MirrorMaker, check the result of committing
offsets and log an useful error message in case t
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570138#comment-17570138
]
Mickael Maison commented on KAFKA-13868:
I think we've addressed all issues apar
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570136#comment-17570136
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison merged PR #420:
URL: https://g
jonathan-albrecht-ibm commented on PR #12343:
URL: https://github.com/apache/kafka/pull/12343#issuecomment-1192747607
Hi @Kvicii, I have rebased this PR to trigger the tests. It looks like
everything that ran passed except for 2 instances of
```
Build / JDK 8 and Scala 2.12 / testFence
dstelljes commented on PR #12295:
URL: https://github.com/apache/kafka/pull/12295#issuecomment-1192603682
@rhauch I see you merged a couple Connect pulls lately; can I bug you for
this one as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r927594387
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,63 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
akatona84 commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r927554756
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -329,6 +334,48 @@ public Set createTopics(NewTopic... topics) {
return c
[
https://issues.apache.org/jira/browse/KAFKA-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569945#comment-17569945
]
Nitish Jain commented on KAFKA-7656:
Hi [~efpe]/Team,
I know this is a very old issu
lhunyady commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r927540197
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -329,6 +334,48 @@ public Set createTopics(NewTopic... topics) {
return cr
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r927540567
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,63 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r927539871
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,63 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r927539567
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,63 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r927536939
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -741,12 +741,15 @@ object KafkaConfig {
/** * Socket Server Configuration ***/
val
divijvaidya commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1192428154
Hey @clolov @cadonna
Yes, I have figured out why the newly converted tests to JUnit5 are not
running. There are two reasons to it:
1. There is an overall block to use JUnit5 for
[
https://issues.apache.org/jira/browse/KAFKA-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569927#comment-17569927
]
Martin Pelak commented on KAFKA-2427:
-
Hi, if you are a Windows user, you can use a f
[
https://issues.apache.org/jira/browse/KAFKA-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569926#comment-17569926
]
Martin Pelak commented on KAFKA-9458:
-
Hi, if you are a Windows user, you can use a f
[
https://issues.apache.org/jira/browse/KAFKA-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569924#comment-17569924
]
Martin Pelak commented on KAFKA-8145:
-
Hi, if you are a Windows user, you can use a f
[
https://issues.apache.org/jira/browse/KAFKA-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569923#comment-17569923
]
Martin Pelak commented on KAFKA-6200:
-
Hi, if you are a Windows user, you can use a f
[
https://issues.apache.org/jira/browse/KAFKA-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569922#comment-17569922
]
Martin Pelak commented on KAFKA-6188:
-
Hi, if you are a Windows user, you can use a f
[
https://issues.apache.org/jira/browse/KAFKA-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569921#comment-17569921
]
Martin Pelak commented on KAFKA-6059:
-
Hi, if you are a Windows user, you can use a f
[
https://issues.apache.org/jira/browse/KAFKA-14088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569873#comment-17569873
]
Ismael Juma edited comment on KAFKA-14088 at 7/22/22 9:08 AM:
nicolasguyomar opened a new pull request, #12431:
URL: https://github.com/apache/kafka/pull/12431
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-14088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569873#comment-17569873
]
Ismael Juma commented on KAFKA-14088:
-
2.2.1 is very old, do yo see this behavior wi
showuon commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r927372305
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,63 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
}
mnegodaev commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1192297843
@rhauch @mimaison @kkonstantine @pjmagee FYI I've
[started](https://lists.apache.org/thread/3hkd9lljobf9rl56ogjpcbo4ldoxcz5n) a
[DISCUSS] thread on the Apache mailing list for
[KIP-855
etolbakov opened a new pull request, #12430:
URL: https://github.com/apache/kafka/pull/12430
Hello, @artemlivshits
As discussed in https://github.com/apache/kafka/pull/12365
the minor enhancement related to changing method visibility.
--
Regards, Eugene
--
This is an au
urbandan commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r927368455
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -329,6 +334,48 @@ public Set createTopics(NewTopic... topics) {
return cr
33 matches
Mail list logo
