[GitHub] [kafka] zigarn commented on pull request #12434: KAFKA-14099 - Fix request logs in connect

2022-07-25 Thread GitBox
zigarn commented on PR #12434: URL: https://github.com/apache/kafka/pull/12434#issuecomment-1195083745 Thanks @C0urante for the feedback. No problem for the issue in the first place, I guess not many people were impacted by this as nobody raised this issue. I'm more concerned about

[jira] [Commented] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571214#comment-17571214 ] Tom Bentley commented on KAFKA-14101: - [~ChrisEgerton] I wonder whether we should re

[jira] [Created] (KAFKA-14106) Fetcher thread was shutdown and all fetched partitions are lost.

2022-07-25 Thread Yang Ling (Jira)
Yang Ling created KAFKA-14106: - Summary: Fetcher thread was shutdown and all fetched partitions are lost. Key: KAFKA-14106 URL: https://issues.apache.org/jira/browse/KAFKA-14106 Project: Kafka I

[GitHub] [kafka] C0urante commented on pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-07-25 Thread GitBox
C0urante commented on PR #12019: URL: https://github.com/apache/kafka/pull/12019#issuecomment-1194881570 Converting this to a draft since I haven't had time to prioritize it (sorry @YeonCheolGit!) and the changes here are not safe to merge as-are. -- This is an automated message from the

[GitHub] [kafka] showuon commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1194872263 @mimaison @tombentley , do you want to have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929446869 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,62 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Priority: Blocker (was: Major) > (SASL/OAUTHBEARER) multiple applications in one JVM process, only th

[jira] [Updated] (KAFKA-14090) Allow Kafka Streams to be configured to not create internal topics

2022-07-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14090: Component/s: streams (was: clients) > Allow Kafka Streams to be confi

[jira] [Comment Edited] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571130#comment-17571130 ] Chris Egerton edited comment on KAFKA-14101 at 7/25/22 11:43 PM: -

[jira] [Comment Edited] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571130#comment-17571130 ] Chris Egerton edited comment on KAFKA-14101 at 7/25/22 11:39 PM: -

[jira] [Commented] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571130#comment-17571130 ] Chris Egerton commented on KAFKA-14101: --- Thanks, [~mimaison]. I believe this is du

[GitHub] [kafka] C0urante commented on a diff in pull request #12429: KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test

2022-07-25 Thread GitBox
C0urante commented on code in PR #12429: URL: https://github.com/apache/kafka/pull/12429#discussion_r929381705 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java: ## @@ -826,15 +830,22 @@ public void testSeparateOffsetsTop

[GitHub] [kafka] C0urante commented on a diff in pull request #12429: KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test

2022-07-25 Thread GitBox
C0urante commented on code in PR #12429: URL: https://github.com/apache/kafka/pull/12429#discussion_r929381599 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java: ## @@ -768,27 +767,32 @@ public void testSeparateOffsetsTop

[GitHub] [kafka] C0urante commented on a diff in pull request #12429: KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test

2022-07-25 Thread GitBox
C0urante commented on code in PR #12429: URL: https://github.com/apache/kafka/pull/12429#discussion_r929381491 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -217,6 +217,9 @@ protected void finalOffsetCommit(boolean fail

[GitHub] [kafka] guozhangwang commented on pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-25 Thread GitBox
guozhangwang commented on PR #12439: URL: https://github.com/apache/kafka/pull/12439#issuecomment-1194710146 Ping @cadonna for reviews, especially about 4) above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-14099) No REST API request logs in Kafka connect

2022-07-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571115#comment-17571115 ] Chris Egerton commented on KAFKA-14099: --- [~zigarn] Since you filed a PR to address

[GitHub] [kafka] C0urante commented on pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-07-25 Thread GitBox
C0urante commented on PR #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-1194686456 @mimaison I've finally gotten around to rebasing this one, mind taking another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] badaiaqrandista commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-25 Thread GitBox
badaiaqrandista commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r929322796 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,93 @@ class SocketServerTest { }, false) } + /** + * Tests for

[GitHub] [kafka] badaiaqrandista commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-25 Thread GitBox
badaiaqrandista commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r929319425 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,93 @@ class SocketServerTest { }, false) } + /** + * Tests for

[GitHub] [kafka] badaiaqrandista commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-25 Thread GitBox
badaiaqrandista commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r929317899 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,93 @@ class SocketServerTest { }, false) } + /** + * Tests for

[jira] [Comment Edited] (KAFKA-13559) The broker's ProduceResponse may be delayed for 300ms

2022-07-25 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571100#comment-17571100 ] Badai Aqrandista edited comment on KAFKA-13559 at 7/25/22 9:28 PM: ---

[jira] [Commented] (KAFKA-13559) The broker's ProduceResponse may be delayed for 300ms

2022-07-25 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571100#comment-17571100 ] Badai Aqrandista commented on KAFKA-13559: -- The sequence of events from the ser

[jira] [Created] (KAFKA-14105) Remove quorum.all_non_upgrade for system tests

2022-07-25 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-14105: - Summary: Remove quorum.all_non_upgrade for system tests Key: KAFKA-14105 URL: https://issues.apache.org/jira/browse/KAFKA-14105 Project: Kafka Issue Type:

[GitHub] [kafka] badaiaqrandista commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-25 Thread GitBox
badaiaqrandista commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r929297029 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -591,6 +591,11 @@ void pollSelectionKeys(Set selectionKeys, long n

[GitHub] [kafka] guozhangwang opened a new pull request, #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-25 Thread GitBox
guozhangwang opened a new pull request, #12439: URL: https://github.com/apache/kafka/pull/12439 1. Consolidate the task recycle procedure into a single function within the task. The current procedure now becomes: a) task.recycleStateAndConvert, at end of it the task is in `closed` while its

[jira] [Created] (KAFKA-14104) Perform CRC validation on KRaft Batch Records and Snapshots

2022-07-25 Thread Niket Goel (Jira)
Niket Goel created KAFKA-14104: -- Summary: Perform CRC validation on KRaft Batch Records and Snapshots Key: KAFKA-14104 URL: https://issues.apache.org/jira/browse/KAFKA-14104 Project: Kafka Issu

[jira] [Assigned] (KAFKA-14104) Perform CRC validation on KRaft Batch Records and Snapshots

2022-07-25 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel reassigned KAFKA-14104: -- Assignee: Niket Goel > Perform CRC validation on KRaft Batch Records and Snapshots >

[jira] [Resolved] (KAFKA-14078) Replica fetches to follower should return NOT_LEADER error

2022-07-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14078. - Resolution: Fixed > Replica fetches to follower should return NOT_LEADER error > ---

[GitHub] [kafka] hachikuji merged pull request #12411: KAFKA-14078; Do leader/epoch validation in Fetch before checking for valid replica

2022-07-25 Thread GitBox
hachikuji merged PR #12411: URL: https://github.com/apache/kafka/pull/12411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] divijvaidya commented on pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page

2022-07-25 Thread GitBox
divijvaidya commented on PR #12438: URL: https://github.com/apache/kafka/pull/12438#issuecomment-1194568297 @bbejeck @mimaison This is the second to last PR before we can close https://issues.apache.org/jira/browse/TINKERPOP-2738. The last one will migrate this code to website with 33 versi

[jira] [Assigned] (KAFKA-14099) No REST API request logs in Kafka connect

2022-07-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14099: - Assignee: Alexandre Garnier > No REST API request logs in Kafka connect > -

[GitHub] [kafka] C0urante commented on pull request #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery

2022-07-25 Thread GitBox
C0urante commented on PR #12433: URL: https://github.com/apache/kafka/pull/12433#issuecomment-1194542890 Thanks guys! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571074#comment-17571074 ] ASF GitHub Bot commented on KAFKA-13868: bbejeck merged PR #427: URL: https://gi

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571075#comment-17571075 ] ASF GitHub Bot commented on KAFKA-13868: bbejeck commented on PR #427: URL: http

[jira] [Commented] (KAFKA-12679) Rebalancing a restoring or running task may cause directory livelocking with newly created task

2022-07-25 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571042#comment-17571042 ] Divij Vaidya commented on KAFKA-12679: -- Hey [~pnahas]  I understand that it has be

[jira] [Updated] (KAFKA-12679) Rebalancing a restoring or running task may cause directory livelocking with newly created task

2022-07-25 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-12679: - Fix Version/s: 3.4.0 > Rebalancing a restoring or running task may cause directory livelocking w

[GitHub] [kafka] divijvaidya opened a new pull request, #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page

2022-07-25 Thread GitBox
divijvaidya opened a new pull request, #12438: URL: https://github.com/apache/kafka/pull/12438 As per the [discussion in the community](https://lists.apache.org/thread/p24xvbf8nkvxpbj668vc0g3x3lojsnk4), we want to replace the embedded YouTube videos with hyperlinks to satisfy the [ASF priv

[GitHub] [kafka] mimaison merged pull request #12423: KAFKA-13158: Move ConnectClusterStateImpl to use Mockito

2022-07-25 Thread GitBox
mimaison merged PR #12423: URL: https://github.com/apache/kafka/pull/12423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571021#comment-17571021 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya commented on PR #427: URL:

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571020#comment-17571020 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya opened a new pull request,

[jira] [Commented] (KAFKA-13877) Flaky RackAwarenessIntegrationTest.shouldDistributeStandbyReplicasOverMultipleClientTags

2022-07-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571014#comment-17571014 ] Guozhang Wang commented on KAFKA-13877: --- Hello [~lkokhreidze], are you still activ

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12427: KAFKA-10199: Add tasks to state updater when they are created

2022-07-25 Thread GitBox
guozhangwang commented on code in PR #12427: URL: https://github.com/apache/kafka/pull/12427#discussion_r929113602 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -136,10 +139,14 @@ private void createActiveTasks(final Map> activeTask

[GitHub] [kafka] peternied commented on pull request #12407: [BUG] Remove duplicate common.message.* from clients:test jar file

2022-07-25 Thread GitBox
peternied commented on PR #12407: URL: https://github.com/apache/kafka/pull/12407#issuecomment-1194293359 @tombentley Can you help me get this PR reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-25 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570964#comment-17570964 ] Jun Rao commented on KAFKA-13868: - Thanks, [~mimaison]. I see it now. > Website updates

[GitHub] [kafka] Gerrrr opened a new pull request, #12437: KAFKA-13769 Add tests for ForeignJoinSubscriptionProcessorSupplier

2022-07-25 Thread GitBox
Ge opened a new pull request, #12437: URL: https://github.com/apache/kafka/pull/12437 This PR introduces a test suite that could've caught the issue hotfixed in https://github.com/apache/kafka/pull/12420. ### Committer Checklist (excluded from commit message) - [ ] Verify desig

[jira] [Created] (KAFKA-14103) Check for hostnames in CoreUtils.scala

2022-07-25 Thread Matthew de Detrich (Jira)
Matthew de Detrich created KAFKA-14103: -- Summary: Check for hostnames in CoreUtils.scala Key: KAFKA-14103 URL: https://issues.apache.org/jira/browse/KAFKA-14103 Project: Kafka Issue Type

[GitHub] [kafka] mdedetrich commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1194125450 JIRA issue created at https://issues.apache.org/jira/browse/KAFKA-14103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928933278 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928918529 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928893597 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928891618 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928891618 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[jira] [Resolved] (KAFKA-14093) Flaky ExactlyOnceSourceIntegrationTest.testFencedLeaderRecovery

2022-07-25 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14093. Fix Version/s: 3.3.0 Assignee: Chris Egerton Resolution: Fixed > Flaky Exa

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928891618 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[GitHub] [kafka] showuon commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1194061491 > As mentioned above if we are on the same page then creating a JIRA issue to do additional checking to see if hosts are valid seems appropriate. Yes, please create a JIRA issue. Th

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928892036 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -206,6 +206,51 @@ class KafkaConfigTest { assertBadConfigContainingMessage(props, "Each listen

[GitHub] [kafka] mimaison commented on pull request #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery

2022-07-25 Thread GitBox
mimaison commented on PR #12433: URL: https://github.com/apache/kafka/pull/12433#issuecomment-1194059039 @jsancio I'm backporting this to 3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] mimaison merged pull request #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery

2022-07-25 Thread GitBox
mimaison merged PR #12433: URL: https://github.com/apache/kafka/pull/12433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] cadonna opened a new pull request, #12436: MINOR: Use builder for mock task in DefaultStateUpdaterTest

2022-07-25 Thread GitBox
cadonna opened a new pull request, #12436: URL: https://github.com/apache/kafka/pull/12436 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] cadonna commented on a diff in pull request #12427: KAFKA-10199: Add tasks to state updater when they are created

2022-07-25 Thread GitBox
cadonna commented on code in PR #12427: URL: https://github.com/apache/kafka/pull/12427#discussion_r928855148 ## streams/src/test/java/org/apache/kafka/test/StreamsTestUtils.java: ## @@ -273,4 +281,70 @@ public static boolean isCheckSupplierCall() { return Arrays.stream

[jira] [Assigned] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14101: - Assignee: Chris Egerton > Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Description: We have 2 web applications (A and B) will consume messages from the same Kafka Server, 

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Description: We have 2 web applications (A and B) will consume messages from the same Kafka Server, 

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928815976 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,63 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mdedetrich commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1193974612 > In that case, should we do this validation? inetAddressValidator.isValid(ep.host). It looks like we don't care about if the host is valid or not, all we want to filter out, is the nu

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928815976 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,63 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Description: We have 2 web applications (A and B) will consume messages from the same Kafka Server, 

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Description: We have 2 web applications (A and B) will consume messages from the same Kafka Server, 

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Description: We have 2 web applications (A and B) will consume messages from the same Kafka Server, 

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Description: We have 2 web applications (A and B) will consume messages from the same Kafka Server, 

[jira] [Created] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-07-25 Thread Shuo Chen (Jira)
Shuo Chen created KAFKA-14102: - Summary: (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages Key: KAFKA-14102 URL: https://issues.apache.org/jira/browse/KAFKA-1

[GitHub] [kafka] tombentley commented on a diff in pull request #12429: KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test

2022-07-25 Thread GitBox
tombentley commented on code in PR #12429: URL: https://github.com/apache/kafka/pull/12429#discussion_r928773599 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -217,6 +217,9 @@ protected void finalOffsetCommit(boolean fa

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928747703 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,57 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928747703 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,57 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928747703 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,57 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] cadonna commented on a diff in pull request #12427: KAFKA-10199: Add tasks to state updater when they are created

2022-07-25 Thread GitBox
cadonna commented on code in PR #12427: URL: https://github.com/apache/kafka/pull/12427#discussion_r928724038 ## streams/src/test/java/org/apache/kafka/test/StreamsTestUtils.java: ## @@ -273,4 +281,70 @@ public static boolean isCheckSupplierCall() { return Arrays.stream

[jira] [Commented] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570820#comment-17570820 ] Mickael Maison commented on KAFKA-14101: cc [~ChrisEgerton] > Flaky ExactlyOnce

[jira] [Created] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-25 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14101: -- Summary: Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary Key: KAFKA-14101 URL: https://issues.apache.org/jira/browse/KAFKA-14101 Project: Kafka

[GitHub] [kafka] cadonna commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-25 Thread GitBox
cadonna commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1193824200 Personally, I would prefer to make the migration incrementally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] cadonna commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-25 Thread GitBox
cadonna commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1193822849 @clolov Let's first try to make it work with the junit vintage engine. I am not clear if there is still an issue with powermock and junit5 and it seems like Streams still uses powermock.

[GitHub] [kafka] divijvaidya commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-25 Thread GitBox
divijvaidya commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1193821477 @clolov we don't have to do it in one go. We can create a new project/task in `build.gradle` which runs streams `integration tests` tagged with `@tag('integration')` using Junit5. Whe

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-25 Thread GitBox
clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1193806664 So then would you like me to coalesce https://github.com/apache/kafka/pull/12301 and https://github.com/apache/kafka/pull/12302 into one, add all remaining tests, make the changes to buil

[GitHub] [kafka] ashmeet13 commented on pull request #12414: KAFKA-14073 Logging the reason for Snapshot

2022-07-25 Thread GitBox
ashmeet13 commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1193791498 @dengziming I have made the requested changes and added the sample logs in the description of the PR. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-25 Thread GitBox
rajinisivaram commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r928627267 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,93 @@ class SocketServerTest { }, false) } + /** + * Tests for K

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

2022-07-25 Thread GitBox
ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r928623470 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -119,16 +119,24 @@ class BrokerMetadataListener( } _bytesSinceLastSnap

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928621118 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,57 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-25 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r928617296 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,57 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)