[GitHub] [kafka] dengziming commented on a diff in pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
dengziming commented on code in PR #12103: URL: https://github.com/apache/kafka/pull/12103#discussion_r953422085 ## shell/src/test/java/org/apache/kafka/shell/MetadataNodeManagerTest.java: ## @@ -336,4 +403,43 @@ public void testProducerIdsRecord() { 11000 + "",

[GitHub] [kafka] showuon commented on a diff in pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
showuon commented on code in PR #12103: URL: https://github.com/apache/kafka/pull/12103#discussion_r953430030 ## metadata/src/main/resources/common/metadata/AccessControlRecord.json: ## @@ -1,38 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one or more -// c

[jira] [Comment Edited] (KAFKA-13813) left/outer joins can wait indefinitely for emitted record with spurious record fix

2022-08-24 Thread Yves Alter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584055#comment-17584055 ] Yves Alter edited comment on KAFKA-13813 at 8/24/22 7:13 AM: -

[jira] [Commented] (KAFKA-13813) left/outer joins can wait indefinitely for emitted record with spurious record fix

2022-08-24 Thread Yves Alter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584055#comment-17584055 ] Yves Alter commented on KAFKA-13813: Same here: We use a left join with a window wit

[GitHub] [kafka] dengziming commented on a diff in pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
dengziming commented on code in PR #12103: URL: https://github.com/apache/kafka/pull/12103#discussion_r953437326 ## metadata/src/main/resources/common/metadata/AccessControlRecord.json: ## @@ -1,38 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one or more -/

[GitHub] [kafka] showuon commented on pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
showuon commented on PR #12103: URL: https://github.com/apache/kafka/pull/12103#issuecomment-1225301693 Thank you! Let's wait for the jenkins build. @jsancio , I'm going to backport this patch to 3.3 tomorrow if you have no objection. Thanks. -- This is an automated message from the Apach

[jira] [Resolved] (KAFKA-14168) Constant memory usage increase

2022-08-24 Thread zhangdong7 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdong7 resolved KAFKA-14168. Resolution: Invalid > Constant memory usage increase > -- > >

[jira] [Closed] (KAFKA-14168) Constant memory usage increase

2022-08-24 Thread zhangdong7 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdong7 closed KAFKA-14168. -- > Constant memory usage increase > -- > > Key: KAFKA-14168 >

[GitHub] [kafka] mimaison commented on pull request #12494: MINOR: Update site docs for ASF compliance

2022-08-24 Thread GitBox
mimaison commented on PR #12494: URL: https://github.com/apache/kafka/pull/12494#issuecomment-1225507751 @bbejeck Can we grab the images from https://github.com/apache/kafka-site/pull/435 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mimaison commented on pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-24 Thread GitBox
mimaison commented on PR #12046: URL: https://github.com/apache/kafka/pull/12046#issuecomment-1225644387 Thanks @tombentley! I've rebased on trunk, I'll let the CI run before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna opened a new pull request, #12554: KAFKA-10199: Handle restored tasks output by state updater

2022-08-24 Thread GitBox
cadonna opened a new pull request, #12554: URL: https://github.com/apache/kafka/pull/12554 Once the state updater restored an active task it put it into an output queue. The stream thread reads the restored active task from the the output queue and after it verified that the task is

[GitHub] [kafka] cadonna commented on pull request #12554: KAFKA-10199: Handle restored tasks output by state updater

2022-08-24 Thread GitBox
cadonna commented on PR #12554: URL: https://github.com/apache/kafka/pull/12554#issuecomment-1225647992 Call for review: @wcarlson5 @lihaosky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vpapavas opened a new pull request, #12555: Optimize self-join

2022-08-24 Thread GitBox
vpapavas opened a new pull request, #12555: URL: https://github.com/apache/kafka/pull/12555 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[GitHub] [kafka] mimaison merged pull request #12534: MINOR; Use underscore for variable initialization in Scala sources

2022-08-24 Thread GitBox
mimaison merged PR #12534: URL: https://github.com/apache/kafka/pull/12534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] cadonna commented on a diff in pull request #12554: KAFKA-10199: Handle restored tasks output by state updater

2022-08-24 Thread GitBox
cadonna commented on code in PR #12554: URL: https://github.com/apache/kafka/pull/12554#discussion_r953802616 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java: ## @@ -50,10 +50,11 @@ import static org.apache.kafka.test.StreamsTe

[GitHub] [kafka] songnon commented on a diff in pull request #12543: KAFKA-10149: Allow auto preferred leader election for partitions are not being reassigned

2022-08-24 Thread GitBox
songnon commented on code in PR #12543: URL: https://github.com/apache/kafka/pull/12543#discussion_r953835358 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {

[GitHub] [kafka] songnon commented on a diff in pull request #12543: KAFKA-10149: Allow auto preferred leader election for partitions are not being reassigned

2022-08-24 Thread GitBox
songnon commented on code in PR #12543: URL: https://github.com/apache/kafka/pull/12543#discussion_r953835358 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {

[GitHub] [kafka] mumrah merged pull request #12551: KAFKA-14178 Don't record queue time for deferred events

2022-08-24 Thread GitBox
mumrah merged PR #12551: URL: https://github.com/apache/kafka/pull/12551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] mumrah commented on pull request #12551: KAFKA-14178 Don't record queue time for deferred events

2022-08-24 Thread GitBox
mumrah commented on PR #12551: URL: https://github.com/apache/kafka/pull/12551#issuecomment-1225783687 Picked to 3.3 as 804caf1f2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] bbejeck commented on pull request #12494: MINOR: Update site docs for ASF compliance

2022-08-24 Thread GitBox
bbejeck commented on PR #12494: URL: https://github.com/apache/kafka/pull/12494#issuecomment-1225798250 @mimaison updated images added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] bbejeck merged pull request #12494: MINOR: Update site docs for ASF compliance

2022-08-24 Thread GitBox
bbejeck merged PR #12494: URL: https://github.com/apache/kafka/pull/12494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] bbejeck commented on pull request #12494: MINOR: Update site docs for ASF compliance

2022-08-24 Thread GitBox
bbejeck commented on PR #12494: URL: https://github.com/apache/kafka/pull/12494#issuecomment-1225830658 Merged #12494 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] C0urante commented on a diff in pull request #12478: KAFKA-13952 fix RetryWithToleranceOperator to respect infinite retries configuration

2022-08-24 Thread GitBox
C0urante commented on code in PR #12478: URL: https://github.com/apache/kafka/pull/12478#discussion_r953898875 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -175,9 +179,8 @@ protected V execAndRetry(Operation ope

[GitHub] [kafka] bbejeck commented on pull request #12494: MINOR: Update site docs for ASF compliance

2022-08-24 Thread GitBox
bbejeck commented on PR #12494: URL: https://github.com/apache/kafka/pull/12494#issuecomment-1225842227 cherry-picked to 3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] mimaison merged pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-24 Thread GitBox
mimaison merged PR #12046: URL: https://github.com/apache/kafka/pull/12046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-10360) Disabling JmxReporter registration

2022-08-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10360. Fix Version/s: 3.4.0 Assignee: Mickael Maison Resolution: Fixed > Disablin

[jira] [Created] (KAFKA-14179) Improve docs/upgrade.html to talk about metadata.version upgrades

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-14179: -- Summary: Improve docs/upgrade.html to talk about metadata.version upgrades Key: KAFKA-14179 URL: https://issues.apache.org/jira/browse/KAFKA-14179

[jira] [Commented] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

2022-08-24 Thread Doug Hoard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584377#comment-17584377 ] Doug Hoard commented on KAFKA-13077: I just experienced this issue using AK 3.2.x in

[GitHub] [kafka] hachikuji commented on pull request #12548: MINOR: A few cleanups for DescribeQuorum APIs

2022-08-24 Thread GitBox
hachikuji commented on PR #12548: URL: https://github.com/apache/kafka/pull/12548#issuecomment-1226006637 @showuon Apologies for missing your comments. I pushed an update to address them. Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (KAFKA-14178) NoOpRecord incorrectly causes high controller queue time metric

2022-08-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14178. -- Resolution: Fixed > NoOpRecord incorrectly causes high controller queue time metric >

[jira] [Updated] (KAFKA-14174) Documentation for KRaft

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Labels: docuentation kraft (was: ) > Documentation for KRaft >

[jira] [Updated] (KAFKA-14174) Documentation for KRaft

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Fix Version/s: (was: 3.3.0) > Documentation for KRaft >

[jira] [Updated] (KAFKA-14179) Improve docs/upgrade.html to talk about metadata.version upgrades

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14179: --- Labels: docuentation kraft (was: ) > Improve docs/upgrade.html to t

[jira] [Updated] (KAFKA-14179) Improve docs/upgrade.html to talk about metadata.version upgrades

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14179: --- Fix Version/s: (was: 3.3.0) > Improve docs/upgrade.html to talk

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12554: KAFKA-10199: Handle restored tasks output by state updater

2022-08-24 Thread GitBox
guozhangwang commented on code in PR #12554: URL: https://github.com/apache/kafka/pull/12554#discussion_r954204311 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -565,6 +583,303 @@ public void shouldHandleRemovedTasksFromStateUp

[jira] [Updated] (KAFKA-14174) Documentation for KRaft

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Labels: documentation kraft (was: docuentation kraft) > Documentati

[jira] [Updated] (KAFKA-14179) Improve docs/upgrade.html to talk about metadata.version upgrades

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14179: --- Labels: documentation kraft (was: docuentation kraft) > Improve doc

[jira] [Updated] (KAFKA-14174) Documentation for KRaft

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Description: KRaft documentation for 3.3 # Disk recovery # Externa

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12554: KAFKA-10199: Handle restored tasks output by state updater

2022-08-24 Thread GitBox
guozhangwang commented on code in PR #12554: URL: https://github.com/apache/kafka/pull/12554#discussion_r954203463 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1038,7 +1104,7 @@ private long sumOfChangelogOffsets(final TaskId id,

[GitHub] [kafka] hachikuji merged pull request #12548: MINOR: A few cleanups for DescribeQuorum APIs

2022-08-24 Thread GitBox
hachikuji merged PR #12548: URL: https://github.com/apache/kafka/pull/12548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Updated] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14156: --- Fix Version/s: 3.3.0 > Built-in partitioner may create suboptimal ba

[jira] [Updated] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14156: --- Issue Type: Bug (was: Improvement) > Built-in partitioner may creat

[jira] [Updated] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14156: --- Priority: Blocker (was: Major) > Built-in partitioner may create su

[jira] [Updated] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-08-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14156: --- Fix Version/s: (was: 3.3.0) > Built-in partitioner may create su

[jira] [Created] (KAFKA-14180) Help, I've been changed into a monstrous, verminous bug

2022-08-24 Thread Gregor Samsa (Jira)
Gregor Samsa created KAFKA-14180: Summary: Help, I've been changed into a monstrous, verminous bug Key: KAFKA-14180 URL: https://issues.apache.org/jira/browse/KAFKA-14180 Project: Kafka Issue

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: KAFKA-14177: Correctly support older kraft versions without FeatureLevelRecord

2022-08-24 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r954300741 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -191,18 +191,26 @@ Found problem: @Test def testDefaultMetadataVersion(): Unit = { val

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: KAFKA-14177: Correctly support older kraft versions without FeatureLevelRecord

2022-08-24 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r954317998 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -316,10 +326,12 @@ public boolean hasNext() { public List next() {

[GitHub] [kafka] hachikuji opened a new pull request, #12556: MINOR: Dump log tool should support bootstrap checkpoint file

2022-08-24 Thread GitBox
hachikuji opened a new pull request, #12556: URL: https://github.com/apache/kafka/pull/12556 It should be possible to use `kafka-dump-log.sh` to print the `bootstrap.checkpoint` file. This patch makes it so. ### Committer Checklist (excluded from commit message) - [ ] Verify design

[GitHub] [kafka] LiamClarkeNZ opened a new pull request, #12557: Fix small regression, where WorkerTest was re-disabled for Java 16+. …

2022-08-24 Thread GitBox
LiamClarkeNZ opened a new pull request, #12557: URL: https://github.com/apache/kafka/pull/12557 …As it no longer uses Powermock, it can be run on Java 16+ Signed-off-by: Liam Clarke-Hutchinson Verified by running unit test with following JVM: ``` liam.clarke-hutchins

[GitHub] [kafka] showuon commented on pull request #12548: MINOR: A few cleanups for DescribeQuorum APIs

2022-08-24 Thread GitBox
showuon commented on PR #12548: URL: https://github.com/apache/kafka/pull/12548#issuecomment-1226684539 Thanks @hachikuji , LGTM! Nice refactor! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] showuon commented on pull request #12557: Fix small regression, where WorkerTest was re-disabled for Java 16+. …

2022-08-24 Thread GitBox
showuon commented on PR #12557: URL: https://github.com/apache/kafka/pull/12557#issuecomment-1226709342 Sorry @LiamClarkeNZ , could you explain more why we should disable WorkerTest? It doesn't fail in the latest trunk build, where jdk 8 and jdk 11 runs well. https://ci-builds.apache.org

[jira] [Created] (KAFKA-14181) Dose kafka counter Brute Force Attack?

2022-08-24 Thread wooo (Jira)
wooo created KAFKA-14181: Summary: Dose kafka counter Brute Force Attack? Key: KAFKA-14181 URL: https://issues.apache.org/jira/browse/KAFKA-14181 Project: Kafka Issue Type: Improvement Re

[GitHub] [kafka] LiamClarkeNZ commented on pull request #12557: Fix small regression, where WorkerTest was re-disabled for Java 16+. …

2022-08-24 Thread GitBox
LiamClarkeNZ commented on PR #12557: URL: https://github.com/apache/kafka/pull/12557#issuecomment-1226724531 Hey @showuon! No, I'm _re-enabling_ `WorkerTest` for test runs under Java 16+, not disabling it :) It was excluded from test runs under Java 16+ previously, because it used P

[GitHub] [kafka] showuon commented on a diff in pull request #12480: MINOR: Small cleanups in integration.kafka tests

2022-08-24 Thread GitBox
showuon commented on code in PR #12480: URL: https://github.com/apache/kafka/pull/12480#discussion_r954465533 ## core/src/test/scala/integration/kafka/api/MetricsTest.scala: ## @@ -226,7 +226,7 @@ class MetricsTest extends IntegrationTestHarness with SaslSetup { private de

[GitHub] [kafka] showuon commented on pull request #12480: MINOR: Small cleanups in integration.kafka tests

2022-08-24 Thread GitBox
showuon commented on PR #12480: URL: https://github.com/apache/kafka/pull/12480#issuecomment-1226729774 Jenkins build seems failed with infra's issue. I've re-trigger it: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12480/3/ -- This is an automated message from the Apache Gi

[GitHub] [kafka] songnon commented on pull request #9302: KAFKA-10149: Allow auto preferred leader election when partitions are reassigning

2022-08-24 Thread GitBox
songnon commented on PR #9302: URL: https://github.com/apache/kafka/pull/9302#issuecomment-1226738844 New PR https://github.com/apache/kafka/pull/12543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2022-08-24 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r954487697 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -273,26 +273,29 @@ public RecordAppendResult append(String topic

[GitHub] [kafka] showuon commented on pull request #12557: MINOR: re-enable WorkerTest for java 16+

2022-08-24 Thread GitBox
showuon commented on PR #12557: URL: https://github.com/apache/kafka/pull/12557#issuecomment-1226808195 Failed tests are un-relabed. Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterSnapshotTest.testSnapshotsGenerated() -- This is an automated message from the Apache Git Service

[GitHub] [kafka] showuon merged pull request #12557: MINOR: re-enable WorkerTest for java 16+

2022-08-24 Thread GitBox
showuon merged PR #12557: URL: https://github.com/apache/kafka/pull/12557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
showuon commented on PR #12103: URL: https://github.com/apache/kafka/pull/12103#issuecomment-1226816797 Failed tests are un-related: ``` Build / JDK 11 and Scala 2.13 / kafka.server.KRaftClusterTest.testCreateClusterAndPerformReassignment() ``` -- This is an automated message fro

[GitHub] [kafka] showuon merged pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
showuon merged PR #12103: URL: https://github.com/apache/kafka/pull/12103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-24 Thread GitBox
showuon commented on PR #12103: URL: https://github.com/apache/kafka/pull/12103#issuecomment-1226818524 backport to 3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u