ableegoldman opened a new pull request, #12585:
URL: https://github.com/apache/kafka/pull/12585
Based on a patch submitted to the `confluentinc` fork & then abandoned.
Needed some updates and minor expansion but more or less just re-applied the
changes proposed in https://github.com/conflue
Philip Nee created KAFKA-14196:
--
Summary: Flaky OffsetValidationTest seems to indicate potential
duplication issue during rebalance
Key: KAFKA-14196
URL: https://issues.apache.org/jira/browse/KAFKA-14196
mghosh4 commented on PR #10910:
URL: https://github.com/apache/kafka/pull/10910#issuecomment-1234907832
Any update on when this diff can be landed? Incase you need some help, I am
happy to help. This is a problem that we have had to deal with too.
--
This is an automated message from the
philipnee closed pull request #12580: MINOR: Fix flaky OffsetValidationTest
URL: https://github.com/apache/kafka/pull/12580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
cmccabe merged PR #12578:
URL: https://github.com/apache/kafka/pull/12578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
vvcephei merged PR #12582:
URL: https://github.com/apache/kafka/pull/12582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
vvcephei commented on PR #12582:
URL: https://github.com/apache/kafka/pull/12582#issuecomment-1234803264
The java 17 build failed with this unrelated exception:
```
10:00:43 Execution failed for task ':core:unitTest'.
10:00:43 > Process 'Gradle Test Executor 50' finished with n
wcarlson5 commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r960982217
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -396,8 +397,7 @@ public static StreamThread create(final TopologyMetadat
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r961032133
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMetada
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r961012010
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMetada
guozhangwang commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r961002924
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
guozhangwang commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960983275
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe
Ron Dagostino created KAFKA-14195:
-
Summary: Fix KRaft AlterConfig policy usage for Legacy/Full case
Key: KAFKA-14195
URL: https://issues.apache.org/jira/browse/KAFKA-14195
Project: Kafka
Iss
rondagostino commented on code in PR #12578:
URL: https://github.com/apache/kafka/pull/12578#discussion_r960958343
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -248,33 +249,45 @@ private void
incrementalAlterConfigResource(Config
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960956896
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
jsancio commented on code in PR #12578:
URL: https://github.com/apache/kafka/pull/12578#discussion_r960954024
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -248,33 +249,45 @@ private void
incrementalAlterConfigResource(ConfigResou
ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1234551652
Thank you @jsancio for the review. Have made the changes.
For the following comment -
>It looks like this method is only used by tests. I think it is okay for
this to have an "
ashmeet13 commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r960902453
##
core/src/main/scala/kafka/server/metadata/MetadataSnapshotter.scala:
##
@@ -31,5 +32,5 @@ trait MetadataSnapshotter {
*
* @return True
ashmeet13 commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r960901993
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala:
##
@@ -59,11 +60,11 @@ class BrokerMetadataSnapshotter(
val writer = writerBuilder
ashmeet13 commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r960901730
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -119,16 +120,29 @@ class BrokerMetadataListener(
}
_bytesSinceLastSnap
ndrwdn opened a new pull request, #12584:
URL: https://github.com/apache/kafka/pull/12584
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
[
https://issues.apache.org/jira/browse/KAFKA-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Dean updated KAFKA-14194:
Component/s: clients
> NPE in Cluster.nodeIfOnline
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Dean updated KAFKA-14194:
Affects Version/s: 3.2.1
> NPE in Cluster.nodeIfOnline
> ---
>
>
Andrew Dean created KAFKA-14194:
---
Summary: NPE in Cluster.nodeIfOnline
Key: KAFKA-14194
URL: https://issues.apache.org/jira/browse/KAFKA-14194
Project: Kafka
Issue Type: Bug
Reporte
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960845326
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960845326
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
cadonna commented on PR #12519:
URL: https://github.com/apache/kafka/pull/12519#issuecomment-1234414581
I am sorry, one of my merged PRs has introduced conflicts here. 🙁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mimaison commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1234403651
Yes if the system tests pass, I'm in favor of merging this in 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599002#comment-17599002
]
John Gray edited comment on KAFKA-14172 at 9/1/22 2:56 PM:
---
I
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r960754245
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -280,25 +280,17 @@ public void shouldClassifyExistingTasksWithStateUpda
cadonna commented on PR #12583:
URL: https://github.com/apache/kafka/pull/12583#issuecomment-1234388852
Call for review: @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cadonna opened a new pull request, #12583:
URL: https://github.com/apache/kafka/pull/12583
Separates the code path for the new state updater from
the code path of the old restoration.
Ensures that with the state updater tasks are processed
before all tasks are running.
###
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599002#comment-17599002
]
John Gray edited comment on KAFKA-14172 at 9/1/22 2:44 PM:
---
I
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598956#comment-17598956
]
John Gray edited comment on KAFKA-14172 at 9/1/22 2:41 PM:
---
My
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599002#comment-17599002
]
John Gray commented on KAFKA-14172:
---
I know next to nothing about the internal working
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960708055
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598956#comment-17598956
]
John Gray edited comment on KAFKA-14172 at 9/1/22 1:29 PM:
---
My
C0urante commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1234282325
@showuon @mimaison @jsancio are we okay with adding this to the 3.3 branch?
There's very little additional risk; the only changes to non-testing code are
an additional branch
[here](htt
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960654203
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960647123
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598956#comment-17598956
]
John Gray edited comment on KAFKA-14172 at 9/1/22 1:12 PM:
---
My
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598956#comment-17598956
]
John Gray commented on KAFKA-14172:
---
My stateful/EOS Kafka apps also seem to be strugg
vvcephei opened a new pull request, #12582:
URL: https://github.com/apache/kafka/pull/12582
People have a hard time understanding what's going on with probing
rebalances, partly due to cryptic messages like this:
```
2022-08-31T12:03:29.197+09:00 . Requested to schedule probing
cadonna merged PR #12573:
URL: https://github.com/apache/kafka/pull/12573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12573:
URL: https://github.com/apache/kafka/pull/12573#issuecomment-1234212740
Build failures are not related:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
Build / JDK 17
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960474042
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,17 +276,36 @@ private void maybeAddNodeForOptimizationMetada
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960457146
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMetada
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r960457146
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMetada
yashmayya commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r960439387
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java:
##
@@ -199,112 +202,156 @@ private RetryWithToleranceOper
yashmayya commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r960436353
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java:
##
@@ -175,9 +179,8 @@ protected V execAndRetry(Operation op
yashmayya commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r960435913
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java:
##
@@ -269,7 +289,7 @@ void backoff(int attempt, long deadlin
jokeryin432 opened a new pull request, #12581:
URL: https://github.com/apache/kafka/pull/12581
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
nizhikov commented on PR #12574:
URL: https://github.com/apache/kafka/pull/12574#issuecomment-1233908096
Hello @showuon.
Can you, please, take a look at my changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
[
https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598790#comment-17598790
]
Sergey Ivanov commented on KAFKA-13077:
---
[~ivanyu], ohh, we continued investigatio
54 matches
Mail list logo
