[GitHub] [kafka] dplavcic commented on pull request #12449: KAFKA-12947: Replace EasyMock and PowerMock with Mockito for StreamsMetricsImplTest

2022-09-09 Thread GitBox
dplavcic commented on PR #12449: URL: https://github.com/apache/kafka/pull/12449#issuecomment-1242651358 @cadonna, @clolov can you please help me get this PR merged (if/when you have time, ofc)? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] philipnee closed pull request #12619: (WIP) KAFKA-14196: Mark partition unfetchable

2022-09-09 Thread GitBox
philipnee closed pull request #12619: (WIP) KAFKA-14196: Mark partition unfetchable URL: https://github.com/apache/kafka/pull/12619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] philipnee opened a new pull request, #12619: KAFKA-14196: Mark Partition unfetchable

2022-09-09 Thread GitBox
philipnee opened a new pull request, #12619: URL: https://github.com/apache/kafka/pull/12619 In KAFKA-14196 we discovered that rebalance can possibly causes some of the fetched offset being lost when autocommit was enabled, and thus causing duplication. The reason being the fetcher continu

[GitHub] [kafka] hachikuji commented on a diff in pull request #12597: KAFKA-14205; Document how to replace the disk for the KRaft Controller

2022-09-09 Thread GitBox
hachikuji commented on code in PR #12597: URL: https://github.com/apache/kafka/pull/12597#discussion_r967549150 ## docs/ops.html: ## @@ -1373,6 +1373,27 @@ delalloc: Delayed allocation means that the filesystem avoid allocating any blocks until the physical write occurs.

[jira] [Created] (KAFKA-14217) app-reset-tool.html should remove reference to --zookeeper flag that no longer exists

2022-09-09 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14217: Summary: app-reset-tool.html should remove reference to --zookeeper flag that no longer exists Key: KAFKA-14217 URL: https://issues.apache.org/jira/browse/KAFKA-14217

[GitHub] [kafka] hachikuji commented on a diff in pull request #12611: KAFKA-14208: Should not wake-up with non-blocking coordinator discovery

2022-09-09 Thread GitBox
hachikuji commented on code in PR #12611: URL: https://github.com/apache/kafka/pull/12611#discussion_r967541336 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -249,7 +249,14 @@ protected synchronized boolean ensureCoordinato

[jira] [Created] (KAFKA-14216) Remove ZK reference from org.apache.kafka.server.quota.ClientQuotaCallback javadoc

2022-09-09 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14216: Summary: Remove ZK reference from org.apache.kafka.server.quota.ClientQuotaCallback javadoc Key: KAFKA-14216 URL: https://issues.apache.org/jira/browse/KAFKA-14216 Pr

[jira] [Updated] (KAFKA-14215) KRaft forwarded requests have no quota enforcement

2022-09-09 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14215: --- Fix Version/s: 3.3.0 > KRaft forwarded requests have no quota enforc

[jira] [Assigned] (KAFKA-14215) KRaft forwarded requests have no quota enforcement

2022-09-09 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-14215: -- Assignee: Jason Gustafson > KRaft forwarded requests have no

[jira] [Assigned] (KAFKA-14214) StandardAuthorizer may transiently process ACLs out of write order

2022-09-09 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti reassigned KAFKA-14214: - Assignee: Akhilesh Chaganti > StandardAuthorizer may transiently process ACLs o

[jira] [Commented] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

2022-09-09 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602575#comment-17602575 ] Jose Armando Garcia Sancio commented on KAFKA-14208: Okay. Thanks fo

[jira] [Created] (KAFKA-14215) KRaft forwarded requests have no quota enforcement

2022-09-09 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14215: --- Summary: KRaft forwarded requests have no quota enforcement Key: KAFKA-14215 URL: https://issues.apache.org/jira/browse/KAFKA-14215 Project: Kafka Issu

[jira] [Commented] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

2022-09-09 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602574#comment-17602574 ] Guozhang Wang commented on KAFKA-14208: --- I marked it as a blocker for 3.3.0 since

[jira] [Updated] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

2022-09-09 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-14208: -- Priority: Blocker (was: Major) > KafkaConsumer#commitAsync throws unexpected WakeupException

[jira] [Updated] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

2022-09-09 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-14208: -- Fix Version/s: 3.3.0 > KafkaConsumer#commitAsync throws unexpected WakeupException > -

[GitHub] [kafka] junrao commented on a diff in pull request #12570: KAFKA-14156: Built-in partitioner may create suboptimal batches

2022-09-09 Thread GitBox
junrao commented on code in PR #12570: URL: https://github.com/apache/kafka/pull/12570#discussion_r967484263 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -378,6 +415,15 @@ private MemoryRecordsBuilder recordsBuilder(ByteBuffe

[jira] [Updated] (KAFKA-14214) StandardAuthorizer may transiently process ACLs out of write order

2022-09-09 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14214: --- Fix Version/s: 3.3.0 > StandardAuthorizer may transiently process AC

[jira] [Created] (KAFKA-14214) StandardAuthorizer may transiently process ACLs out of write order

2022-09-09 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-14214: - Summary: StandardAuthorizer may transiently process ACLs out of write order Key: KAFKA-14214 URL: https://issues.apache.org/jira/browse/KAFKA-14214 Project:

[GitHub] [kafka] jsancio commented on a diff in pull request #12597: KAFKA-14205; Document how to replace the disk for the KRaft Controller

2022-09-09 Thread GitBox
jsancio commented on code in PR #12597: URL: https://github.com/apache/kafka/pull/12597#discussion_r967491694 ## docs/ops.html: ## @@ -1373,6 +1373,27 @@ delalloc: Delayed allocation means that the filesystem avoid allocating any blocks until the physical write occurs. Th

[GitHub] [kafka] jsancio commented on a diff in pull request #12597: KAFKA-14205; Document how to replace the disk for the KRaft Controller

2022-09-09 Thread GitBox
jsancio commented on code in PR #12597: URL: https://github.com/apache/kafka/pull/12597#discussion_r967490851 ## docs/ops.html: ## @@ -1373,6 +1373,27 @@ delalloc: Delayed allocation means that the filesystem avoid allocating any blocks until the physical write occurs. Th

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12570: KAFKA-14156: Built-in partitioner may create suboptimal batches

2022-09-09 Thread GitBox
artemlivshits commented on code in PR #12570: URL: https://github.com/apache/kafka/pull/12570#discussion_r967463676 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -1137,23 +1137,26 @@ public void onCompletion(RecordMetadata

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
guozhangwang commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r967380695 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -250,32 +250,502 @@ public void shouldClassifyExistingTasksWithou

[GitHub] [kafka] ijuma commented on pull request #12616: KAFKA-14198: Define separate swagger configuration

2022-09-09 Thread GitBox
ijuma commented on PR #12616: URL: https://github.com/apache/kafka/pull/12616#issuecomment-1242276303 Thanks @C0urante. Did you verify that the documentation is still generated correctly and the release tarball still doesn't have swagger and snakyaml in the dependencies? -- This is an au

[GitHub] [kafka] ijuma commented on a diff in pull request #12616: KAFKA-14198: Define separate swagger configuration

2022-09-09 Thread GitBox
ijuma commented on code in PR #12616: URL: https://github.com/apache/kafka/pull/12616#discussion_r967325334 ## build.gradle: ## @@ -2653,9 +2659,9 @@ project(':connect:runtime') { } task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, depends

[GitHub] [kafka] ijuma commented on a diff in pull request #12616: KAFKA-14198: Define separate swagger configuration

2022-09-09 Thread GitBox
ijuma commented on code in PR #12616: URL: https://github.com/apache/kafka/pull/12616#discussion_r967324775 ## build.gradle: ## @@ -2564,7 +2568,9 @@ project(':connect:runtime') { implementation libs.mavenArtifact implementation libs.swaggerAnnotations Review Comment:

[GitHub] [kafka] vamossagar12 commented on pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-09 Thread GitBox
vamossagar12 commented on PR #12561: URL: https://github.com/apache/kafka/pull/12561#issuecomment-1242211508 @C0urante I made the switch back as suggested. Plz review whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-09 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r967271849 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment perfor

[GitHub] [kafka] cmccabe commented on a diff in pull request #12597: KAFKA-14205; Document how to replace the disk for the KRaft Controller

2022-09-09 Thread GitBox
cmccabe commented on code in PR #12597: URL: https://github.com/apache/kafka/pull/12597#discussion_r967248834 ## docs/ops.html: ## @@ -1373,6 +1373,27 @@ delalloc: Delayed allocation means that the filesystem avoid allocating any blocks until the physical write occurs. Th

[GitHub] [kafka] cmccabe commented on a diff in pull request #12597: KAFKA-14205; Document how to replace the disk for the KRaft Controller

2022-09-09 Thread GitBox
cmccabe commented on code in PR #12597: URL: https://github.com/apache/kafka/pull/12597#discussion_r967247190 ## docs/ops.html: ## @@ -1373,6 +1373,27 @@ delalloc: Delayed allocation means that the filesystem avoid allocating any blocks until the physical write occurs. Th

[GitHub] [kafka] cmccabe commented on a diff in pull request #12597: KAFKA-14205; Document how to replace the disk for the KRaft Controller

2022-09-09 Thread GitBox
cmccabe commented on code in PR #12597: URL: https://github.com/apache/kafka/pull/12597#discussion_r967246344 ## docs/ops.html: ## @@ -1373,6 +1373,27 @@ delalloc: Delayed allocation means that the filesystem avoid allocating any blocks until the physical write occurs. Th

[GitHub] [kafka] jsancio commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-09 Thread GitBox
jsancio commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r967205692 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -325,7 +325,7 @@ class BrokerMetadataListener( try { _image = _delta.apply()

[jira] [Updated] (KAFKA-14194) NPE in Cluster.nodeIfOnline

2022-09-09 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14194: --- Fix Version/s: 3.3.0 > NPE in Cluster.nodeIfOnline > ---

[GitHub] [kafka] C0urante commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

2022-09-09 Thread GitBox
C0urante commented on PR #12609: URL: https://github.com/apache/kafka/pull/12609#issuecomment-1242086218 Filed https://github.com/apache/kafka/pull/12616 as a non-urgent follow-up to remove the combined compile-time and runtime classpath hack. -- This is an automated message from the Apac

[GitHub] [kafka] C0urante opened a new pull request, #12616: KAFKA-14198: Define separate swagger configuration

2022-09-09 Thread GitBox
C0urante opened a new pull request, #12616: URL: https://github.com/apache/kafka/pull/12616 Follow-up from https://github.com/apache/kafka/pull/12609. Non-urgent, just tidies up the build file a bit. ### Committer Checklist (excluded from commit message) - [ ] Verify design and imp

[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

2022-09-09 Thread GitBox
C0urante commented on code in PR #12609: URL: https://github.com/apache/kafka/pull/12609#discussion_r967164120 ## build.gradle: ## @@ -2652,7 +2653,7 @@ project(':connect:runtime') { } task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, depe

[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

2022-09-09 Thread GitBox
C0urante commented on code in PR #12609: URL: https://github.com/apache/kafka/pull/12609#discussion_r967164120 ## build.gradle: ## @@ -2652,7 +2653,7 @@ project(':connect:runtime') { } task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, depe

[GitHub] [kafka] jsancio merged pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

2022-09-09 Thread GitBox
jsancio merged PR #12609: URL: https://github.com/apache/kafka/pull/12609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-14213) Reduce lock contention between control-plane-kafka-request-handler and kafka-log-cleaner-thread

2022-09-09 Thread Lucas Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Wang updated KAFKA-14213: --- Description: We found that the StopReplica request's local processing time may be quite long due to

[jira] [Created] (KAFKA-14213) Reduce lock contention between control-plane-kafka-request-handler and kafka-log-cleaner-thread

2022-09-09 Thread Lucas Wang (Jira)
Lucas Wang created KAFKA-14213: -- Summary: Reduce lock contention between control-plane-kafka-request-handler and kafka-log-cleaner-thread Key: KAFKA-14213 URL: https://issues.apache.org/jira/browse/KAFKA-14213

[jira] [Assigned] (KAFKA-14212) Fetch error response when hitting public OAuth/OIDC provider

2022-09-09 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan reassigned KAFKA-14212: --- Assignee: Sushant Mahajan > Fetch error response when hitting public OAuth/OIDC pro

[jira] [Created] (KAFKA-14212) Fetch error response when hitting public OAuth/OIDC provider

2022-09-09 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-14212: --- Summary: Fetch error response when hitting public OAuth/OIDC provider Key: KAFKA-14212 URL: https://issues.apache.org/jira/browse/KAFKA-14212 Project: Kafka

[jira] [Commented] (KAFKA-14199) Installed kafka in ubuntu and not able to access in browser. org.apache.kafka.common.network.InvalidReceiveException: Invalid receive (size = 1195725856 larger than 1

2022-09-09 Thread Kouame (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602333#comment-17602333 ] Kouame commented on KAFKA-14199: you could not communicate with the kafka broker via the

[GitHub] [kafka] cadonna commented on pull request #12376: KAFKA-14044: Upgrade Netty and Jackson versions for CVE fixes

2022-09-09 Thread GitBox
cadonna commented on PR #12376: URL: https://github.com/apache/kafka/pull/12376#issuecomment-1241932688 Backported to 3.2, 3.1, 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] showuon commented on a diff in pull request #12603: KAFKA-14196: Pausing partition to prevent duplication when autocommit is enabled

2022-09-09 Thread GitBox
showuon commented on code in PR #12603: URL: https://github.com/apache/kafka/pull/12603#discussion_r967027203 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -756,10 +756,15 @@ protected boolean onJoinPrepare(Timer timer, int

[GitHub] [kafka] showuon commented on a diff in pull request #12603: KAFKA-14196: Pausing partition to prevent duplication when autocommit is enabled

2022-09-09 Thread GitBox
showuon commented on code in PR #12603: URL: https://github.com/apache/kafka/pull/12603#discussion_r967027203 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -756,10 +756,15 @@ protected boolean onJoinPrepare(Timer timer, int

[GitHub] [kafka] showuon commented on a diff in pull request #12603: KAFKA-14196: Pausing partition to prevent duplication when autocommit is enabled

2022-09-09 Thread GitBox
showuon commented on code in PR #12603: URL: https://github.com/apache/kafka/pull/12603#discussion_r967027203 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -756,10 +756,15 @@ protected boolean onJoinPrepare(Timer timer, int

[GitHub] [kafka] showuon commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-09 Thread GitBox
showuon commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r967018912 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment performTask

[jira] [Comment Edited] (KAFKA-14211) Streams log message has partition and offset transposed

2022-09-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602299#comment-17602299 ] Bruno Cadonna edited comment on KAFKA-14211 at 9/9/22 12:15 PM: --

[jira] [Commented] (KAFKA-14211) Streams log message has partition and offset transposed

2022-09-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602299#comment-17602299 ] Bruno Cadonna commented on KAFKA-14211: --- This is fixed via https://github.com/apac

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966991995 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -817,14 +867,17 @@ private boolean handleRestoredTasksFromStateUpdater(fina

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966987932 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final Map

[jira] [Created] (KAFKA-14211) Streams log message has partition and offset transposed

2022-09-09 Thread Matt Allwood (Jira)
Matt Allwood created KAFKA-14211: Summary: Streams log message has partition and offset transposed Key: KAFKA-14211 URL: https://issues.apache.org/jira/browse/KAFKA-14211 Project: Kafka Issue

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966978149 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-09 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r966947727 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTaskTest.java: ## @@ -162,71 +121,53 @@ public void stopBeforeStarting() { // now run

[GitHub] [kafka] yashmayya opened a new pull request, #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-09 Thread GitBox
yashmayya opened a new pull request, #12615: URL: https://github.com/apache/kafka/pull/12615 This is the second batch of tests from https://issues.apache.org/jira/browse/KAFKA-14132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-09 Thread GitBox
clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1241764996 Hey @guozhangwang and thank you for the insightful comments! I will aim to give explanations and amend the PR in the upcoming days. -- This is an automated message from the Apache Git Se

[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-09 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1241764136 Heya @cadonna and thank you very much for the review! I will address your comments over the next few days. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Danny02 commented on pull request #12608: Enable KStream to be merged with itself

2022-09-09 Thread GitBox
Danny02 commented on PR #12608: URL: https://github.com/apache/kafka/pull/12608#issuecomment-1241762494 I have really no idea why completely different tests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-09 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r966825384 ## clients/src/main/java/org/apache/kafka/common/requests/FetchMetadata.java: ## @@ -114,9 +114,21 @@ public boolean equals(Object o) { } /** - * Ret

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-09 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r966822783 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1941,76 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-09 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r966823251 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,40 @@ private ClusterResourceListeners configureClusterResourceL

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-09 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r966819850 ## clients/src/test/java/org/apache/kafka/common/security/authenticator/ClientAuthenticationFailureTest.java: ## @@ -90,12 +90,12 @@ public void testConsumerWithInva

[jira] [Comment Edited] (KAFKA-6599) KTable KTable join semantics violated when caching enabled

2022-09-09 Thread Jan Filipiak (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600611#comment-17600611 ] Jan Filipiak edited comment on KAFKA-6599 at 9/9/22 9:07 AM: -

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-09 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602212#comment-17602212 ] Nicholas Telford commented on KAFKA-10635: -- Hi [~guozhang], thanks for the expl

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-09 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r966783019 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment perfor

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966773511 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(final Ma

[GitHub] [kafka] dengziming commented on a diff in pull request #12614: MINOR: Support KRaft mode in RequestQuotaTest

2022-09-09 Thread GitBox
dengziming commented on code in PR #12614: URL: https://github.com/apache/kafka/pull/12614#discussion_r966769259 ## core/src/test/scala/unit/kafka/server/RequestQuotaTest.scala: ## @@ -90,93 +104,142 @@ class RequestQuotaTest extends BaseRequestTest { super.setUp(testInfo)

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966773511 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(final Ma

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966771190 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(final Ma

[GitHub] [kafka] dengziming opened a new pull request, #12614: MINOR: Support KRaft mode in RequestQuotaTest

2022-09-09 Thread GitBox
dengziming opened a new pull request, #12614: URL: https://github.com/apache/kafka/pull/12614 *More detailed description of your change* Support kraft mode in RequestQuotaTest *Summary of testing strategy (including rationale)* QA ### Committer Checklist (excluded from com

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966762475 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final Se

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966762475 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final Se

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966755655 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final Se

[GitHub] [kafka] showuon commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-09 Thread GitBox
showuon commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r966680846 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,40 @@ private ClusterResourceListeners configureClusterResourceListe

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-09 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966750330 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(final Ma

[GitHub] [kafka] cadonna commented on a diff in pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-09 Thread GitBox
cadonna commented on code in PR #12505: URL: https://github.com/apache/kafka/pull/12505#discussion_r966707489 ## streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentSessionStoreTest.java: ## @@ -258,58 +266,45 @@ public void shouldPutBackwardFetchAllK

[GitHub] [kafka] a1d1a1r1s1h1 commented on pull request #6329: KAFKA-1194: Fix renaming open files on Windows

2022-09-09 Thread GitBox
a1d1a1r1s1h1 commented on PR #6329: URL: https://github.com/apache/kafka/pull/6329#issuecomment-1241617078 @kobihikri Hi, I wanted to use it with Kafka 3.2.1 as the fix isn't present in it and restarting kafka every 30 minutes is proving difficult. Would you please guide me how to use this

[GitHub] [kafka] dajac commented on pull request #12584: KAFKA-14194: Fix NPE in Cluster.nodeIfOnline

2022-09-09 Thread GitBox
dajac commented on PR #12584: URL: https://github.com/apache/kafka/pull/12584#issuecomment-1241606073 @ijuma That makes sense. Backported it to 3.3 and 3.2. cc @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use