divijvaidya commented on PR #12591:
URL: https://github.com/apache/kafka/pull/12591#issuecomment-1243849390
Thank you both for your review.
Since, we agree up to pick up this incremental change, I am assuming no
action is required from my side before you approve & merge?
Note t
junrao commented on PR #12570:
URL: https://github.com/apache/kafka/pull/12570#issuecomment-1243846932
Thanks for the feedback @Kaiserchen . Could you run your MM test by changing
`last == null || last.isFull()` to `deque.size() > 1 || last == null ||
last.isFull()` and see if it's still fu
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968491064
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1941,76 @@ private Map
topicPartitionTags(TopicPartition tp) {
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968480496
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -2403,17 +2404,40 @@ private ClusterResourceListeners
configureClusterResourceL
C0urante commented on PR #12616:
URL: https://github.com/apache/kafka/pull/12616#issuecomment-1243801973
Thanks Ismael. Kicked off another Jenkins build since the previous one
failed with a disk space error; will merge if everything looks alright.
--
This is an automated message from the
C0urante merged PR #12475:
URL: https://github.com/apache/kafka/pull/12475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603102#comment-17603102
]
Suresh Rukmangathan commented on KAFKA-14184:
-
[~cadonna] - We are yet to tr
ijuma commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968463099
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1941,76 @@ private Map
topicPartitionTags(TopicPartition tp) {
cadonna commented on code in PR #12600:
URL: https://github.com/apache/kafka/pull/12600#discussion_r968443807
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final
Se
cadonna commented on code in PR #12600:
URL: https://github.com/apache/kafka/pull/12600#discussion_r968441157
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -421,73 +421,96 @@ private void classifyTasksWithoutStateUpdater(final
Map
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968439965
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1941,76 @@ private Map
topicPartitionTags(TopicPartition tp) {
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968439103
##
clients/src/test/java/org/apache/kafka/common/security/authenticator/ClientAuthenticationFailureTest.java:
##
@@ -90,12 +90,12 @@ public void testConsumerWithInva
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968407998
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1941,76 @@ private Map
topicPartitionTags(TopicPartition tp) {
ijuma commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968392833
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -446,6 +429,31 @@ private RequestFuture
sendMetadataRequest(MetadataRequest.Build
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968387276
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -446,6 +429,31 @@ private RequestFuture
sendMetadataRequest(MetadataRequest
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968386276
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -446,6 +429,31 @@ private RequestFuture
sendMetadataRequest(MetadataRequest
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968381069
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -2403,17 +2404,40 @@ private ClusterResourceListeners
configureClusterResourceL
cadonna commented on code in PR #12600:
URL: https://github.com/apache/kafka/pull/12600#discussion_r968378813
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##
@@ -52,11 +53,8 @@ class Tasks implements TasksRegistry {
// we receive a new a
divijvaidya opened a new pull request, #12623:
URL: https://github.com/apache/kafka/pull/12623
**Problem**
`ConsumerPerformanceTest` fails when running on a machine with a Locale
where decimal is represented by a comma. E.g. in locale of Germany, one point 2
is written as `1,2` and not `
C0urante commented on PR #12616:
URL: https://github.com/apache/kafka/pull/12616#issuecomment-1243683309
Thanks @ijuma. Yes, I verified both, and updated the PR description with the
steps I took to do so.
--
This is an automated message from the Apache Git Service.
To respond to the messa
C0urante commented on code in PR #12616:
URL: https://github.com/apache/kafka/pull/12616#discussion_r968366903
##
build.gradle:
##
@@ -2653,9 +2659,9 @@ project(':connect:runtime') {
}
task genConnectOpenAPIDocs(type:
io.swagger.v3.plugins.gradle.tasks.ResolveTask, depe
dajac commented on PR #12603:
URL: https://github.com/apache/kafka/pull/12603#issuecomment-1243677992
@philipnee Thanks for the PR. Could you please update the description to
explain the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
C0urante commented on code in PR #12616:
URL: https://github.com/apache/kafka/pull/12616#discussion_r968359263
##
build.gradle:
##
@@ -2564,7 +2568,9 @@ project(':connect:runtime') {
implementation libs.mavenArtifact
implementation libs.swaggerAnnotations
Review Comme
[
https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603056#comment-17603056
]
Pritam Kumar commented on KAFKA-14220:
--
The following is the patch made and verifie
kumarpritam863 opened a new pull request, #12622:
URL: https://github.com/apache/kafka/pull/12622
In case of the revocation of partitions, the updation of "**partition
count**" metrics is being done before updating the new set of assignments.
"**invokePartitionsRevoked**" method of "**onJoi
Pritam Kumar created KAFKA-14220:
Summary: "partition-count" not getting updated after revocation of
partitions in case of Incremental Co-operative rebalancing.
Key: KAFKA-14220
URL: https://issues.apache.org/jira
Kaiserchen commented on PR #12570:
URL: https://github.com/apache/kafka/pull/12570#issuecomment-1243614928
Just stumbled over this.
Our company basically runs similar code.
Without this optimization MM is non functional for us :)
--
This is an automated message from the Apache Git Se
srishti-saraswat closed pull request #12567: Migrate connect system tests to
KRaft
URL: https://github.com/apache/kafka/pull/12567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1243525214
@cadonna I have just rebased the PR with the latest streams changes that got
merged into. trunk. I also did some more improvements for `StreamThreadTest`
with the usage of `MockitoJUni
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1243496402
@ijuma @mimaison Any chance of a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-14206:
-
Assignee: Luke Chen
> Upgrade zookeeper to 3.7.1 to address security vulnerabilities
>
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968209811
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4068,18 +3796,14 @@ public void shouldConvertStandbyTaskToActiveTask()
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968208668
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -2180,29 +2035,16 @@ public void
shouldCommitAllActiveTasksThatNeedComm
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968207227
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -271,11 +265,13 @@ public void shouldClassifyExistingTasksWithStateUpdat
cadonna commented on code in PR #12600:
URL: https://github.com/apache/kafka/pull/12600#discussion_r968207039
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final
Se
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968206590
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4091,21 +3815,20 @@ public void shouldListNotPausedTasks() {
t
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968206590
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4091,21 +3815,20 @@ public void shouldListNotPausedTasks() {
t
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968204971
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1300,28 +1229,16 @@ public void
shouldCloseActiveTasksWhenHandlingLost
clolov commented on code in PR #12607:
URL: https://github.com/apache/kafka/pull/12607#discussion_r968200658
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -325,25 +318,21 @@ public void
shouldHandleRemovedTasksToRecycleFromSta
[
https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603003#comment-17603003
]
Divij Vaidya commented on KAFKA-14218:
--
While working on this task, the owner must
srishti-saraswat opened a new pull request, #12621:
URL: https://github.com/apache/kafka/pull/12621
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary o
101 - 141 of 141 matches
Mail list logo
