[GitHub] [kafka] showuon merged pull request #12649: MINOR: replace deprecated egrep in kafka-run-class

2022-09-15 Thread GitBox
showuon merged PR #12649: URL: https://github.com/apache/kafka/pull/12649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #12649: kafka-run-class: MINOR: Fixing "egrep: warning: egrep is obsolescent; using …

2022-09-15 Thread GitBox
showuon commented on PR #12649: URL: https://github.com/apache/kafka/pull/12649#issuecomment-1248970472 The `egrep` is deprecated in 2007 and be replaced with `grep -E` https://www.redhat.com/sysadmin/deprecated-linux-command-replacements -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-1935) Consumer should use a separate socket for Coordinator connection

2022-09-15 Thread Akshay Bhadange (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605621#comment-17605621 ] Akshay Bhadange commented on KAFKA-1935: Hi [~guozhang], is this issue still exis

[jira] [Commented] (KAFKA-14212) Fetch error response when hitting public OAuth/OIDC provider

2022-09-15 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605608#comment-17605608 ] Sushant Mahajan commented on KAFKA-14212: - Hi Kirk, yes I will submit the PR in

[GitHub] [kafka] matthewstidham commented on pull request #12649: kafka-run-class: MINOR: Fixing "egrep: warning: egrep is obsolescent; using …

2022-09-15 Thread GitBox
matthewstidham commented on PR #12649: URL: https://github.com/apache/kafka/pull/12649#issuecomment-1248865624 @showuon Thank you, I have updated the title and description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Updated] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-09-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13840: -- Fix Version/s: 3.2.1 > KafkaConsumer is unable to recover connection to group coordinator after > com

[jira] [Resolved] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-09-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13840. --- Resolution: Fixed > KafkaConsumer is unable to recover connection to group coordinator after > comm

[jira] [Commented] (KAFKA-14212) Fetch error response when hitting public OAuth/OIDC provider

2022-09-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605566#comment-17605566 ] Kirk True commented on KAFKA-14212: --- Thanks for finding this, Sushant! I see this Jira

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-15 Thread GitBox
guozhangwang commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r972414206 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4068,18 +3796,14 @@ public void shouldConvertStandbyTaskToActiveT

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-15 Thread GitBox
guozhangwang commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r972413951 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2180,29 +2035,16 @@ public void shouldCommitAllActiveTasksThatNe

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-15 Thread GitBox
guozhangwang commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r972413688 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4091,21 +3815,20 @@ public void shouldListNotPausedTasks() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-15 Thread GitBox
guozhangwang commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r972412952 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -325,25 +318,21 @@ public void shouldHandleRemovedTasksToRecycleF

[GitHub] [kafka] forlack commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-15 Thread GitBox
forlack commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r972385831 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] matthewstidham opened a new pull request, #12649: kafka-run-class: Fixing "egrep: warning: egrep is obsolescent; using …

2022-09-15 Thread GitBox
matthewstidham opened a new pull request, #12649: URL: https://github.com/apache/kafka/pull/12649 …grep -E" Signed-off-by: Matthew Stidham *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a sep

[GitHub] [kafka] lucasbru opened a new pull request, #12648: MINOR: Fixes in release.py

2022-09-15 Thread GitBox
lucasbru opened a new pull request, #12648: URL: https://github.com/apache/kafka/pull/12648 1) Permissions set incorrectly, probably because it used incorrect python3 syntax (octals should use 0o prefix). 2) JAVA_HOME logic didn't seem to hold up to its promise. The original logic

[GitHub] [kafka] vvcephei commented on a diff in pull request #12641: KAFKA-14209 : Change Topology optimization to accept list of rules 1/3

2022-09-15 Thread GitBox
vvcephei commented on code in PR #12641: URL: https://github.com/apache/kafka/pull/12641#discussion_r972139781 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -233,6 +235,15 @@ public class StreamsConfig extends AbstractConfig { @SuppressWarnings

[GitHub] [kafka] vvcephei commented on a diff in pull request #12641: KAFKA-14209 : Change Topology optimization to accept list of rules 1/3

2022-09-15 Thread GitBox
vvcephei commented on code in PR #12641: URL: https://github.com/apache/kafka/pull/12641#discussion_r972202540 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -1263,6 +1263,54 @@ public void testInvalidSecurityProtocol() { assertTrue(ce.

[GitHub] [kafka] vvcephei commented on a diff in pull request #12641: KAFKA-14209 : Change Topology optimization to accept list of rules 1/3

2022-09-15 Thread GitBox
vvcephei commented on code in PR #12641: URL: https://github.com/apache/kafka/pull/12641#discussion_r972139781 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -233,6 +235,15 @@ public class StreamsConfig extends AbstractConfig { @SuppressWarnings

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12641: KAFKA-14209 : Change Topology optimization to accept list of rules 1/3

2022-09-15 Thread GitBox
guozhangwang commented on code in PR #12641: URL: https://github.com/apache/kafka/pull/12641#discussion_r972339213 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -1263,6 +1263,54 @@ public void testInvalidSecurityProtocol() { assertTrue

[GitHub] [kafka] dplavcic commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-15 Thread GitBox
dplavcic commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1248454855 Yes, I will add the MR soon (next week). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] hshi2022 commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-15 Thread GitBox
hshi2022 commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1248445910 @dajac @rajinisivaram could you please review this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-15 Thread GitBox
guozhangwang commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r972283623 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -209,7 +212,9 @@ void registerStateStores(final List allStor

[GitHub] [kafka] jeqo opened a new pull request, #12647: KAFKA-14191: Add end-to-end latency metrics to Connectors

2022-09-15 Thread GitBox
jeqo opened a new pull request, #12647: URL: https://github.com/apache/kafka/pull/12647 KIP-864 implementation. *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests s

[jira] [Created] (KAFKA-14235) Document MM2 auto topic creation behavior for MM2-internal topics

2022-09-15 Thread Maruthi (Jira)
Maruthi created KAFKA-14235: --- Summary: Document MM2 auto topic creation behavior for MM2-internal topics Key: KAFKA-14235 URL: https://issues.apache.org/jira/browse/KAFKA-14235 Project: Kafka Issu

[GitHub] [kafka] C0urante commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-15 Thread GitBox
C0urante commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r972121384 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,11 +217,16 @@ private void parseArguments(final String[] args) { .ofType(String.class)

[GitHub] [kafka] lucasbru opened a new pull request, #12646: KAFKA-12689: Remove exactly_once / exactly_once_beta

2022-09-15 Thread GitBox
lucasbru opened a new pull request, #12646: URL: https://github.com/apache/kafka/pull/12646 Removes all code for handling the processing_guarantee settings exactly_once and exactly_once_beta, which have been deprecated since 3.0.0 and can be removed with the release of 4.0.0. Some te

[jira] [Resolved] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-09-15 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13985. --- Resolution: Fixed > MirrorSourceTask commitRecord throws NPE if SMT is filtering out source

[jira] [Updated] (KAFKA-13632) MirrorMaker 2.0 NPE and Warning "Failure to commit records" for filtered records

2022-09-15 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13632: -- Fix Version/s: 3.4.0 > MirrorMaker 2.0 NPE and Warning "Failure to commit records" for filtere

[jira] [Updated] (KAFKA-13632) MirrorMaker 2.0 NPE and Warning "Failure to commit records" for filtered records

2022-09-15 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13632: -- Affects Version/s: 3.2.0 3.3.0 > MirrorMaker 2.0 NPE and Warning "Failu

[jira] [Resolved] (KAFKA-13632) MirrorMaker 2.0 NPE and Warning "Failure to commit records" for filtered records

2022-09-15 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13632. --- Resolution: Fixed > MirrorMaker 2.0 NPE and Warning "Failure to commit records" for filtered

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-09-15 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13985: -- Affects Version/s: 3.3.0 > MirrorSourceTask commitRecord throws NPE if SMT is filtering out so

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-09-15 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13985: -- Fix Version/s: 3.4.0 > MirrorSourceTask commitRecord throws NPE if SMT is filtering out source

[GitHub] [kafka] C0urante merged pull request #12602: KAFKA-13985: Skip committing MirrorSourceTask records without metadata

2022-09-15 Thread GitBox
C0urante merged PR #12602: URL: https://github.com/apache/kafka/pull/12602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ijuma commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-15 Thread GitBox
ijuma commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971999299 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -109,14 +110,9 @@ public class StandardAuthorizerData { private fina

[GitHub] [kafka] ijuma commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-15 Thread GitBox
ijuma commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r972004724 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; } Rev

[GitHub] [kafka] ijuma commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-15 Thread GitBox
ijuma commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971999299 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -109,14 +110,9 @@ public class StandardAuthorizerData { private fina

[GitHub] [kafka] ijuma commented on pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-15 Thread GitBox
ijuma commented on PR #12636: URL: https://github.com/apache/kafka/pull/12636#issuecomment-1248110491 Thanks for the PR. @cmccabe can you please include the benchmark results before/after this change? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (KAFKA-12689) Remove deprecated EOS configs

2022-09-15 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-12689: -- Assignee: Lucas Brutschy (was: loboxu) > Remove deprecated EOS configs > ---

[GitHub] [kafka] showuon commented on pull request #12639: KAFKA-14233: do not init managers twice to avoid resource leak

2022-09-15 Thread GitBox
showuon commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1248055476 cc @ijuma , I think we should merge this fix soon to help our build turn red back to yellow/green light. https://user-images.githubusercontent.com/43372967/190407215-e2c95d76-0e81-4

[GitHub] [kafka] dajac commented on pull request #12645: MINOR: Log controller id/epoch when LeaderAndIsr, StopReplica and UpdateMetadata requests are fenced

2022-09-15 Thread GitBox
dajac commented on PR #12645: URL: https://github.com/apache/kafka/pull/12645#issuecomment-1247945472 Thanks @showuon. I will merge it when the builds complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] showuon commented on pull request #12639: KAFKA-14233: do not init managers twice to avoid resource leak

2022-09-15 Thread GitBox
showuon commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1247933895 There's been 3 straight builds not get terminated in the `:core:unitTest`. https://user-images.githubusercontent.com/43372967/190386149-93694736-db70-4196-b626-b07ff275adc2.png";>

[GitHub] [kafka] dajac opened a new pull request, #12645: MINOR: Log controller id/epoch when LeaderAndIsr, StopReplica and UpdateMetadata requests are fenced

2022-09-15 Thread GitBox
dajac opened a new pull request, #12645: URL: https://github.com/apache/kafka/pull/12645 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade not

[jira] [Commented] (KAFKA-3332) Consumer can't consume messages from zookeeper chroot

2022-09-15 Thread Hang HOU (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605224#comment-17605224 ] Hang HOU commented on KAFKA-3332: - I met this situation now in kafka 2.4.1. zookeeper.co

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-15 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971709124 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -209,7 +212,9 @@ void registerStateStores(final List allStores,

[GitHub] [kafka] vpapavas opened a new pull request, #12644: KAFKA-14209 : Rewrite self joins to use single state store 2/3

2022-09-15 Thread GitBox
vpapavas opened a new pull request, #12644: URL: https://github.com/apache/kafka/pull/12644 KIP can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-862%3A+Self-join It only applies to Stream-Stream joins and not n-way self-joins. This is an inner-join topo

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-15 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971663927 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRegister.java: ## @@ -31,6 +33,8 @@ public interface ChangelogRegister { */ voi

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-15 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971663620 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -347,6 +348,12 @@ public void register(final TopicPartition partit

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-15 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971662847 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -444,6 +451,8 @@ public void restore(final Map tasks) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-15 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971662847 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -444,6 +451,8 @@ public void restore(final Map tasks) {

[GitHub] [kafka] showuon commented on pull request #12639: KAFKA-14233: do not init managers twice to avoid resource leak

2022-09-15 Thread GitBox
showuon commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1247685312 @divijvaidya , thanks. > I am curious, how did you narrow down that Gradle Test Executor 128 is related to testReloadUpdatedFilesWithoutConfigChange. Did you check the the logs and

[GitHub] [kafka] showuon closed pull request #12334: MINOR: [WIP] build tests

2022-09-15 Thread GitBox
showuon closed pull request #12334: MINOR: [WIP] build tests URL: https://github.com/apache/kafka/pull/12334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m