[jira] [Commented] (KAFKA-14063) CVE-2022-34917: Kafka message parsing can cause ooms with small antagonistic payloads

2022-09-26 Thread Swathi Mocharla (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609820#comment-17609820 ] Swathi Mocharla commented on KAFKA-14063: - hi [~omkreddy], Will there be an official PR created

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2022-09-26 Thread GitBox
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r980725833 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1237,6 +1238,35 @@ public void testInitTransactionWhileThrottled() {

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609798#comment-17609798 ] Guozhang Wang commented on KAFKA-10635: --- HI [~nicktelford] just making sure you get the latest

[GitHub] [kafka] showuon commented on pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
showuon commented on PR #12682: URL: https://github.com/apache/kafka/pull/12682#issuecomment-125447 backport to 3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] showuon merged pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
showuon merged PR #12682: URL: https://github.com/apache/kafka/pull/12682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #12688: MINOR: Delete config/kraft/README.me

2022-09-26 Thread GitBox
showuon commented on PR #12688: URL: https://github.com/apache/kafka/pull/12688#issuecomment-1258885468 @ijuma , we've just merged the updated readme for kraft: https://github.com/apache/kafka/pull/12642 . I don't think this is out of date now. -- This is an automated message from the

[GitHub] [kafka] showuon commented on pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
showuon commented on PR #12682: URL: https://github.com/apache/kafka/pull/12682#issuecomment-1258882134 > @showuon I'd appreciate one more look before we merge if you have time. Thanks! Will merge it soon. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] showuon commented on a diff in pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
showuon commented on code in PR #12682: URL: https://github.com/apache/kafka/pull/12682#discussion_r980670293 ## docs/security.html: ## @@ -36,7 +36,136 @@ 7.2 Encryption and Authentication using SSL +7.2 Listener Configuration + +In order to secure a Kafka cluster, it

[GitHub] [kafka] hachikuji commented on pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
hachikuji commented on PR #12682: URL: https://github.com/apache/kafka/pull/12682#issuecomment-1258878768 @showuon I'd appreciate one more look before we merge if you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] LinShunKang commented on pull request #12683: KAFKA-4852: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not compatible with offsets

2022-09-26 Thread GitBox
LinShunKang commented on PR #12683: URL: https://github.com/apache/kafka/pull/12683#issuecomment-1258853602 > Re-starting tests, if they pass I think we can merge it. I re-run the tests on branch trunk, but it also fails, and the branch fix/ByteBufferSerializer is checked out from

[GitHub] [kafka] hachikuji commented on a diff in pull request #12691: MINOR: Small update docs/design.html grammar and typo

2022-09-26 Thread GitBox
hachikuji commented on code in PR #12691: URL: https://github.com/apache/kafka/pull/12691#discussion_r980626434 ## docs/design.html: ## @@ -322,7 +322,7 @@

[GitHub] [kafka] forlack opened a new pull request, #12691: MINOR: Small update docs/design.html grammar and typo

2022-09-26 Thread GitBox
forlack opened a new pull request, #12691: URL: https://github.com/apache/kafka/pull/12691 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Assigned] (KAFKA-14253) StreamsPartitionAssignor should print the member count in assignment logs

2022-09-26 Thread Christopher Pooya Razavian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Pooya Razavian reassigned KAFKA-14253: -- Assignee: Christopher Pooya Razavian >

[jira] [Commented] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

2022-09-26 Thread Avi Cherry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609709#comment-17609709 ] Avi Cherry commented on KAFKA-14260: [~guozhang] as far as I can see, your PR with the "copyOnRange"

[jira] [Commented] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

2022-09-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609705#comment-17609705 ] Guozhang Wang commented on KAFKA-14260: --- Hello [~aviperksy] just checking is

[GitHub] [kafka] guozhangwang commented on pull request #12683: KAFKA-4852: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not compatible with offsets

2022-09-26 Thread GitBox
guozhangwang commented on PR #12683: URL: https://github.com/apache/kafka/pull/12683#issuecomment-1258711127 Re-starting tests, if they pass I think we can merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-14261) Dependency Vulnerability Scan Results (Mend/WhiteSource)

2022-09-26 Thread VeeVee Wang (Jira)
VeeVee Wang created KAFKA-14261: --- Summary: Dependency Vulnerability Scan Results (Mend/WhiteSource) Key: KAFKA-14261 URL: https://issues.apache.org/jira/browse/KAFKA-14261 Project: Kafka Issue

[GitHub] [kafka] hachikuji commented on a diff in pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
hachikuji commented on code in PR #12682: URL: https://github.com/apache/kafka/pull/12682#discussion_r980518429 ## docs/security.html: ## @@ -36,7 +36,104 @@ 7.2 Encryption and Authentication using SSL +7.2 Listener Configuration + +In order to secure a Kafka cluster,

[GitHub] [kafka] hshi2022 commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-26 Thread GitBox
hshi2022 commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1258645793 > @hshi2022 Thanks for the patch. Did you catch this deadlock in practice or did you use some tool to find it? We caught in practice. -- This is an automated message from the

[GitHub] [kafka] hachikuji commented on a diff in pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
hachikuji commented on code in PR #12682: URL: https://github.com/apache/kafka/pull/12682#discussion_r980495338 ## docs/security.html: ## @@ -36,7 +36,104 @@ 7.2 Encryption and Authentication using SSL +7.2 Listener Configuration + +In order to secure a Kafka cluster,

[GitHub] [kafka] hachikuji commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-26 Thread GitBox
hachikuji commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1258622106 @hshi2022 Thanks for the patch. Did you catch this deadlock in practice or did you use some tool to find it? -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (KAFKA-12370) Refactor KafkaStreams exposed metadata hierarchy

2022-09-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12370: -- Description: Currently in KafkaStreams we have two groups of metadata getter: 1. {code}

[GitHub] [kafka] jsancio commented on a diff in pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
jsancio commented on code in PR #12682: URL: https://github.com/apache/kafka/pull/12682#discussion_r980449119 ## docs/security.html: ## @@ -36,7 +36,104 @@ 7.2 Encryption and Authentication using SSL +7.2 Listener Configuration + +In order to secure a Kafka cluster, it

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: KAFKA-14247: Define event handler interface and events

2022-09-26 Thread GitBox
philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r980468305 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a diff in pull request #12663: KAFKA-14247: Define event handler interface and events

2022-09-26 Thread GitBox
hachikuji commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r980464181 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji merged pull request #12690: MINOR: Update design docs to avoid zookeeper-specific assumptions

2022-09-26 Thread GitBox
hachikuji merged PR #12690: URL: https://github.com/apache/kafka/pull/12690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji opened a new pull request, #12690: MINOR: Update design docs to avoid zookeeper-specific assumptions

2022-09-26 Thread GitBox
hachikuji opened a new pull request, #12690: URL: https://github.com/apache/kafka/pull/12690 There are a few cases in the design documentation which need to be updated for KRaft. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] cadonna merged pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna merged PR #12687: URL: https://github.com/apache/kafka/pull/12687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12644: KAFKA-14209 : Rewrite self joins to use single state store 2/3

2022-09-26 Thread GitBox
guozhangwang commented on code in PR #12644: URL: https://github.com/apache/kafka/pull/12644#discussion_r980366498 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -375,6 +382,48 @@ private void mergeDuplicateSourceNodes() {

[GitHub] [kafka] cadonna commented on pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna commented on PR #12687: URL: https://github.com/apache/kafka/pull/12687#issuecomment-1258446812 Build failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=kraft Build / JDK 11

[jira] [Updated] (KAFKA-14207) Add a 6.10 section for KRaft

2022-09-26 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14207: --- Fix Version/s: 3.3.0 > Add a 6.10 section for KRaft >

[jira] [Resolved] (KAFKA-14207) Add a 6.10 section for KRaft

2022-09-26 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-14207. Resolution: Fixed > Add a 6.10 section for KRaft >

[GitHub] [kafka] jsancio merged pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-26 Thread GitBox
jsancio merged PR #12642: URL: https://github.com/apache/kafka/pull/12642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] see-quick opened a new pull request, #12689: MINOR: Improve unit test coverage of LeaderAndIsr class

2022-09-26 Thread GitBox
see-quick opened a new pull request, #12689: URL: https://github.com/apache/kafka/pull/12689 Signed-off-by: morsak This PR adds a few test cases for `LeaderAndIsr` class. Currently, on the UNIT level, we check `newRecoveringLeaderAndIsr` method. Therefore I have created mostly all

[GitHub] [kafka] jsancio commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-26 Thread GitBox
jsancio commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r980343819 ## config/kraft/README.md: ## @@ -110,19 +105,15 @@ This is particularly important for the metadata log maintained by the controller nothing in the log, which would

[GitHub] [kafka] jsancio commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-26 Thread GitBox
jsancio commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r980338126 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12659: KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-26 Thread GitBox
guozhangwang commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r980338228 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java: ## @@ -170,6 +174,27 @@ public int hashCode() { */ Set

[GitHub] [kafka] jsancio commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-26 Thread GitBox
jsancio commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r980338126 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12659: KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-26 Thread GitBox
guozhangwang commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r980337970 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -500,23 +500,29 @@ public void remove(final TaskId taskId) {

[GitHub] [kafka] divijvaidya commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-26 Thread GitBox
divijvaidya commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1258336831 @C0urante I won't be able to pick this up until 16th Oct. If no one has picked this up my then, I would happily pick it up. A problem that is common amongst the tests that I am

[jira] [Updated] (KAFKA-10140) Incremental config api excludes plugin config changes

2022-09-26 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-10140: --- Description: I was trying to alter the jmx metric filters using the

[jira] [Updated] (KAFKA-10140) Incremental config api excludes plugin config changes

2022-09-26 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10140: Description: I was trying to alter the jmx metric filters using the incremental alter

[GitHub] [kafka] hachikuji commented on a diff in pull request #12682: MINOR: Add section on listener configuration (including kraft) to security docs

2022-09-26 Thread GitBox
hachikuji commented on code in PR #12682: URL: https://github.com/apache/kafka/pull/12682#discussion_r980271965 ## docs/security.html: ## @@ -36,7 +36,101 @@ 7.2 Encryption and Authentication using SSL +7.2 Listener Configuration + +In order to secure a Kafka cluster,

[jira] [Updated] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

2022-09-26 Thread Avi Cherry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avi Cherry updated KAFKA-14260: --- Affects Version/s: 2.3.1 > InMemoryKeyValueStore iterator still throws

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-26 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1258272010 @dplavcic No worries, it happens :) @yashmayya @mdedetrich @clolov @divijvaidya any interest in taking this one on? Fairly high-priority as it's blocking other PRs. -- This is

[GitHub] [kafka] dplavcic commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-26 Thread GitBox
dplavcic commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1258270035 Hi @C0urante, I'm really sorry but I didn't have time to complete this on planned schedule (last week). It would be awesome if someone else can complete this (and unblock other PRs).

[GitHub] [kafka] ijuma commented on pull request #12065: KAFKA-13788: Use AdminClient.incrementalAlterConfigs in ConfigCommand

2022-09-26 Thread GitBox
ijuma commented on PR #12065: URL: https://github.com/apache/kafka/pull/12065#issuecomment-1258220878 @dajac Would falling back have the same semantics? If not, it's a bit more complicated. I suggest we need a KIP to cover the proposal details. Given that 2.4 is pretty old these days and

[GitHub] [kafka] C0urante commented on pull request #10910: KAFKA-12965 - Graceful clean up of task error metrics

2022-09-26 Thread GitBox
C0urante commented on PR #10910: URL: https://github.com/apache/kafka/pull/10910#issuecomment-1258142812 No worries! If for some reason it's difficult to find the time to carry this across the finish line, let me know and I can either complete the remaining work myself or find another

[GitHub] [kafka] ramesh-muthusamy commented on pull request #10910: KAFKA-12965 - Graceful clean up of task error metrics

2022-09-26 Thread GitBox
ramesh-muthusamy commented on PR #10910: URL: https://github.com/apache/kafka/pull/10910#issuecomment-1258139870 > Hi @ramesh-muthusamy--any plans to rebase this? Hi Chris, I will get to this this weekend. Apologies for the delay. -- This is an automated message from the Apache

[jira] [Comment Edited] (KAFKA-14063) CVE-2022-34917: Kafka message parsing can cause ooms with small antagonistic payloads

2022-09-26 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608137#comment-17608137 ] Manikumar edited comment on KAFKA-14063 at 9/26/22 2:21 PM: commit for 2.8

[jira] [Comment Edited] (KAFKA-14063) CVE-2022-34917: Kafka message parsing can cause ooms with small antagonistic payloads

2022-09-26 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608137#comment-17608137 ] Manikumar edited comment on KAFKA-14063 at 9/26/22 2:21 PM: commit for 2.8

[GitHub] [kafka] mumrah merged pull request #12678: MINOR: update configuration.html with KRaft details

2022-09-26 Thread GitBox
mumrah merged PR #12678: URL: https://github.com/apache/kafka/pull/12678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma opened a new pull request, #12688: MINOR: Delete config/kraft/README.me

2022-09-26 Thread GitBox
ijuma opened a new pull request, #12688: URL: https://github.com/apache/kafka/pull/12688 It's out of data and we have since updated the main documentation to cover KRaft. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] C0urante commented on pull request #10910: KAFKA-12965 - Graceful clean up of task error metrics

2022-09-26 Thread GitBox
C0urante commented on PR #10910: URL: https://github.com/apache/kafka/pull/10910#issuecomment-1258046216 Hi @ramesh-muthusamy--any plans to rebase this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cadonna commented on a diff in pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna commented on code in PR #12687: URL: https://github.com/apache/kafka/pull/12687#discussion_r979979250 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -292,7 +292,9 @@ private void removeTask(final TaskId taskId) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna commented on code in PR #12687: URL: https://github.com/apache/kafka/pull/12687#discussion_r979978934 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java: ## @@ -674,7 +674,24 @@ public void

[GitHub] [kafka] cadonna commented on a diff in pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna commented on code in PR #12687: URL: https://github.com/apache/kafka/pull/12687#discussion_r979978529 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -84,7 +84,7 @@ public Collection getUpdatingStandbyTasks() {

[GitHub] [kafka] cadonna commented on pull request #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna commented on PR #12687: URL: https://github.com/apache/kafka/pull/12687#issuecomment-1257964043 Call for review: @wcarlson5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cadonna opened a new pull request, #12687: KAFKA-10199: Fix switching to updating standbys if standby is removed

2022-09-26 Thread GitBox
cadonna opened a new pull request, #12687: URL: https://github.com/apache/kafka/pull/12687 When the state updater only contains standby tasks and then a standby task is removed, an IllegalStateException is thrown because the changelog reader does not allow to switch to standby updating

[GitHub] [kafka] vpapavas closed pull request #12555: Optimize self-join

2022-09-26 Thread GitBox
vpapavas closed pull request #12555: Optimize self-join URL: https://github.com/apache/kafka/pull/12555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on a diff in pull request #12659: KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-26 Thread GitBox
cadonna commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r979883060 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -500,23 +500,29 @@ public void remove(final TaskId taskId) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12659: KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-26 Thread GitBox
cadonna commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r979883060 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -500,23 +500,29 @@ public void remove(final TaskId taskId) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12659: KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-26 Thread GitBox
cadonna commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r979837654 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java: ## @@ -170,6 +174,27 @@ public int hashCode() { */ Set getTasks();

[GitHub] [kafka] ajborley commented on pull request #12440: KAFKA-14107: Upgrade Jetty version for CVE fixes

2022-09-26 Thread GitBox
ajborley commented on PR #12440: URL: https://github.com/apache/kafka/pull/12440#issuecomment-1257571494 No, this is just a dependency update. The fix must have been in either https://github.com/apache/kafka/pull/12603 or https://github.com/apache/kafka/pull/12626 as those are the only

[GitHub] [kafka] showuon commented on pull request #12679: MINOR: Adding KRaft Monitoring Related Metrics to docs/ops.html

2022-09-26 Thread GitBox
showuon commented on PR #12679: URL: https://github.com/apache/kafka/pull/12679#issuecomment-1257540453 backport to v3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] showuon merged pull request #12679: MINOR: Adding KRaft Monitoring Related Metrics to docs/ops.html

2022-09-26 Thread GitBox
showuon merged PR #12679: URL: https://github.com/apache/kafka/pull/12679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #12679: MINOR: Adding KRaft Monitoring Related Metrics to docs/ops.html

2022-09-26 Thread GitBox
showuon commented on PR #12679: URL: https://github.com/apache/kafka/pull/12679#issuecomment-1257537908 Failed tests are unrelated: ``` Build / JDK 11 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft-Distributed, Name=testPathToJsonFile, MetadataVersion=3.3-IV3,