cmccabe commented on PR #12695:
URL: https://github.com/apache/kafka/pull/12695#issuecomment-1261804450
I added two tests. One unit test and one integration test. I verified that
both fail without the fix. The integration tests succeeds with AclAuthorizer
prior to the StandardAuthorizer fix
hachikuji commented on code in PR #12695:
URL: https://github.com/apache/kafka/pull/12695#discussion_r982972020
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java:
##
@@ -394,35 +399,61 @@ private MatchingAclRule findAclRule(
retu
wykkevin closed pull request #12696: Insert ctest config in scala
URL: https://github.com/apache/kafka/pull/12696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
Colin McCabe created KAFKA-14265:
Summary: Prefix ACLs may shadow other prefix ACLs
Key: KAFKA-14265
URL: https://issues.apache.org/jira/browse/KAFKA-14265
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610748#comment-17610748
]
Alex Collins commented on KAFKA-2526:
-
I've created a PR to fix this.
[https://gith
guozhangwang merged PR #12659:
URL: https://github.com/apache/kafka/pull/12659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
hachikuji commented on code in PR #12634:
URL: https://github.com/apache/kafka/pull/12634#discussion_r982935129
##
core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala:
##
@@ -30,6 +30,9 @@ import scala.jdk.CollectionConverters._
object ClientRequestQuotaManager {
alexec opened a new pull request, #12694:
URL: https://github.com/apache/kafka/pull/12694
Signed-off-by: Alex Collins
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping
hshi2022 commented on PR #12634:
URL: https://github.com/apache/kafka/pull/12634#issuecomment-1261498478
@hachikuji Thanks for review. I have addressed your comments. And I am
wondering whether you know how to rerun the checks/tests without submitting any
changes. This PR currently fails a
hshi2022 commented on code in PR #12634:
URL: https://github.com/apache/kafka/pull/12634#discussion_r982817712
##
core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala:
##
@@ -30,6 +30,9 @@ import scala.jdk.CollectionConverters._
object ClientRequestQuotaManager {
[
https://issues.apache.org/jira/browse/KAFKA-13657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13657:
---
Fix Version/s: (was: 3.3)
> StandardAuthorizer should implement
[
https://issues.apache.org/jira/browse/KAFKA-13206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13206:
---
Fix Version/s: (was: 3.3)
> shutting down broker needs to stop f
[
https://issues.apache.org/jira/browse/KAFKA-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-14259.
Resolution: Fixed
> BrokerRegistration#toString throws an exceptio
[
https://issues.apache.org/jira/browse/KAFKA-13806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13806:
---
Fix Version/s: (was: 3.3)
> Check CRC when reading snapshots
> -
[
https://issues.apache.org/jira/browse/KAFKA-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14259:
---
Fix Version/s: 3.3.0
(was: 3.3)
> BrokerRegis
[
https://issues.apache.org/jira/browse/KAFKA-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14259:
---
Affects Version/s: (was: 3.3)
> BrokerRegistration#toString thro
see-quick commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982830205
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return elec
philipnee commented on code in PR #12663:
URL: https://github.com/apache/kafka/pull/12663#discussion_r982820685
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPrototypeAsyncConsumer.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
guozhangwang commented on PR #12683:
URL: https://github.com/apache/kafka/pull/12683#issuecomment-1261408099
I re-run the test case in trunk as well as in your branch locally with IDE,
and both passes, so I think it's due to jenkins machines compute resource limit
itself.
But I got a
philipnee commented on code in PR #12663:
URL: https://github.com/apache/kafka/pull/12663#discussion_r982803945
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPrototypeAsyncConsumer.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
hachikuji commented on code in PR #12663:
URL: https://github.com/apache/kafka/pull/12663#discussion_r982794220
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPrototypeAsyncConsumer.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
divijvaidya commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r982716173
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -452,25 +441,24 @@ public void
shouldNotUseSameStor
hachikuji commented on PR #12669:
URL: https://github.com/apache/kafka/pull/12669#issuecomment-1261291916
I started one more build since the last one had a bunch of failures due to a
lingering thread.
--
This is an automated message from the Apache Git Service.
To respond to the message,
divijvaidya commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r982709687
##
clients/src/main/java/org/apache/kafka/common/protocol/types/TaggedFields.java:
##
@@ -165,7 +165,7 @@ public Map validate(Object item) {
}
divijvaidya commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r982695511
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1941,79 @@ private Map
topicPartitionTags(TopicPartition tp) {
jolshan commented on PR #12392:
URL: https://github.com/apache/kafka/pull/12392#issuecomment-1261212204
@urbandan
> If it is better to keep the producer in a usable state, I can give it a
shot. I had one experiment in which I tried keeping the producer usable by
increasing the epoch on
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13888:
---
Summary: KIP-836: Expose replication information of the cluster metad
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r982661269
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java:
##
@@ -517,13 +517,13 @@ public void testTaskAs
[
https://issues.apache.org/jira/browse/KAFKA-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13410:
---
Summary: KRaft to KRaft Upgrades (was: KRaft Upgrades)
> KRaft to K
C0urante commented on PR #12671:
URL: https://github.com/apache/kafka/pull/12671#issuecomment-1261137537
That's interesting--were you running a dedicated MM2 cluster, or were you
deploying MM2 as a connector on a vanilla Kafka Connect cluster? And if the
latter, were you able to read the st
viktorsomogyi commented on PR #12671:
URL: https://github.com/apache/kafka/pull/12671#issuecomment-1261125559
To me it seems like it persists. Let me explain what I see in my logs, maybe
I'm in the wrong here.
So first let's start when it stops the task during the frequent rebalances:
divijvaidya commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r898097965
##
core/src/main/scala/kafka/log/remote/RemoteLogManager.scala:
##
@@ -0,0 +1,291 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
see-quick commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982473889
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return elec
ijuma commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r982463816
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1941,79 @@ private Map
topicPartitionTags(TopicPartition tp) {
ijuma commented on PR #12688:
URL: https://github.com/apache/kafka/pull/12688#issuecomment-1260973649
@showuon Yes, I know, but I still think we should delete it since we now
have the documentation in the right place. This was a placeholder until we had
that.
--
This is an automated mess
mimaison commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982449921
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return elect
see-quick commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982443619
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return elec
ijuma commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r982437499
##
clients/src/main/java/org/apache/kafka/common/protocol/types/TaggedFields.java:
##
@@ -165,7 +165,7 @@ public Map validate(Object item) {
}
re
divijvaidya commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982359239
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return el
mimaison commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982348035
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return elect
[
https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-10733:
---
Summary: Enhance Transactional Producer Exception Handling (was: Enforce
exception thrown f
[
https://issues.apache.org/jira/browse/KAFKA-14257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jianbin.chen closed KAFKA-14257.
> Unexpected error INCONSISTENT_CLUSTER_ID in VOTE response
>
[
https://issues.apache.org/jira/browse/KAFKA-14257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jianbin.chen resolved KAFKA-14257.
--
Resolution: Done
> Unexpected error INCONSISTENT_CLUSTER_ID in VOTE response
> ---
see-quick commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982190906
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return elec
[
https://issues.apache.org/jira/browse/KAFKA-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610459#comment-17610459
]
Hang HOU edited comment on KAFKA-3332 at 9/28/22 9:19 AM:
--
About
[
https://issues.apache.org/jira/browse/KAFKA-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610459#comment-17610459
]
Hang HOU commented on KAFKA-3332:
-
About my last description,I found it was my mistake. I
divijvaidya commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982147666
##
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return el
47 matches
Mail list logo
