[GitHub] [kafka] LinShunKang commented on pull request #12683: KAFKA-4852: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not compatible with offsets

2022-09-29 Thread GitBox
LinShunKang commented on PR #12683: URL: https://github.com/apache/kafka/pull/12683#issuecomment-1262595051 > I re-run the test case in trunk as well as in your branch locally with IDE, and both passes, so I think it's due to jenkins machines compute resource limit itself. > > But I

[GitHub] [kafka] divijvaidya commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-09-29 Thread GitBox
divijvaidya commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r983849860 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -169,4 +181,140 @@ class ReplicaFetcherThread(name: String, partition.truncateFullyAndStar

[GitHub] [kafka] divijvaidya commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-09-29 Thread GitBox
divijvaidya commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r983849860 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -169,4 +181,140 @@ class ReplicaFetcherThread(name: String, partition.truncateFullyAndStar

[GitHub] [kafka] guozhangwang merged pull request #12683: KAFKA-4852: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not compatible with offsets

2022-09-29 Thread GitBox
guozhangwang merged PR #12683: URL: https://github.com/apache/kafka/pull/12683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Updated] (KAFKA-4852) ByteBufferSerializer not compatible with offsets

2022-09-29 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-4852: - Fix Version/s: 3.4.0 > ByteBufferSerializer not compatible with offsets > ---

[jira] [Updated] (KAFKA-14265) Prefix ACLs may shadow other prefix ACLs

2022-09-29 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14265: --- Fix Version/s: 3.3.1 > Prefix ACLs may shadow other prefix ACLs > --

[jira] [Updated] (KAFKA-14265) Prefix ACLs may shadow other prefix ACLs

2022-09-29 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14265: --- Affects Version/s: 3.3.0 > Prefix ACLs may shadow other prefix ACLs

[jira] [Updated] (KAFKA-14259) BrokerRegistration#toString throws an exception, terminating metadata replay

2022-09-29 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14259: --- Affects Version/s: 3.3.0 > BrokerRegistration#toString throws an exc

[jira] [Updated] (KAFKA-14259) BrokerRegistration#toString throws an exception, terminating metadata replay

2022-09-29 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14259: --- Fix Version/s: 3.3.1 (was: 3.3.0) > BrokerReg

[jira] [Resolved] (KAFKA-14265) Prefix ACLs may shadow other prefix ACLs

2022-09-29 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-14265. Resolution: Fixed > Prefix ACLs may shadow other prefix ACLs > ---

[GitHub] [kafka] alexec commented on pull request #12697: KAFKA-2526 : fix deserializer/serializer from properties for console …

2022-09-29 Thread GitBox
alexec commented on PR #12697: URL: https://github.com/apache/kafka/pull/12697#issuecomment-1262651094 @mjsax can I please request review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] alexec commented on pull request #12698: Add ExceptionHandlingDeserializer

2022-09-29 Thread GitBox
alexec commented on PR #12698: URL: https://github.com/apache/kafka/pull/12698#issuecomment-1262652496 @yeralin can I please request review from you as you know this code and are a recent committer. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] alexec opened a new pull request, #12699: Add PipeDeserializer/PipeSerializer

2022-09-29 Thread GitBox
alexec opened a new pull request, #12699: URL: https://github.com/apache/kafka/pull/12699 Signed-off-by: Alex Collins *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping rev

[GitHub] [kafka] alexec commented on pull request #12698: Add ExceptionHandlingDeserializer

2022-09-29 Thread GitBox
alexec commented on PR #12698: URL: https://github.com/apache/kafka/pull/12698#issuecomment-1262660882 Needs KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Created] (KAFKA-14268) When aggregating on a KGroupedStream allow an InitializerWithKey

2022-09-29 Thread Christopher Meier (Jira)
Christopher Meier created KAFKA-14268: - Summary: When aggregating on a KGroupedStream allow an InitializerWithKey Key: KAFKA-14268 URL: https://issues.apache.org/jira/browse/KAFKA-14268 Project: K

[GitHub] [kafka] eikemeier opened a new pull request, #12700: Fix generated Kafka Streams version file name

2022-09-29 Thread GitBox
eikemeier opened a new pull request, #12700: URL: https://github.com/apache/kafka/pull/12700 Kafka Streams expects a version resource at /kafka/kafka-streams-version.properties. It is read by `ClientMetrics`, initialised by https://github.com/apache/kafka/blob/3.3.0/streams/src/main

[jira] [Commented] (KAFKA-14267) CVE-2022-36944 - Scala deserialization bug

2022-09-29 Thread Zach Fry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611180#comment-17611180 ] Zach Fry commented on KAFKA-14267: -- Upon some investigation, I wasn't able to find anyw

[GitHub] [kafka] jsancio opened a new pull request, #12701: MINOR; Update upgrade documentation for 3.3.1

2022-09-29 Thread GitBox
jsancio opened a new pull request, #12701: URL: https://github.com/apache/kafka/pull/12701 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] jsancio merged pull request #12701: MINOR; Update upgrade documentation for 3.3.1

2022-09-29 Thread GitBox
jsancio merged PR #12701: URL: https://github.com/apache/kafka/pull/12701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] jsancio opened a new pull request, #12702: MINOR; Add missing code end tag

2022-09-29 Thread GitBox
jsancio opened a new pull request, #12702: URL: https://github.com/apache/kafka/pull/12702 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] jsancio merged pull request #12702: MINOR; Add missing code end tag

2022-09-29 Thread GitBox
jsancio merged PR #12702: URL: https://github.com/apache/kafka/pull/12702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] hachikuji opened a new pull request, #12703: MINOR: Add initial property tests for StandardAuthorizer

2022-09-29 Thread GitBox
hachikuji opened a new pull request, #12703: URL: https://github.com/apache/kafka/pull/12703 In https://github.com/apache/kafka/pull/12695, we discovered a gap in our testing of `StandardAuthorizer`. We addressed the specific case that was failing, but I think we need to establish a better

[GitHub] [kafka] hachikuji merged pull request #12669: KAFKA-14248: Fix flaky test PlaintextAdminIntegrationTest.testCreateTopicsReturnsConfigs

2022-09-29 Thread GitBox
hachikuji merged PR #12669: URL: https://github.com/apache/kafka/pull/12669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Commented] (KAFKA-4852) ByteBufferSerializer not compatible with offsets

2022-09-29 Thread Werner Daehn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611345#comment-17611345 ] Werner Daehn commented on KAFKA-4852: - Thanks! > ByteBufferSerializer not compatible

[jira] [Commented] (KAFKA-4852) ByteBufferSerializer not compatible with offsets

2022-09-29 Thread LinShunkang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611351#comment-17611351 ] LinShunkang commented on KAFKA-4852: That's all right : ) > ByteBufferSerializer not

[GitHub] [kafka] urbandan commented on pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-09-29 Thread GitBox
urbandan commented on PR #12392: URL: https://github.com/apache/kafka/pull/12392#issuecomment-1261958861 @jolshan It is an idea, the first version of the PR was trying to implement that, but the current state of the PR is based on the fatal state. The idea about keeping the producer i

[GitHub] [kafka] divijvaidya commented on pull request #12669: KAFKA-14248: Fix flaky test PlaintextAdminIntegrationTest.testCreateTopicsReturnsConfigs

2022-09-29 Thread GitBox
divijvaidya commented on PR #12669: URL: https://github.com/apache/kafka/pull/12669#issuecomment-1262126497 Test failures are unrelated. > Build / JDK 17 and Scala 2.13 / testTransactionAfterProducerIdExpires(String).quorum=zk - kafka.api.TransactionsExpirationTest > Build / JDK 1

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12692: MINOR: Add test cases to the Raft module

2022-09-29 Thread GitBox
divijvaidya commented on code in PR #12692: URL: https://github.com/apache/kafka/pull/12692#discussion_r983414080 ## raft/src/main/java/org/apache/kafka/raft/VotedState.java: ## @@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs) { return el

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

2022-09-29 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611018#comment-17611018 ] zhangzhisheng commented on KAFKA-12946: --- upgrade 2.4.2 > __consumer_offsets topic

[GitHub] [kafka] showuon commented on a diff in pull request #12639: KAFKA-14242: do not init managers twice to avoid resource leak

2022-09-29 Thread GitBox
showuon commented on code in PR #12639: URL: https://github.com/apache/kafka/pull/12639#discussion_r983504767 ## core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataPublisherTest.scala: ## @@ -178,15 +181,21 @@ class BrokerMetadataPublisherTest { private def newMoc

[GitHub] [kafka] showuon commented on pull request #12639: KAFKA-14242: use mock managers to avoid duplicated resource allocation

2022-09-29 Thread GitBox
showuon commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1262235095 @hachikuji , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (KAFKA-14266) MirrorSourceTask will stop mirroring when get the corrupt record

2022-09-29 Thread Yu Wang (Jira)
Yu Wang created KAFKA-14266: --- Summary: MirrorSourceTask will stop mirroring when get the corrupt record Key: KAFKA-14266 URL: https://issues.apache.org/jira/browse/KAFKA-14266 Project: Kafka Issue

[jira] [Updated] (KAFKA-14266) MirrorSourceTask will stop mirroring when get the corrupt record

2022-09-29 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-14266: Description: The mirror task will keeping throwing this error when got a corrupt record {code:java} [2022-

[jira] [Updated] (KAFKA-14266) MirrorSourceTask will stop mirroring when get the corrupt record

2022-09-29 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-14266: Issue Type: Bug (was: Improvement) > MirrorSourceTask will stop mirroring when get the corrupt record > -

[jira] [Updated] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-29 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-14266: Summary: MirrorSourceTask will stop mirroring when get corrupt record (was: MirrorSourceTask will stop mi

[GitHub] [kafka] see-quick commented on a diff in pull request #12692: MINOR: Add test cases to the Raft module

2022-09-29 Thread GitBox
see-quick commented on code in PR #12692: URL: https://github.com/apache/kafka/pull/12692#discussion_r983614070 ## raft/src/main/java/org/apache/kafka/raft/VotedState.java: ## @@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs) { return elec

[jira] [Updated] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-29 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-14266: Description: The mirror task will keeping throwing this error when got a corrupt record {code:java} [2022-

[jira] [Updated] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-29 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-14266: Description: The mirror task will keeping throwing this error when got a corrupt record {code:java} [2022-

[GitHub] [kafka] szalapski commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

2022-09-29 Thread GitBox
szalapski commented on PR #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-1262375026 Would love to get this fixed. How can I help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-29 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang reassigned KAFKA-14266: --- Assignee: Yu Wang > MirrorSourceTask will stop mirroring when get corrupt record >

[GitHub] [kafka] alexec commented on pull request #12694: KAFKA-2526 : fix deserializer/serializer from properties for console consume/producer

2022-09-29 Thread GitBox
alexec commented on PR #12694: URL: https://github.com/apache/kafka/pull/12694#issuecomment-1262401939 Replaced by https://github.com/apache/kafka/pull/12697. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] alexec opened a new pull request, #12697: KAFKA-2526 : fix deserializer/serializer from properties for console …

2022-09-29 Thread GitBox
alexec opened a new pull request, #12697: URL: https://github.com/apache/kafka/pull/12697 Signed-off-by: Alex Collins Fixes [KAFKA-2526](https://issues.apache.org/jira/browse/KAFKA-2526) Configuration of the `ConsoleProducer` and `ConsoleConsumer` has been broken since 2017. Despi

[GitHub] [kafka] alexec closed pull request #12694: KAFKA-2526 : fix deserializer/serializer from properties for console consume/producer

2022-09-29 Thread GitBox
alexec closed pull request #12694: KAFKA-2526 : fix deserializer/serializer from properties for console consume/producer URL: https://github.com/apache/kafka/pull/12694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] BrokenWingsIcarus commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2022-09-29 Thread GitBox
BrokenWingsIcarus commented on PR #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-1262432302 by casuse see [http ://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6728842](http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6728842) -- This is an automated message from the

[GitHub] [kafka] hachikuji commented on pull request #12695: KAFKA-14265: Prefix ACLs may shadow other prefix ACLs

2022-09-29 Thread GitBox
hachikuji commented on PR #12695: URL: https://github.com/apache/kafka/pull/12695#issuecomment-1262460687 The build is failing due to the newly added test: `kafka.api.AuthorizerIntegrationTest.testPrefixAcls(String).quorum=zk` -- This is an automated message from the Apache Git Service. T

[GitHub] [kafka] alexec opened a new pull request, #12698: Add ExceptionHandlingDeserializer

2022-09-29 Thread GitBox
alexec opened a new pull request, #12698: URL: https://github.com/apache/kafka/pull/12698 Signed-off-by: Alex Collins *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping rev

[GitHub] [kafka] cmccabe merged pull request #12695: KAFKA-14265: Prefix ACLs may shadow other prefix ACLs

2022-09-29 Thread GitBox
cmccabe merged PR #12695: URL: https://github.com/apache/kafka/pull/12695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-14267) CVE-2022-36944 - Scala deserialization bug

2022-09-29 Thread Zach Fry (Jira)
Zach Fry created KAFKA-14267: Summary: CVE-2022-36944 - Scala deserialization bug Key: KAFKA-14267 URL: https://issues.apache.org/jira/browse/KAFKA-14267 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-14267) CVE-2022-36944 - Scala deserialization bug

2022-09-29 Thread Zach Fry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach Fry updated KAFKA-14267: - Description: [https://nvd.nist.gov/vuln/detail/CVE-2022-36944] This is marked as CRITICAL severity vuln